Repository navigation
test(agent): repro huge random node ids after agent subgraph unpack - #18108
claude[bot] wants to merge 2 commits into
Conversation
The in-app agent has no dedicated unpack tool (no "unpack" entry point anywhere in cloud's services/agent/internal/loop/tools.go), so it reconstructs a subgraph's interior nodes on the flat canvas with add_node primitives. comfy-cli's mint_id() deliberately mints those ids as large random 53-bit integers (workflow_ops.py's leaderless, collision-free identity scheme), and reconcileAgentAdapters adopts that id verbatim with no re-mint step, unlike the native Unpack Subgraph command (unpackSubgraph.ts), which always re-mints a small sequential id via idAllocation.ts's mintNodeId. Reported live on nightly (2026-09-08): flattened nodes showed IDs like #3999039427639531 instead of small, readable ones.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2035 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T04:50:07.641Z",
"gitSha": "0027b81f0453ac8aba2e6549be99f551ffc0b6af",
"branch": "test/agent-unpack-large-node-ids",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.374000000013,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.991000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.288,
"heapDeltaBytes": -3664360,
"heapUsedBytes": 57947332,
"domNodes": -261,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 12.479999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2004.2329999999993,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.285000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.241,
"heapDeltaBytes": 14789340,
"heapUsedBytes": 76208944,
"domNodes": -259,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 12.529000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1934.4689999999787,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.905,
"layouts": 14,
"layoutDurationMs": 4.888,
"taskDurationMs": 960.2810000000001,
"heapDeltaBytes": 13146524,
"heapUsedBytes": 74372620,
"domNodes": -267,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 181.01999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1838.7750000000551,
"styleRecalcs": 75,
"styleRecalcDurationMs": 31.038,
"layouts": 14,
"layoutDurationMs": 4.385,
"taskDurationMs": 898.406,
"heapDeltaBytes": 9102544,
"heapUsedBytes": 70279464,
"domNodes": -264,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 174.11300000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.3979999999842,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.531,
"layouts": 6,
"layoutDurationMs": 1.5539999999999998,
"taskDurationMs": 319.084,
"heapDeltaBytes": 2087024,
"heapUsedBytes": 63277200,
"domNodes": 73,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 14.997999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.966000000005,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.687,
"layouts": 6,
"layoutDurationMs": 1.145,
"taskDurationMs": 375.6769999999999,
"heapDeltaBytes": 2094416,
"heapUsedBytes": 64147836,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 15.301999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 713.5410000000206,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.836000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.141,
"heapDeltaBytes": 17155000,
"heapUsedBytes": 77769640,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 168.542,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 679.7480000000178,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.445999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.41600000000005,
"heapDeltaBytes": 17916748,
"heapUsedBytes": 79885512,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 170.72799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2031.7959999999857,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.0840000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.6909999999999,
"heapDeltaBytes": 3053448,
"heapUsedBytes": 82499496,
"domNodes": -249,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 36.718,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2022.485999999958,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.528,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.282,
"heapDeltaBytes": 3085524,
"heapUsedBytes": 82956832,
"domNodes": -251,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 32.967999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2524.268999999947,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.457,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1788.3880000000004,
"heapDeltaBytes": -1103552,
"heapUsedBytes": 79358780,
"domNodes": -254,
"jsHeapTotalBytes": 1527808,
"scriptDurationMs": 906.797,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2302.863000000002,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.014000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1665.8820000000003,
"heapDeltaBytes": 18997328,
"heapUsedBytes": 83120704,
"domNodes": -253,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 864.201,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3614.976000000013,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.503999999999996,
"layouts": 60,
"layoutDurationMs": 13.991,
"taskDurationMs": 1815.3550000000002,
"heapDeltaBytes": 9801316,
"heapUsedBytes": 74659476,
"domNodes": -257,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 827.307,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3660.618999999997,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.072000000000001,
"layouts": 60,
"layoutDurationMs": 13.321,
"taskDurationMs": 1784.94,
"heapDeltaBytes": 8072316,
"heapUsedBytes": 73992292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 839.098,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3122.197999999969,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1978.806,
"heapDeltaBytes": 18531704,
"heapUsedBytes": 84053320,
"domNodes": 2,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 993.7239999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3125.1130000000558,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.320000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1956.1380000000001,
"heapDeltaBytes": 19046932,
"heapUsedBytes": 84630812,
"domNodes": -259,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 987.6919999999999,
"eventListeners": 28,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.3529999999996,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.061999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.2060000000001,
"heapDeltaBytes": 19722432,
"heapUsedBytes": 83677728,
"domNodes": -253,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.901,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.8689999999724,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.7219999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 668.1320000000001,
"heapDeltaBytes": -7433712,
"heapUsedBytes": 79733624,
"domNodes": -259,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 38.951,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 604.3900000000235,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.161,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.11300000000006,
"heapDeltaBytes": 13100976,
"heapUsedBytes": 76465108,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 150.88000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.4999999999536,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.072999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.197,
"heapDeltaBytes": 13815368,
"heapUsedBytes": 77045792,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.443,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.849000000002,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.541999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.323,
"heapDeltaBytes": 16192888,
"heapUsedBytes": 79278784,
"domNodes": -277,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.517000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2021.5590000000248,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.932999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.533,
"heapDeltaBytes": 14754796,
"heapUsedBytes": 77823716,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.757,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.3469999999938,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.937,
"layouts": 18,
"layoutDurationMs": 5.47,
"taskDurationMs": 833.4619999999999,
"heapDeltaBytes": 8316632,
"heapUsedBytes": 71699532,
"domNodes": -275,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 120.15999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.843999999971,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.162,
"layouts": 18,
"layoutDurationMs": 5.2299999999999995,
"taskDurationMs": 828.532,
"heapDeltaBytes": 7259044,
"heapUsedBytes": 70679788,
"domNodes": -277,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 118.513,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.9990000000616,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.977000000000004,
"layouts": 5,
"layoutDurationMs": 14.125999999999996,
"taskDurationMs": 1038.02,
"heapDeltaBytes": -6440368,
"heapUsedBytes": 80273168,
"domNodes": 13587,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 33.35900000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 153,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9017.559999999947,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.575,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6190.673000000001,
"heapDeltaBytes": -4738592,
"heapUsedBytes": 74937824,
"domNodes": -249,
"jsHeapTotalBytes": -77824,
"scriptDurationMs": 2884.842,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8746.000999999978,
"styleRecalcs": 246,
"styleRecalcDurationMs": 35.617,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6157.446,
"heapDeltaBytes": -5051292,
"heapUsedBytes": 75313024,
"domNodes": -251,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 2888.621,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18413.710999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17924.387,
"heapDeltaBytes": -59629416,
"heapUsedBytes": 177182260,
"domNodes": -8061,
"jsHeapTotalBytes": -10817536,
"scriptDurationMs": 289.986,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16966.746000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16639.993000000002,
"heapDeltaBytes": -54065108,
"heapUsedBytes": 176841012,
"domNodes": -8061,
"jsHeapTotalBytes": -12914688,
"scriptDurationMs": 280.765,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22971.750000000044,
"styleRecalcs": 177,
"styleRecalcDurationMs": 22.990999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22767.288,
"heapDeltaBytes": -41159744,
"heapUsedBytes": 189579112,
"domNodes": -8061,
"jsHeapTotalBytes": -12185600,
"scriptDurationMs": 920.931,
"eventListeners": -14928,
"totalBlockingTimeMs": 211,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 20430.10000000004,
"styleRecalcs": 149,
"styleRecalcDurationMs": 18.683000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20325.858,
"heapDeltaBytes": -42231320,
"heapUsedBytes": 167590424,
"domNodes": -8061,
"jsHeapTotalBytes": -12390400,
"scriptDurationMs": 853.013,
"eventListeners": -14928,
"totalBlockingTimeMs": 115,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6589.883999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.52599999999998,
"layouts": 20,
"layoutDurationMs": 24.318000000000005,
"taskDurationMs": 6535.407999999999,
"heapDeltaBytes": -19771204,
"heapUsedBytes": 195929092,
"domNodes": -8065,
"jsHeapTotalBytes": 13955072,
"scriptDurationMs": 117.772,
"eventListeners": -14928,
"totalBlockingTimeMs": 446,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6204.621999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.70499999999997,
"layouts": 20,
"layoutDurationMs": 24.030999999999995,
"taskDurationMs": 6110.986,
"heapDeltaBytes": -50756404,
"heapUsedBytes": 183586452,
"domNodes": -8061,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 115.405,
"eventListeners": -14928,
"totalBlockingTimeMs": 422,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9221.596999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9089.435,
"heapDeltaBytes": 4372052,
"heapUsedBytes": 186749012,
"domNodes": 0,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 155.528,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8439.026000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8292.287,
"heapDeltaBytes": -21641056,
"heapUsedBytes": 170458348,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 127.71200000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 121.61800000001222,
"styleRecalcs": 8,
"styleRecalcDurationMs": 19.834999999999997,
"layouts": 4,
"layoutDurationMs": 2.519,
"taskDurationMs": 97.51300000000002,
"heapDeltaBytes": 3171688,
"heapUsedBytes": 64633268,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.683,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 97.42899999992005,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.359,
"layouts": 3,
"layoutDurationMs": 1.3250000000000002,
"taskDurationMs": 73.16600000000001,
"heapDeltaBytes": 3023480,
"heapUsedBytes": 63802688,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.7589999999999995,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
The This is an npm-registry connectivity flake, unrelated to this PR's diff (a red-only unit test with no dependency/lockfile changes). Corroborating: PR #18107 — an unrelated unit-test-only PR — hit the identical I attempted to re-run the failed job, but the workflow run is still in progress (other shards still executing), so GitHub refuses a rerun until the whole run completes ("This workflow is already running"). Once the run finishes, this shard can be re-run via the Actions UI/API, or it may not even be needed if the required checks don't gate on this specific sharded job. Generated by Claude Code |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18108 +/- ##
==========================================
+ Coverage 82.78% 83.73% +0.95%
==========================================
Files 2936 2242 -694
Lines 144482 127632 -16850
Branches 37152 34338 -2814
==========================================
- Hits 119610 106879 -12731
+ Misses 23615 20458 -3157
+ Partials 1257 295 -962
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Closing as superseded: large node IDs are now intentional. Full context for agent readers#18095 made Agent-bound frontend graphs mint from a disjoint random range: frontend IDs set bit 41 and clear bit 40, while Agent IDs set bit 40. Re-minting the Agent IDs to small sequential values, as this red test requests, would undo that collision-prevention invariant. The fix is already on Glossary:
|
Requested by Christian Byrne · Slack thread
Summary
Adds a failing (
it.fails) regression test proving that nodes the in-app agent reconstructs during a subgraph unpack keep their huge, comfy-cli-minted node ids instead of getting reasonably-sized ones.Root cause
The in-app agent has no dedicated "unpack subgraph" tool (no
unpackentry point anywhere incloud'sservices/agent/internal/loop/tools.go). Asked to unpack a subgraph, it reconstructs the interior nodes on the flat canvas with the genericadd_nodestructured-edit primitive instead.comfy-cli'smint_id()(comfy_cli/workflow_ops.py) deliberately mints those new ids as large random 53-bit integers —_ID_FLOOR | random.getrandbits(52)with_ID_FLOOR = 1 << 40— by design, so a leaderless/CRDT agent write never collides with the frontend's own small sequential node-id counter.reconcileAgentAdapters/agentNodeMaterializer.tsthen adopts that op-supplied id verbatim (node.id = state.id) with no re-mint step, so the huge id becomes the permanent on-canvas id. This is unlike the native "Unpack Subgraph" canvas command (unpackSubgraph.ts'smaterializeSubgraphNodes), which always re-mints a small sequential id viaidAllocation.ts'smintNodeId, regardless of the interior nodes' original ids.Reported live on nightly: after asking the agent to unpack a subgraph, the flattened nodes' IDs displayed as huge random numbers (e.g.
#3999039427639531) instead of small, readable ones.Changes
it.failscase inagentNodeMaterializer.test.tsthat seeds several agent-added nodes with comfy-cli-shaped mint_id() ids, reconciles them onto the graph, and asserts (as the desired behavior) that their ids end up reasonably small — currently false, proving the defect at its exact materialization point.Review Focus
This is a repro/regression test only, no fix. The fix likely belongs either in
comfy-cli/the agent's tool layer (give unpack-style bulk node reconstruction a real "unpack" primitive that reuses the frontend's small-id remint) or inagentNodeMaterializer.ts(remint an agent-supplied id to a small display id on first materialization, the wayunpackSubgraph.tsalready does for the native command). This test passes today underit.fails; a fix should flip it to a normal passingit.🤖 Generated with Claude Code
https://claude.ai/code/session_01GsW1eCwZpRD9ZA9DM8pdY3
Generated by Claude Code