Repository navigation
test(agent): WIP harness for CRDT subgraph-interior wire-op repro - #18105
claude[bot] wants to merge 2 commits into
Conversation
Adds a local-write-leg harness (LocalWriteLegHarness) that binds the agent panel's CRDT follower to a fake doc host using the real comfy-multi-player library in-process, plus two fixme'd e2e cases for Sentry CLOUD-FRONTEND-STAGING-4KM: an interior node delete/create never mints a wire op (layoutMintPort.ts's reportUnrepresentableInteriorChange guard, added in #16611). The harness cannot yet drive isDocBound() true outside the real app flow - the agent_active_tab event is sent and parses, but the CRDT follower never issues a doc_subscribe for it, so the mint-port gate is never reached. Marked test.fixme() with next-step notes in the file header rather than shipping a red-for-the-wrong-reason repro.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2041 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T04:39:51.584Z",
"gitSha": "23bc64010aa0c290ac5b0de09611dc8410e01423",
"branch": "test/crdt-subgraph-interior-wire-op-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.453999999986,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.221,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.55699999999996,
"heapDeltaBytes": 5277356,
"heapUsedBytes": 67256916,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.289999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2004.7630000000254,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.097999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.368,
"heapDeltaBytes": 8703312,
"heapUsedBytes": 70694740,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.861,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1972.659999999962,
"styleRecalcs": 74,
"styleRecalcDurationMs": 29.985,
"layouts": 14,
"layoutDurationMs": 4.212000000000001,
"taskDurationMs": 974.272,
"heapDeltaBytes": 12084248,
"heapUsedBytes": 73201664,
"domNodes": -265,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 185.435,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1859.0450000000374,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.689,
"layouts": 14,
"layoutDurationMs": 4.258000000000001,
"taskDurationMs": 863.7850000000001,
"heapDeltaBytes": 7671456,
"heapUsedBytes": 69741004,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 169.04,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.536999999993,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.983000000000002,
"layouts": 6,
"layoutDurationMs": 1.0340000000000003,
"taskDurationMs": 314.86,
"heapDeltaBytes": 2096600,
"heapUsedBytes": 64228556,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.951999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.5449999999819,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.753,
"layouts": 6,
"layoutDurationMs": 1.075,
"taskDurationMs": 326.69599999999997,
"heapDeltaBytes": 2049292,
"heapUsedBytes": 64115924,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.157000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 632.9739999999902,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.265999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.101,
"heapDeltaBytes": 18271884,
"heapUsedBytes": 79916148,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 168.709,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 662.3730000000023,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.729999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.716,
"heapDeltaBytes": 17899240,
"heapUsedBytes": 79921920,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 168.47899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.601999999964,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.561999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.527,
"heapDeltaBytes": 2686576,
"heapUsedBytes": 82416968,
"domNodes": -246,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 30.024000000000008,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2010.3900000000294,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.5820000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.2520000000001,
"heapDeltaBytes": 19726012,
"heapUsedBytes": 83338980,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.272999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2170.0439999999617,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.609000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1459.9730000000002,
"heapDeltaBytes": 19258244,
"heapUsedBytes": 83466748,
"domNodes": -256,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 867.589,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2212.20100000005,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.996000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1589.2530000000002,
"heapDeltaBytes": 13967776,
"heapUsedBytes": 78524892,
"domNodes": 4,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 834.4580000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3402.9930000000377,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.104000000000001,
"layouts": 60,
"layoutDurationMs": 12.132,
"taskDurationMs": 1577.9260000000002,
"heapDeltaBytes": 8358396,
"heapUsedBytes": 74116996,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 758.501,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3740.150000000085,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.588999999999999,
"layouts": 60,
"layoutDurationMs": 13.799000000000001,
"taskDurationMs": 1857.043,
"heapDeltaBytes": -8755340,
"heapUsedBytes": 73150712,
"domNodes": -265,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 827.784,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3120.7339999999704,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.038000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1973.353,
"heapDeltaBytes": 24909288,
"heapUsedBytes": 90222444,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 1055.686,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3107.032000000004,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.706000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1929.897,
"heapDeltaBytes": 21269484,
"heapUsedBytes": 86689412,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 997.811,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2024.4829999999752,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.266,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.2729999999999,
"heapDeltaBytes": -3785356,
"heapUsedBytes": 83770440,
"domNodes": -251,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 35.645999999999994,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.0639999999103,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.760999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.989,
"heapDeltaBytes": -3340944,
"heapUsedBytes": 83853288,
"domNodes": -252,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.156000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.6909999999871,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.562000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.6379999999999,
"heapDeltaBytes": 13799312,
"heapUsedBytes": 76841356,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.82500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.4920000000493,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.671,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.428,
"heapDeltaBytes": 13187788,
"heapUsedBytes": 76440616,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.512,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.1050000000146,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.615,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.876,
"heapDeltaBytes": -2223152,
"heapUsedBytes": 61188464,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.862999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1998.7429999999904,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.041,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.65099999999995,
"heapDeltaBytes": 12833884,
"heapUsedBytes": 75968960,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.005000000000003,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.339,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.439,
"layouts": 18,
"layoutDurationMs": 6.047000000000001,
"taskDurationMs": 798.124,
"heapDeltaBytes": -881704,
"heapUsedBytes": 61660692,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 111.503,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1696.95999999999,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.855000000000004,
"layouts": 18,
"layoutDurationMs": 5.478000000000001,
"taskDurationMs": 786.412,
"heapDeltaBytes": 1125576,
"heapUsedBytes": 64328828,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 107.782,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.429999999952,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.00400000000001,
"layouts": 5,
"layoutDurationMs": 12.795000000000002,
"taskDurationMs": 890.593,
"heapDeltaBytes": -6445288,
"heapUsedBytes": 80975420,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 29.450000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8320.292999999992,
"styleRecalcs": 248,
"styleRecalcDurationMs": 33.594,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5654.129,
"heapDeltaBytes": -4434812,
"heapUsedBytes": 75348252,
"domNodes": -248,
"jsHeapTotalBytes": -307200,
"scriptDurationMs": 2725.0950000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8478.68799999992,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.731,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5921.379,
"heapDeltaBytes": -4553388,
"heapUsedBytes": 75255036,
"domNodes": -250,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 2823.085,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16696.590999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16223.819,
"heapDeltaBytes": -26507472,
"heapUsedBytes": 190258184,
"domNodes": -8061,
"jsHeapTotalBytes": -13832192,
"scriptDurationMs": 293.144,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17182.600999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16678.377999999997,
"heapDeltaBytes": -22166192,
"heapUsedBytes": 191327848,
"domNodes": -8061,
"jsHeapTotalBytes": -15372288,
"scriptDurationMs": 262.689,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20650.259000000005,
"styleRecalcs": 153,
"styleRecalcDurationMs": 17.259999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20400.799,
"heapDeltaBytes": -51365552,
"heapUsedBytes": 179738460,
"domNodes": -8061,
"jsHeapTotalBytes": -14528512,
"scriptDurationMs": 896.617,
"eventListeners": -14928,
"totalBlockingTimeMs": 132,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20570.49900000004,
"styleRecalcs": 156,
"styleRecalcDurationMs": 17.263000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20267.896999999997,
"heapDeltaBytes": -50862396,
"heapUsedBytes": 178859368,
"domNodes": -8061,
"jsHeapTotalBytes": -8450048,
"scriptDurationMs": 895.2560000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 74,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6143.110999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.986,
"layouts": 20,
"layoutDurationMs": 22.459000000000007,
"taskDurationMs": 6038.156,
"heapDeltaBytes": -25572932,
"heapUsedBytes": 194934380,
"domNodes": -8061,
"jsHeapTotalBytes": 14045184,
"scriptDurationMs": 107.459,
"eventListeners": -14928,
"totalBlockingTimeMs": 360,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6230.848999999921,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.30900000000001,
"layouts": 20,
"layoutDurationMs": 25.030999999999985,
"taskDurationMs": 6146.363000000001,
"heapDeltaBytes": -52308696,
"heapUsedBytes": 178426012,
"domNodes": -8061,
"jsHeapTotalBytes": 14348288,
"scriptDurationMs": 116.77699999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 419,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8596.531999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8426.538,
"heapDeltaBytes": 1083376,
"heapUsedBytes": 189889328,
"domNodes": 0,
"jsHeapTotalBytes": -19922944,
"scriptDurationMs": 138.54,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8662.573000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8396.164,
"heapDeltaBytes": -9414512,
"heapUsedBytes": 171725960,
"domNodes": 0,
"jsHeapTotalBytes": -9175040,
"scriptDurationMs": 138.54900000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 127.76800000006006,
"styleRecalcs": 12,
"styleRecalcDurationMs": 22.017000000000003,
"layouts": 5,
"layoutDurationMs": 2.2909999999999995,
"taskDurationMs": 105.484,
"heapDeltaBytes": 3312028,
"heapUsedBytes": 64094156,
"domNodes": 137,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.694,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 127.65200000001187,
"styleRecalcs": 8,
"styleRecalcDurationMs": 21.537,
"layouts": 4,
"layoutDurationMs": 2.2,
"taskDurationMs": 95.503,
"heapDeltaBytes": 3069888,
"heapUsedBytes": 64639696,
"domNodes": 133,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.796,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
The Pushed a fix ( Generated by Claude Code |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18105 +/- ##
==========================================
+ Coverage 82.77% 83.79% +1.02%
==========================================
Files 2936 2242 -694
Lines 144482 127635 -16847
Branches 39021 34338 -4683
==========================================
- Hits 119593 106958 -12635
+ Misses 23632 20387 -3245
+ Partials 1257 290 -967
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
|
The Generated by Claude Code |
|
Assessed whether the underlying production fix (making subgraph-interior Why not trivial:
Rough shape of the work, once design questions are resolved:
Open questions for the team: the shared-definition semantics decision (product decision as much as engineering), and whether it should be settled before or alongside #16818's own open fork question. Generated by Claude Code 🤖 Generated with Claude Code |
|
Closing as an obsolete WIP carrier after the graph-API rewrite. Both cases remain |
<!-- ccr-slack-attribution -->
Requested via Slack thread
Summary
WIP: a test harness for reproducing Sentry CLOUD-FRONTEND-STAGING-4KM (subgraph-interior structural edits never reach the bound CRDT doc) end-to-end. This is not a working repro yet — see Status below. No production code is touched.
Changes
LocalWriteLegHarness(browser_tests/fixtures/agentLocalWriteLegFixture.ts) binds the agent panel's CRDT follower to a fake doc host using the real@comfyorg/comfy-multi-playerlibrary in-process (same techniqueagentConversationFixtureuses for the existing recorded-agent-conversation replay suite), and captures every client-sent/wsframe sodoc_opssent for a local human edit can be inspected.browser_tests/fixtures/utils/rawCanvasNodeOps.tsadds minimal canvas node helpers (enterSubgraphNode,clickNodeTitle,currentGraphNodeIds,isInsideSubgraph) for specs booted viaagentPanelFixture's rawpage, sincecomfyPage.nodeOps/NodeReferenceare typed againstComfyPageand unavailable there.browser_tests/tests/agent/agentCrdtSubgraphInteriorWireGap.spec.tshas two cases (interior node DELETE, interior node CREATE via copy/paste) markedtest.fixme().Status — WIP, not a working repro
The bug's root cause is not in question:
reportUnrepresentableInteriorChangeinsrc/workbench/extensions/agent/crdt/layoutMintPort.ts(added by #16611, lines ~91-137) is a deliberate guard — when a node'sownerGraphIddiffers from the rootgraphIdacreateNode/deleteNodeoperation carries, it reports the divergence viareportErrorand returns WITHOUT enqueuing a wire op, because the wire protocol'sOpunion has no subgraph-scoping field foradd_node/delete_nodeyet.What's blocking the e2e repro: getting
isDocBound()true (required before the mint-port gate above is even reached) needs the agent panel bound to a workflow. The harness sends a realagent_active_tabWS event (parses fine againstzAgentWsEvent) naming the bound workflow id, but the CRDT follower never issues adoc_subscribefor it — confirmed by capturing every client-sent/wsframe: onlyfeature_flagsever arrives,doc_subscribenever does. SoisBoundWorkflowActiveinAgentPanelRoot.vuenever flips true and the guard this bug lives behind is never exercised. An earlier attempt driving the panel's own "Switch workflow"menuitemradiopicker UI hit the same wall from a different angle: the click (also tried.click({force:true})and.press('Enter')) never flipped the item's ownaria-checked, so it isn't a network-mock gap in that path either.Two concrete next leads, left in the spec file's header comment:
useAgentWorkflowSelection'sstatus/canSelectTargetstate directly off the Pinia store viapage.evaluateto see what's actually keepingisBoundWorkflowActivefalse after theagent_active_tabevent lands.workflow?.activeTab?.(event.data)inuseAgentSession.ts(~line 496) andbindingStore.bind()/onWorkflowActiveTabinAgentPanelRoot.vue(~line 440) to find the exact condition that keeps a freshly-loaded tab from being "adoptable".Both tests are
test.fixme()rather thantest.fail()for now: the assertion bodies already express the desired end state (a matchingadd_node/delete_nodewire op reaches the bound doc, which is currently false), but they aren't reachable yet, so a red run today would be red for the wrong reason. OnceisDocBound()is reachable, flip back totest.fail()— the assertions themselves don't need to change.Also worth noting: the existing
agentConversationReplay.spec.tssuite also can't complete in the sandbox this was developed in (waitForCloudApptimes out —window.app.extensionManagernever appears) because that suite'sobjectInfo: 'server'boot path needs a live ComfyUI backend the sandbox doesn't have; this harness deliberately avoids that mode, and I couldn't cross-check the picker-selection behavior against a known-working baseline run because of it. This looked sandbox-specific (no backend / restricted egress), not a clean-checkout issue, but I did not verify on a from-scratch checkout with a real backend.Review Focus
The workflow-binding gap above is the whole review focus — everything else (the
HostDocreuse, the canvas helpers, the assertion shapes) typechecks, lints, and formats clean but is otherwise unexercised until that's resolved.Sentry issue: https://comfy-org.sentry.io/issues/7727249665/
Related: #16611 (introduced the guard)
🤖 Generated with Claude Code
https://claude.ai/code/session_01XsqYHW3iRhQnK8RrbCrS5p
Generated by Claude Code