Repository navigation
test: failing e2e repro for two-session agent CRDT tab-switch subscription bugs - #18088
claude[bot] wants to merge 7 commits into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2122 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.98 MB gzipDetailsSummary
Category Glance App Entry Points — 3.87 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.44 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 132 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 639 kBConfiguration panels, inspectors, and settings screens
Status: 28 added User & Accounts — 37.9 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 124 kBReusable component library chunks
Status: 16 added Data & Services — 3.94 MBStores, services, APIs, and repositories
Status: 16 added Utilities & Hooks — 577 kBHelpers, composables, and utility bundles
Status: 38 added Vendor & Third-Party — 17.4 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 17.8 MBBundles that do not match a named category
Status: 302 added ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T08:48:25.779Z",
"gitSha": "910bb85d351b765d075f0aadbb518089293f995b",
"branch": "test/agent-two-session-crdt-subscription",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.0759999999837,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.409999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.64200000000005,
"heapDeltaBytes": -8581508,
"heapUsedBytes": 58713696,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.209999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2006.7850000000362,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.428,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.64400000000006,
"heapDeltaBytes": -7755312,
"heapUsedBytes": 59824652,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.226,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.7490000000325,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.099,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 775.4519999999999,
"heapDeltaBytes": 10737120,
"heapUsedBytes": 78133664,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 145.439,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.4760000000633,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.086,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.936,
"heapDeltaBytes": -1019284,
"heapUsedBytes": 66642668,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 147.047,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.3260000000055,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.537999999999998,
"layouts": 6,
"layoutDurationMs": 1.1450000000000002,
"taskDurationMs": 328.642,
"heapDeltaBytes": 3148700,
"heapUsedBytes": 70582396,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.812000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.4709999999804,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.528,
"layouts": 6,
"layoutDurationMs": 1.1550000000000002,
"taskDurationMs": 328.93699999999995,
"heapDeltaBytes": 3144780,
"heapUsedBytes": 70679896,
"domNodes": 81,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.966999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 610.2789999999914,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.485,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.84499999999997,
"heapDeltaBytes": 18310768,
"heapUsedBytes": 80714128,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 160.633,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 599.5779999999513,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.148,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.3179999999999,
"heapDeltaBytes": 18937004,
"heapUsedBytes": 86402004,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 161.826,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1161.4790000000426,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 812.095,
"heapDeltaBytes": 38959308,
"heapUsedBytes": 104120040,
"domNodes": -265,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 64.324,
"eventListeners": -195,
"totalBlockingTimeMs": 526,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1128.0709999999772,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 752.5949999999999,
"heapDeltaBytes": 38554568,
"heapUsedBytes": 105685028,
"domNodes": 0,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 60.592999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 523,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.952999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.3700000000004,
"heapDeltaBytes": 14517164,
"heapUsedBytes": 89822272,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 142.61700000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 828.8820000000214,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.5749999999997,
"heapDeltaBytes": 14443228,
"heapUsedBytes": 89784708,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 134.967,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9480.968000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8614.585,
"heapDeltaBytes": 16471232,
"heapUsedBytes": 93371788,
"domNodes": -16,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 6976.659,
"eventListeners": 0,
"totalBlockingTimeMs": 340,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9313.657000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8428.283000000001,
"heapDeltaBytes": -2128108,
"heapUsedBytes": 79934704,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 6846.834999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 127,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9045.836000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8309.525,
"heapDeltaBytes": -1588648,
"heapUsedBytes": 81131136,
"domNodes": -16,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 6689.91,
"eventListeners": 0,
"totalBlockingTimeMs": 246,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9135.318999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8254.493,
"heapDeltaBytes": 13037836,
"heapUsedBytes": 95206056,
"domNodes": -14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 6699.178,
"eventListeners": 0,
"totalBlockingTimeMs": 149,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2024.8139999999921,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.475000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.4570000000001,
"heapDeltaBytes": -3462856,
"heapUsedBytes": 83030328,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.569,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2001.1580000000322,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.262999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.49,
"heapDeltaBytes": 19872608,
"heapUsedBytes": 83366056,
"domNodes": -246,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.712,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2154.988000000003,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.469999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1522.181,
"heapDeltaBytes": 15663956,
"heapUsedBytes": 79863988,
"domNodes": -248,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 784.2289999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2192.1149999999443,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.540999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1579.2260000000003,
"heapDeltaBytes": -6840016,
"heapUsedBytes": 80920372,
"domNodes": -245,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 801.672,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3509.0380000000323,
"styleRecalcs": 64,
"styleRecalcDurationMs": 17.316,
"layouts": 60,
"layoutDurationMs": 14.224,
"taskDurationMs": 1705.6950000000002,
"heapDeltaBytes": -15192900,
"heapUsedBytes": 74064120,
"domNodes": -254,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 761.558,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3465.5709999999544,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.156999999999998,
"layouts": 60,
"layoutDurationMs": 14.329999999999998,
"taskDurationMs": 1680.2659999999998,
"heapDeltaBytes": -15330620,
"heapUsedBytes": 73811116,
"domNodes": -256,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 772.8309999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3032.2780000000193,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.557999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1853.973,
"heapDeltaBytes": 21040492,
"heapUsedBytes": 87081932,
"domNodes": 8,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 973.0740000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2794.7810000000572,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.883,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1714.4409999999998,
"heapDeltaBytes": 23360704,
"heapUsedBytes": 89714700,
"domNodes": 6,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 965.8109999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2043.4940000000097,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.403000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.463,
"heapDeltaBytes": -6954004,
"heapUsedBytes": 81865592,
"domNodes": -245,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 34.637,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.5570000000207,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.347999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.4,
"heapDeltaBytes": -4399140,
"heapUsedBytes": 84233524,
"domNodes": -246,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 31.491000000000007,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.2859999999391,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.167999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.19,
"heapDeltaBytes": 13967084,
"heapUsedBytes": 83749124,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.39499999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.5840000000444,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.614,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.868,
"heapDeltaBytes": 13508132,
"heapUsedBytes": 83566064,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 146.639,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.2660000000105,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.240999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.39899999999994,
"heapDeltaBytes": 166776,
"heapUsedBytes": 70325792,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.07,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1997.015000000033,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.2349999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.34299999999996,
"heapDeltaBytes": -3273544,
"heapUsedBytes": 59556712,
"domNodes": -277,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.492999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.0900000000074,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.809999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 687.448,
"heapDeltaBytes": -2398572,
"heapUsedBytes": 60755632,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 95.72699999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.1599999999307,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.321999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 706.945,
"heapDeltaBytes": -7891340,
"heapUsedBytes": 62312188,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 96.651,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.1189999999788,
"styleRecalcs": 17,
"styleRecalcDurationMs": 26.857999999999993,
"layouts": 5,
"layoutDurationMs": 11.623,
"taskDurationMs": 870.49,
"heapDeltaBytes": -6298144,
"heapUsedBytes": 80829528,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 28.223000000000006,
"eventListeners": 2383,
"totalBlockingTimeMs": 122,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8308.359999999993,
"styleRecalcs": 253,
"styleRecalcDurationMs": 41.092000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5528.108,
"heapDeltaBytes": -9356936,
"heapUsedBytes": 76465700,
"domNodes": -235,
"jsHeapTotalBytes": 1531904,
"scriptDurationMs": 2627.567,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8278.133000000025,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.937,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5451.301,
"heapDeltaBytes": -10086280,
"heapUsedBytes": 76172712,
"domNodes": -245,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 2623.742,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17233.35899999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16709.181999999997,
"heapDeltaBytes": -24669328,
"heapUsedBytes": 198280376,
"domNodes": -8061,
"jsHeapTotalBytes": -17272832,
"scriptDurationMs": 272.42,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17897.996000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16924.903000000002,
"heapDeltaBytes": -35665412,
"heapUsedBytes": 178171144,
"domNodes": -8061,
"jsHeapTotalBytes": -16232448,
"scriptDurationMs": 276.079,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20922.17900000003,
"styleRecalcs": 155,
"styleRecalcDurationMs": 18.311999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20707.385000000002,
"heapDeltaBytes": 14762944,
"heapUsedBytes": 182425136,
"domNodes": 0,
"jsHeapTotalBytes": -16777216,
"scriptDurationMs": 892.032,
"eventListeners": 0,
"totalBlockingTimeMs": 191,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21147.00300000004,
"styleRecalcs": 158,
"styleRecalcDurationMs": 17.953999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20745.332000000002,
"heapDeltaBytes": -50227936,
"heapUsedBytes": 191087888,
"domNodes": -8061,
"jsHeapTotalBytes": -18358272,
"scriptDurationMs": 881.874,
"eventListeners": -14928,
"totalBlockingTimeMs": 138,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6161.865000000034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.87800000000003,
"layouts": 20,
"layoutDurationMs": 23.132,
"taskDurationMs": 6074.318000000001,
"heapDeltaBytes": -57585160,
"heapUsedBytes": 182965540,
"domNodes": -8061,
"jsHeapTotalBytes": 14176256,
"scriptDurationMs": 111.396,
"eventListeners": -14928,
"totalBlockingTimeMs": 421,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6168.005999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.715,
"layouts": 20,
"layoutDurationMs": 23.508000000000003,
"taskDurationMs": 6082.544,
"heapDeltaBytes": -46465456,
"heapUsedBytes": 193987120,
"domNodes": -8061,
"jsHeapTotalBytes": 8269824,
"scriptDurationMs": 106.891,
"eventListeners": -14928,
"totalBlockingTimeMs": 420,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8715.741999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8409.234999999999,
"heapDeltaBytes": 11869372,
"heapUsedBytes": 194167804,
"domNodes": 0,
"jsHeapTotalBytes": -8126464,
"scriptDurationMs": 138.66,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6564.760999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6299.123000000001,
"heapDeltaBytes": -22279264,
"heapUsedBytes": 173400176,
"domNodes": 0,
"jsHeapTotalBytes": -28573696,
"scriptDurationMs": 109.88600000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 110.84499999992659,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.455000000000002,
"layouts": 2,
"layoutDurationMs": 1.4050000000000002,
"taskDurationMs": 75.89100000000002,
"heapDeltaBytes": 3190720,
"heapUsedBytes": 68775480,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.899,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 465.0649999999814,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.664,
"layouts": 3,
"layoutDurationMs": 1.803,
"taskDurationMs": 117.85100000000001,
"heapDeltaBytes": 4995828,
"heapUsedBytes": 70672276,
"domNodes": 150,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.628999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (6 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0859c16eb97db188f25f4fbc500d34302cc5129e
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18088 +/- ##
==========================================
+ Coverage 83.52% 84.53% +1.01%
==========================================
Files 2989 2288 -701
Lines 148031 130773 -17258
Branches 40129 34277 -5852
==========================================
- Hits 123637 110547 -13090
+ Misses 23109 19926 -3183
+ Partials 1285 300 -985
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
66832b1 to
7e2d05b
Compare
Fix assessment for PM-1319 / PM-1320Read Shared root cause
That one stale value feeds two independent consumers, which is why it reads as two tickets:
We could not find an actual two-watcher ordering race — both bugs trace to the same single stale ref, not to a timing gap between independent watchers. (The follower's own Why it isn't trivial
and the The correct direction is closer to decoupling: the CRDT follower's subscribe target and the mint gate should track whichever workflow the active tab is bound to (via Candidate approaches (for deliberation, not decided)
Approach 1 is narrower and safer to attempt, but still needs a human decision on the "active-but-unbound tab" state transition before anyone should write code, plus new unit coverage in Test file is unchanged; both Generated by Claude Code |
Adds a two-session CRDT harness that boots one cloud app, binds two agent workflows through the real agent_active_tab path against a shared in-process doc host, and switches between their tabs. Two failing repros (test.fail) plus one passing control: - returning to the first session's tab shows stale values because the follower never resubscribes the active tab's workflow; - a human edit on the returned-to tab is dropped because the mint port stays bound to the other session's workflow; - control: an edit on a bound, active tab does reach its doc.
Fallow's audit gate (CI: Fallow) flagged the new onClientFrame method with a CRAP score of 63.6 (threshold 30, cyclomatic 15). Split it into a pure parseClientFrame helper plus recordOutboundDocOps/handleDocSubscribe, matching fallow's own suggested fix (extract helper functions). Behavior is unchanged; test.fail() assertions untouched.
The control ("a human edit on the bound active tab reaches its doc")
polled docOpsCount() with the default 5s expect.poll timeout while its
sibling assertions in the same file use 20s. Under the
playwright-video-new-tests job (SLOW_MO=250, --retries=0) that 5s
budget is too tight for the real mint round trip and the control
failed. Match the 20s timeout already used elsewhere in this spec.
7e2d05b to
1e16c69
Compare
Key was renamed to agent.entryButton in #17621, leaving OPEN_AGENT_LABEL undefined and getByRole matching every button on the page.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 4 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
…ion-crdt-subscription
Pin the boot tab as the composer target so Send actually posts (with no target it opens the Switch workflow picker), take thread ids from the mocked POST ack, and rebuild the fixture around user-visible actions: startThread, bindViaActiveTab, finishTurn, newChat. Bug tests keep test.fail placed after setup so a fixture failure is still reported.
Marker (P1): deriving the expected status from the result meant the test could never go red for PM-1535 — a fix produced a silent pass with nothing telling the fixer to remove the marker, and a later regression re-armed it and stayed green. Hard-assert the two allowed outcomes, then arm the marker unconditionally: a wrong canvas fails before the marker, an empty one is the expected failure, and the fix reports an unexpected pass, which is the signal to delete it. Settled reader returned a second read rather than the value the poll saw, so a build that rendered and was then cleared came back empty and was misfiled as the expected failure. Capture inside the callback. Dead harness code: hostWidgetValue, hostNodeIds, docOpsCount, outboundDocOps and the doc_ops judge had no caller here. Instrumenting the socket shows these flows send only doc_subscribe, doc_unsubscribe and feature_flags — no doc_ops at all — so the judge and its casts go too. waitForSubscribe's waiter registry collapses to expect.poll. Also: parse the turn ack with zAgentTurnAccepted instead of hand-typing response.json(); reuse the existing emptySeed and require the seed; drop the manual Comfy.VueNodes.Enabled that the @vue-nodes tag already owns; add test.step phases and @slow; and delete or correct the comments that described #18088's widget-edit coverage, which this branch no longer has.
|
Superseded deliberately by #18610. That carrier retains this branch in its ancestry but narrows the landed behavior to the PM-1535 empty-canvas pin; commit 11c4ccf removes the three PM-1319 cases and #18610 later removes their fixture-only API. The PM-1319 pins are therefore not considered landed through #18610. Restoring them in a focused carrier, together with consolidating the duplicated WebSocket and Agent API mocks, is tracked in #19663. |
…nd (PM-1535) (Comfy-Org#18610) ## Summary Adds a black-box E2E pin for [PM-1535](https://linear.app/comfyorg/issue/PM-1535): after two Agent threads bind two workflow tabs, Alpha's build reaches Alpha's document while Bravo remains active, but returning to Alpha leaves the selected canvas empty. The first case keeps an unconditional known-failure marker. An empty canvas is the expected PM-1535 failure, a wrong or partial canvas fails before the marker, and a fixed canvas becomes an unexpected pass that tells the fixer to remove the marker and containment guard. The second case is the positive control: a later turn rebinding Alpha materializes the exact build already held by Alpha's document. This carrier supersedes Comfy-Org#18088 but intentionally does not carry its three PM-1319 cases. Those pins and the shared-fixture consolidation are tracked separately in Comfy-Org#19663. ## Changes - **What**: Adds `agentTwoSessionCrdtFixture.ts` and two focused cloud Playwright cases for displaced-build return and recovery. - **Dependencies**: None. ## Review Focus - The unconditional `test.fail` must remain until PM-1535 is fixed. - `expect([[], BUILT_NODE_IDS]).toContainEqual(canvas)` must reject wrong or partial canvases before the known-failure marker. - The exact-id positive control must continue proving that the stored build is recoverable after rebinding. - Scope is one of the two empty canvases in the report. This carrier must not close PM-1535 by itself. ## Verification ```bash PLAYWRIGHT_TEST_URL=http://127.0.0.1:6254 \ PLAYWRIGHT_SETUP_API_URL=http://127.0.0.1:6290 \ DEV_SERVER_COMFYUI_URL=http://127.0.0.1:6290 \ DISTRIBUTION=cloud NODE_OPTIONS=--no-experimental-webstorage \ pnpm exec playwright test \ browser_tests/tests/agent/agentTwoSessionCrdtSubscription.spec.ts \ --project=cloud --workers=1 --retries=0 ``` Head `c61b3507f136c3c687833024af59a0fb8432aad7`: 2/2 focused tests passed against a local backend. Mutation proof at that head makes a canvas reader that always throws fail at that exact error instead of passing as PM-1535. `6a40cf8` trims the harness (schema-parsed `doc_subscribe`, private internals, catalog taken from the build recording, comments moved into assertion and marker messages) without changing either oracle; ESLint, type-aware oxlint, oxfmt, `pnpm typecheck:browser`, and the hosted cloud Playwright shards cover it. Related: PM-1535 --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
…nd (PM-1535) (#18610) ## Summary Adds a black-box E2E pin for [PM-1535](https://linear.app/comfyorg/issue/PM-1535): after two Agent threads bind two workflow tabs, Alpha's build reaches Alpha's document while Bravo remains active, but returning to Alpha leaves the selected canvas empty. The first case keeps an unconditional known-failure marker. An empty canvas is the expected PM-1535 failure, a wrong or partial canvas fails before the marker, and a fixed canvas becomes an unexpected pass that tells the fixer to remove the marker and containment guard. The second case is the positive control: a later turn rebinding Alpha materializes the exact build already held by Alpha's document. This carrier supersedes #18088 but intentionally does not carry its three PM-1319 cases. Those pins and the shared-fixture consolidation are tracked separately in #19663. ## Changes - **What**: Adds `agentTwoSessionCrdtFixture.ts` and two focused cloud Playwright cases for displaced-build return and recovery. - **Dependencies**: None. ## Review Focus - The unconditional `test.fail` must remain until PM-1535 is fixed. - `expect([[], BUILT_NODE_IDS]).toContainEqual(canvas)` must reject wrong or partial canvases before the known-failure marker. - The exact-id positive control must continue proving that the stored build is recoverable after rebinding. - Scope is one of the two empty canvases in the report. This carrier must not close PM-1535 by itself. ## Verification ```bash PLAYWRIGHT_TEST_URL=http://127.0.0.1:6254 \ PLAYWRIGHT_SETUP_API_URL=http://127.0.0.1:6290 \ DEV_SERVER_COMFYUI_URL=http://127.0.0.1:6290 \ DISTRIBUTION=cloud NODE_OPTIONS=--no-experimental-webstorage \ pnpm exec playwright test \ browser_tests/tests/agent/agentTwoSessionCrdtSubscription.spec.ts \ --project=cloud --workers=1 --retries=0 ``` Head `c61b3507f136c3c687833024af59a0fb8432aad7`: 2/2 focused tests passed against a local backend. Mutation proof at that head makes a canvas reader that always throws fail at that exact error instead of passing as PM-1535. `6a40cf8` trims the harness (schema-parsed `doc_subscribe`, private internals, catalog taken from the build recording, comments moved into assertion and marker messages) without changing either oracle; ESLint, type-aware oxlint, oxfmt, `pnpm typecheck:browser`, and the hosted cloud Playwright shards cover it. Related: PM-1535 --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
Requested by Christian Byrne · Slack thread
Test-only PR. It adds failing end-to-end repros (Playwright
test.fail) for two related in-app-agent CRDT bugs that share one root cause, plus the reusable harness they run on. No product code changes.Before
When one running app has two agent sessions bound to two workflow tabs, the CRDT follower's subscribe target is the session's
boundWorkflowId. That value only moves on a turn ack, anagent_active_tab,loadThread, ornewChat, never when the user simply clicks back to an earlier tab. So once a second session binds a second workflow, the follower is pointed at that second workflow, and the first tab is left with a follower bound to a workflow that is not the one on screen:After
The new spec reproduces both failures deterministically and pins them to that single mechanism. A passing control in the same spec proves the harness actually observes minting and delivery, so the two
test.failcases are real red, not vacuous.Both are marked
test.fail(they document known-broken behavior); each carries a comment telling a future fixer exactly when to remove the marker.New two-session CRDT harness
browser_tests/fixtures/agentTwoSessionCrdtFixture.tsis new reusable infrastructure. Reviewers should read it as the load-bearing part of this PR:HostDoc(the real@comfyorg/comfy-multi-playerlibrary, only the transport faked) that the existing single-session replay fixture already uses.bindViaActiveTab()binds a workflow the way the agent does when it moves the user's canvas: it sends a realagent_active_tabframe, the panel opens/creates that workflow's tab, binds the session to it, and the follower subscribes, at which point the shared host answers with that workflow's catch-up. This is what lets one app hold two independently agent-bound workflows, which is the scenario the reports describe and which the existing fixtures could not express./ws, answersdoc_subscribefrom the matching host, and records every outbounddoc_opsframe so a test can assert what reached which doc. It exposeshostEdit()(apply + broadcast an effect frame),subscribeCount(), anddocOpsCount().The spec drives real tab switches through the topbar and reads canvas widget values and outbound frames, so the assertions are on user-visible state and wire behavior, not on internals.
Test results (local, cloud project)
cfgstays at the pre-edit value (7) instead of the value the host applied while away (5). This confirms the leading hypothesis: the follower's subscribe target isboundWorkflowIdand is never re-derived from the active tab, so no resubscribe fires on return.cfgedit on the active (returned-to) tab produces nodoc_opsframe for that workflow at all. The control proves the same edit does reach the doc when the active tab and the bound workflow agree, so the write loss is caused by the follower/mint port being bound to the other session's workflow, the same root cause as the read-path failure. The exact reported symptom of a single frame being addressed to the doc being left before an unsubscribe a few ms later is a sub-frame reactivity race that a deterministic harness cannot force; the deterministic write-loss it produces is what this test captures.Test plan
pnpm typecheckpnpm lint(eslint) andpnpm exec oxlinton the new filespnpm format:check(oxfmt)pnpm knip🤖 Generated with Claude Code
https://claude.ai/code/session_016oZCk4m4Hhf2uLcer3KFWD
Generated by Claude Code