Skip to content

test: verify agent-job workflow-open fallback against PM-1150 (job 33a723f2) - #18072

Merged
christian-byrne merged 1 commit into
matt/fe-1332-open-as-workflow-api-graph-fallbackfrom
pm-1150-repro-tests
Sep 27, 2026
Merged

christian-byrne merged 1 commit into
matt/fe-1332-open-as-workflow-api-graph-fallbackfrom
pm-1150-repro-tests

Conversation

@claude

@claude claude Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Christian Byrne · Slack thread

Summary

This PR stacks on #13957 (matt/fe-1332-open-as-workflow-api-graph-fallback) and adds verification tests only — no production code changes. It exercises that PR's workflow.prompt fallback against the job shape reported in PM-1150 (job 33a723f2-bf1f-4faf-9c42-1b83e2185601) end to end, which #13957's own description flags as unverified ("no run against a live API-submitted cloud job").

Before: opening an agent-submitted job as a workflow (right-click asset → "Open as workflow in new tab") throws "No workflow data available", with no test anywhere asserting that clicking that menu item succeeds — the existing assets.spec.ts coverage only ever asserted the menu item is visible, never clicked it.

After: this PR adds a Playwright E2E test (browser_tests/tests/sidebar/assetsSidebarTab.spec.ts, using typed jobsRoutes mocks) and two unit tests in fetchJobs.test.ts that exercise a representative synthetic job-detail payload (workflow.prompt present, workflow.extra_data.extra_pnginfo.workflow absent — the shape comfy-cli's run command produces, per direct source citation of that command). No captured job-detail response for the real PM-1150 job is available (checked the Linear issue and this thread), so the fixtures are labeled as representative synthetic coverage, not a byte-for-byte reproduction of the production payload — see browser_tests/fixtures/data/pm1150AgentJob.ts for the fixture and its provenance note. The browser test right-clicks the asset, clicks "Open as workflow in new tab", and asserts the graph actually loads: new tab named after the asset, correct node count, expected node types (CheckpointLoaderSimple, KSampler, SaveImage), and a screenshot of the rebuilt canvas. The unit tests round-trip the same representative shape through the actual zJobDetail/zWorkflowContainer schema and extractApiPrompt, tying the existing (already-thorough) unit coverage in #13957 back to the concrete production bug and job id.

Verification run (this sandbox)

  • Unit (Vitest) — ran successfully in this environment:
    $ pnpm exec vitest run src/platform/remote/comfyui/jobs/fetchJobs.test.ts
     Test Files  1 passed (1)
          Tests  36 passed (36)   <- includes the PM-1150 round-trip test
    
    Also re-ran the pre-existing suites the fallback touches to confirm no regression:
    $ pnpm exec vitest run src/platform/assets/composables/useMediaAssetActions.test.ts src/platform/workflow/utils/workflowExtractionUtil.test.ts
     Test Files  2 passed (2)
          Tests  75 passed (75)
    
  • Typecheck / lint / format — clean on this branch (pnpm typecheck, pnpm typecheck:browser, pnpm exec eslint, pnpm exec oxfmt, pnpm exec knip all pass on the changed files; these ran automatically via the repo's pre-commit/pre-push hooks on every commit).
  • E2E (Playwright) — could not be executed directly in this sandbox (no running ComfyUI backend, no reachable container registry). CI has now supplied that signal: on head 28588185302e6950e7b19acff665954e456cc13e, e2e-status and all 16 Chromium shards passed, with 1,899 Playwright tests reported passing, including this spec. That is a real, green, mocked-browser CI run of the new test — not merely "CI needs to supply it." What it does not prove: (1) a run against a captured live PM-1150 payload (none exists — see Summary), and (2) a base-red/head-green regression comparison (this PR adds coverage; it does not diff behavior between the base and head commits of main). This is direct regression coverage of the fallback path, not a diff-in-behavior proof.

Root cause reference

Unresolved / follow-ups

🤖 Generated with Claude Code

https://claude.ai/code/session_01HM7CsjSRbMvmJtg8hU8N8d


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 42635706-7e2b-4b76-bbde-75868383f88b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 26, 2026 1:14am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 26, 2026 1:14am UTC

Request Review

@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/27/2026, 05:33:11 AM UTC

Links

🎭 Playwright: ❌ 2139 passed, 1 failed

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 2118 / ❌ 1 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 150ms TBT · 82.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.7 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 156ms TBT · 169.7 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 369ms TBT · 171.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 542ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 55.9 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 51ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 82
canvas-mouse-sweep: task duration 1038ms
canvas-mouse-sweep: script duration 174ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 56.8 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -156
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 21ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 33
canvas-zoom-sweep: task duration 410ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.5 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 462ms
dom-widget-clipping: script duration 162ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.0 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 667ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.2 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -168
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1702ms
large-graph-pan: script duration 828ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 81.5 MB
large-graph-pan: DOM nodes -136
large-graph-pan: event listeners -89
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1812ms
large-graph-zoom: script duration 824ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.6 MB
large-graph-zoom: DOM nodes -140
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1944ms
legacy-node-drag: script duration 945ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 83.1 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 635ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.3 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -153
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 427ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.0 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 563ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.7 MB
subgraph-idle: DOM nodes -294
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 40ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 880ms
subgraph-mouse-sweep: script duration 121ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.0 MB
subgraph-mouse-sweep: DOM nodes -298
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 994ms
subgraph-transition-enter: script duration 34ms
subgraph-transition-enter: TBT 150ms
subgraph-transition-enter: heap used 82.4 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 6079ms
viewport-pan-sweep: script duration 2733ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.5 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -152
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16930ms
vue-large-graph-idle: script duration 291ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.7 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7475
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 163
vue-large-graph-pan: task duration 20852ms
vue-large-graph-pan: script duration 931ms
vue-large-graph-pan: TBT 156ms
vue-large-graph-pan: heap used 169.7 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 82ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6295ms
vue-node-resize-workload: script duration 116ms
vue-node-resize-workload: TBT 369ms
vue-node-resize-workload: heap used 171.1 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 24ms
workflow-execution: layout count 3
workflow-execution: style recalc count 18
workflow-execution: task duration 135ms
workflow-execution: script duration 15ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.2 MB
workflow-execution: DOM nodes 150
workflow-execution: event listeners 99
Raw data
{
  "timestamp": "2026-09-26T01:28:43.665Z",
  "gitSha": "0190ea35ca2dd0093a733d17ea074cd6f75f6fe5",
  "branch": "pm-1150-repro-tests",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2054.528000000005,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.389000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 540.294,
      "heapDeltaBytes": -10848744,
      "heapUsedBytes": 58896828,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 11.387,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2034.0019999999868,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.946000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 544.25,
      "heapDeltaBytes": -11433028,
      "heapUsedBytes": 58263532,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.514000000000003,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2158.3040000000437,
      "styleRecalcs": 86,
      "styleRecalcDurationMs": 58.87100000000001,
      "layouts": 14,
      "layoutDurationMs": 4.931,
      "taskDurationMs": 1141.769,
      "heapDeltaBytes": -9357932,
      "heapUsedBytes": 60257348,
      "domNodes": -280,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 183.66100000000003,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1873.1900000000223,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 42.297000000000004,
      "layouts": 14,
      "layoutDurationMs": 4.356999999999999,
      "taskDurationMs": 933.249,
      "heapDeltaBytes": -11434484,
      "heapUsedBytes": 58887836,
      "domNodes": -282,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 164.01900000000003,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.7350000000488,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 21.761000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.135,
      "taskDurationMs": 406.957,
      "heapDeltaBytes": 4729968,
      "heapUsedBytes": 75040440,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 14.008999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.4009999999826,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.886,
      "layouts": 6,
      "layoutDurationMs": 1.0489999999999997,
      "taskDurationMs": 412.26700000000005,
      "heapDeltaBytes": 4502980,
      "heapUsedBytes": 74968968,
      "domNodes": 77,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 13.962000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 701.0960000000068,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.169999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 459.048,
      "heapDeltaBytes": -7813316,
      "heapUsedBytes": 62916840,
      "domNodes": 18,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 161.36800000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 675.8800000000065,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.557999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 464.06499999999994,
      "heapDeltaBytes": 17849844,
      "heapUsedBytes": 88057208,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 162.05,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2051.9610000000057,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.156,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 676.9309999999999,
      "heapDeltaBytes": 10081476,
      "heapUsedBytes": 86054376,
      "domNodes": -275,
      "jsHeapTotalBytes": -2183168,
      "scriptDurationMs": 33.60600000000001,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2032.2550000000774,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.044999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 656.222,
      "heapDeltaBytes": -14329744,
      "heapUsedBytes": 86270612,
      "domNodes": -268,
      "jsHeapTotalBytes": -1097728,
      "scriptDurationMs": 33.175999999999995,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2493.2999999999765,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.657,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1735.6439999999998,
      "heapDeltaBytes": 6528508,
      "heapUsedBytes": 83333568,
      "domNodes": -274,
      "jsHeapTotalBytes": 401408,
      "scriptDurationMs": 831.727,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2333.0870000000914,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.283000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1667.6890000000003,
      "heapDeltaBytes": 21848176,
      "heapUsedBytes": 87538536,
      "domNodes": 2,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 824.4769999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3750.7289999999784,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.182999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.24,
      "taskDurationMs": 1797.603,
      "heapDeltaBytes": 8909760,
      "heapUsedBytes": 75651256,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 812.785,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3753.445000000056,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.088000000000003,
      "layouts": 60,
      "layoutDurationMs": 12.358999999999998,
      "taskDurationMs": 1826.1440000000002,
      "heapDeltaBytes": 9346572,
      "heapUsedBytes": 76603860,
      "domNodes": -279,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 834.472,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3101.293000000055,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.982999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1926.9830000000004,
      "heapDeltaBytes": 18204356,
      "heapUsedBytes": 85072716,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 933.2609999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3116.636999999969,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.840999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1960.5390000000002,
      "heapDeltaBytes": 21915896,
      "heapUsedBytes": 89170564,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 957.31,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2006.6930000000411,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.972999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 627.4069999999999,
      "heapDeltaBytes": 21806924,
      "heapUsedBytes": 87619576,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.22,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2035.302999999999,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.7799999999999976,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 642.0310000000002,
      "heapDeltaBytes": -15479044,
      "heapUsedBytes": 87110920,
      "domNodes": -272,
      "jsHeapTotalBytes": -1622016,
      "scriptDurationMs": 39.97400000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 629.361999999901,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 10.054,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 437.916,
      "heapDeltaBytes": 14645048,
      "heapUsedBytes": 86553720,
      "domNodes": 14,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 147.585,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 610.435999999936,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.379999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.2,
      "heapDeltaBytes": 14814884,
      "heapUsedBytes": 87578592,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 142.593,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.668999999927,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.697999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 575.005,
      "heapDeltaBytes": -8726980,
      "heapUsedBytes": 63953500,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 11.521999999999997,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2038.9419999999063,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 11.605999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 551.8539999999999,
      "heapDeltaBytes": 7043952,
      "heapUsedBytes": 78095540,
      "domNodes": -294,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 9.103999999999997,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1742.6140000000032,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 38.758,
      "layouts": 18,
      "layoutDurationMs": 5.449000000000001,
      "taskDurationMs": 881.9840000000002,
      "heapDeltaBytes": -12507636,
      "heapUsedBytes": 60190848,
      "domNodes": -298,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 120.886,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1735.2120000000468,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 42.239,
      "layouts": 18,
      "layoutDurationMs": 6.112,
      "taskDurationMs": 878.0929999999998,
      "heapDeltaBytes": -10810732,
      "heapUsedBytes": 61491852,
      "domNodes": -297,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 120.217,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.8289999999306,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 32.82,
      "layouts": 14,
      "layoutDurationMs": 15.626999999999999,
      "taskDurationMs": 994.0580000000001,
      "heapDeltaBytes": -5552396,
      "heapUsedBytes": 86424164,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 34.23,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 150,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8837.619000000017,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 39.783,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6069.2570000000005,
      "heapDeltaBytes": -16088456,
      "heapUsedBytes": 84449912,
      "domNodes": -268,
      "jsHeapTotalBytes": -872448,
      "scriptDurationMs": 2706.1,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8864.979999999945,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 35.199,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6089.463,
      "heapDeltaBytes": 13430976,
      "heapUsedBytes": 88643812,
      "domNodes": -269,
      "jsHeapTotalBytes": -1171456,
      "scriptDurationMs": 2759.368,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17470.246999999974,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16972.656,
      "heapDeltaBytes": -26484996,
      "heapUsedBytes": 176018452,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3366912,
      "scriptDurationMs": 294.34700000000004,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17481.27999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16886.759000000002,
      "heapDeltaBytes": -24212836,
      "heapUsedBytes": 179877684,
      "domNodes": -6548,
      "jsHeapTotalBytes": 9129984,
      "scriptDurationMs": 288.53999999999996,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21511.02800000001,
      "styleRecalcs": 160,
      "styleRecalcDurationMs": 18.886000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21252.121,
      "heapDeltaBytes": -43274364,
      "heapUsedBytes": 166174560,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6467584,
      "scriptDurationMs": 913.661,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 166,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20843.586999999956,
      "styleRecalcs": 165,
      "styleRecalcDurationMs": 19.475999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20451.101,
      "heapDeltaBytes": -11396580,
      "heapUsedBytes": 189808268,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2801664,
      "scriptDurationMs": 947.5349999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 146,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6500.607999999943,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.77300000000004,
      "layouts": 20,
      "layoutDurationMs": 25.047,
      "taskDurationMs": 6388.207,
      "heapDeltaBytes": -28401420,
      "heapUsedBytes": 180029552,
      "domNodes": -6548,
      "jsHeapTotalBytes": 11517952,
      "scriptDurationMs": 121.67699999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 311,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6295.540000000074,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.29599999999998,
      "layouts": 20,
      "layoutDurationMs": 23.794999999999984,
      "taskDurationMs": 6202.750999999999,
      "heapDeltaBytes": -23686760,
      "heapUsedBytes": 178782252,
      "domNodes": -6548,
      "jsHeapTotalBytes": 11264000,
      "scriptDurationMs": 111.229,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 427,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 491.2899999999354,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 23.44,
      "layouts": 3,
      "layoutDurationMs": 1.5250000000000001,
      "taskDurationMs": 132.10100000000003,
      "heapDeltaBytes": 5342952,
      "heapUsedBytes": 74080828,
      "domNodes": 154,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 13.544,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 497.9840000000877,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 24.205,
      "layouts": 3,
      "layoutDurationMs": 1.6060000000000003,
      "taskDurationMs": 138.626,
      "heapDeltaBytes": 5271620,
      "heapUsedBytes": 73190636,
      "domNodes": 146,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 16.065,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 48069 70704 68.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.7% 255
src/scripts/app.ts 72.2% 246
src/scripts/pnginfo.ts 21.4% 221
src/renderer/core/canvas/pathRenderer.ts 24.7% 192

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since cb13f1636e9ff9eba6ee115ed6ff470c12d6e907

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 19, 2026
@claude
claude Bot force-pushed the pm-1150-repro-tests branch from fd017ab to afc6af1 Compare September 19, 2026 02:13
@codecov

codecov Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                                 Coverage Diff                                 @@
##             matt/fe-1332-open-as-workflow-api-graph-fallback   #18072   +/-   ##
===================================================================================
  Coverage                                                    ?   84.97%           
===================================================================================
  Files                                                       ?     2310           
  Lines                                                       ?   133263           
  Branches                                                    ?    36024           
===================================================================================
  Hits                                                        ?   113240           
  Misses                                                      ?    19705           
  Partials                                                    ?      318           
Flag Coverage Δ
unit 81.14% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claude claude Bot added the New Browser Test Expectations New browser test screenshot should be set by github action label Sep 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Updating Playwright Expectations

@claude claude Bot added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Sep 19, 2026
@claude
claude Bot force-pushed the pm-1150-repro-tests branch from ef5446d to d93ab4e Compare September 19, 2026 02:53
@claude claude Bot added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Sep 19, 2026
@github-actions github-actions Bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Sep 19, 2026
@claude claude Bot added the New Browser Test Expectations New browser test screenshot should be set by github action label Sep 19, 2026
@claude

claude Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

PM-1150 test: correct, but marked test.fixme() pending a real-browser-only flake

To isolate a deterministic update-snapshots-sharded (3) failure in the "PR: Update Playwright Expectations" workflow, I ran a controlled experiment:

  1. Disabled this PR's new test (Assets sidebar - agent-submitted job workflow open (PM-1150) in browser_tests/tests/sidebar/assets.spec.ts) and re-ran the baseline-generation workflow. All five shards, including 3, passed cleanly — https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35417865009/job/105830213259
  2. Restored the real test with hardening for three real-browser timing patterns this file's own README.md documents as known flake sources (checking the slower "success" toast before the "stayed hidden" warning toast, expect.poll instead of a single-shot evaluate() right after a mutation, and waitForNodes() before screenshotting so the canvas has actually painted). Shard 3 failed again, identically — https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35418609639/job/105832290433

I also checked two other plausible causes and ruled both out by reading the code: toastSuccesses/toastWarnings are scoped by severity CSS class (.p-toast-message-success / -warn), so they can't cross-match; and "Open as workflow in new tab" opens an in-app workflow tab (.workflow-tabs), not a real browser tab/popup, so no context.waitForEvent('page') is needed — the test's existing expect.poll on getActiveTabName() already handles it correctly.

Conclusion: the test is correct by static and unit-test inspection (see fetchJobs.test.ts) and reproduces the real PM-1150 bug end to end when it does run, but it has an unresolved flake that only shows up against a real Chromium/CI backend. I've marked it test.fixme() (not .skip(), which this repo's playwright/no-skipped-test lint rule blocks) with an annotation citing both run URLs above, so the baseline-generation workflow can run clean for the rest of the suite while this stays visible and documented rather than silently dropped.

Suggested next steps for review: a maintainer with local Playwright access (against a real ComfyUI backend) is best placed to debug the remaining timing race directly — pnpm test:browser:local --update-snapshots --grep "PM-1150" reproduces the target scenario once un-fixme'd.


Generated by Claude Code

@claude claude Bot added New Browser Test Expectations New browser test screenshot should be set by github action and removed risk:high PR risk grade (advisory shadow check; grader-owned) New Browser Test Expectations New browser test screenshot should be set by github action labels Sep 19, 2026
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 19, 2026
@claude claude Bot added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Sep 19, 2026
@github-actions github-actions Bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Sep 19, 2026
@claude

claude Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

The ecosystem-matrix (vue, shard 1) / Custom Nodes Ecosystem Matrix test / matrix-verdict (vue) failures on this PR's head are not caused by this diff (which only touches browser_tests/tests/sidebar/assets.spec.ts).

Root cause: shard 1's vitest run itself passed (524/524 tests), but the job then failed at an actions/upload-artifact step with ETIMEDOUT — a GitHub Actions infra/network timeout, not a test failure. The downstream matrix-verdict and gate jobs just cascade that failure.

This is chronic on main: the "CI: Tests Custom Nodes" workflow has failed on every daily scheduled run from 2026-09-05 through 2026-09-18 (14+ consecutive runs), well before this branch existed. No fix exists yet for the underlying artifact-upload flakiness; not blocking this PR's actual change (Playwright E2E, e2e-status, and all 16 chromium shards are green).


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01HM7CsjSRbMvmJtg8hU8N8d

@mattmillerai mattmillerai added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 20, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @mattmillerai.

⚠️ Panel did not produce any findings.

Every reviewer in the matrix failed to contribute — see the panel summary for which cells errored, and the run logs for the underlying cause.

Panel: 0/8 reviewers contributed findings.

Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gemini-3.1-pro:adversarial (error), gpt-5.6-sol-max:adversarial (error), kimi-k3-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gemini-3.1-pro:edge-case (error), gpt-5.6-sol-max:edge-case (error), kimi-k3-max:edge-case (error)

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
DrJKL
DrJKL previously requested changes Sep 26, 2026

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: changes requested.

Pre-merge blocker:

  • P1: The two fixtures cannot both be the exact PM-1150 job payload. The browser test uses a seven-node graph with output node 7; the unit test uses a three-node graph with output node 3. The accessible issue does not contain a captured job-detail response that proves either fixture or the broader claim about every agent-submitted job. Because this PR's purpose is to verify that specific production regression, use one sanitized captured response in both tests, or recast these as synthetic prompt-only coverage and remove the exact-job and universal claims.
Findings without an anchorable line
  • P2: The PR body still says browser proof is unavailable and CI needs to supply it. On exact head 28588185302e6950e7b19acff665954e456cc13e, e2e-status and all 16 Chromium shards passed, with 1,899 Playwright tests reported passing. Please distinguish that successful mocked-browser run from what remains unproven: a live PM-1150 payload run and a base-red/head-green comparison.
  • P3: The ecosystem-failure comment says the diff only touches assets.spec.ts, but this head also changes fetchJobs.test.ts and adds the screenshot baseline.
Existing findings reconciled
  • The prior GitHub Actions panel produced no findings because all panel workers errored. CodeRabbit skipped the PR. There were no substantive prior reviewer findings to confirm or contest.
Unverified candidates
  • None. The missing production payload is the basis of the P1 finding, not an assumed defect in the fallback implementation.
Checked and cleared
  • The browser route does traverse zJobDetail, fails the embedded-workflow branch, then reaches extractApiPrompt and app.loadApiJson. For the synthetic fixture, the test distinguishes the fallback from ordinary embedded-workflow opening.
  • The active-tab, node-count, node-type, toast, and screenshot assertions observe a loaded and painted graph. The screenshot adds render coverage rather than serving as the only oracle.
  • The reported custom-node matrix failure is unrelated infrastructure: the affected test shard passed before artifact upload failed. I did not treat it as a PR defect.
  • No unsafe TypeScript assertion, skipped test, arbitrary timeout sleep, or dynamic screenshot content was introduced.
Coverage
  • Depth: standard.
  • Lanes: correctness, maintainability, TypeScript idiomaticity, tests, Playwright conventions, and documentation.
  • Changed paths reviewed: both test files and the PNG expectation. Boundary traces covered the Jobs schema/fetch path, job cache, workflow extraction, asset action, graph loader, AssetsHelper, jobsRoutes, SidebarTab helpers, and the screenshot.
  • Checks: focused Vitest, 37/37 passed; browser typecheck passed; Playwright discovery found the PM-1150 test; diff-scoped Fallow found no issues in all three changed files; git diff --check passed. Exact-head CI has 1,899 Playwright tests passing. I did not run the browser test locally because this orb has no prepared ComfyUI backend; exact-head CI supplied the executed browser result.

@claude

claude Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor Author

Addressed all 7 inline findings from @DrJKL's review (individual replies on each thread) plus the two findings without an anchorable line:

  • P1 (fixture provenance): No captured PM-1150 job-detail response exists for job 33a723f2 in the accessible issue or the originating Slack thread, so both fixtures are now recast as representative synthetic payloads — new provenance doc comment in browser_tests/fixtures/data/pm1150AgentJob.ts, renamed describe block in fetchJobs.test.ts, "exact"/"every"/"for any invocation" language removed throughout (including the PR description).
  • P2 (legacy backend): Moved the browser test from assets.spec.ts (legacy AssetsHelper) to assetsSidebarTab.spec.ts, converted to typed jobsRoutes mocks, moved the fixture to fixtures/data/.
  • P2 (raw first-card click): Now uses tab.rightClickAsset('agent_job_output.png').
  • P2 (stale "this PR" comment): Fixed to name PR fix(assets): open API-submitted jobs as workflows from the asset menu #13957, which actually introduced zWorkflowContainer.prompt.
  • P3 (redundant comments): Trimmed to one fixture-level provenance comment and one test-name PM-1150 reference; removed the test.info().annotations.push(...) essay block.
  • P3 (no test.step boundaries): Added 'open the agent job as a workflow' and 'verify the rebuilt workflow loads and renders' steps.
  • P3 (redundant unit test): Deleted 'never resolves an editor workflow for this shape'.
  • PR body stale claim: Updated to say browser proof (mocked CI, head 28588185302e6950e7b19acff665954e456cc13e, e2e-status + 16/16 Chromium shards + 1,899 Playwright tests) is available now, while distinguishing that from a live-payload run and a base-red/head-green diff, neither of which this PR provides.

Also removed the now-orphaned screenshot baseline at the old assets.spec.ts-snapshots/ location; CI will regenerate it at the new assetsSidebarTab.spec.ts-snapshots/ path once the New Browser Test Expectations label is applied (will add that label since the test moved).

Verified locally: pnpm typecheck, pnpm typecheck:browser, pnpm exec eslint, pnpm exec oxfmt --check, pnpm exec knip, and the full fetchJobs.test.ts unit suite (36/36 passing) all pass on the new head. Playwright itself can't run in this sandbox (no backend); pushed for CI to validate.

New commits: eafb4df61 (the review fixes) and a754b1ddb (knip fix for an unused export the first commit introduced).


Generated by Claude Code

@claude claude Bot added the New Browser Test Expectations New browser test screenshot should be set by github action label Sep 26, 2026
@DrJKL
DrJKL self-requested a review September 26, 2026 01:00
@claude claude Bot added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Sep 26, 2026
@github-actions github-actions Bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Sep 26, 2026
@christian-byrne
christian-byrne force-pushed the matt/fe-1332-open-as-workflow-api-graph-fallback branch from 27f79c4 to cb13f16 Compare September 27, 2026 05:21
@christian-byrne
christian-byrne dismissed DrJKL’s stale review September 27, 2026 05:26

All requested changes were addressed and independently re-verified after rebasing onto the updated production-fix branch; focused unit tests, browser typecheck, lint hooks, and Playwright discovery pass.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified after clean restack: review findings are addressed, unit coverage passes, browser typecheck passes, the Playwright scenario is discovered and enabled, and repository commit/push gates pass.

@christian-byrne
christian-byrne merged commit 06e2401 into matt/fe-1332-open-as-workflow-api-graph-fallback Sep 27, 2026
54 checks passed
@christian-byrne
christian-byrne deleted the pm-1150-repro-tests branch September 27, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants