Repository navigation
test: verify agent-job workflow-open fallback against PM-1150 (job 33a723f2) - #18072
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 2139 passed, 1 failed❌ Failed Tests📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-26T01:28:43.665Z",
"gitSha": "0190ea35ca2dd0093a733d17ea074cd6f75f6fe5",
"branch": "pm-1150-repro-tests",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.528000000005,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.389000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.294,
"heapDeltaBytes": -10848744,
"heapUsedBytes": 58896828,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.387,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2034.0019999999868,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.946000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.25,
"heapDeltaBytes": -11433028,
"heapUsedBytes": 58263532,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.514000000000003,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2158.3040000000437,
"styleRecalcs": 86,
"styleRecalcDurationMs": 58.87100000000001,
"layouts": 14,
"layoutDurationMs": 4.931,
"taskDurationMs": 1141.769,
"heapDeltaBytes": -9357932,
"heapUsedBytes": 60257348,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 183.66100000000003,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1873.1900000000223,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.297000000000004,
"layouts": 14,
"layoutDurationMs": 4.356999999999999,
"taskDurationMs": 933.249,
"heapDeltaBytes": -11434484,
"heapUsedBytes": 58887836,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 164.01900000000003,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.7350000000488,
"styleRecalcs": 33,
"styleRecalcDurationMs": 21.761000000000003,
"layouts": 6,
"layoutDurationMs": 1.135,
"taskDurationMs": 406.957,
"heapDeltaBytes": 4729968,
"heapUsedBytes": 75040440,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.008999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.4009999999826,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.886,
"layouts": 6,
"layoutDurationMs": 1.0489999999999997,
"taskDurationMs": 412.26700000000005,
"heapDeltaBytes": 4502980,
"heapUsedBytes": 74968968,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 13.962000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 701.0960000000068,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.169999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.048,
"heapDeltaBytes": -7813316,
"heapUsedBytes": 62916840,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 161.36800000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 675.8800000000065,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.557999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.06499999999994,
"heapDeltaBytes": 17849844,
"heapUsedBytes": 88057208,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 162.05,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2051.9610000000057,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.156,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 676.9309999999999,
"heapDeltaBytes": 10081476,
"heapUsedBytes": 86054376,
"domNodes": -275,
"jsHeapTotalBytes": -2183168,
"scriptDurationMs": 33.60600000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2032.2550000000774,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.044999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 656.222,
"heapDeltaBytes": -14329744,
"heapUsedBytes": 86270612,
"domNodes": -268,
"jsHeapTotalBytes": -1097728,
"scriptDurationMs": 33.175999999999995,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2493.2999999999765,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.657,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1735.6439999999998,
"heapDeltaBytes": 6528508,
"heapUsedBytes": 83333568,
"domNodes": -274,
"jsHeapTotalBytes": 401408,
"scriptDurationMs": 831.727,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2333.0870000000914,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.283000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1667.6890000000003,
"heapDeltaBytes": 21848176,
"heapUsedBytes": 87538536,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 824.4769999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3750.7289999999784,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.182999999999998,
"layouts": 60,
"layoutDurationMs": 12.24,
"taskDurationMs": 1797.603,
"heapDeltaBytes": 8909760,
"heapUsedBytes": 75651256,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 812.785,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3753.445000000056,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.088000000000003,
"layouts": 60,
"layoutDurationMs": 12.358999999999998,
"taskDurationMs": 1826.1440000000002,
"heapDeltaBytes": 9346572,
"heapUsedBytes": 76603860,
"domNodes": -279,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 834.472,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3101.293000000055,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.982999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1926.9830000000004,
"heapDeltaBytes": 18204356,
"heapUsedBytes": 85072716,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 933.2609999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3116.636999999969,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.840999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1960.5390000000002,
"heapDeltaBytes": 21915896,
"heapUsedBytes": 89170564,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 957.31,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2006.6930000000411,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.972999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.4069999999999,
"heapDeltaBytes": 21806924,
"heapUsedBytes": 87619576,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.22,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2035.302999999999,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.7799999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 642.0310000000002,
"heapDeltaBytes": -15479044,
"heapUsedBytes": 87110920,
"domNodes": -272,
"jsHeapTotalBytes": -1622016,
"scriptDurationMs": 39.97400000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.361999999901,
"styleRecalcs": 44,
"styleRecalcDurationMs": 10.054,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.916,
"heapDeltaBytes": 14645048,
"heapUsedBytes": 86553720,
"domNodes": 14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 147.585,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.435999999936,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.379999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.2,
"heapDeltaBytes": 14814884,
"heapUsedBytes": 87578592,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 142.593,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.668999999927,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.697999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.005,
"heapDeltaBytes": -8726980,
"heapUsedBytes": 63953500,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.521999999999997,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2038.9419999999063,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.605999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.8539999999999,
"heapDeltaBytes": 7043952,
"heapUsedBytes": 78095540,
"domNodes": -294,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.103999999999997,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.6140000000032,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.758,
"layouts": 18,
"layoutDurationMs": 5.449000000000001,
"taskDurationMs": 881.9840000000002,
"heapDeltaBytes": -12507636,
"heapUsedBytes": 60190848,
"domNodes": -298,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 120.886,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.2120000000468,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.239,
"layouts": 18,
"layoutDurationMs": 6.112,
"taskDurationMs": 878.0929999999998,
"heapDeltaBytes": -10810732,
"heapUsedBytes": 61491852,
"domNodes": -297,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 120.217,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.8289999999306,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.82,
"layouts": 14,
"layoutDurationMs": 15.626999999999999,
"taskDurationMs": 994.0580000000001,
"heapDeltaBytes": -5552396,
"heapUsedBytes": 86424164,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 34.23,
"eventListeners": 2383,
"totalBlockingTimeMs": 150,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8837.619000000017,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.783,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6069.2570000000005,
"heapDeltaBytes": -16088456,
"heapUsedBytes": 84449912,
"domNodes": -268,
"jsHeapTotalBytes": -872448,
"scriptDurationMs": 2706.1,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8864.979999999945,
"styleRecalcs": 246,
"styleRecalcDurationMs": 35.199,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6089.463,
"heapDeltaBytes": 13430976,
"heapUsedBytes": 88643812,
"domNodes": -269,
"jsHeapTotalBytes": -1171456,
"scriptDurationMs": 2759.368,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17470.246999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16972.656,
"heapDeltaBytes": -26484996,
"heapUsedBytes": 176018452,
"domNodes": -6548,
"jsHeapTotalBytes": -3366912,
"scriptDurationMs": 294.34700000000004,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17481.27999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16886.759000000002,
"heapDeltaBytes": -24212836,
"heapUsedBytes": 179877684,
"domNodes": -6548,
"jsHeapTotalBytes": 9129984,
"scriptDurationMs": 288.53999999999996,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21511.02800000001,
"styleRecalcs": 160,
"styleRecalcDurationMs": 18.886000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21252.121,
"heapDeltaBytes": -43274364,
"heapUsedBytes": 166174560,
"domNodes": -6548,
"jsHeapTotalBytes": -6467584,
"scriptDurationMs": 913.661,
"eventListeners": -7469,
"totalBlockingTimeMs": 166,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20843.586999999956,
"styleRecalcs": 165,
"styleRecalcDurationMs": 19.475999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20451.101,
"heapDeltaBytes": -11396580,
"heapUsedBytes": 189808268,
"domNodes": -6548,
"jsHeapTotalBytes": 2801664,
"scriptDurationMs": 947.5349999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 146,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6500.607999999943,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.77300000000004,
"layouts": 20,
"layoutDurationMs": 25.047,
"taskDurationMs": 6388.207,
"heapDeltaBytes": -28401420,
"heapUsedBytes": 180029552,
"domNodes": -6548,
"jsHeapTotalBytes": 11517952,
"scriptDurationMs": 121.67699999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 311,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6295.540000000074,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.29599999999998,
"layouts": 20,
"layoutDurationMs": 23.794999999999984,
"taskDurationMs": 6202.750999999999,
"heapDeltaBytes": -23686760,
"heapUsedBytes": 178782252,
"domNodes": -6548,
"jsHeapTotalBytes": 11264000,
"scriptDurationMs": 111.229,
"eventListeners": -7471,
"totalBlockingTimeMs": 427,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 491.2899999999354,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.44,
"layouts": 3,
"layoutDurationMs": 1.5250000000000001,
"taskDurationMs": 132.10100000000003,
"heapDeltaBytes": 5342952,
"heapUsedBytes": 74080828,
"domNodes": 154,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 13.544,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 497.9840000000877,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.205,
"layouts": 3,
"layoutDurationMs": 1.6060000000000003,
"taskDurationMs": 138.626,
"heapDeltaBytes": 5271620,
"heapUsedBytes": 73190636,
"domNodes": 146,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.065,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since cb13f1636e9ff9eba6ee115ed6ff470c12d6e907
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
fd017ab to
afc6af1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## matt/fe-1332-open-as-workflow-api-graph-fallback #18072 +/- ##
===================================================================================
Coverage ? 84.97%
===================================================================================
Files ? 2310
Lines ? 133263
Branches ? 36024
===================================================================================
Hits ? 113240
Misses ? 19705
Partials ? 318
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Updating Playwright Expectations |
ef5446d to
d93ab4e
Compare
PM-1150 test: correct, but marked
|
|
The Root cause: shard 1's vitest run itself passed (524/524 tests), but the job then failed at an This is chronic on Generated by Claude Code Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Every reviewer in the matrix failed to contribute — see the panel summary for which cells errored, and the run logs for the underlying cause.
Panel: 0/8 reviewers contributed findings.
Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gemini-3.1-pro:adversarial (error), gpt-5.6-sol-max:adversarial (error), kimi-k3-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gemini-3.1-pro:edge-case (error), gpt-5.6-sol-max:edge-case (error), kimi-k3-max:edge-case (error)
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested.
Pre-merge blocker:
- P1: The two fixtures cannot both be the exact PM-1150 job payload. The browser test uses a seven-node graph with output node
7; the unit test uses a three-node graph with output node3. The accessible issue does not contain a captured job-detail response that proves either fixture or the broader claim about every agent-submitted job. Because this PR's purpose is to verify that specific production regression, use one sanitized captured response in both tests, or recast these as synthetic prompt-only coverage and remove the exact-job and universal claims.
Findings without an anchorable line
- P2: The PR body still says browser proof is unavailable and CI needs to supply it. On exact head
28588185302e6950e7b19acff665954e456cc13e,e2e-statusand all 16 Chromium shards passed, with 1,899 Playwright tests reported passing. Please distinguish that successful mocked-browser run from what remains unproven: a live PM-1150 payload run and a base-red/head-green comparison. - P3: The ecosystem-failure comment says the diff only touches
assets.spec.ts, but this head also changesfetchJobs.test.tsand adds the screenshot baseline.
Existing findings reconciled
- The prior GitHub Actions panel produced no findings because all panel workers errored. CodeRabbit skipped the PR. There were no substantive prior reviewer findings to confirm or contest.
Unverified candidates
- None. The missing production payload is the basis of the P1 finding, not an assumed defect in the fallback implementation.
Checked and cleared
- The browser route does traverse
zJobDetail, fails the embedded-workflow branch, then reachesextractApiPromptandapp.loadApiJson. For the synthetic fixture, the test distinguishes the fallback from ordinary embedded-workflow opening. - The active-tab, node-count, node-type, toast, and screenshot assertions observe a loaded and painted graph. The screenshot adds render coverage rather than serving as the only oracle.
- The reported custom-node matrix failure is unrelated infrastructure: the affected test shard passed before artifact upload failed. I did not treat it as a PR defect.
- No unsafe TypeScript assertion, skipped test, arbitrary timeout sleep, or dynamic screenshot content was introduced.
Coverage
- Depth: standard.
- Lanes: correctness, maintainability, TypeScript idiomaticity, tests, Playwright conventions, and documentation.
- Changed paths reviewed: both test files and the PNG expectation. Boundary traces covered the Jobs schema/fetch path, job cache, workflow extraction, asset action, graph loader, AssetsHelper, jobsRoutes, SidebarTab helpers, and the screenshot.
- Checks: focused Vitest, 37/37 passed; browser typecheck passed; Playwright discovery found the PM-1150 test; diff-scoped Fallow found no issues in all three changed files;
git diff --checkpassed. Exact-head CI has 1,899 Playwright tests passing. I did not run the browser test locally because this orb has no prepared ComfyUI backend; exact-head CI supplied the executed browser result.
|
Addressed all 7 inline findings from @DrJKL's review (individual replies on each thread) plus the two findings without an anchorable line:
Also removed the now-orphaned screenshot baseline at the old Verified locally: New commits: Generated by Claude Code |
27f79c4 to
cb13f16
Compare
db44c5c to
bf227e3
Compare
All requested changes were addressed and independently re-verified after rebasing onto the updated production-fix branch; focused unit tests, browser typecheck, lint hooks, and Playwright discovery pass.
christian-byrne
left a comment
There was a problem hiding this comment.
Verified after clean restack: review findings are addressed, unit coverage passes, browser typecheck passes, the Playwright scenario is discovered and enabled, and repository commit/push gates pass.
06e2401
into
matt/fe-1332-open-as-workflow-api-graph-fallback
Requested by Christian Byrne · Slack thread
Summary
This PR stacks on #13957 (
matt/fe-1332-open-as-workflow-api-graph-fallback) and adds verification tests only — no production code changes. It exercises that PR'sworkflow.promptfallback against the job shape reported in PM-1150 (job33a723f2-bf1f-4faf-9c42-1b83e2185601) end to end, which #13957's own description flags as unverified ("no run against a live API-submitted cloud job").Before: opening an agent-submitted job as a workflow (right-click asset → "Open as workflow in new tab") throws "No workflow data available", with no test anywhere asserting that clicking that menu item succeeds — the existing
assets.spec.tscoverage only ever asserted the menu item is visible, never clicked it.After: this PR adds a Playwright E2E test (
browser_tests/tests/sidebar/assetsSidebarTab.spec.ts, using typedjobsRoutesmocks) and two unit tests infetchJobs.test.tsthat exercise a representative synthetic job-detail payload (workflow.promptpresent,workflow.extra_data.extra_pnginfo.workflowabsent — the shape comfy-cli'sruncommand produces, per direct source citation of that command). No captured job-detail response for the real PM-1150 job is available (checked the Linear issue and this thread), so the fixtures are labeled as representative synthetic coverage, not a byte-for-byte reproduction of the production payload — seebrowser_tests/fixtures/data/pm1150AgentJob.tsfor the fixture and its provenance note. The browser test right-clicks the asset, clicks "Open as workflow in new tab", and asserts the graph actually loads: new tab named after the asset, correct node count, expected node types (CheckpointLoaderSimple,KSampler,SaveImage), and a screenshot of the rebuilt canvas. The unit tests round-trip the same representative shape through the actualzJobDetail/zWorkflowContainerschema andextractApiPrompt, tying the existing (already-thorough) unit coverage in #13957 back to the concrete production bug and job id.Verification run (this sandbox)
pnpm typecheck,pnpm typecheck:browser,pnpm exec eslint,pnpm exec oxfmt,pnpm exec knipall pass on the changed files; these ran automatically via the repo's pre-commit/pre-push hooks on every commit).28588185302e6950e7b19acff665954e456cc13e,e2e-statusand all 16 Chromium shards passed, with 1,899 Playwright tests reported passing, including this spec. That is a real, green, mocked-browser CI run of the new test — not merely "CI needs to supply it." What it does not prove: (1) a run against a captured live PM-1150 payload (none exists — see Summary), and (2) a base-red/head-green regression comparison (this PR adds coverage; it does not diff behavior between the base and head commits ofmain). This is direct regression coverage of the fallback path, not a diff-in-behavior proof.Root cause reference
33a723f2-bf1f-4faf-9c42-1b83e2185601): https://linear.app/comfyorg/issue/PM-1150/test-agent-generated-job-33a723f2-has-no-workflow-attachedruncommand (used by the in-app agent's backend service to submit jobs) never populatesextra_data.extra_pnginfo.workflow, only the API-formatpromptgraph plus a top-levelworkflow_id— confirmed by directcomfy-clisource citation.Unresolved / follow-ups
test.fail()cases were needed.33a723f2-...) exists in the accessible issue or this thread, so both the browser and unit fixtures are representative synthetic payloads, not the exact production payload — flagged and addressed per review (seebrowser_tests/fixtures/data/pm1150AgentJob.ts).useJobMenu.ts, PR fix: fall back to API prompt when opening workflow for API-dispatched jobs #10929, draft) is untouched, per the original task scope.🤖 Generated with Claude Code
https://claude.ai/code/session_01HM7CsjSRbMvmJtg8hU8N8d
Generated by Claude Code