Skip to content

[backport cloud/1.54] fix(stores): align collision contracts across entity registries (FE-1811) - #18054

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-15720-to-cloud-1.54
Sep 19, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-15720-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #15720 to cloud/1.54

Automatically created by backport workflow.

…811) (#15720)

## Summary

- **`nodeDataStore`**: add `console.error` on id collision — it was the
only store that silently rejected without logging, making a real
identity bug indistinguishable from a no-op at runtime. Matches the
style already used by `linkStore` and `rerouteStore`.
- **`widgetValueStore`**: preserve the existing type-mismatch overwrite
behavior, but add a comment in the implementation explaining *why* — the
rationale previously lived only in a test comment, invisible to
extension authors reading the store. Widget keys are slot-addressable
and can legitimately change type after a subgraph convert; this is
intentionally different from the other three stores where IDs are
identity-stable.
- **`nodeDataStore.test.ts`**: extend the existing duplicate-id
rejection test to assert the error is logged.

Closes FE-1811. Answers issue Q5 ("where is that written so an extension
author finds it?") by moving the rationale into the implementation.

## Test plan

- [ ] Existing `nodeDataStore.test.ts` duplicate-id test now asserts
`console.error` is called
- [ ] Existing `widgetValueStore.test.ts` type-mismatch test continues
to pass (behavior unchanged)
- [ ] `pnpm typecheck` passes

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 19, 2026
@vercel

vercel Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 19, 2026 12:08am UTC

Request Review

@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/19/2026, 12:10:38 AM UTC

Links

🎭 Playwright: ✅ 1922 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1901 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 126ms TBT · 99.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.3 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 142ms TBT · 177.5 MB heap
vue-node-resize-workload: · 53.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 411ms TBT · 168.4 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 496ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 71.6 MB
canvas-idle: DOM nodes -278
canvas-idle: event listeners -144
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 36ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 874ms
canvas-mouse-sweep: script duration 149ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 74.8 MB
canvas-mouse-sweep: DOM nodes -278
canvas-mouse-sweep: event listeners -146
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 351ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.7 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 447ms
dom-widget-clipping: script duration 156ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.4 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 603ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.3 MB
large-graph-idle: DOM nodes -266
large-graph-idle: event listeners -158
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1566ms
large-graph-pan: script duration 776ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 81.4 MB
large-graph-pan: DOM nodes -269
large-graph-pan: event listeners -143
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1636ms
large-graph-zoom: script duration 755ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.5 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1852ms
legacy-node-drag: script duration 939ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 90.3 MB
legacy-node-drag: DOM nodes 3
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 570ms
minimap-idle: script duration 30ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.0 MB
minimap-idle: DOM nodes -269
minimap-idle: event listeners -159
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 395ms
subgraph-dom-widget-clipping: script duration 137ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.4 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 458ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 70.9 MB
subgraph-idle: DOM nodes -138
subgraph-idle: event listeners -92
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 794ms
subgraph-mouse-sweep: script duration 102ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.2 MB
subgraph-mouse-sweep: DOM nodes -292
subgraph-mouse-sweep: event listeners -191
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 902ms
subgraph-transition-enter: script duration 28ms
subgraph-transition-enter: TBT 126ms
subgraph-transition-enter: heap used 99.3 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5552ms
viewport-pan-sweep: script duration 2547ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.9 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -143
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16931ms
vue-large-graph-idle: script duration 320ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.3 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 173
vue-large-graph-pan: task duration 21081ms
vue-large-graph-pan: script duration 907ms
vue-large-graph-pan: TBT 142ms
vue-large-graph-pan: heap used 177.5 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
vue-node-resize-workload: avg frame time 19ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 75ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6118ms
vue-node-resize-workload: script duration 115ms
vue-node-resize-workload: TBT 411ms
vue-node-resize-workload: heap used 168.4 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7473
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8529ms
vue-zoom-out-idle: script duration 150ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.6 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 2
workflow-execution: style recalc count 6
workflow-execution: task duration 67ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.4 MB
workflow-execution: DOM nodes 126
workflow-execution: event listeners 18
Raw data
{
  "timestamp": "2026-09-19T00:19:35.134Z",
  "gitSha": "3c7cda656828a0ef8343398be826301b1c541e7a",
  "branch": "backport-15720-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2022.0350000000167,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.387,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 499.703,
      "heapDeltaBytes": 3934868,
      "heapUsedBytes": 74071860,
      "domNodes": -278,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.907999999999999,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2064.4620000000486,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.398999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 492.49999999999994,
      "heapDeltaBytes": 5915592,
      "heapUsedBytes": 76112820,
      "domNodes": -277,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.174999999999999,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1891.3049999999885,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 36.394,
      "layouts": 14,
      "layoutDurationMs": 4.392999999999999,
      "taskDurationMs": 869.1829999999999,
      "heapDeltaBytes": 8109520,
      "heapUsedBytes": 79174692,
      "domNodes": -279,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 146.15,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1892.0830000000137,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.284,
      "layouts": 14,
      "layoutDurationMs": 4.5729999999999995,
      "taskDurationMs": 879.278,
      "heapDeltaBytes": 6688540,
      "heapUsedBytes": 77726156,
      "domNodes": -276,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 151.479,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1663.3699999999862,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 16.08,
      "layouts": 6,
      "layoutDurationMs": 1.0740000000000003,
      "taskDurationMs": 348.282,
      "heapDeltaBytes": 4744680,
      "heapUsedBytes": 74249576,
      "domNodes": 78,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 9.947000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1664.447999999993,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.423000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.1440000000000001,
      "taskDurationMs": 353.21599999999995,
      "heapDeltaBytes": 5001364,
      "heapUsedBytes": 76037604,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.221999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 674.6229999999969,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.143999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.955,
      "heapDeltaBytes": -7914104,
      "heapUsedBytes": 63288396,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 156.691,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 645.4530000000318,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.696000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 435.906,
      "heapDeltaBytes": 18424588,
      "heapUsedBytes": 88650248,
      "domNodes": 16,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 155.197,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2047.65900000001,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.997999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 603.142,
      "heapDeltaBytes": 10942192,
      "heapUsedBytes": 87287004,
      "domNodes": -266,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 32.650999999999996,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.903999999965,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.323999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 602.7940000000001,
      "heapDeltaBytes": 10770288,
      "heapUsedBytes": 87381476,
      "domNodes": -266,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 35.842999999999996,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2164.773999999966,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.431000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1536.0310000000004,
      "heapDeltaBytes": 19210240,
      "heapUsedBytes": 85385348,
      "domNodes": -268,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 761.727,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2177.1499999999833,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.763,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1596.5010000000002,
      "heapDeltaBytes": 19497676,
      "heapUsedBytes": 85382528,
      "domNodes": -270,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 790.9620000000001,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3447.4370000000363,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.241999999999997,
      "layouts": 60,
      "layoutDurationMs": 12.682999999999998,
      "taskDurationMs": 1642.351,
      "heapDeltaBytes": 9250940,
      "heapUsedBytes": 75921124,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 753.19,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3445.316999999932,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.277000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.933,
      "taskDurationMs": 1629.573,
      "heapDeltaBytes": 8195684,
      "heapUsedBytes": 76042260,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 757.2599999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2985.7810000000313,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.218999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1866.0510000000002,
      "heapDeltaBytes": 22148192,
      "heapUsedBytes": 90373880,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 945.0849999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2965.7700000000204,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 7.727000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1837.3,
      "heapDeltaBytes": 19293076,
      "heapUsedBytes": 98955340,
      "domNodes": 6,
      "jsHeapTotalBytes": 3301376,
      "scriptDurationMs": 933.481,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2006.7879999999718,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.153999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 555.643,
      "heapDeltaBytes": 22345396,
      "heapUsedBytes": 88553196,
      "domNodes": -269,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 30.044,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.4609999999457,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.729000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 585.332,
      "heapDeltaBytes": 10332568,
      "heapUsedBytes": 87567640,
      "domNodes": -269,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 30.525000000000002,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 575.3389999999854,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.832,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 400.258,
      "heapDeltaBytes": 15061652,
      "heapUsedBytes": 86915800,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 139.344,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 569.7589999999764,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.594000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 390.426,
      "heapDeltaBytes": 14838596,
      "heapUsedBytes": 87999708,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 135.268,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.9800000000228,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.306,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.626,
      "heapDeltaBytes": 9458580,
      "heapUsedBytes": 82168676,
      "domNodes": -293,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.065999999999999,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.8130000000128,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.175000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.92699999999996,
      "heapDeltaBytes": 1148472,
      "heapUsedBytes": 66505868,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 6.9369999999999985,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.297000000016,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 37.472,
      "layouts": 18,
      "layoutDurationMs": 6.006000000000001,
      "taskDurationMs": 804.122,
      "heapDeltaBytes": -12148016,
      "heapUsedBytes": 60776428,
      "domNodes": -293,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 101.348,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1719.8339999999916,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 36.312,
      "layouts": 18,
      "layoutDurationMs": 5.378000000000001,
      "taskDurationMs": 783.963,
      "heapDeltaBytes": 3235092,
      "heapUsedBytes": 75985472,
      "domNodes": -290,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 103.303,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1367.853000000025,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 30.482000000000003,
      "layouts": 14,
      "layoutDurationMs": 14.387,
      "taskDurationMs": 901.694,
      "heapDeltaBytes": 20013016,
      "heapUsedBytes": 104153676,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 27.88999999999999,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 126,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8400.404999999977,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 38.665,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5556.786,
      "heapDeltaBytes": 8891004,
      "heapUsedBytes": 85152700,
      "domNodes": -267,
      "jsHeapTotalBytes": -1449984,
      "scriptDurationMs": 2543.482,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8236.743000000046,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 38.108000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5546.549,
      "heapDeltaBytes": 12847516,
      "heapUsedBytes": 88623264,
      "domNodes": -269,
      "jsHeapTotalBytes": -1712128,
      "scriptDurationMs": 2550.343,
      "eventListeners": -158,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17839.218000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16985.301,
      "heapDeltaBytes": -30803468,
      "heapUsedBytes": 180445312,
      "domNodes": -6548,
      "jsHeapTotalBytes": 8855552,
      "scriptDurationMs": 309.736,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17796.557000000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16876.108000000004,
      "heapDeltaBytes": -36929992,
      "heapUsedBytes": 174646400,
      "domNodes": -6548,
      "jsHeapTotalBytes": 454656,
      "scriptDurationMs": 329.679,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21578.51400000004,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 18.82400000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21212.726,
      "heapDeltaBytes": -29488812,
      "heapUsedBytes": 181892316,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4907008,
      "scriptDurationMs": 902.7579999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 103,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21276.508999999918,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 19.857999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20950.224,
      "heapDeltaBytes": -13204916,
      "heapUsedBytes": 190416980,
      "domNodes": -6548,
      "jsHeapTotalBytes": 745472,
      "scriptDurationMs": 911.568,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 180,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6227.385999999968,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.98700000000002,
      "layouts": 20,
      "layoutDurationMs": 24.295999999999985,
      "taskDurationMs": 6137.813999999999,
      "heapDeltaBytes": -11676044,
      "heapUsedBytes": 177054412,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12861440,
      "scriptDurationMs": 112.057,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 409,
      "frameDurationMs": 18.886666666666677,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6171.41300000003,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 72.40599999999998,
      "layouts": 20,
      "layoutDurationMs": 22.891999999999996,
      "taskDurationMs": 6097.48,
      "heapDeltaBytes": -28707488,
      "heapUsedBytes": 176131560,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12832768,
      "scriptDurationMs": 118.15299999999999,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 412,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9084.474,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8623.657000000001,
      "heapDeltaBytes": 21725120,
      "heapUsedBytes": 180989260,
      "domNodes": 0,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 144.35700000000006,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8718.57,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8434.519999999999,
      "heapDeltaBytes": -400960,
      "heapUsedBytes": 174779320,
      "domNodes": 0,
      "jsHeapTotalBytes": -8126464,
      "scriptDurationMs": 155.08499999999998,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 90.42199999998957,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 12.036,
      "layouts": 2,
      "layoutDurationMs": 1.2209999999999999,
      "taskDurationMs": 64.70199999999998,
      "heapDeltaBytes": 3017708,
      "heapUsedBytes": 71275904,
      "domNodes": 125,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.0070000000000014,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 98.01900000002206,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.349,
      "layouts": 2,
      "layoutDurationMs": 1.3639999999999999,
      "taskDurationMs": 68.62499999999999,
      "heapDeltaBytes": 3005216,
      "heapUsedBytes": 72077612,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.684999999999998,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 49915 74626 66.9% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 305
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.6% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18054   +/-   ##
=============================================
  Coverage              ?   83.05%           
=============================================
  Files                 ?     2057           
  Lines                 ?   120444           
  Branches              ?    31359           
=============================================
  Hits                  ?   100039           
  Misses                ?    20229           
  Partials              ?      176           
Flag Coverage Δ
e2e 66.89% <100.00%> (?)
unit 77.69% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/core/graph/nodeShell/nodeShellLifecycle.ts 93.33% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodeJuggernaut CodeJuggernaut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean cherry-pick of #15720 onto cloud/1.54.

@comfy-pr-bot
comfy-pr-bot merged commit 13209f4 into cloud/1.54 Sep 19, 2026
101 of 104 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-15720-to-cloud-1.54 branch September 19, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants