Repository navigation
fix: guard slot context menu against non-finite canvas scale - #18034
claude[bot] wants to merge 1 commit into
Conversation
updateAnchorPosition and show() divide/multiply by lgCanvas.ds.scale on every animation frame while the menu is open. If scale is ever 0 or non-finite (e.g. DragAndScale.animateToBounds sets it without going through changeScale's min/max clamp), the derived screenPosition becomes non-finite and dispatchContextMenuEvent throws constructing new MouseEvent with a non-finite clientX/clientY. Fall back to a scale of 1 when the canvas transform is invalid, and skip dispatching the contextmenu event entirely if the resulting position is still non-finite.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 2030 passed, 1 failed · 2 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-18T19:13:19.083Z",
"gitSha": "8b941c28f9eab8c10dd639b134d428bc620f154a",
"branch": "fix/mouseevent-nonfinite-clientx-slot-menu",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.2609999999763,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.531,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.67100000000005,
"heapDeltaBytes": -3447328,
"heapUsedBytes": 58952556,
"domNodes": -263,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.246000000000002,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2006.591999999955,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.9399999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.325,
"heapDeltaBytes": 2643604,
"heapUsedBytes": 64598240,
"domNodes": -263,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.917999999999996,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1965.00199999997,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.715,
"layouts": 14,
"layoutDurationMs": 4.526,
"taskDurationMs": 898.0200000000001,
"heapDeltaBytes": 9029208,
"heapUsedBytes": 69918284,
"domNodes": -264,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 175.031,
"eventListeners": -158,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1908.5860000000139,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.977,
"layouts": 14,
"layoutDurationMs": 4.9430000000000005,
"taskDurationMs": 898.4799999999999,
"heapDeltaBytes": 8800716,
"heapUsedBytes": 71255180,
"domNodes": -263,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 176.07399999999998,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.7060000000024,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.687,
"layouts": 6,
"layoutDurationMs": 1.274,
"taskDurationMs": 364.61299999999994,
"heapDeltaBytes": 2164784,
"heapUsedBytes": 64607288,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.989999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.7040000000216,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.416,
"layouts": 6,
"layoutDurationMs": 1.139,
"taskDurationMs": 342.441,
"heapDeltaBytes": 2199948,
"heapUsedBytes": 64699808,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.033999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 658.476999999948,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.4,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.35600000000005,
"heapDeltaBytes": 17856596,
"heapUsedBytes": 80053992,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 163.92999999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 625.1549999999497,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.572999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.99399999999997,
"heapDeltaBytes": 18128484,
"heapUsedBytes": 80610040,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 162.74099999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2028.3719999999903,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.330000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.0169999999999,
"heapDeltaBytes": 3507764,
"heapUsedBytes": 83537104,
"domNodes": -248,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 32.582,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2018.7169999999242,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.5120000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 574.4639999999998,
"heapDeltaBytes": 2905636,
"heapUsedBytes": 83117236,
"domNodes": -252,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 33.372,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2292.8529999999796,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.487,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1666.251,
"heapDeltaBytes": 14777912,
"heapUsedBytes": 79209476,
"domNodes": -252,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 864.72,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2326.8719999999803,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.384999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1640.2290000000003,
"heapDeltaBytes": 15199820,
"heapUsedBytes": 79569732,
"domNodes": -249,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 832.775,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3619.2290000000185,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.127999999999995,
"layouts": 60,
"layoutDurationMs": 13.347999999999999,
"taskDurationMs": 1731.311,
"heapDeltaBytes": 8105192,
"heapUsedBytes": 74333388,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 792.115,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3518.053000000009,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.445999999999996,
"layouts": 60,
"layoutDurationMs": 12.812000000000001,
"taskDurationMs": 1694.3980000000001,
"heapDeltaBytes": 5428104,
"heapUsedBytes": 70978916,
"domNodes": -258,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 790.9329999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3123.6529999999902,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.685999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1930.027,
"heapDeltaBytes": 20170452,
"heapUsedBytes": 86835352,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 988.682,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3179.263999999989,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.472999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1934.526,
"heapDeltaBytes": 22803272,
"heapUsedBytes": 89426460,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 993.055,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2035.5140000000347,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.507999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.8249999999999,
"heapDeltaBytes": -3663044,
"heapUsedBytes": 83900592,
"domNodes": -250,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 33.336000000000006,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2006.8209999999453,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.9829999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.0179999999999,
"heapDeltaBytes": 19388324,
"heapUsedBytes": 84037152,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.32199999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.4570000000094,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.685,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.163,
"heapDeltaBytes": 13434760,
"heapUsedBytes": 77137832,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.75500000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.4570000000003,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.961,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.387,
"heapDeltaBytes": 13512472,
"heapUsedBytes": 76908780,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.75600000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.7569999999837,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.889,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.513,
"heapDeltaBytes": 4957248,
"heapUsedBytes": 68644008,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.718000000000002,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2001.2590000000046,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.386,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.12500000000006,
"heapDeltaBytes": 12201120,
"heapUsedBytes": 75785440,
"domNodes": -276,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.653999999999998,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.7130000000225,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.903000000000006,
"layouts": 18,
"layoutDurationMs": 5.282,
"taskDurationMs": 816.8069999999999,
"heapDeltaBytes": 5455256,
"heapUsedBytes": 69151048,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 111.83500000000001,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.7999999999774,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.362,
"layouts": 18,
"layoutDurationMs": 5.006,
"taskDurationMs": 784.342,
"heapDeltaBytes": -3615164,
"heapUsedBytes": 60206720,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 107.949,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.4540000000052,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.952999999999992,
"layouts": 5,
"layoutDurationMs": 13.012000000000002,
"taskDurationMs": 956.607,
"heapDeltaBytes": -6390188,
"heapUsedBytes": 80887884,
"domNodes": 13587,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 32.41100000000001,
"eventListeners": 2387,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8494.315000000028,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.806000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5904.116,
"heapDeltaBytes": -3905876,
"heapUsedBytes": 76073364,
"domNodes": -246,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 2787.783,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8497.65100000002,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5939.301,
"heapDeltaBytes": -12862920,
"heapUsedBytes": 67009316,
"domNodes": -248,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 2820.604,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16948.676000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16585.91,
"heapDeltaBytes": -33695944,
"heapUsedBytes": 180776920,
"domNodes": -8090,
"jsHeapTotalBytes": -9445376,
"scriptDurationMs": 268.40000000000003,
"eventListeners": -14926,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16738.12399999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16370.818999999998,
"heapDeltaBytes": -21745848,
"heapUsedBytes": 189458432,
"domNodes": -8061,
"jsHeapTotalBytes": -10031104,
"scriptDurationMs": 261.81,
"eventListeners": -14926,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20307.920000000024,
"styleRecalcs": 147,
"styleRecalcDurationMs": 17.434000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20054.54,
"heapDeltaBytes": -52489856,
"heapUsedBytes": 179303872,
"domNodes": -8061,
"jsHeapTotalBytes": -11866112,
"scriptDurationMs": 883.272,
"eventListeners": -14924,
"totalBlockingTimeMs": 94,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20163.07399999994,
"styleRecalcs": 145,
"styleRecalcDurationMs": 16.36700000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19944.915999999997,
"heapDeltaBytes": -52959756,
"heapUsedBytes": 179590740,
"domNodes": -8061,
"jsHeapTotalBytes": -14528512,
"scriptDurationMs": 867.275,
"eventListeners": -14920,
"totalBlockingTimeMs": 60,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6129.654000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.623,
"layouts": 20,
"layoutDurationMs": 22.551000000000002,
"taskDurationMs": 6060.205,
"heapDeltaBytes": -31284168,
"heapUsedBytes": 183854092,
"domNodes": -8061,
"jsHeapTotalBytes": 15720448,
"scriptDurationMs": 107.37500000000001,
"eventListeners": -14922,
"totalBlockingTimeMs": 373,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6100.3520000000435,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.27699999999999,
"layouts": 20,
"layoutDurationMs": 23.435000000000013,
"taskDurationMs": 6065.474000000001,
"heapDeltaBytes": -33716920,
"heapUsedBytes": 183551468,
"domNodes": -8061,
"jsHeapTotalBytes": 19853312,
"scriptDurationMs": 107.174,
"eventListeners": -14924,
"totalBlockingTimeMs": 429,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8427.96199999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8220.238000000001,
"heapDeltaBytes": 4725396,
"heapUsedBytes": 193858076,
"domNodes": 0,
"jsHeapTotalBytes": -6291456,
"scriptDurationMs": 126.35099999999998,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8380.030000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8234.768999999998,
"heapDeltaBytes": -1551648,
"heapUsedBytes": 179165924,
"domNodes": 0,
"jsHeapTotalBytes": -25427968,
"scriptDurationMs": 127.55299999999997,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 475.371999999993,
"styleRecalcs": 22,
"styleRecalcDurationMs": 27.724,
"layouts": 4,
"layoutDurationMs": 2.174,
"taskDurationMs": 134.15600000000003,
"heapDeltaBytes": 5140024,
"heapUsedBytes": 67253300,
"domNodes": 147,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.187,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 464.76800000004914,
"styleRecalcs": 21,
"styleRecalcDurationMs": 24.729,
"layouts": 4,
"layoutDurationMs": 1.9639999999999995,
"taskDurationMs": 119.24800000000002,
"heapDeltaBytes": 4978408,
"heapUsedBytes": 66911080,
"domNodes": 144,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.72,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## quick-connections-variant-a #18034 +/- ##
===============================================================
+ Coverage 83.54% 83.67% +0.12%
===============================================================
Files 2214 2204 -10
Lines 126801 126419 -382
Branches 35780 35654 -126
===============================================================
- Hits 105936 105778 -158
+ Misses 20581 20353 -228
- Partials 284 288 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 77 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Requested by Christian Byrne · Slack thread
This targets
quick-connections-variant-a(the base of #8691) rather thanmain, becauseSlotContextMenu.vueonly exists on this branch —maindoesn't have this component yet.Summary
Fixes a
TypeError: Failed to construct 'MouseEvent'crash (Sentry,cloud-frontend-staging) inSlotContextMenu.vuecaused by dividing/multiplying by an unvalidated canvas zoom scale on every animation frame while the slot menu is open.Changes
updateAnchorPosition()andshow()inSlotContextMenu.vuenow readlgCanvas.ds.scalethrough agetSafeScale()guard that falls back to1if the value is0or non-finite, instead of dividing/multiplying by it directly.dispatchContextMenuEvent()additionally skips dispatching if the computedscreenPositionis ever still non-finite, sonew MouseEvent(...)is never constructed with a badclientX/clientY.Before / after
Before: while a slot's "Connect to..." menu is open,
updateAnchorPosition()runs every animation frame and recomputes the popup's screen position from the live canvas transform (lgCanvas.ds.scale/offset). Ifscaleis ever0/Infinity/NaNfor a frame, the derived position becomes non-finite and the very nextnew MouseEvent('contextmenu', { clientX, clientY })throws — crashing the component (and, per Sentry, users) instead of just mispositioning the menu.After: an invalid scale falls back to
1so the position math always stays finite, and as a final safety net the contextmenu event is simply skipped (not dispatched) on a frame where the position still isn't finite for any other reason, instead of throwing.Root cause
4d16be0e52("test: verify slot context menu behavior") refactoredshow()'s single, one-timecontextmenudispatch — which previously used the real DOM event's ownevent.clientX/clientY(always finite) — into a shareddispatchContextMenuEvent()helper driven by a derivedscreenPositionref, and wired it to also fire fromupdateAnchorPosition()on everyuseRafFntick while the menu is open (needed so the popup tracks canvas pan/zoom in real time — see the existing "moves the rendered popup when the canvas camera changes" test).That derived position divides by
lgCanvas.ds.scale. Under normal interactionchangeScale()clamps scale to[min_scale, max_scale](0.1–10), butDragAndScale.animateToBounds()(src/lib/litegraph/src/DragAndScale.ts:291, used by fit-view/zoom-to-selection animations) setsthis.scale = Math.min(cw / currentWidth, ch / currentHeight)directly, bypassing that clamp. IfcurrentWidth/currentHeight/cwis ever0mid-animation (e.g. a canvas-resize race),scalebecomes non-finite for that frame, and any slot menu left open at that moment crashes on the nextupdateAnchorPositiontick.This PR only guards the consumer side in
SlotContextMenu.vue, scoped to this feature. It does not touchanimateToBounds's missing clamp — that's a separate, pre-existing bug in shared canvas-zoom code with many other consumers (CurveEditor, node dragging, the minimap, etc.) and deserves its own investigation/PR rather than being bundled into this experimental branch. Flagging it here as a known follow-up, not filing it myself.One correction for the record: an earlier lead attributed this bug to commit
cfb6d3133b, butgit blame/git showconfirm that commit only touches a test file and never touchesSlotContextMenu.vue— the line was actually introduced by4d16be0e52, cited above.Review Focus
scale = 1(vs. e.g. the last known-good scale) is the right recovery behavior, given this is a rare/transient invalid-state case rather than the common path.DragAndScale.animateToBounds's clamp gap is worth fixing now instead of as a follow-up.Testing
SlotContextMenu.test.ts(falls back to a finite position instead of dispatching a non-finite contextmenu event when scale is invalid) that setscanvasTransform.scale = 0and confirms the menu still opens at a finite, correct position. Verified this test fails against the pre-fix code (anchor collapses to0,0instead of the expected position) and passes with the fix.pnpm exec vitest run src/renderer/extensions/vueNodes/components/SlotContextMenu.test.ts— 7/7 passedpnpm exec oxlint,pnpm exec eslint,pnpm exec oxfmt --checkon both changed files — cleanpnpm typecheck(full project) — passed🤖 Generated with Claude Code
https://claude.ai/code/session_01XnhamLRp7jHmfYVzfgBEfb