Repository navigation
[backport cloud/1.54] fix(agent): keep live nodes displayed as saved through a catch-up reconcile - #17995
Conversation
…oncile (#17963) Returning to a workflow tab with Agent open re-binds the follower, and its catch-up reconciled every doc node as a fresh record: the title fell back to the type string and the node's live widgets were cleared for placeholders, so Vue nodes lost their controls and showed an error outline. The catch-up now treats a doc node entry as a value patch for a live node. - **What**: `graphMutations` (moved to `src/workbench/extensions/agent/crdt/`) parses `widgets_values` once into a discriminated `WidgetValuePayload` (`omitted | positional | named`, in the leaf module `nodePayload.ts`) and applies it to live widgets by name or serialized order. A same-type reconcile of a live node never clears its widgets; only a type change replaces the node (`deleteNode` then `addNode`). Titles fall back to the registered display name, then the type. `ecsFollowerAdapter` hands the host branch to `reconcileNodeFields` instead of looping `setWidget` per name. - **Tests first**: contract table for the widget payload (10 rows), title table (4 rows), aggregate-snapshot integration over follower → adapter → mutations → materializer → LGraph, projection round trip through save/reload with a partial `{steps}` patch, and a browser spec that switches A → B → A with Agent open and expects the edited workflow back (titles, widget rows, links, viewport, one panel). A rebind-only mutant (re-subscribe without the value-patch change) fails the spec at the post-switch `renderedWidgetRows` equality, so the spec detects the bug and not just the re-subscription. - **ADR**: `CRDT-FOLLOWER-0025` gains an amendment recording `graphMutations` as the store adapter's durable mutation layer, superseding the 2026-08-21 "Dispose" classification. - Value-patch semantics: a partial named payload leaves sibling widgets alone; a deleted doc key or replaced widget map keeps the live widget; positional values past the serialized widget count are dropped. - `agentSubgraphFollower.test.ts` S1d now expects an opaque `[9]` to land on the live `value` widget instead of a placeholder `'0'`. - The conversation harness no longer accepts a type string where a display name belongs. - `agentConversationReplay.spec.ts` `two-turn-dependent-edit-wired` golden: CI regenerated it on this branch. The delta is the fix itself on the second turn's existing-node edit (display-name titles instead of `CheckpointLoaderSimple`/`VAEDecode`/`SaveImage`, the positive prompt text present, no error outline on `sampler_name`), not rasterization noise. - Out of scope, stated per the 17264 reviews: no Agent policy in `LGraph`, shared layers, `LiteGraphGlobal`, error cleanup, subgraph release, or widget hydration. Generic contracts land separately (FE-2451/2452/2453 under PM-1293, FE-2404). Rollback, LGraph lifecycle tables, dynamic-input hydration, and late-registration rebind are not in this PR. Fixes PM-985 --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1922 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-18T04:20:44.589Z",
"gitSha": "652cba5765d1a951d109b06549c1cf4d2c2a6979",
"branch": "backport-17963-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2106.96999999999,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.129,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.779,
"heapDeltaBytes": 12566648,
"heapUsedBytes": 82352804,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.384999999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2036.689000000024,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.822000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.6149999999999,
"heapDeltaBytes": 3900700,
"heapUsedBytes": 72866812,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.809999999999999,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1924.9189999999885,
"styleRecalcs": 80,
"styleRecalcDurationMs": 42.073,
"layouts": 14,
"layoutDurationMs": 4.7749999999999995,
"taskDurationMs": 911.46,
"heapDeltaBytes": 3519548,
"heapUsedBytes": 74617256,
"domNodes": -277,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 157.412,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1885.9830000000102,
"styleRecalcs": 77,
"styleRecalcDurationMs": 46.392,
"layouts": 14,
"layoutDurationMs": 4.551,
"taskDurationMs": 883.9269999999999,
"heapDeltaBytes": -10716,
"heapUsedBytes": 70164548,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 142.63500000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.2849999999803,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.289,
"layouts": 6,
"layoutDurationMs": 1.1179999999999999,
"taskDurationMs": 347.60100000000006,
"heapDeltaBytes": 4088736,
"heapUsedBytes": 67580048,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.295000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.439999999995,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.167999999999996,
"layouts": 6,
"layoutDurationMs": 1.2670000000000001,
"taskDurationMs": 381.422,
"heapDeltaBytes": 5109360,
"heapUsedBytes": 75706296,
"domNodes": 78,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.489,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 660.5370000000335,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.859000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.786,
"heapDeltaBytes": 18487908,
"heapUsedBytes": 88605092,
"domNodes": 20,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 160.05700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 696.5529999999944,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.829000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.415,
"heapDeltaBytes": -7846456,
"heapUsedBytes": 62996512,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 154.637,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2035.9700000000203,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.9970000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.3679999999999,
"heapDeltaBytes": 11016396,
"heapUsedBytes": 87413976,
"domNodes": -270,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 31.668999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.536999999953,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.652,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.1270000000001,
"heapDeltaBytes": 10500440,
"heapUsedBytes": 86755828,
"domNodes": -269,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 35.160000000000004,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2160.6140000000096,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.287999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1560.4080000000001,
"heapDeltaBytes": 19064644,
"heapUsedBytes": 84898076,
"domNodes": -274,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 760.2489999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2298.7600000000157,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.862000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1619.408,
"heapDeltaBytes": 26007700,
"heapUsedBytes": 92327344,
"domNodes": -271,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 788.4590000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3598.512000000028,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.692,
"layouts": 60,
"layoutDurationMs": 13.156,
"taskDurationMs": 1701.4969999999998,
"heapDeltaBytes": 8038268,
"heapUsedBytes": 76219240,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 766.929,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3490.45000000001,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.501,
"layouts": 60,
"layoutDurationMs": 12.964,
"taskDurationMs": 1675.5639999999999,
"heapDeltaBytes": 8505096,
"heapUsedBytes": 75996828,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 752.3180000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3184.235000000001,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.484,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1950.245,
"heapDeltaBytes": 26732964,
"heapUsedBytes": 94044244,
"domNodes": -278,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 974.0129999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3235.8859999999368,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.446,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2044.117,
"heapDeltaBytes": 25964632,
"heapUsedBytes": 93685588,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1004.1900000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.889000000021,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.693000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.4280000000001,
"heapDeltaBytes": 10874804,
"heapUsedBytes": 87978800,
"domNodes": -271,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 34.80599999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.0850000000037,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.836,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.021,
"heapDeltaBytes": 21918560,
"heapUsedBytes": 88106344,
"domNodes": -267,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.696999999999996,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.8249999999994,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.839,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.74999999999994,
"heapDeltaBytes": 15168324,
"heapUsedBytes": 88177348,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 137.643,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 635.3930000000219,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.672,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.9989999999999,
"heapDeltaBytes": 15188380,
"heapUsedBytes": 88271432,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 147.68800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.4939999999947,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.230000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.603,
"heapDeltaBytes": 948524,
"heapUsedBytes": 74081292,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.761999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.1240000000194,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.335,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.50300000000004,
"heapDeltaBytes": -7419196,
"heapUsedBytes": 65529212,
"domNodes": -292,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.270000000000002,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1736.263000000008,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.58,
"layouts": 18,
"layoutDurationMs": 5.0969999999999995,
"taskDurationMs": 801.327,
"heapDeltaBytes": -2944984,
"heapUsedBytes": 69247232,
"domNodes": -290,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 101.004,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1785.888,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.672,
"layouts": 18,
"layoutDurationMs": 5.072,
"taskDurationMs": 812.785,
"heapDeltaBytes": -861124,
"heapUsedBytes": 71381468,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 98.504,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.3249999999898,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.321999999999996,
"layouts": 15,
"layoutDurationMs": 14.462000000000003,
"taskDurationMs": 918.7599999999998,
"heapDeltaBytes": -11277140,
"heapUsedBytes": 84408968,
"domNodes": 13751,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 30.017000000000003,
"eventListeners": 2387,
"totalBlockingTimeMs": 130,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8358.384000000002,
"styleRecalcs": 246,
"styleRecalcDurationMs": 36.89,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5725.380999999999,
"heapDeltaBytes": -17259284,
"heapUsedBytes": 85003500,
"domNodes": -270,
"jsHeapTotalBytes": 159744,
"scriptDurationMs": 2599.386,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8334.490999999958,
"styleRecalcs": 245,
"styleRecalcDurationMs": 36.968,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5632.272000000001,
"heapDeltaBytes": 13157596,
"heapUsedBytes": 89414280,
"domNodes": -276,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 2524.911,
"eventListeners": -158,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17492.916000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16770.137,
"heapDeltaBytes": -23835368,
"heapUsedBytes": 179068136,
"domNodes": -6548,
"jsHeapTotalBytes": -1597440,
"scriptDurationMs": 276.856,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18035.271999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17588.529000000002,
"heapDeltaBytes": -29130968,
"heapUsedBytes": 177118148,
"domNodes": -6548,
"jsHeapTotalBytes": -3596288,
"scriptDurationMs": 307.627,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22109.510000000002,
"styleRecalcs": 178,
"styleRecalcDurationMs": 20.44099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21769.483999999997,
"heapDeltaBytes": -41573596,
"heapUsedBytes": 167022568,
"domNodes": -6548,
"jsHeapTotalBytes": -4419584,
"scriptDurationMs": 884.145,
"eventListeners": -7469,
"totalBlockingTimeMs": 112,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21796.918000000005,
"styleRecalcs": 156,
"styleRecalcDurationMs": 22.077000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21571.008,
"heapDeltaBytes": -41057980,
"heapUsedBytes": 169955800,
"domNodes": -6548,
"jsHeapTotalBytes": -2052096,
"scriptDurationMs": 912.9710000000001,
"eventListeners": -7467,
"totalBlockingTimeMs": 236,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6361.804000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.88699999999999,
"layouts": 20,
"layoutDurationMs": 25.394,
"taskDurationMs": 6294.404000000001,
"heapDeltaBytes": -27852084,
"heapUsedBytes": 179854588,
"domNodes": -6548,
"jsHeapTotalBytes": 7573504,
"scriptDurationMs": 110.91000000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 550,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6644.395999999915,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.05400000000002,
"layouts": 20,
"layoutDurationMs": 27.248000000000008,
"taskDurationMs": 6579.108999999999,
"heapDeltaBytes": -31949828,
"heapUsedBytes": 179361596,
"domNodes": -6548,
"jsHeapTotalBytes": 10584064,
"scriptDurationMs": 125.093,
"eventListeners": -7473,
"totalBlockingTimeMs": 473,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9061.273999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8614.262999999999,
"heapDeltaBytes": 14014532,
"heapUsedBytes": 174963528,
"domNodes": 0,
"jsHeapTotalBytes": -6291456,
"scriptDurationMs": 179.58700000000005,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9193.785000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8866.113000000001,
"heapDeltaBytes": 10114952,
"heapUsedBytes": 176174196,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 144.77400000000006,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 107.8300000000354,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.833000000000002,
"layouts": 3,
"layoutDurationMs": 1.6079999999999999,
"taskDurationMs": 86.27499999999999,
"heapDeltaBytes": 3514360,
"heapUsedBytes": 71765808,
"domNodes": 195,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.369,
"eventListeners": 55,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 160.4690000000346,
"styleRecalcs": 10,
"styleRecalcDurationMs": 16.159,
"layouts": 2,
"layoutDurationMs": 0.8230000000000002,
"taskDurationMs": 78.686,
"heapDeltaBytes": 3033164,
"heapUsedBytes": 70960776,
"domNodes": 112,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.732,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #17995 +/- ##
=============================================
Coverage ? 83.05%
=============================================
Files ? 2057
Lines ? 120441
Branches ? 31259
=============================================
Hits ? 100034
Misses ? 20231
Partials ? 176
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Manual backport of pull request 17963 (squash commit
24bb3f73). Fixes the tab-switch display corruption tracked as Linear PM-985 (titles fall back to the type string, widgets cleared, error outline after returning to a workflow tab with Agent open).Auto-backport failed on real conflicts, so this carries the fix by hand. Browser spec and its fixture are not included; the unit and integration tests are.
Full context for agent readers
Why manual
The
pr-backportworkflow (run 35304472374) hit cherry-pick conflicts on both 1.54 targets. The 1.54 branches predate the agent-area refactors onmain(roughly 173 files differ insrc/workbench/extensions/agent), but the fix's own dependencies are narrow.What differs from the
maincommitKept as-is:
nodePayload.ts,graphMutations.ts(moved fromsrc/core/graph/tosrc/workbench/extensions/agent/crdt/, same as the original PR),graphMutations.test.ts,ecsFollowerAdapter.ts, the materializer and follower test updates, theLGraph.test.tsdeletion, and the amendment to the CRDT follower boundaries decision record (docs/adr/CRDT-FOLLOWER-0025).Adapted to 1.54 APIs:
registerPlaceholderingraphMutations.tsdrops the extraundefinedargument; 1.54'swidgetValueStore.registerWidgethas four parameters.linkPresentationStoredoes not exist on 1.54; no references remain.AgentPanelRoot.vuekeeps 1.54'sreportErrorimport alongside the newcreateGraphMutationsimport path.agentCrdtProjection.integration.test.tsis ported to 1.54 primitives:AgentCrdtProjection(introduced by pull request 16908, not on 1.54) is replaced byEcsFollowerAdapterplusreconcileAgentAdapters, which is exactly whatuseAgentCrdtFollower.reconcileLiveGraphdoes on this branch.asserttakes two arguments here, so the context object is folded into the message.Dropped:
browser_tests/tests/agent/agentTabSwitchCatchUp.spec.ts,browser_tests/fixtures/agentConversationFixture.ts, and thetwo-turn-dependent-edit-wiredsnapshot. They depend on the conversation-replay harness (agentConversationHostDoc,data/agent/*) that does not exist on 1.54.followerProductGate.test.tsedit: the file does not exist on 1.54.Verification (local, Node 26.8.2)
pnpm typecheck: clean.pnpm vitest run src/workbench/extensions/agent/crdt src/lib/litegraph/src/LGraph.test.ts: 39 files passed; the singleexpected failis upstream's ownit.failsmarker ingraphMutations.test.ts, identical onmain.Glossary
graphMutations: the store adapter's mutation layer that applies doc nodes and widget values to the live LGraph.