Repository navigation
[backport core/1.54] fix(agent): keep live nodes displayed as saved through a catch-up reconcile - #17994
Conversation
…oncile (#17963) Returning to a workflow tab with Agent open re-binds the follower, and its catch-up reconciled every doc node as a fresh record: the title fell back to the type string and the node's live widgets were cleared for placeholders, so Vue nodes lost their controls and showed an error outline. The catch-up now treats a doc node entry as a value patch for a live node. - **What**: `graphMutations` (moved to `src/workbench/extensions/agent/crdt/`) parses `widgets_values` once into a discriminated `WidgetValuePayload` (`omitted | positional | named`, in the leaf module `nodePayload.ts`) and applies it to live widgets by name or serialized order. A same-type reconcile of a live node never clears its widgets; only a type change replaces the node (`deleteNode` then `addNode`). Titles fall back to the registered display name, then the type. `ecsFollowerAdapter` hands the host branch to `reconcileNodeFields` instead of looping `setWidget` per name. - **Tests first**: contract table for the widget payload (10 rows), title table (4 rows), aggregate-snapshot integration over follower → adapter → mutations → materializer → LGraph, projection round trip through save/reload with a partial `{steps}` patch, and a browser spec that switches A → B → A with Agent open and expects the edited workflow back (titles, widget rows, links, viewport, one panel). A rebind-only mutant (re-subscribe without the value-patch change) fails the spec at the post-switch `renderedWidgetRows` equality, so the spec detects the bug and not just the re-subscription. - **ADR**: `CRDT-FOLLOWER-0025` gains an amendment recording `graphMutations` as the store adapter's durable mutation layer, superseding the 2026-08-21 "Dispose" classification. - Value-patch semantics: a partial named payload leaves sibling widgets alone; a deleted doc key or replaced widget map keeps the live widget; positional values past the serialized widget count are dropped. - `agentSubgraphFollower.test.ts` S1d now expects an opaque `[9]` to land on the live `value` widget instead of a placeholder `'0'`. - The conversation harness no longer accepts a type string where a display name belongs. - `agentConversationReplay.spec.ts` `two-turn-dependent-edit-wired` golden: CI regenerated it on this branch. The delta is the fix itself on the second turn's existing-node edit (display-name titles instead of `CheckpointLoaderSimple`/`VAEDecode`/`SaveImage`, the positive prompt text present, no error outline on `sampler_name`), not rasterization noise. - Out of scope, stated per the 17264 reviews: no Agent policy in `LGraph`, shared layers, `LiteGraphGlobal`, error cleanup, subgraph release, or widget hydration. Generic contracts land separately (FE-2451/2452/2453 under PM-1293, FE-2404). Rollback, LGraph lifecycle tables, dynamic-input hydration, and late-registration rebind are not in this PR. Fixes PM-985 --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1921 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-18T04:20:11.247Z",
"gitSha": "04ab5a415995735183ff462e0de3adfef370c457",
"branch": "backport-17963-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2035.868999999991,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.309999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.32,
"heapDeltaBytes": -1507864,
"heapUsedBytes": 68486792,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 10.922,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2057.132000000024,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.244000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.5529999999999,
"heapDeltaBytes": -6073472,
"heapUsedBytes": 63004284,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.178,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1920.216000000039,
"styleRecalcs": 75,
"styleRecalcDurationMs": 43.215,
"layouts": 14,
"layoutDurationMs": 4.352,
"taskDurationMs": 933.213,
"heapDeltaBytes": 7487144,
"heapUsedBytes": 76665068,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 142.882,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1736.0830000000078,
"styleRecalcs": 76,
"styleRecalcDurationMs": 30.790000000000003,
"layouts": 14,
"layoutDurationMs": 3.849,
"taskDurationMs": 780.372,
"heapDeltaBytes": -366164,
"heapUsedBytes": 69400060,
"domNodes": -279,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 128.27499999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1671.9780000000242,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.713999999999999,
"layouts": 6,
"layoutDurationMs": 1.003,
"taskDurationMs": 341.026,
"heapDeltaBytes": 5067720,
"heapUsedBytes": 76080608,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.198999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.9690000000483,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.517999999999997,
"layouts": 6,
"layoutDurationMs": 1.062,
"taskDurationMs": 345.27200000000005,
"heapDeltaBytes": 4462484,
"heapUsedBytes": 73829764,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.558,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 604.945999999984,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.835,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.068,
"heapDeltaBytes": -7835796,
"heapUsedBytes": 62983112,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 135.71099999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 625.8449999999698,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.844,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.85600000000005,
"heapDeltaBytes": -7250596,
"heapUsedBytes": 63469280,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 132.66899999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2008.6100000000329,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.5920000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.589,
"heapDeltaBytes": 22552180,
"heapUsedBytes": 88116936,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.150999999999996,
"eventListeners": -140,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2022.250999999983,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.000000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.858,
"heapDeltaBytes": 11123796,
"heapUsedBytes": 87433244,
"domNodes": -268,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 32.620000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2164.3920000000207,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.478000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1317.197,
"heapDeltaBytes": 22420776,
"heapUsedBytes": 88567872,
"domNodes": 8,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 638.207,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2391.1529999999743,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.475,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1427.33,
"heapDeltaBytes": 23040852,
"heapUsedBytes": 89385432,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 676.8799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3283.177999999964,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.511999999999999,
"layouts": 60,
"layoutDurationMs": 12.322000000000001,
"taskDurationMs": 1467.055,
"heapDeltaBytes": 8475968,
"heapUsedBytes": 75916244,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 636.636,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3239.836999999966,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.282999999999998,
"layouts": 60,
"layoutDurationMs": 12.239,
"taskDurationMs": 1478.093,
"heapDeltaBytes": 8217040,
"heapUsedBytes": 75897024,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 637.455,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2545.879999999954,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.815999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1614.8599999999997,
"heapDeltaBytes": 22440204,
"heapUsedBytes": 89522528,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 795.961,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2523.123999999939,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.774999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1701.4479999999999,
"heapDeltaBytes": 17650716,
"heapUsedBytes": 85373940,
"domNodes": -278,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 818.748,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2013.1729999999948,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.556000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.943,
"heapDeltaBytes": 21916772,
"heapUsedBytes": 87626016,
"domNodes": -266,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.929,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2019.6369999999888,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.6370000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.4599999999999,
"heapDeltaBytes": 10282952,
"heapUsedBytes": 86628748,
"domNodes": -269,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 36.782,
"eventListeners": -140,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.3400000000042,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.508,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.17199999999997,
"heapDeltaBytes": 14739796,
"heapUsedBytes": 86661136,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 118.20700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 536.877000000004,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.747,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.147,
"heapDeltaBytes": 14771376,
"heapUsedBytes": 87820224,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 115.77799999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.3770000000195,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.494999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.57399999999996,
"heapDeltaBytes": -10565188,
"heapUsedBytes": 61484196,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.014999999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.2950000000092,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.865,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.425,
"heapDeltaBytes": -1918748,
"heapUsedBytes": 70302204,
"domNodes": -293,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.602999999999998,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.3070000000002,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.531999999999996,
"layouts": 18,
"layoutDurationMs": 4.462,
"taskDurationMs": 732.861,
"heapDeltaBytes": 813420,
"heapUsedBytes": 73782036,
"domNodes": -293,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 92.364,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.275000000005,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.021,
"layouts": 18,
"layoutDurationMs": 4.5200000000000005,
"taskDurationMs": 704.831,
"heapDeltaBytes": -12117420,
"heapUsedBytes": 60425880,
"domNodes": -293,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 90.161,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1318.0249999999774,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.24,
"layouts": 14,
"layoutDurationMs": 12.156000000000002,
"taskDurationMs": 850.4430000000001,
"heapDeltaBytes": 2045592,
"heapUsedBytes": 99856200,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 27.999999999999996,
"eventListeners": 2385,
"totalBlockingTimeMs": 90,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8625.36,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.479,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5017.999000000001,
"heapDeltaBytes": 17840016,
"heapUsedBytes": 93512152,
"domNodes": -266,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 2167.939,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9010.771999999975,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.629,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5140.655000000001,
"heapDeltaBytes": 13310528,
"heapUsedBytes": 89433764,
"domNodes": -266,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 2227.813,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15122.278999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14700.193000000001,
"heapDeltaBytes": -33847708,
"heapUsedBytes": 177509664,
"domNodes": -6548,
"jsHeapTotalBytes": -5947392,
"scriptDurationMs": 232.91400000000002,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15263.990000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14849.478,
"heapDeltaBytes": -38657532,
"heapUsedBytes": 178135052,
"domNodes": -6548,
"jsHeapTotalBytes": 843776,
"scriptDurationMs": 262.53099999999995,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17578.438000000006,
"styleRecalcs": 126,
"styleRecalcDurationMs": 17.129000000000033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17351.387000000002,
"heapDeltaBytes": -39706156,
"heapUsedBytes": 163097172,
"domNodes": -6548,
"jsHeapTotalBytes": 1531904,
"scriptDurationMs": 734.3430000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 19,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17911.594000000037,
"styleRecalcs": 131,
"styleRecalcDurationMs": 17.339999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17667.234999999997,
"heapDeltaBytes": -41263444,
"heapUsedBytes": 168141912,
"domNodes": -6548,
"jsHeapTotalBytes": -2965504,
"scriptDurationMs": 749.715,
"eventListeners": -7471,
"totalBlockingTimeMs": 5,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5350.99699999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.473,
"layouts": 20,
"layoutDurationMs": 21.925,
"taskDurationMs": 5266.704000000001,
"heapDeltaBytes": -17539484,
"heapUsedBytes": 181387752,
"domNodes": -6548,
"jsHeapTotalBytes": 21532672,
"scriptDurationMs": 94.45499999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 213,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5463.193000000047,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.66200000000002,
"layouts": 20,
"layoutDurationMs": 22.444000000000006,
"taskDurationMs": 5409.576999999999,
"heapDeltaBytes": -32643512,
"heapUsedBytes": 175407752,
"domNodes": -6552,
"jsHeapTotalBytes": 7241728,
"scriptDurationMs": 135.29400000000004,
"eventListeners": -7473,
"totalBlockingTimeMs": 231,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7644.258000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7481.397000000001,
"heapDeltaBytes": 14323608,
"heapUsedBytes": 184810788,
"domNodes": 0,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 115.73299999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.22666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7628.757999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7416.869999999999,
"heapDeltaBytes": 3619680,
"heapUsedBytes": 163047280,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 116.25799999999997,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 79.7680000000014,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.808,
"layouts": 2,
"layoutDurationMs": 0.5479999999999999,
"taskDurationMs": 57.37200000000001,
"heapDeltaBytes": 3117092,
"heapUsedBytes": 72073920,
"domNodes": 107,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.056999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 82.63799999997445,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.142,
"layouts": 2,
"layoutDurationMs": 0.6910000000000001,
"taskDurationMs": 57.71,
"heapDeltaBytes": 3025884,
"heapUsedBytes": 71970268,
"domNodes": 104,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.686,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #17994 +/- ##
==========================================
Coverage 83.04% 83.04%
==========================================
Files 2056 2057 +1
Lines 120389 120413 +24
Branches 30153 30169 +16
==========================================
+ Hits 99980 100000 +20
- Misses 20229 20233 +4
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Manual backport of pull request 17963 (squash commit
24bb3f73). Fixes the tab-switch display corruption tracked as Linear PM-985 (titles fall back to the type string, widgets cleared, error outline after returning to a workflow tab with Agent open).Auto-backport failed on real conflicts, so this carries the fix by hand. Browser spec and its fixture are not included; the unit and integration tests are.
Full context for agent readers
Why manual
The
pr-backportworkflow (run 35304472374) hit cherry-pick conflicts on both 1.54 targets. The 1.54 branches predate the agent-area refactors onmain(roughly 173 files differ insrc/workbench/extensions/agent), but the fix's own dependencies are narrow.What differs from the
maincommitKept as-is:
nodePayload.ts,graphMutations.ts(moved fromsrc/core/graph/tosrc/workbench/extensions/agent/crdt/, same as the original PR),graphMutations.test.ts,ecsFollowerAdapter.ts, the materializer and follower test updates, theLGraph.test.tsdeletion, and the amendment to the CRDT follower boundaries decision record (docs/adr/CRDT-FOLLOWER-0025).Adapted to 1.54 APIs:
registerPlaceholderingraphMutations.tsdrops the extraundefinedargument; 1.54'swidgetValueStore.registerWidgethas four parameters.linkPresentationStoredoes not exist on 1.54; no references remain.AgentPanelRoot.vuekeeps 1.54'sreportErrorimport alongside the newcreateGraphMutationsimport path.agentCrdtProjection.integration.test.tsis ported to 1.54 primitives:AgentCrdtProjection(introduced by pull request 16908, not on 1.54) is replaced byEcsFollowerAdapterplusreconcileAgentAdapters, which is exactly whatuseAgentCrdtFollower.reconcileLiveGraphdoes on this branch.asserttakes two arguments here, so the context object is folded into the message.Dropped:
browser_tests/tests/agent/agentTabSwitchCatchUp.spec.ts,browser_tests/fixtures/agentConversationFixture.ts, and thetwo-turn-dependent-edit-wiredsnapshot. They depend on the conversation-replay harness (agentConversationHostDoc,data/agent/*) that does not exist on 1.54.followerProductGate.test.tsedit: the file does not exist on 1.54.Verification (local, Node 26.8.2)
pnpm typecheck: clean.pnpm vitest run src/workbench/extensions/agent/crdt src/lib/litegraph/src/LGraph.test.ts: 39 files passed; the singleexpected failis upstream's ownit.failsmarker ingraphMutations.test.ts, identical onmain.Glossary
graphMutations: the store adapter's mutation layer that applies doc nodes and widget values to the live LGraph.