Repository navigation
test: cut Chromium E2E latency without timeout bumps - #17972
Conversation
Speed up subgraphSlots rename, widgetTooltip, and two workflowPersistence reload cases that burned the 15s Chromium project timeout. Toggle Vue nodes via settings, route object_info before first boot, and reopen saved workflows through the store instead of the sidebar.
🎭 Playwright: ✅ 2037 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 10.1 MB gzip 🔴 +2 MBDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.64 kB) • 🔴 +137 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.25 MB) • 🔴 +199 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 1 removed / 1 shrank Views & Navigation — 132 kB (baseline 112 kB) • 🔴 +20 kBTop-level views, pages, and routed surfaces
Status: 17 added / 15 removed / 1 shrank Panels & Settings — 637 kB (baseline 551 kB) • 🔴 +86.5 kBConfiguration panels, inspectors, and settings screens
Status: 27 added / 26 removed User & Accounts — 37.9 kB (baseline 29.1 kB) • 🔴 +8.83 kBAuthentication, profile, and account management bundles
Status: 11 added / 10 removed Editors & Dialogs — 126 kB (baseline 121 kB) • 🔴 +4.96 kBModals, dialogs, drawers, and in-app editors
Status: 8 added / 6 removed UI Components — 124 kB (baseline 64.7 kB) • 🔴 +58.8 kBReusable component library chunks
Status: 16 added / 14 removed Data & Services — 3.84 MB (baseline 3.37 MB) • 🔴 +474 kBStores, services, APIs, and repositories
Status: 16 added / 17 removed Utilities & Hooks — 563 kB (baseline 357 kB) • 🔴 +206 kBHelpers, composables, and utility bundles
Status: 38 added / 35 removed Vendor & Third-Party — 18.2 MB (baseline 15.7 MB) • 🔴 +2.51 MBExternal libraries and shared vendor chunks
Status: 18 added / 16 removed Other — 17.7 MB (baseline 12.4 MB) • 🔴 +5.33 MBBundles that do not match a named category
Status: 186 added / 164 removed / 110 shrank / 1 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-18T01:01:31.219Z",
"gitSha": "8891972a1a0f254b7e1ec74522e35f9a17bd6381",
"branch": "cursor/e2e-chromium-timeout-cuts-dab9",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2027.181999999982,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.308,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.03400000000005,
"heapDeltaBytes": 1760808,
"heapUsedBytes": 63217720,
"domNodes": -264,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.198999999999998,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1997.3059999999805,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.497,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.88400000000007,
"heapDeltaBytes": 6040176,
"heapUsedBytes": 68203496,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.4,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1773.7000000000194,
"styleRecalcs": 76,
"styleRecalcDurationMs": 25.904999999999998,
"layouts": 14,
"layoutDurationMs": 4.239,
"taskDurationMs": 802.612,
"heapDeltaBytes": -4460900,
"heapUsedBytes": 58009248,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 154.757,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1758.8419999999587,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.781000000000002,
"layouts": 14,
"layoutDurationMs": 3.8720000000000003,
"taskDurationMs": 807.367,
"heapDeltaBytes": -4271428,
"heapUsedBytes": 58305784,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 158.359,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.0659999999798,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.879999999999999,
"layouts": 6,
"layoutDurationMs": 0.992,
"taskDurationMs": 318.956,
"heapDeltaBytes": 2224720,
"heapUsedBytes": 64677740,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.866999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.4369999999471,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.325000000000001,
"layouts": 6,
"layoutDurationMs": 1.158,
"taskDurationMs": 316.78,
"heapDeltaBytes": 2161364,
"heapUsedBytes": 64615536,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.778000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 610.4550000000017,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.987000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.961,
"heapDeltaBytes": 18212436,
"heapUsedBytes": 80574504,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 162.56599999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 620.8679999999731,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.202,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.76000000000005,
"heapDeltaBytes": 17946232,
"heapUsedBytes": 80551592,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 158.55799999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2022.0219999999927,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.255999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.3919999999999,
"heapDeltaBytes": 3037176,
"heapUsedBytes": 83113556,
"domNodes": -249,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 30.442999999999998,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.830000000009,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.930000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.162,
"heapDeltaBytes": 3347680,
"heapUsedBytes": 83601588,
"domNodes": -248,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 29.595999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2302.5879999999574,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.536999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1623.31,
"heapDeltaBytes": -2297344,
"heapUsedBytes": 79758308,
"domNodes": -273,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 832.7339999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2247.4509999999555,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.355000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1567.171,
"heapDeltaBytes": -1491016,
"heapUsedBytes": 79436432,
"domNodes": -253,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 825.706,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3569.675000000018,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.556000000000001,
"layouts": 60,
"layoutDurationMs": 13.378,
"taskDurationMs": 1697.8970000000002,
"heapDeltaBytes": -17354808,
"heapUsedBytes": 65677788,
"domNodes": -267,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 789.367,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3479.0779999999586,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.938999999999997,
"layouts": 60,
"layoutDurationMs": 12.313999999999998,
"taskDurationMs": 1619.4749999999997,
"heapDeltaBytes": 9810704,
"heapUsedBytes": 75271352,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 768.1340000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3006.5290000000005,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.514,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1865.3559999999998,
"heapDeltaBytes": 19499492,
"heapUsedBytes": 86189612,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 968.276,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2841.5300000000343,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.730999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1756.8260000000002,
"heapDeltaBytes": -4441516,
"heapUsedBytes": 79777488,
"domNodes": -228,
"jsHeapTotalBytes": 1196032,
"scriptDurationMs": 972.4750000000001,
"eventListeners": -2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.8140000000108,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.233999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.479,
"heapDeltaBytes": -3774896,
"heapUsedBytes": 84234460,
"domNodes": -251,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.675999999999995,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2015.657000000033,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.947000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.6700000000001,
"heapDeltaBytes": 19781608,
"heapUsedBytes": 84154388,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.218,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 566.9389999999908,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.751999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.022,
"heapDeltaBytes": 13981480,
"heapUsedBytes": 76890072,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.907,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.0590000000666,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.867999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.695,
"heapDeltaBytes": 13430672,
"heapUsedBytes": 77273940,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 140.831,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.7409999999963,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.9460000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.85799999999995,
"heapDeltaBytes": 4355804,
"heapUsedBytes": 68269788,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.782,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.1849999999731,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.046999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.711,
"heapDeltaBytes": -2685780,
"heapUsedBytes": 61190364,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.832999999999998,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.9329999999964,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.172,
"layouts": 18,
"layoutDurationMs": 5.359,
"taskDurationMs": 755.026,
"heapDeltaBytes": -5584868,
"heapUsedBytes": 57944956,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 106.166,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.8880000000254,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.956,
"layouts": 18,
"layoutDurationMs": 5.174,
"taskDurationMs": 747.185,
"heapDeltaBytes": 8659676,
"heapUsedBytes": 72630020,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 101.69,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.0499999999256,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.790000000000003,
"layouts": 5,
"layoutDurationMs": 13.024999999999999,
"taskDurationMs": 912.9080000000002,
"heapDeltaBytes": 21202472,
"heapUsedBytes": 101460664,
"domNodes": 13587,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 28.398999999999994,
"eventListeners": 2387,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8376.860999999963,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.050999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5710.659,
"heapDeltaBytes": -12543776,
"heapUsedBytes": 67344752,
"domNodes": -223,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 2788.2129999999997,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8469.469000000005,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.262,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5650.365000000001,
"heapDeltaBytes": 13090004,
"heapUsedBytes": 93142964,
"domNodes": -260,
"jsHeapTotalBytes": 2576384,
"scriptDurationMs": 2754.1479999999997,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17713.461999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16951.692000000003,
"heapDeltaBytes": -64257628,
"heapUsedBytes": 168475224,
"domNodes": -8061,
"jsHeapTotalBytes": -15052800,
"scriptDurationMs": 249.184,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16496.593000000074,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15723.503999999999,
"heapDeltaBytes": -20426272,
"heapUsedBytes": 189968152,
"domNodes": -8062,
"jsHeapTotalBytes": -10555392,
"scriptDurationMs": 255.90999999999997,
"eventListeners": -14930,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21610.461999999985,
"styleRecalcs": 178,
"styleRecalcDurationMs": 17.763999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21416.427,
"heapDeltaBytes": -53886424,
"heapUsedBytes": 177286780,
"domNodes": -8061,
"jsHeapTotalBytes": -14999552,
"scriptDurationMs": 892.3960000000001,
"eventListeners": -14920,
"totalBlockingTimeMs": 165,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20093.406999999956,
"styleRecalcs": 162,
"styleRecalcDurationMs": 16.175999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19700.327,
"heapDeltaBytes": -24378048,
"heapUsedBytes": 192753816,
"domNodes": -8061,
"jsHeapTotalBytes": -9838592,
"scriptDurationMs": 892.925,
"eventListeners": -14920,
"totalBlockingTimeMs": 146,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6254.256000000055,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.58400000000002,
"layouts": 20,
"layoutDurationMs": 21.573999999999995,
"taskDurationMs": 6149.246999999999,
"heapDeltaBytes": -38827068,
"heapUsedBytes": 183538496,
"domNodes": -8061,
"jsHeapTotalBytes": 12906496,
"scriptDurationMs": 111.608,
"eventListeners": -14924,
"totalBlockingTimeMs": 468,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4519.130000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.86200000000002,
"layouts": 20,
"layoutDurationMs": 22.811999999999998,
"taskDurationMs": 4397.55,
"heapDeltaBytes": -40918580,
"heapUsedBytes": 179614636,
"domNodes": -8061,
"jsHeapTotalBytes": 20250624,
"scriptDurationMs": 130.54399999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 57,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8959.422000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8519.526,
"heapDeltaBytes": 5885720,
"heapUsedBytes": 182760536,
"domNodes": 0,
"jsHeapTotalBytes": -20447232,
"scriptDurationMs": 121.16600000000005,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8249.522999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7895.729999999999,
"heapDeltaBytes": -12794092,
"heapUsedBytes": 171606148,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 131.0260000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 479.3930000000728,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.547,
"layouts": 5,
"layoutDurationMs": 3.557,
"taskDurationMs": 150.315,
"heapDeltaBytes": 5200876,
"heapUsedBytes": 67250100,
"domNodes": 149,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.114,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 97.14900000005855,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.345,
"layouts": 2,
"layoutDurationMs": 1.333,
"taskDurationMs": 70.514,
"heapDeltaBytes": 2926864,
"heapUsedBytes": 65094412,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.591999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe browser tests add reusable helpers for Vue node state, workflow popover dismissal, and persisted workflow opening. Several specs move settings and routing into fixture setup and update workflow and subgraph navigation. ChangesBrowser test helper updates
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Other Suggested reviewers: Merge Risk: 🔵 Low · up to The tooltip test behavior is unchanged, but a small required TypeScript cleanup remains. This is bounded to test maintenance and is mergeable with owner awareness. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17972 +/- ##
==========================================
+ Coverage 82.69% 83.71% +1.01%
==========================================
Files 2917 2231 -686
Lines 143912 127286 -16626
Branches 38873 32387 -6486
==========================================
- Hits 119010 106554 -12456
+ Misses 23668 20447 -3221
+ Partials 1234 285 -949
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| await this.page | ||
| .locator('.workflow-popover-fade') | ||
| .waitFor({ state: 'hidden', timeout: 5000 }) | ||
| .catch(() => {}) |
There was a problem hiding this comment.
Could this use expect(...).toBeHidden()?
There was a problem hiding this comment.
toBeHidden() asserts, so a lingering popover would fail the test. This wait is deliberately best-effort: the popover may never exist, and if it outlives the wait we still want to try the click. locator.waitFor({ state: 'hidden' }) is the non-asserting form, same as ConfirmDialog.ts:35. Added a one-line doc in #17988 so the intent is visible instead of implied.
There was a problem hiding this comment.
Correcting myself: you were right, and my reasoning above was wrong.
.workflow-popover-fade is a hover popover on the workflow tabs (WorkflowTabPopover.vue:55), so it only closes on mouseleave. Passively waiting for it can never succeed while the pointer rests on a tab. The .catch(() => {}) then swallowed the timeout and handed the intercepted menu click a full test timeout to hang in. #17988 CI caught it: 5.0 s Wait for selector .workflow-popover-fade followed by a click that burned the whole 180s.
#17988 moves the pointer off the tab first, then asserts with toBeHidden() as you suggested, so a real failure is immediate instead of a 180s hang. Under SLOW_MO=250 --timeout=180000, that case goes from timing out at 180s to passing in 9.6s.
| return new VueNodeFixture(this.getNodeLocator(nodeId)) | ||
| } | ||
|
|
||
| async setEnabled(enabled: boolean): Promise<void> { |
There was a problem hiding this comment.
setEnabled isn't super self explanatory. I get that it's on the helper...
Do we have that many tests that need to flip into Nodes 2.0?
There was a problem hiding this comment.
I'd also rather have the utilities use one of the two ways a user could do this, the menu toggle or a keybind, if possible.
There was a problem hiding this comment.
Agreed, removed in #17988. One caller, and it was not worth a third way to flip the renderer.
There was a problem hiding this comment.
Agreed. #17988 puts subgraphSlots back on topbar.setVueNodesEnabled. The actual timeout fix was dismissWorkflowPopover inside openTopbarMenu; the settings helper was scope I did not need.
| 'Comfy.NodeSearchBoxImpl': 'v1 (legacy)' | ||
| 'Comfy.UseNewMenu': 'Disabled', | ||
| 'Comfy.NodeSearchBoxImpl': 'v1 (legacy)', | ||
| 'Comfy.VueNodes.Enabled': false |
There was a problem hiding this comment.
Nodes 2.0 are disabled by default, unless the test is tagged with @vue-nodes
There was a problem hiding this comment.
Right, and browser_tests/README.md says the same: never set Comfy.VueNodes.Enabled through initialSettings. Removed in #17988.
| 'bounded tooltip surface' | ||
| const tooltipContent = `${label}\n\n${longValue}` | ||
|
|
||
| const test = comfyPageFixture.extend({ |
There was a problem hiding this comment.
Could you do this with a separate fixture and mergeTests?
There was a problem hiding this comment.
The page override is deliberate: routeObjectInfoFromSetupApi has to land before comfyPage boots the app, and an auto fixture does not guarantee that ordering while overriding page does. mergeTests would move it to another module without changing that, and there is one consumer today. Happy to extract it if you want it out of the spec.
| const seed = await node.getWidgetByName('seed') | ||
| const originalSeed = await seed.getValue() | ||
| const savedSeed = 123456789 | ||
| test.describe(`saved reload Vue Nodes ${vueNodesEnabled ? 'enabled' : 'disabled'}`, () => { |
There was a problem hiding this comment.
Still don't like this... Test suites should be flat and boring, not clever.
There was a problem hiding this comment.
Also, we could replace enabled with @vue-nodes since tags in the title count.
There was a problem hiding this comment.
Agreed, and you already called it: the vueNodesEnabled loop and the if (vueNodesEnabled) branches predate this PR. Splitting them into flat per-renderer specs is a real restructure of a file I only touched for latency, so I would rather do it on its own. Say the word and I will file it.
There was a problem hiding this comment.
That would work and it drops the explicit setting, which is the part README.md warns about. It needs the conditional-title shape across the whole vueNodesEnabled loop though, so I would rather fold it into the flattening pass than half-apply it here.
| ).toBeVisible() | ||
| await expect( | ||
| comfyPage.page | ||
| if (vueNodesEnabled) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Same thread as above: the branches in that body are the pre-existing if (vueNodesEnabled) split. Worth fixing under the same flattening pass rather than piecemeal.
DrJKL
left a comment
There was a problem hiding this comment.
P1 blocker:
openPersistedWorkflow()calls the management store'sopenWorkflow(), not the workflow service that loads graph data. After reload, the target is already active, so this call returns immediately and the tests can pass without exercising their claimed reopen step.
Findings without an anchorable line
None.
Existing findings confirmed
- Popover hidden wait: confirmed. A web-first
toBeHidden()assertion should own this readiness boundary. Swallowing its timeout lets every topbar command proceed with the overlay still present. VueNodeHelpers.setEnabled: confirmed. It has one caller and duplicates the existing user-facing topbar/command routes, so the name and ownership do not explain which behavior it tests.- Subgraph renderer setup: confirmed.
browser_tests/README.mdexplicitly forbids settingComfy.VueNodes.EnabledthroughinitialSettingsin an@vue-nodestest. - Tooltip fixture composition: the suggested
mergeTestspattern exists throughout this suite. The local extension has correct setup and cleanup, so this is a structure question rather than a behavior defect. - Nested persistence suite: confirmed. The new nested
describeadds a layer around cases that were already parameterized without owning another lifecycle. - Missing
@vue-nodestag: confirmed.ComfyPage.isVueNodesand workflow-load readiness derive from the tag, so the enabled cases currently run with fixture identity and readiness set to legacy mode. - Conditional test logic: confirmed. The touched branches conflict with the repository rule that a branch is two tests and touched violations must be fixed.
Unverified candidate
- P2: the description says the PR "cuts real latency," but there is no matched base/head timing result. Head CI proves the cases complete within the unchanged timeout. A same-runner base/head comparison would settle the stronger latency claim. My local run discovered all six targeted cases but stopped before their bodies because the orb backend was unreachable through IPv6 localhost.
Checked and cleared
- The diff adds no
test.slow()ortest.setTimeout()call and changes no product file. - The tooltip route is installed before boot and removed in
finally. - Diff-scoped lint, formatting, and Fallow checks produced no additional changed-code findings.
Coverage
Standard-depth review. Correctness, maintainability, TypeScript/Playwright idioms, test design, and PR-description claims were reviewed across all seven changed files. The Playwright lane inventoried 525 fixture methods and classified 70 changed-spec interactions. CI E2E, lint, formatting, and Fallow are green at bcd9c0e; the local focused Playwright run was blocked before test execution by the orb's IPv6 localhost/backend mismatch.
| if (!workflow) { | ||
| throw new Error(`Persisted workflow not found: ${name}`) | ||
| } | ||
| await store.openWorkflow(workflow) |
There was a problem hiding this comment.
[P1] This calls the management store's openWorkflow(), not workflowService.openWorkflow(). The store only loads metadata and marks the workflow active; if the target is already active after the page reload, it returns immediately. It never calls app.loadGraphData(). These persistence cases can therefore pass against the graph restored by reload without exercising the reopen step that this helper claims to perform. Please use the same service boundary as the sidebar, or make the graph distinguishably different before reopening and prove the saved graph is restored.
There was a problem hiding this comment.
Real, and it merged before I caught it. Fixed in #17988: openPersistedWorkflow goes back through the workflows sidebar. Worth noting workflowService.openWorkflow has the same early return (workflowService.ts:399-405, isActive(workflow) && !options.force) and is not reachable from page context, so the service boundary alone would not have proven the reopen either. The sidebar interaction is the one that does.
| const store = (window.app!.extensionManager as WorkspaceStore).workflow | ||
| await store.syncWorkflows() | ||
| const workflow = | ||
| store.getWorkflowByPath(`workflows/${name}.json`) ?? |
There was a problem hiding this comment.
[P3] Both callers have just saved a generated top-level name, so workflows/${name}.json is the exact identity they need. The filename and suffix fallbacks add two looser sources of truth and can silently select a nested same-suffix workflow. Please fail on a missing canonical path instead.
There was a problem hiding this comment.
Agreed, dropped both fallbacks in #17988. Canonical path or throw.
|
|
||
| await unrouteObjectInfo() | ||
| const width = await tooltipText.evaluate( | ||
| (el) => (el as HTMLElement).getBoundingClientRect().width |
There was a problem hiding this comment.
[P3] getBoundingClientRect() exists on both members of Playwright's inferred SVGElement | HTMLElement union, so this narrowing assertion is unnecessary.
| (el) => (el as HTMLElement).getBoundingClientRect().width | |
| (el) => el.getBoundingClientRect().width |
| 'Comfy.NodeSearchBoxImpl': 'v1 (legacy)' | ||
| 'Comfy.UseNewMenu': 'Disabled', | ||
| 'Comfy.NodeSearchBoxImpl': 'v1 (legacy)', | ||
| 'Comfy.VueNodes.Enabled': false |
There was a problem hiding this comment.
[P2] This does more than avoid the blocked menu click: it changes the test from Vue -> legacy -> Vue to legacy -> Vue, while the diff also removes the pre-rename Vue widget visibility and placement assertions. A regression where the promoted widget is already missing or misplaced before rename now passes. Please keep the tagged Vue startup and those initial assertions, then switch through the supported renderer helper before the legacy-only interaction.
There was a problem hiding this comment.
Right on both counts. #17988 restores the tagged Vue startup and the pre-rename visibility and placement assertions, and switches renderer through topbar.setVueNodesEnabled. Passes locally at 11.3s, under the 15s project timeout.
DrJKL
left a comment
There was a problem hiding this comment.
Approved. The posted findings are test-quality and coverage concerns rather than product regressions; none is catastrophic enough to block this latency-focused test change.
Summary
Tip-push Chromium E2E hard-failed the 15s project timeout on run 35246301535 @
88a3a51(subgraphSlotsrename,widgetTooltip, twoworkflowPersistencereload cases). Same SHA already passed merge_group. Root cause for the rename case wasTopbar.setVueNodesEnabledmenu-click blocked byworkflow-popover-fade. This PR cuts real latency instead of the closedtest.slow()workarounds in #17944/#17945.POM:
VueNodeHelpers.setEnabled(settings +waitForNodes),Topbar.dismissWorkflowPopover(#17715 pattern;openTopbarMenu/AppModeHelper.enterBuilder),WorkflowHelper.openPersistedWorkflow(store reopen, not sidebar). Specs call those methods. Tests-only; notest.slow(), notest.setTimeoutbumps, no product code.Verification
Expected: under Chromium 15s without
test.slow().This branch’s Chromium E2E is green on run 35292808691 @
bcd9c0e30b(all 16 chromium shards +e2e-status). Local Playwright could not run here: no Docker/ComfyUI backend.