Repository navigation
[backport cloud/1.54] fix(agent): repair diagnostic report copying and recovery - #17938
Conversation
Backport #17773 to cloud/1.54 using the release branch's existing Agent fixture and preserving its pins and deleted run-mode popover.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1922 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-17T16:51:26.867Z",
"gitSha": "d5916781de19d4327194b7350327e648c463c71a",
"branch": "backport-17773-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.1399999999267,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.602999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.06600000000003,
"heapDeltaBytes": 4602876,
"heapUsedBytes": 74672736,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.795,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2030.5759999999964,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.473000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.01,
"heapDeltaBytes": -5257356,
"heapUsedBytes": 65019600,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.214000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1781.564000000003,
"styleRecalcs": 75,
"styleRecalcDurationMs": 33.476,
"layouts": 14,
"layoutDurationMs": 4.234,
"taskDurationMs": 835.928,
"heapDeltaBytes": 10006448,
"heapUsedBytes": 78893128,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 145.035,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.4050000000525,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.778,
"layouts": 14,
"layoutDurationMs": 3.8579999999999997,
"taskDurationMs": 692.8480000000001,
"heapDeltaBytes": -104556,
"heapUsedBytes": 70161564,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 117.308,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1671.2049999999863,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.895999999999999,
"layouts": 6,
"layoutDurationMs": 0.9039999999999998,
"taskDurationMs": 285.465,
"heapDeltaBytes": 4720260,
"heapUsedBytes": 74755364,
"domNodes": 78,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.934000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.4510000000155,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.889999999999997,
"layouts": 6,
"layoutDurationMs": 0.942,
"taskDurationMs": 289.3790000000001,
"heapDeltaBytes": 4751696,
"heapUsedBytes": 74660308,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 9.940999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 566.6289999999208,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.454999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.53400000000005,
"heapDeltaBytes": 18221016,
"heapUsedBytes": 88354644,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 133.127,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 548.5899999999901,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.046,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.787,
"heapDeltaBytes": -7777112,
"heapUsedBytes": 62820584,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 125.917,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2014.5670000000564,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.407000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.3829999999999,
"heapDeltaBytes": -15021144,
"heapUsedBytes": 87786364,
"domNodes": -264,
"jsHeapTotalBytes": -1114112,
"scriptDurationMs": 27.977,
"eventListeners": -140,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2030.0419999999804,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.395,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.72,
"heapDeltaBytes": -14520660,
"heapUsedBytes": 87836312,
"domNodes": -265,
"jsHeapTotalBytes": -327680,
"scriptDurationMs": 32.211999999999996,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2121.3659999999663,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.307,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1287.758,
"heapDeltaBytes": 4736168,
"heapUsedBytes": 80752596,
"domNodes": -266,
"jsHeapTotalBytes": 1171456,
"scriptDurationMs": 619.424,
"eventListeners": -140,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2107.058000000052,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.452,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1266.8809999999999,
"heapDeltaBytes": 17880732,
"heapUsedBytes": 84459512,
"domNodes": 8,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 626.926,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3205.652999999984,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.252000000000002,
"layouts": 60,
"layoutDurationMs": 11.391,
"taskDurationMs": 1365.213,
"heapDeltaBytes": 8076900,
"heapUsedBytes": 75933276,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 616.082,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3362.404999999967,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.828000000000001,
"layouts": 60,
"layoutDurationMs": 11.998,
"taskDurationMs": 1460.0310000000002,
"heapDeltaBytes": 11733988,
"heapUsedBytes": 79648976,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 641.7669999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2272.3250000000235,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.135999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1506.314,
"heapDeltaBytes": 14990216,
"heapUsedBytes": 82199864,
"domNodes": 4,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 740.34,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2519.3100000000186,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.8020000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1581.6849999999997,
"heapDeltaBytes": 13766284,
"heapUsedBytes": 81566220,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 775.876,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.210000000081,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.1949999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.6660000000001,
"heapDeltaBytes": 22322428,
"heapUsedBytes": 88067352,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.499000000000002,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.5300000000407,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.344999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.82899999999995,
"heapDeltaBytes": 10773216,
"heapUsedBytes": 87277628,
"domNodes": -267,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 30.044999999999995,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 522.9010000000471,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.830000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.893,
"heapDeltaBytes": 14106328,
"heapUsedBytes": 86254092,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 109.478,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 569.8899999999867,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.262999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.68699999999995,
"heapDeltaBytes": 15144436,
"heapUsedBytes": 87293784,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 119.65999999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2019.9249999999438,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.905000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.584,
"heapDeltaBytes": -6073080,
"heapUsedBytes": 59447484,
"domNodes": -294,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.451,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1990.7160000000204,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.529000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.371,
"heapDeltaBytes": -14014132,
"heapUsedBytes": 57355784,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.323999999999998,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.7939999999826,
"styleRecalcs": 76,
"styleRecalcDurationMs": 30.275000000000002,
"layouts": 18,
"layoutDurationMs": 4.812,
"taskDurationMs": 660.6580000000001,
"heapDeltaBytes": -12034676,
"heapUsedBytes": 59966160,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 87.73599999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.9490000000224,
"styleRecalcs": 78,
"styleRecalcDurationMs": 30.53,
"layouts": 18,
"layoutDurationMs": 4.56,
"taskDurationMs": 686.633,
"heapDeltaBytes": -1006216,
"heapUsedBytes": 71255428,
"domNodes": -294,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 88.07000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 884.0300000000525,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.207,
"layouts": 16,
"layoutDurationMs": 11.803999999999998,
"taskDurationMs": 705.95,
"heapDeltaBytes": 20989008,
"heapUsedBytes": 109551788,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 21.857000000000003,
"eventListeners": 2385,
"totalBlockingTimeMs": 94,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8265.420999999948,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.623,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4544.022,
"heapDeltaBytes": 17050620,
"heapUsedBytes": 93260564,
"domNodes": -269,
"jsHeapTotalBytes": -1187840,
"scriptDurationMs": 2111.193,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8451.25799999994,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.150000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4885.241,
"heapDeltaBytes": -8251148,
"heapUsedBytes": 93508648,
"domNodes": -269,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 2190.547,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14481.30900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13857.916,
"heapDeltaBytes": -14235308,
"heapUsedBytes": 176313760,
"domNodes": -6548,
"jsHeapTotalBytes": 2138112,
"scriptDurationMs": 213.256,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14922.963999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14541.534000000001,
"heapDeltaBytes": -35584392,
"heapUsedBytes": 181064268,
"domNodes": -6548,
"jsHeapTotalBytes": 6045696,
"scriptDurationMs": 222.66600000000003,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17097.395000000004,
"styleRecalcs": 138,
"styleRecalcDurationMs": 13.727000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16644.216,
"heapDeltaBytes": -9824180,
"heapUsedBytes": 179642964,
"domNodes": -6548,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 702.9060000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 3,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17362.578999999983,
"styleRecalcs": 143,
"styleRecalcDurationMs": 14.546000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17010.118000000002,
"heapDeltaBytes": -27692224,
"heapUsedBytes": 176559252,
"domNodes": -6548,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 709.8520000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5154.39600000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.01699999999999,
"layouts": 20,
"layoutDurationMs": 20.414,
"taskDurationMs": 5045.515,
"heapDeltaBytes": -30634368,
"heapUsedBytes": 177830632,
"domNodes": -6548,
"jsHeapTotalBytes": 14159872,
"scriptDurationMs": 82.99900000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 167,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5292.382000000089,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.308,
"layouts": 20,
"layoutDurationMs": 21.810999999999996,
"taskDurationMs": 5194.205,
"heapDeltaBytes": -39786792,
"heapUsedBytes": 177270452,
"domNodes": -6548,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 91.771,
"eventListeners": -7471,
"totalBlockingTimeMs": 194,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7285.098999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7030.642,
"heapDeltaBytes": 19007568,
"heapUsedBytes": 184050620,
"domNodes": 0,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 109.01800000000006,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7318.570000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7143.633999999999,
"heapDeltaBytes": 1884320,
"heapUsedBytes": 176910520,
"domNodes": 0,
"jsHeapTotalBytes": -6815744,
"scriptDurationMs": 111.14099999999999,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 73.95499999995536,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.645999999999999,
"layouts": 2,
"layoutDurationMs": 0.96,
"taskDurationMs": 53.809999999999995,
"heapDeltaBytes": 3074820,
"heapUsedBytes": 71215828,
"domNodes": 127,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 4.732,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 453.3440000000155,
"styleRecalcs": 16,
"styleRecalcDurationMs": 21.116000000000003,
"layouts": 3,
"layoutDurationMs": 0.8699999999999999,
"taskDurationMs": 101.28099999999999,
"heapDeltaBytes": 4805948,
"heapUsedBytes": 72259900,
"domNodes": 123,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.397,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #17938 +/- ##
=============================================
Coverage ? 83.05%
=============================================
Files ? 2056
Lines ? 120416
Branches ? 33069
=============================================
Hits ? 100016
Misses ? 20224
Partials ? 176
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Target-native diagnostic-copy adaptation looks correct.
Exact-head cloud acceptance is green.
Unit CI remains the only active merge gate.
Full context for agent readers
Reviewed the complete diff at exact head d7a520c0 against cloud/1.54 parent 0b599fac.
The adaptation preserves raw string logs while serializing structured Cloud log responses, defaults optional diagnostics on, retains/redacts collection status correctly, and provides a retryable readonly fallback when clipboard access fails. It intentionally keeps release-native fixtures and leaves the target-deleted run-mode popover test absent.
Local exact-head evidence: 59 focused unit tests and three diagnostic browser cases passed; the cloud build, formatting, lint, static analysis, root/browser type checks, dependency analysis, and diff checks passed. Parent runs failed 21 focused unit assertions and all three new browser cases for the intended missing behavior. Frontend remains version 1.54.10 and the multiplayer dependency remains version 0.2.1.
The existing Agent flag-on lifecycle case passed. The flag-off lifecycle case fails identically on the parent and this head, so it is recorded as a release baseline rather than attributed to this change. No code-review findings or human objections are present. This is a COMMENT review because GitHub does not permit honest self-approval. Merge still requires the active hosted unit job to finish and the target-aware guard to pass.
Backports frontend source PR #17773 to
cloud/1.54. Target-specific tests are green; release pins are unchanged.Full context for agent readers
Target-native adaptation
1.54.10and@comfyorg/comfy-multi-player0.2.1pins.Verification at exact head
cloud/1.54for the intended missing behavior.build:cloudpassed.No deployment or release/tag automation is included.