Repository navigation
FE-2216 fix(billing): close the review findings left open on the subscription rail - #17922
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 2033 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
📦 Bundle: 10.1 MB gzip 🔴 +338 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 34.9 kB (baseline 34.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.82 MB (baseline 3.82 MB) • 🔴 +235 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 562 kB (baseline 562 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 18 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • 🔴 +241 BBundles that do not match a named category
Status: 73 added / 73 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-17T11:02:30.655Z",
"gitSha": "805fe505494b6e420f2dc9a7292139204e2d9aa4",
"branch": "jaewon/fe-2216-rail-review-followups",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1990.0080000000173,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.582000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.0589999999999,
"heapDeltaBytes": 1241388,
"heapUsedBytes": 63826868,
"domNodes": -261,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.015,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1992.542999999955,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.590000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 260.697,
"heapDeltaBytes": 9028296,
"heapUsedBytes": 71375988,
"domNodes": -258,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.524000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.2990000000204,
"styleRecalcs": 73,
"styleRecalcDurationMs": 25.254999999999995,
"layouts": 14,
"layoutDurationMs": 4.748,
"taskDurationMs": 617.98,
"heapDeltaBytes": 8024356,
"heapUsedBytes": 70349616,
"domNodes": -260,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 115.82699999999998,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1690.322999999978,
"styleRecalcs": 73,
"styleRecalcDurationMs": 25.196,
"layouts": 14,
"layoutDurationMs": 4.568,
"taskDurationMs": 623.902,
"heapDeltaBytes": -4507248,
"heapUsedBytes": 57561516,
"domNodes": -256,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 118.80199999999999,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.120000000008,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.583,
"layouts": 6,
"layoutDurationMs": 1.2069999999999999,
"taskDurationMs": 273.82300000000004,
"heapDeltaBytes": 2161592,
"heapUsedBytes": 64656768,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.616999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.962000000005,
"styleRecalcs": 30,
"styleRecalcDurationMs": 19.313000000000002,
"layouts": 6,
"layoutDurationMs": 2.329,
"taskDurationMs": 246.34,
"heapDeltaBytes": 2069164,
"heapUsedBytes": 64564672,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.129000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 515.2549999999678,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.028999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.967,
"heapDeltaBytes": 17990996,
"heapUsedBytes": 79689924,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 111.17,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 509.49500000001535,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.7890000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.75,
"heapDeltaBytes": 17855244,
"heapUsedBytes": 80626912,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 110.343,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2024.8690000000238,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.989999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.78000000000003,
"heapDeltaBytes": -9813040,
"heapUsedBytes": 75763404,
"domNodes": -256,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 28.85,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.7749999999573,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.014999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.52400000000006,
"heapDeltaBytes": -4283960,
"heapUsedBytes": 75352776,
"domNodes": -254,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 27.477,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2587.926999999979,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.570999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1247.134,
"heapDeltaBytes": 19595744,
"heapUsedBytes": 84040632,
"domNodes": -245,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 602.488,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2224.847000000011,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.25,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1201.0770000000002,
"heapDeltaBytes": -979356,
"heapUsedBytes": 80005756,
"domNodes": -242,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 586.802,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3432.644000000039,
"styleRecalcs": 62,
"styleRecalcDurationMs": 13.261999999999997,
"layouts": 60,
"layoutDurationMs": 15.539,
"taskDurationMs": 1296.621,
"heapDeltaBytes": 7216616,
"heapUsedBytes": 74080356,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 568.053,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3187.172999999973,
"styleRecalcs": 67,
"styleRecalcDurationMs": 17.365,
"layouts": 60,
"layoutDurationMs": 14.925999999999998,
"taskDurationMs": 1253.9640000000002,
"heapDeltaBytes": -8373496,
"heapUsedBytes": 73534516,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 546.769,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2716.7759999999817,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.494999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1483.995,
"heapDeltaBytes": 9520556,
"heapUsedBytes": 92792028,
"domNodes": 12,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 723.477,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2270.372000000009,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.135000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1345.95,
"heapDeltaBytes": 17803484,
"heapUsedBytes": 101095980,
"domNodes": 12,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 656.3,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2036.1230000000319,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.649999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.10499999999996,
"heapDeltaBytes": -10940664,
"heapUsedBytes": 77359880,
"domNodes": -256,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 34.19200000000001,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1989.2360000000053,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.4399999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.89,
"heapDeltaBytes": 19666968,
"heapUsedBytes": 84499752,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.235999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 474.68000000003485,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.227999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 307.77700000000004,
"heapDeltaBytes": 13490888,
"heapUsedBytes": 77101676,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 103.437,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 430.217999999968,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.904,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.16600000000005,
"heapDeltaBytes": 13734368,
"heapUsedBytes": 76964696,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 102.424,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.0440000000212,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.257,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.11100000000005,
"heapDeltaBytes": -6244404,
"heapUsedBytes": 57577064,
"domNodes": -273,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.088000000000001,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1988.5039999999776,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.328000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.475,
"heapDeltaBytes": 11372380,
"heapUsedBytes": 75040812,
"domNodes": -272,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.859999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.811000000031,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.389000000000003,
"layouts": 18,
"layoutDurationMs": 6.04,
"taskDurationMs": 638.573,
"heapDeltaBytes": 1432324,
"heapUsedBytes": 65340176,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 90.459,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.035000000009,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.224999999999998,
"layouts": 18,
"layoutDurationMs": 5.778999999999999,
"taskDurationMs": 598.3640000000001,
"heapDeltaBytes": -4036844,
"heapUsedBytes": 59841872,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 91.477,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 802.1499999999833,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.077000000000005,
"layouts": 5,
"layoutDurationMs": 8.262,
"taskDurationMs": 587.7159999999999,
"heapDeltaBytes": 19662388,
"heapUsedBytes": 101356600,
"domNodes": 13587,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 20.784999999999997,
"eventListeners": 2385,
"totalBlockingTimeMs": 67,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10233.524999999987,
"styleRecalcs": 248,
"styleRecalcDurationMs": 47.07600000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4806.07,
"heapDeltaBytes": 3766016,
"heapUsedBytes": 84215736,
"domNodes": -246,
"jsHeapTotalBytes": -339968,
"scriptDurationMs": 2213.934,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8370.851000000017,
"styleRecalcs": 250,
"styleRecalcDurationMs": 45.669000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4368.576,
"heapDeltaBytes": -14130220,
"heapUsedBytes": 65330456,
"domNodes": -252,
"jsHeapTotalBytes": 2875392,
"scriptDurationMs": 2077.361,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12511.320999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12309.05,
"heapDeltaBytes": -27362064,
"heapUsedBytes": 182143660,
"domNodes": -8061,
"jsHeapTotalBytes": -6594560,
"scriptDurationMs": 181.52599999999998,
"eventListeners": -14926,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12515.517000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12332.800000000001,
"heapDeltaBytes": -46503952,
"heapUsedBytes": 184453796,
"domNodes": -8062,
"jsHeapTotalBytes": -13426688,
"scriptDurationMs": 177.378,
"eventListeners": -14926,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14893.313999999975,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.350000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14787.143,
"heapDeltaBytes": -52007052,
"heapUsedBytes": 178788560,
"domNodes": -8061,
"jsHeapTotalBytes": -11591680,
"scriptDurationMs": 650.888,
"eventListeners": -14924,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15037.120000000072,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.713000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14888.649,
"heapDeltaBytes": -35707028,
"heapUsedBytes": 195525836,
"domNodes": -8061,
"jsHeapTotalBytes": -6418432,
"scriptDurationMs": 630.4490000000001,
"eventListeners": -14924,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4578.080999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.64600000000001,
"layouts": 20,
"layoutDurationMs": 27.686000000000003,
"taskDurationMs": 4559.391,
"heapDeltaBytes": -34990964,
"heapUsedBytes": 196220108,
"domNodes": -8061,
"jsHeapTotalBytes": 20914176,
"scriptDurationMs": 75.70900000000002,
"eventListeners": -14924,
"totalBlockingTimeMs": 167,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4457.071000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.99799999999999,
"layouts": 20,
"layoutDurationMs": 24.017999999999997,
"taskDurationMs": 4428.573,
"heapDeltaBytes": -40966100,
"heapUsedBytes": 190493468,
"domNodes": -8062,
"jsHeapTotalBytes": 20434944,
"scriptDurationMs": 72.682,
"eventListeners": -14924,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6229.636000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6120.0960000000005,
"heapDeltaBytes": -14060248,
"heapUsedBytes": 171422184,
"domNodes": 0,
"jsHeapTotalBytes": -22806528,
"scriptDurationMs": 109.82300000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6452.661000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6376.259000000001,
"heapDeltaBytes": 13207216,
"heapUsedBytes": 176166892,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 96.661,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 88.55399999998781,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.086999999999998,
"layouts": 3,
"layoutDurationMs": 1.423,
"taskDurationMs": 61.233999999999995,
"heapDeltaBytes": 3113480,
"heapUsedBytes": 65218836,
"domNodes": 123,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.96,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 423.2319999999845,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.057,
"layouts": 3,
"layoutDurationMs": 0.892,
"taskDurationMs": 87.86400000000002,
"heapDeltaBytes": 4867636,
"heapUsedBytes": 66890956,
"domNodes": 122,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.735999999999998,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (10)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe changes expand subscription response tests, validate and deduplicate hosted billing URLs, stabilize checkout rail state, and verify hosted-tab write order. Several comments now describe operation adoption, joining, and billing fallback behavior. ChangesBilling flow
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant BillingSdkStore
participant validateActionUrl
participant BrowserWindow
BillingSdkStore->>validateActionUrl: validate pending hosted action URL
validateActionUrl-->>BillingSdkStore: return HTTPS URL or undefined
BillingSdkStore->>BrowserWindow: open each validated URL once per operation
Merge Risk: ⚪ Minimal · up to The billing action validation and checkout rail behavior are covered by the supplied implementation and targeted tests; no current merge-blocking risk is identified. Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The check fails all three conditions. The title uses
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17922 +/- ##
=======================================
Coverage 82.63% 82.63%
=======================================
Files 2892 2892
Lines 143082 143087 +5
Branches 36775 36776 +1
=======================================
+ Hits 118237 118244 +7
+ Misses 23611 23609 -2
Partials 1234 1234
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approving. The fix is right and the defect was real — I checked it on main rather than taking the description for it:
// main today
useSubscriptionRail()?.subscriptionActionUrl ?? null // inside the computed
// here
const subscriptionRail = useSubscriptionRail() // hoisted to setup
subscriptionRail?.subscriptionActionUrl ?? nullCalling a composable inside a computed makes the getter's value depend on when it recomputes rather than on its inputs, which is how a flag flip mid-checkout could drop the parked hosted URL. Given that URL is the customer's only route through a blocked payment popup, "vanishes while they are standing in front of it" is an accurate description of the consequence. Hoisting to setup scope is the minimal correct fix, and the new assertions on activeCheckoutActionUrl.value pin it.
One process point, and I think it matters more than the diff
Ten review findings arrived on #17856 after christian-byrne had approved it. Pushing them there would have dismissed that approval, so they land here instead.
I appreciate the intent, but I would rather you had dismissed the approval. That trade is inverted: an approval is cheap to re-earn, a customer-facing defect on main is not.
Concretely — I have re-approved five or six PRs this session after head moves, usually inside the hour, and each time the re-check was cheap because I keep the properties I verified written down. The cost of dismissing me is one tick. The cost of the other choice is that this defect is live on main right now and stays there until this PR lands.
The split is the right call for most of those ten: comments that no longer matched the code, test fixtures, a guarantee that was correct but undiscoverable. None of those need to gate a merge. It is specifically the one a customer can hit that should have gone back to #17856 and taken my approval with it.
If it helps: treat my approval as never being the thing to protect. If something real arrives after it, push to the same PR and ping me — I would rather re-read a diff than have a known defect ship to keep a green check intact.
Scope
I verified the activeCheckoutActionUrl fix and read its tests. The remaining comment and fixture changes I skimmed rather than read line by line; they are the low-risk half by construction, but my approval should not imply otherwise. CI green, no open threads.
|
Taken, and the rule is changed rather than noted. I had it as "once an approval is in hand, non-blocking findings go to a follow-up" — which quietly made protecting the check the thing being optimised. It is now: split on whether a customer can hit it. A real defect goes back to the same PR and takes the approval with it; comments, fixtures and correct-but-undiscoverable guarantees go to a follow-up. You are right about which of the ten this was. Nine were the low-risk half by construction. The The part of your comment I want to hold onto is why re-approval is cheap for you: you keep the properties you verified written down, so a head move is a re-check rather than a re-read. That makes the ping worth doing well — I will say what changed and which property to re-check, rather than just that the head moved. Noted too that your approval is scoped to the |
…nt UI package (Comfy-Org#17927) Linear FE-2218. ## Why `@comfyorg/account-ui` is the only workspace package that ships Vue — `@comfyorg/design-system` ships CSS and icons, `@comfyorg/tailwind-utils` ships `cn()`, and neither exports a component. So "put this component somewhere shared" has exactly one destination, and what belongs there has never been written down: `git grep account-ui docs/` returns nothing. The question stopped being theoretical. `apps/billing-web` renders `/v1/checkout` as a static mock with `checkout-enabled` false. The working flow is `src/platform/workspace/components/UnifiedStripePaymentSelector.vue` — 383 lines that mount Stripe Elements, call `createConfirmationToken`, and hand the token to `subscribe` for the lifecycle to drive through 3DS — and `apps/billing-web` cannot import it, because its only Vite alias is `@` onto its own `src`. Hosted checkout is a choice between promoting that component and writing a second one. ## Root cause of the ambiguity The boundary exists only as an export map plus one header comment, and that comment says the opposite of what we now want. `packages/account-ui/src/billing/index.ts`: > routing, windows, dialogs, the payment provider's SDK, and styling all stay > with the host. Read literally, provider-bound payment UI is out of scope for the package — which would leave duplication as the only path. Meanwhile ADR-AUTH-BILLING-0032 rule 4 forbids exactly that for the neighbouring case, naming embedded checkout among the surfaces that "do not get a site-local implementation … they wait for the shared command layer." The command layer landed. Nothing said where the view half of it lives, so the two rules point in opposite directions with no document resolving them. ## How One ADR, no code change. `PACKAGES-ACCOUNT-UI-0034` records five points: 1. Payment presentation — card element, confirmation token, authentication challenge — is in scope for `@comfyorg/account-ui`. 2. The header contract above changes with it, rather than being quietly contradicted. Routing, windows, dialogs and styling stay with the host. 3. The provider SDK enters behind `./billing/stripe` with `@stripe/stripe-js` as an optional peer, so a consumer wanting only composables does not take it on. No host has stated a requirement either way; this is the reversible direction, since collapsing two entry points is cheaper than splitting one consumers already import. 4. Promoted components take host couplings as inputs — `Button` by slot, telemetry by port — so the package stays unstyled. 5. Transport, commands and readers stay in `@comfyorg/account-core`. Moving a surface does not make it shareable: `useNextInvoice.ts` assembles an invoice amount from several server fields and its own docstring defers to an authoritative amount the backend does not expose, so it is not promoted. The identifier follows the grammar in `docs/adr/README.md`: `PACKAGES` is the owning subsystem, `ACCOUNT-UI` the narrower concern, two tags, broad to narrow. ## Review focus **Point 3 is the one I picked rather than derived.** Whether the Stripe entry point is separate or folded into `./billing` depends on whether the Platform install wants the payment UI, which nobody has told me. I took the split because it is the reversible error. If Platform is known to want checkout, folding it into `./billing` is simpler and this should change before the ADR is accepted. **Point 2 reverses something written down.** Anyone who read that header and kept provider code in a host was following the documented rule. Worth confirming the reversal is what we want rather than a gap being papered over. **The cost named under Consequences is real and lands before the first promotion.** `account-ui` has no `tsconfig.build.json` and no Vite config; the three SDK packages build with `tsc`, which cannot emit `.vue`. Making it publishable needs library-mode bundling plus `vue-tsc` declarations — new tooling, not a copy of what Comfy-Org#17882 did. ## AS IS / TO BE Documentation only; no runtime or UI change. `pnpm adr:check` passes (naming, identifier uniqueness, index row). - **AS IS** — the boundary is an export map and a header comment that excludes the provider SDK; `apps/billing-web` has no path to a real checkout that does not duplicate the cloud app. - **TO BE** — the boundary is a document, the header is scheduled to change with it, and promotion is the sanctioned path. ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | 5 slice 2 | Subscribe / plan change on the SDK rail | FE-2216 | merged (Comfy-Org#17856, Comfy-Org#17922) | | rollout C | `hosted_billing_destination` + `hostedDestination` port | FE-2218 | merged (Comfy-Org#17716, Comfy-Org#17783, Comfy-Org#17860) | | 6 | Contract tests per generated schema | FE-2217 | merged (Comfy-Org#17829) | | 7 | billing-web session, sign-in, `/v1` surfaces | FE-2218 | merged (Comfy-Org#17798) | | 7 | Publish readiness for account-core / billing-contract / ingest-types | FE-2218 | merged (Comfy-Org#17882) | | 7 | Package release workflows + versioning ADR | FE-2218 | open (Comfy-Org#17881) | | 7 | billing-web Vercel deployment config | FE-2218 | open (Comfy-Org#17788) | | 7 | **What belongs in `@comfyorg/account-ui`** | FE-2218 | **this PR** | | 7 | `account-ui` publish readiness + Vue library build | FE-2218 | todo (depends on this) | | 7 | First publish (`private` off), Platform install | FE-2218 | todo | | 8 ui | Promote the Stripe payment UI into `account-ui` | FE-2331 | todo (depends on this) | | 8 ui | billing-web `/v1/checkout` on the real flow, `/v1/result` | FE-2331 | todo | | 8 ui | billing-web subscription write actions | FE-2331 | todo | | 8 ui | `/v1/invoices` opens the provider portal, matching the cloud app | FE-2331 | todo | | 9 | Cloud app readers move onto the SDK rail | FE-2331 | todo | | 6 | Live E2E per flow x consumer + evidence table | FE-2217 | todo (needs staging flags) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui composables (merged)"] P5["Phase 5 top-up + subscription rails (merged)"] BWV["billing-web /v1 surfaces (merged)"] PUBR["publish readiness: 3 SDK packages (merged)"] REL["release workflows + ADR-0033"] VER["billing-web Vercel config"] ADR["ADR-0034 what belongs in account-ui"] UIPK["account-ui publish readiness + Vue build"] PROMO["promote Stripe payment UI"] CHK["billing-web real checkout + /v1/result"] SUBW["billing-web subscription writes"] INV["/v1/invoices to provider portal"] RD["cloud app readers on the SDK rail"] PUB["first publish + Platform install"] E2E["live E2E evidence"] P3 --> P4 P4 --> P5 P4 --> BWV PUBR --> REL REL --> PUB ADR --> UIPK ADR --> PROMO UIPK --> PUB PROMO --> CHK BWV --> CHK BWV --> SUBW BWV --> INV VER --> E2E CHK --> E2E P5 --> RD style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style BWV fill:#d4edda,stroke:#155724 style PUBR fill:#d4edda,stroke:#155724 style ADR stroke:#0366d6,stroke-width:4px ```
…rtal (Comfy-Org#18139) ## Why Comfy-Org#17853 put cancel, resubscribe **and** the payment portal on the subscription rail. `cancelSubscriptionSdkRail.spec.ts` covered cancel only, so two of the three shipped with no browser case on either rail — and the portal is the one with the most branching, because Comfy-Org#17922 added a three-destination cascade behind it. ## How `browser_tests/tests/dialogs/subscriptionLifecycleSdkRail.spec.ts`, a sibling of the cancel spec rather than an extension of it: both actions need a cancelled subscription and a populated plan catalog, which the cancel spec's active-subscription fixture does not have. Six rows plus the cascade. **Resubscribe — off / on / 404.** Same discriminator as cancel: the SDK transport runs on `fetch` and sends an `Idempotency-Key` matching the body's `idempotency_key`; the legacy workspace client runs on axios' XHR and sends neither. The 404 row proves the fallback fires once and the second attempt is the legacy one. **The six-row `/api/billing/plans` fixture** is the gap Comfy-Org#17853's evidence run recorded. The Reactivate plan button reads the catalog to name the plan being resumed, so an empty or one-row `plans` response never renders it — which is why resubscribe had no browser case to extend in the first place. **Payment portal — off / on / 404,** with one assertion that is deliberately a non-defect: `openPaymentPortal` carries **no** idempotency key on either rail, because it is a plain POST outside the operation lifecycle. The spec asserts its absence rather than treating it as missing, so a later change that adds one is noticed rather than assumed correct. **The blocked-popup cascade.** `manageSubscription` tries three destinations in order — the hosted billing-web page, then the rail, then the legacy call — and each opens a different page, so a browser refusing one says nothing about the next. The last row refuses every `window.open` and asserts the rail is still asked and the legacy call still runs after it. A refused tab must not be read as "the portal is handled", which is the regression Comfy-Org#17922 fixed. The `window.open` stand-in is the one from `hostedBillingDestination.spec.ts` — a proxy that records the destination instead of navigating, so a disowned-tab open cannot steer the test page — extended to record more than one destination, since the cascade opens several. ## AS IS / TO BE **No product change** — this PR adds a spec file and touches no source. There is nothing to capture; what changes is what CI proves about code already on `main`. ## Testing - `subscriptionLifecycleSdkRail.spec.ts` (new, `@cloud`) — 7 rows as above. - `pnpm typecheck`, `pnpm typecheck:browser` and `pnpm lint` pass. **This spec has not been executed locally.** It needs a cloud backend on `:8188`, which this checkout has no access to, so CI is its first run. Reviewers should treat a red `@cloud` shard here as the spec's own problem rather than a regression, and I will chase it. ## Plan position Milestone 1, Step 1b — [PR plan](https://linear.app/comfyorg/document/milestone-1-pr-plan-605f42c5e709). This is **PR 15**, backfill for code already on `main` (Comfy-Org#17853, Comfy-Org#17922), independent of every Step 1 PR and of the other two Step 1b PRs. | PR | Step | Tickets | What | Status | | --- | --- | --- | --- | --- | | 1 | 1 | FE-2469 | operation-state projections | merged — Comfy-Org#18036 | | 2 | 1 | FE-2467 | billing events reader | open — Comfy-Org#18042 | | 3 | 1 | FE-2479 | usage log on the rail | open — Comfy-Org#18047 | | 4 | 1 | FE-2468 | payment recovery on the rail | open — Comfy-Org#18060 | | 5 | 1 | FE-2470 | team checkout on the rail | open — Comfy-Org#18136 | | 6 | 1 | FE-2471 | one status reader | open — Comfy-Org#18092 | | 7 | 1 | FE-2480 + FE-2481 | checkout reads on the rail | open — Comfy-Org#18134 | | 8 | 1 | FE-2482 | subscription panel on the rail | open — Comfy-Org#18133 | | 9 | 1 | FE-2484 + FE-2483 + FE-2485 | recovery on the rail | open — Comfy-Org#18135 | | 10 | 1 | FE-2474 | top-up dialog adapter | open — Comfy-Org#18132 | | 11 | 1 | FE-2481 | one `proration_at` rule | backend answer | | 12 | 1 | FE-2472 | table-driven safety net | open — Comfy-Org#18137 | | 13 | 1b | FE-2475 | top-up rail E2E | open — Comfy-Org#18138 | | 14 | 1b | FE-2476 | six reads E2E | needs 3 | | **15** | **1b** | **FE-2477** | **resubscribe + portal E2E** | **this PR** | ```mermaid flowchart LR PR15["PR 15 · FE-2477<br/>resubscribe + portal E2E"]:::here STEP1["Step 1 · PRs 1-12"] PR13["PR 13 · FE-2475"] PR3["PR 3 · FE-2479"] --> PR14["PR 14 · FE-2476"] STEP1 --> BAKE["Step 3 · staging bake"] PR13 --> BAKE PR14 --> BAKE PR15 --> BAKE BAKE --> RAMP["Step 4 · production ramp"] --> REMOVE["Step 5 · legacy removal"] classDef here fill:#f2994a,stroke:#b35c00,color:#1a1a1a,font-weight:bold ``` - Part of FE-2477
Linear FE-2216.
Why
Ten review findings arrived on #17856 after christian-byrne had approved it. Pushing them there would have dismissed that approval, so they land here instead. Nothing in this PR blocks anything that shipped; it closes a guarantee that was correct but undiscoverable, one defect a customer could hit mid-checkout, and a set of comments and test fixtures that no longer said what the code does.
Root cause
Three distinct causes, one per behavioural fix.
The rail read the subscription rail inside a computed.
activeCheckoutActionUrlcalleduseSubscriptionRail()on every recomputation, so a flag flip mid-checkout re-evaluated the getter and dropped the parked hosted URL — the customer's only way through a blocked payment popup vanished while they were standing in front of it. It also meant the first caller to touch that computed constructed the SDK store, with its lifecycle subscription and window listeners, from inside a reactive getter.offeredActionswas aMap<string, string>holding only the latest URL and was never cleared. A publish sequence A, B, A offered A twice, and an operation that settled kept its entry forever.The hosted action URL's https guarantee lived only at the lifecycle boundary.
validateActionUrlruns inoperationLifecycle.ts:240andoperationState.ts:247, which are the only two writers ofactionUrlon a pending operation, so ajavascript:URL cannot reach the rail in production. But the type at the rail is a barestring, and the store's test harness publishes states directly, so nothing at that layer expressed the rule and the next reader has to re-derive it.How
billingSdkStore.ts— onehostedActionUrl(state)helper appliesvalidateActionUrlwhere the rail hands the URL out, read by bothsubscriptionActionUrlandopenHostedAction. Idempotent with the lifecycle's own check; it makes the property local and testable rather than adding a guarantee.billingSdkStore.ts—offeredActionsbecomesMap<string, Set<string>>, so a step already offered is never re-offered, and the entry is dropped when the operation leavespending, beside where the progress toast is cleared.useSubscriptionCheckout.ts—useSubscriptionRail()is hoisted beside the other store handles, read once.issuedStatusrather than relying on an omitted field;subscriptionCommands.tssays the issued status stays unset whenbeginadopted an operation or joined one another subscription command had in flight; themanageSubscriptionordering comment describes the cascade it actually performs; the disowned-tab docblock names what clearingopenerdoes not buy back.Two findings are declined with reasons in thread:
subscriptionActionUrlpicking the first of several pending subscription operations (three independent mechanisms make two simultaneous ones impossible), and derivingrequiredPaymentfromresumed(which does not distinguish a join from a fresh issue).AS-IS / TO-BE
No visual change. The one customer-visible difference is behavioural and has no UI to capture: with
billing_sdk_subscription_enabledflipped off during a checkout that is parked on a blocked payment popup, AS-IS the Complete verification button loses its URL and the customer is stuck; TO-BE the checkout keeps the rail it started on and the button still works.Testing
pnpm vitest run src/platform/workspacepnpm --filter @comfyorg/account-core testpnpm typecheck,pnpm lint,pnpm format:check,pnpm knipEvery behavioural change is red-first; the failures are quoted in the threads on #17856. The action-URL row publishes
javascript:alert(document.cookie)and expects no open.