Repository navigation
refactor(website): construct the workshop session client with a lazy identity #17833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MaanilVerma
merged 120 commits into
main
from
maanil/fe-2196-c3b-website-construct-with-identity
Sep 18, 2026
Merged
Changes from all commits
Commits
Show all changes
120 commits
Select commit
Hold shift + click to select a range
c19c893
refactor(account): make hosts the single source of auth copy
MaanilVerma e211cd3
fix(locales): drop account-existence wording from email-already-in-use
MaanilVerma 64ece9e
test(auth): guard cloud auth copy against account enumeration
MaanilVerma 3aa6c3c
test(auth): address review nits on auth copy resolution
MaanilVerma 36c5790
test(website): assert the collapsed invalid-credential line on user-n…
MaanilVerma c66a653
fix(website): drop the unrenderable user-not-found/wrong-password copy
MaanilVerma 9348238
test(website): broaden the sign-in enumeration oracle to match the cl…
MaanilVerma b742c75
Merge branch 'main' into maanil/fe-2188-localization-sso
MaanilVerma 7184764
fix(locales): drop the unrenderable user-not-found/wrong-password copy
MaanilVerma d0e3c13
Merge branch 'main' into maanil/fe-2188-localization-sso
MaanilVerma 3633eb7
test(website): use the i18n generic-error copy after the main merge
MaanilVerma cea548a
Merge branch 'main' into maanil/fe-2188-localization-sso
MaanilVerma 61b4451
fix(workspace): type the session error key against the locale shape
MaanilVerma b7a3541
Merge branch 'main' into maanil/fe-2188-localization-sso
MaanilVerma 885faf4
Merge branch 'main' into maanil/fe-2188-localization-sso
MaanilVerma e68e3f0
Merge remote-tracking branch 'origin/main' into maanil/fe-2188-locali…
MaanilVerma 4db1dbe
Merge remote-tracking branch 'origin/main' into maanil/fe-2191-decomp…
MaanilVerma d69670b
refactor(account): add pure session state transition and mint arbitra…
MaanilVerma 7a16e1f
refactor(account): route every session commit through one transition
MaanilVerma 6c9c0a5
refactor(account): import AccountUser from sessionContracts in identity
MaanilVerma d5e9fc3
refactor(account): carry commit payloads in session events and effects
MaanilVerma 4878540
refactor(account): extract credential cache and mint coordinator from…
MaanilVerma 3ccca0d
refactor(account): keep credential freshness policy with the cache
MaanilVerma d18c716
Merge remote-tracking branch 'origin/main' into maanil/fe-2196-c2-con…
MaanilVerma ce6d000
feat(account): construct the session client with identity and add dis…
MaanilVerma c265fdb
fix(account): harden the construct-with-identity tests and neutralize…
MaanilVerma 4516673
refactor(cloud): construct the session client with identity in worksp…
MaanilVerma 75711dc
refactor(cloud): review fixes for construct-with-identity in workspac…
MaanilVerma e35ef22
feat(account): lazily activated identity port
MaanilVerma dcc57ab
refactor(website): construct the workshop session client with a lazy …
MaanilVerma 35d7eb4
fix(account): resolve lazy identity activation on the first delivery
MaanilVerma d043b0f
test(website): flag off then on never shows signed-out before Firebas…
MaanilVerma c723b51
fix(account): drop a lazy identity loader rejection that lands after …
MaanilVerma 1e2216a
test(website): drive the workshop session host over the real session …
MaanilVerma 821bdf6
refactor(account): route the expiry commit through the single commit …
MaanilVerma c31f4ac
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma 75e3c28
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma 9dc4b31
fix(account): guard lazy identity delivery by generation and sign out…
MaanilVerma f5fc42b
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma f7e2e23
Merge remote-tracking branch 'origin/main' into maanil/fe-2191-decomp…
MaanilVerma e7153ec
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma 7459488
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma f2adf68
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma 9874cfe
Merge branch 'main' into maanil/fe-2188-localization-sso
MaanilVerma 651e277
Merge branch 'maanil/fe-2188-localization-sso' into maanil/fe-2191-de…
MaanilVerma 59b7573
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma 1b84482
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma 8f17e4e
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma 71e38b3
refactor(account): split the session transition and mint arbitration …
MaanilVerma 0f96221
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma d48d1f1
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma 5f7ad49
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma 612a1bb
fix(account): tighten the popup mint to exactly one identity event
MaanilVerma 44bbc19
perf(account): read stored credentials only when the in-memory one is…
MaanilVerma d65981c
fix(account): let a failed lazy identity activation retry and settle …
MaanilVerma 84a1ca2
fix(account): detach an identity subscription disposed during its fir…
MaanilVerma aeb36fc
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma 6699d65
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma 709b4c8
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma 23c5bb6
test(auth): share the enumeration oracle and cover the cancelled seco…
MaanilVerma df8ea1d
Merge branch 'main' into maanil/fe-2188-localization-sso
MaanilVerma 82e272e
Merge remote-tracking branch 'origin/maanil/fe-2188-localization-sso'…
MaanilVerma 65fa927
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma eb6dd94
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma 2e0858b
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma 448c4b9
Merge remote-tracking branch 'origin/main' into maanil/fe-2188-locali…
MaanilVerma 52054e1
Merge branch 'maanil/fe-2188-localization-sso' into maanil/fe-2191-de…
MaanilVerma 838ae89
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma d179a6c
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma eaa4428
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma 386d96d
Merge remote-tracking branch 'origin/main' into maanil/fe-2188-locali…
MaanilVerma 1b89a09
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma ffbec33
Merge branch 'maanil/fe-2188-localization-sso' into maanil/fe-2191-de…
MaanilVerma ea2ac9a
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma 2889104
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma 006f110
test(account): name the post-dispose explicit-user mint for what it does
MaanilVerma df6ffd7
refactor(account): name the mint guards by verdict and split the type…
MaanilVerma dc2ab4c
docs(account): state what lazy identity activation resolves on and th…
MaanilVerma 19ae957
test(account): take the identity suite's fakes from the shared fixture
MaanilVerma d48db49
test(account): share the session test fakes from one fixture module
MaanilVerma c5801ad
test(cloud): model the Firebase first delivery one way and pin store …
MaanilVerma 016f718
docs(cloud): name the construction-order dependency behind the identi…
MaanilVerma 7306ed8
test(website): pin the lazy identity re-activation, the abandoned min…
MaanilVerma 03bfdb7
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma 482ba49
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma 7d1d4c7
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma 37a84c2
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma 7af0afe
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma 9826d1b
Merge remote-tracking branch 'origin/main' into maanil/fe-2188-locali…
MaanilVerma f8e97d4
Merge branch 'maanil/fe-2188-localization-sso' into maanil/fe-2191-de…
MaanilVerma 4d98540
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma 53db9f3
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma ba5c637
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma feaeccc
test(account): split the client builder out of the data fixture and d…
MaanilVerma 01a3b78
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma 112bec2
test(account): import the scheduler buffer default instead of copying it
MaanilVerma 83d8fb8
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma b321250
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma f32024e
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma 4fbdc9b
fix(account): drop a session subscriber whose first replay throws
MaanilVerma 50580a6
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma 94b1495
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma 6b17307
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma da83189
test(website): pin the flag-off delivery, the cache hit, and trim the…
MaanilVerma 5b8b504
test(cloud): guard the replay port, export the settle ceiling, and ex…
MaanilVerma 9c1a388
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma 7614f52
Merge remote-tracking branch 'origin/main' into maanil/fe-2191-decomp…
MaanilVerma 4fa9efd
Merge branch 'maanil/fe-2191-decompose-session' into maanil/fe-2196-c…
MaanilVerma cb01c88
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma a8003b7
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma e8b0522
test(cloud): stub firebase and vuefire in the billing subscription-ra…
MaanilVerma e3ef8fd
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma 2949c2e
Merge remote-tracking branch 'origin/main' into maanil/fe-2196-c2-con…
MaanilVerma 4eea04e
Merge branch 'maanil/fe-2196-c2-construct-with-identity' into maanil/…
MaanilVerma c01fa5f
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma d145c57
Merge branch 'main' into maanil/fe-2196-c3-store-construct-with-identity
MaanilVerma 6e819ed
Merge branch 'maanil/fe-2196-c3-store-construct-with-identity' into m…
MaanilVerma 5e57606
Merge remote-tracking branch 'origin/main' into maanil/fe-2196-c3-sto…
MaanilVerma 549b82b
fix(cloud): fail closed when a rollback catches a unified mint parked…
MaanilVerma c93e823
Merge remote-tracking branch 'origin/maanil/fe-2196-c3-store-construc…
MaanilVerma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
27 changes: 27 additions & 0 deletions
27
apps/website/src/config/__fixtures__/workshopSessionFakes.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /** | ||
| * The user and token-exchange fakes the workshop session suites share. A | ||
| * suite keeps the transitions it drives; only the exchange contract lives here. | ||
| */ | ||
| import { vi } from 'vitest' | ||
|
|
||
| import type { AccountUser } from '@comfyorg/account-core/session' | ||
|
|
||
| export function testUser(uid = 'uid-1'): AccountUser { | ||
| return { uid, getIdToken: vi.fn(async () => 'id-token') } | ||
| } | ||
|
|
||
| export function mintBody(token: string) { | ||
| return { | ||
| token, | ||
| permissions: ['workspace:read'], | ||
| expires_at: new Date(Date.now() + 90 * 60 * 1000).toISOString(), | ||
| workspace: { id: 'ws-1', name: 'Personal', type: 'personal' }, | ||
| role: 'owner' | ||
| } | ||
| } | ||
|
|
||
| export function okFetch(token = 'jwt-1') { | ||
| return vi.fn<typeof fetch>( | ||
| async () => new Response(JSON.stringify(mintBody(token)), { status: 200 }) | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.