Repository navigation
test(billing): pin the status guard in needsCustomerAttention - #17803
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe test table adds coverage for a succeeded operation with a stale ChangesCustomer attention evaluation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to This test-only change is mergeable with minimal current-head risk. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2013 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle: 10 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 32.3 kB (baseline 32.3 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 123 kB (baseline 123 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.8 MB (baseline 3.8 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 561 kB (baseline 561 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.5 MB (baseline 17.5 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-16T03:14:54.011Z",
"gitSha": "92517c1e8658c6e8ff16105a3fb9b3d1ba7f98bb",
"branch": "jaewon/fe-2216-stale-action-url-case",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1998.4910000000013,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.296999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.019,
"heapDeltaBytes": 4748804,
"heapUsedBytes": 66744888,
"domNodes": -260,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.213,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2005.1469999999654,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.265999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.66200000000003,
"heapDeltaBytes": 13266192,
"heapUsedBytes": 74796412,
"domNodes": -264,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.537,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1980.827999999974,
"styleRecalcs": 76,
"styleRecalcDurationMs": 32.282000000000004,
"layouts": 14,
"layoutDurationMs": 5.118,
"taskDurationMs": 1015.3619999999999,
"heapDeltaBytes": 3760116,
"heapUsedBytes": 65732812,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 176.97500000000002,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.0890000000545,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.29,
"layouts": 14,
"layoutDurationMs": 4.832,
"taskDurationMs": 725.0360000000001,
"heapDeltaBytes": 18806192,
"heapUsedBytes": 81053112,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 141.325,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.8300000000345,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.665999999999999,
"layouts": 6,
"layoutDurationMs": 1.2129999999999999,
"taskDurationMs": 343.082,
"heapDeltaBytes": 2011016,
"heapUsedBytes": 63788428,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.308,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.1050000000087,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.967000000000002,
"layouts": 6,
"layoutDurationMs": 1.283,
"taskDurationMs": 350.52699999999993,
"heapDeltaBytes": 2096012,
"heapUsedBytes": 63644524,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.386000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 629.5180000000187,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.222000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.312,
"heapDeltaBytes": 18282572,
"heapUsedBytes": 80195688,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 149.585,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 608.1439999999247,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.364,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.831,
"heapDeltaBytes": 17883380,
"heapUsedBytes": 80207468,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 146.258,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2053.0390000000125,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.380000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.8770000000001,
"heapDeltaBytes": 3909988,
"heapUsedBytes": 83214164,
"domNodes": -247,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 36.981,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2054.860000000076,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.8069999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.367,
"heapDeltaBytes": -8644364,
"heapUsedBytes": 77116588,
"domNodes": -259,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 34.50599999999999,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2311.1449999999536,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.837999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1593.8850000000002,
"heapDeltaBytes": 15193264,
"heapUsedBytes": 79985896,
"domNodes": -251,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 778.014,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2400.6309999999758,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.201000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1551.1139999999998,
"heapDeltaBytes": 13986672,
"heapUsedBytes": 78955208,
"domNodes": 4,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 766.074,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3563.378,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.595999999999998,
"layouts": 60,
"layoutDurationMs": 15.167,
"taskDurationMs": 1666.2039999999997,
"heapDeltaBytes": -7765052,
"heapUsedBytes": 74110816,
"domNodes": -259,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 718.7059999999999,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3541.537000000062,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.113999999999999,
"layouts": 60,
"layoutDurationMs": 15.221000000000002,
"taskDurationMs": 1627.3950000000002,
"heapDeltaBytes": 9373480,
"heapUsedBytes": 92183096,
"domNodes": 10,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 729.909,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3178.59100000004,
"styleRecalcs": 44,
"styleRecalcDurationMs": 9.644999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1990.9040000000002,
"heapDeltaBytes": 1474828,
"heapUsedBytes": 85530728,
"domNodes": -231,
"jsHeapTotalBytes": 2244608,
"scriptDurationMs": 982.1129999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 3182.083000000034,
"styleRecalcs": 44,
"styleRecalcDurationMs": 12.434000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1875.3920000000003,
"heapDeltaBytes": -1859668,
"heapUsedBytes": 81746396,
"domNodes": -231,
"jsHeapTotalBytes": 1982464,
"scriptDurationMs": 919.837,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.3229999999676,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.035000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.2940000000001,
"heapDeltaBytes": -4283660,
"heapUsedBytes": 83882684,
"domNodes": -250,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.062000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.8229999999503,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.378999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.2570000000001,
"heapDeltaBytes": -3181224,
"heapUsedBytes": 84559720,
"domNodes": -247,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.5,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.3170000000405,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.805000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.0400000000001,
"heapDeltaBytes": 13774756,
"heapUsedBytes": 77576176,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 133.295,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.1920000000819,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.865,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.05800000000005,
"heapDeltaBytes": 13727944,
"heapUsedBytes": 77363944,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 136.155,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2030.288999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.229999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.99499999999995,
"heapDeltaBytes": -5030084,
"heapUsedBytes": 58675276,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.534,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1998.548000000028,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.858,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.909,
"heapDeltaBytes": -1340908,
"heapUsedBytes": 62224216,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.839,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.198999999966,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.117,
"layouts": 18,
"layoutDurationMs": 5.702,
"taskDurationMs": 805.4659999999999,
"heapDeltaBytes": 11542592,
"heapUsedBytes": 75098432,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 99.177,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.538999999917,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.482,
"layouts": 18,
"layoutDurationMs": 5.561,
"taskDurationMs": 789.73,
"heapDeltaBytes": -3563388,
"heapUsedBytes": 60144616,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 99.749,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1366.6880000000674,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.251000000000005,
"layouts": 5,
"layoutDurationMs": 10.205,
"taskDurationMs": 840.6759999999999,
"heapDeltaBytes": 20099448,
"heapUsedBytes": 103366924,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.992,
"eventListeners": 2387,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8369.430000000022,
"styleRecalcs": 248,
"styleRecalcDurationMs": 42.687000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5493.585,
"heapDeltaBytes": -13700456,
"heapUsedBytes": 65811856,
"domNodes": -225,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 2567.8770000000004,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8304.725999999959,
"styleRecalcs": 248,
"styleRecalcDurationMs": 41.87499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5425.311,
"heapDeltaBytes": -3828996,
"heapUsedBytes": 75346076,
"domNodes": -245,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 2502.907,
"eventListeners": -136,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14474.279999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14092.362,
"heapDeltaBytes": -28932340,
"heapUsedBytes": 172982500,
"domNodes": -6542,
"jsHeapTotalBytes": 466944,
"scriptDurationMs": 236.55099999999996,
"eventListeners": -7480,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14373.660999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13855.263999999997,
"heapDeltaBytes": -42208032,
"heapUsedBytes": 159701296,
"domNodes": -6542,
"jsHeapTotalBytes": 204800,
"scriptDurationMs": 234.96500000000003,
"eventListeners": -7480,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17403.821999999993,
"styleRecalcs": 133,
"styleRecalcDurationMs": 19.12799999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17254.546,
"heapDeltaBytes": -33581732,
"heapUsedBytes": 185530924,
"domNodes": -6542,
"jsHeapTotalBytes": -4694016,
"scriptDurationMs": 844.617,
"eventListeners": -7474,
"totalBlockingTimeMs": 18,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17395.37799999994,
"styleRecalcs": 133,
"styleRecalcDurationMs": 19.57399999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17154.818,
"heapDeltaBytes": -13572764,
"heapUsedBytes": 187737060,
"domNodes": -6541,
"jsHeapTotalBytes": -126976,
"scriptDurationMs": 851.256,
"eventListeners": -7474,
"totalBlockingTimeMs": 51,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5237.285999999926,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.26000000000002,
"layouts": 20,
"layoutDurationMs": 25.948999999999998,
"taskDurationMs": 5198.289000000001,
"heapDeltaBytes": -4922936,
"heapUsedBytes": 189613072,
"domNodes": -6542,
"jsHeapTotalBytes": 13836288,
"scriptDurationMs": 103.40399999999998,
"eventListeners": -7478,
"totalBlockingTimeMs": 210,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5251.919999999927,
"styleRecalcs": 20,
"styleRecalcDurationMs": 90.00899999999997,
"layouts": 20,
"layoutDurationMs": 31.805,
"taskDurationMs": 5176.032,
"heapDeltaBytes": -28175476,
"heapUsedBytes": 166168952,
"domNodes": -6542,
"jsHeapTotalBytes": 10690560,
"scriptDurationMs": 98.74099999999999,
"eventListeners": -7478,
"totalBlockingTimeMs": 350,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7358.229000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7177.909,
"heapDeltaBytes": -2886684,
"heapUsedBytes": 186261300,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 156.16299999999995,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7321.1299999999255,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7162.661,
"heapDeltaBytes": -15160256,
"heapUsedBytes": 174461400,
"domNodes": 0,
"jsHeapTotalBytes": -8650752,
"scriptDurationMs": 137.859,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 112.05600000005234,
"styleRecalcs": 7,
"styleRecalcDurationMs": 18.991,
"layouts": 4,
"layoutDurationMs": 2.3949999999999996,
"taskDurationMs": 93.17200000000001,
"heapDeltaBytes": 3208328,
"heapUsedBytes": 65219852,
"domNodes": 109,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.086,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 108.237000000031,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.915000000000001,
"layouts": 4,
"layoutDurationMs": 1.8780000000000001,
"taskDurationMs": 75.61100000000002,
"heapDeltaBytes": 3004464,
"heapUsedBytes": 65008940,
"domNodes": 124,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 5.0969999999999995,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
The table exercised every attention signal on a pending operation, so removing the `status === 'pending'` guard left all six cases green. That guard is the one semantic difference between the two predicates merged in #17792: the old `topupOperationView.needsCustomerAttention` had no status guard, `billingOperationStore` did. A settled operation carrying a stale `actionUrl` is the case that separates them, and it now fails without the guard.
ae074c7 to
737f29e
Compare
|
Rebased onto #17792 landed as a squash ( Re-verified on the rebased head: 7 passed. Mutation re-checked against the merged |
christian-byrne
left a comment
There was a problem hiding this comment.
Approving. I checked the claim rather than the diff, because the claim is the interesting part: "deleting the status === 'pending' guard left all six green."
CI cannot confirm that. The suite passes with or without the guard, which is the whole point being made, so green here says nothing about whether the new row does work. I enumerated it by hand instead, against the mutant:
// mutant: `operation.status === 'pending' &&` removed
return operation.status === 'reconciliation_needed' ||
(operation.actionUrl !== null ||
operation.authenticationState === 'requires_action' ||
operation.authenticationState === 'failed_retryable')with processing = { status: 'pending', actionUrl: null, authenticationState: null }:
| row | expected | mutant gives | survives? |
|---|---|---|---|
| hosted verification link | true | true | yes |
| in-page challenge | true | true | yes |
| retryable decline | true | true | yes |
| reconciliation_needed | true | true (first clause) | yes |
| merely processing | false | false | yes |
settled, {status:'succeeded'} |
false | false (actionUrl null) | yes |
| new: settled + stale actionUrl | false | true | no |
So all six did survive, and the new row is the only one that kills it. The mechanism is precise: every prior "attention" row varied the signal while leaving status pending, and every prior "no attention" row left actionUrl null, so no row ever crossed a settled status with a live signal. That intersection is exactly where the guard lives.
Two things I like about this beyond the coverage. The case is realistic rather than constructed for the mutant - a settled operation holding a stale actionUrl is what you actually get when a verification link outlives its purchase, and treating that as "needs attention" would put a dialog in front of someone whose payment already succeeded. And it is the fix arriving as its own test-only PR rather than riding along inside a behaviour change, which keeps it reviewable.
Nothing else here. Test-only, no behaviour change, and the table row is in the right file.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17803 +/- ##
==========================================
+ Coverage 82.50% 83.50% +0.99%
==========================================
Files 2827 2170 -657
Lines 141515 125512 -16003
Branches 36412 33788 -2624
==========================================
- Hits 116759 104807 -11952
+ Misses 23545 20411 -3134
+ Partials 1211 294 -917
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
The added row is the one that kills the guard removal; nothing to add.
Summary
Follow-up to #17792 (review thread): adds the one case that pins the
status === 'pending'guard inneedsCustomerAttention.Changes
customerAttention.test.tstable — a settled operation carrying a staleactionUrl, expectedfalse. Test-only; no behavior change.Review Focus
Every existing row exercised an attention signal on a pending operation, so deleting the
status === 'pending'guard left all six green. That guard is the only semantic difference between the two predicates #17792 merged — the oldtopupOperationView.needsCustomerAttentionhad no status guard,billingOperationStoredid — so it was the one thing the table had to pin and didn't.Verified by mutation: with the guard removed, 1 failed / 6 passed, and the failure is this new row. With the real predicate, 7 passed.
Based on
jaewon/fe-2216-customer-attention-predicatebecausecustomerAttention.tsdoes not exist onmainuntil #17792 lands; GitHub will retarget this tomainon merge.