Skip to content

docs(models): V2 keeps models and workflows in two catalogues - #17790

Closed
mariana953 wants to merge 7 commits into
mainfrom
mariana/v2-catalogue-decision
Closed

mariana953 wants to merge 7 commits into
mainfrom
mariana/v2-catalogue-decision

Conversation

@mariana953

@mariana953 mariana953 commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Branched off mariana/account-menu-polish by mistake, so it carried that PR's six commits alongside the ADR. Reopened clean off main as #17791.

The log out control lost its text in #17743 and kept only an aria-label, so
the door icon said nothing to anyone looking at it. The label returns on hover
as before, and now on focus too, so a keyboard reaches it.

The workspace monogram reads as a lighter step of the panel rather than a
colour of its own, so it takes the translucent white the menu already builds
with instead of the ocean step.

The workspace row sat on a 12px gutter while the credits row and the footer
sat on 16, which crowded the top of the menu and left the monogram out of
line with the coins under it. It joins them, and the space below the credits
gives back what the top now takes.
The email row carried a full 16px band above and below a single line of text,
which read as a gap under the address. The space under the credits goes back
to what it was.
The reveal is hover and focus state in the browser, which a component test
cannot exercise. The spec opens the menu on a real session and holds that the
label is hidden at rest, appears when the footer row is hovered, goes again
when the pointer leaves, and appears on keyboard focus.

Verified in reverse: with the reveal classes removed the case fails on the
hover assertion while the other eight in the file pass.
The switcher used to be a full width row, so a submenu placed to its left
cleared the menu. #17743 made it a 32px button at the right edge, and the
submenu has been landing on top of the menu ever since, covering the very
workspace it is offered from.

The offset is measured from the menu's own left edge rather than the button's,
so it follows the menu if its width changes instead of pinning a number that
would rot.

Covered against a real signed-in session: the list's right edge stays at or
before the menu's left edge. Verified in reverse by restoring the old offset,
which fails that case.
The button was sized to its line in #17756 but the icon inside it was not, so a
20px glyph sat beside 11px text and read as the loudest thing in the row.

CopyTextButton takes an optional icon class, merged over its own default the way
the button's class already is, so the four other callers keep the size they
have.
The point of passing the size through cn is that the caller's size wins rather
than sitting beside the default and leaving the outcome to stylesheet order.

Verified in reverse: with the merge replaced by a plain class list, the icon
carries both size-5 and size-3.5 and that case fails.
The V2 prototype built one merged list. The case against shipping it is a set
of numbers about the committed catalogue, and numbers quoted in a document rot
the moment the template snapshot is refreshed.

So the argument goes in an ADR and the numbers come from a script beside it:
610 templates against 145 models, 72 of them routable to a model page, 101
naming one, four titles that are a model name letter for letter, 78 needing
custom nodes, and every workflow already landing in the eight use cases the
models use.

The script separates the two counts that are easy to confuse: what navigation
can route, and what merely names a model. The second is the one that says how
often a merged list would repeat itself.
@mariana953
mariana953 requested review from a team and benjcooley September 16, 2026 01:03
@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1cd4551a-94c3-4e67-8d5c-041074b0475d

📥 Commits

Reviewing files that changed from the base of the PR and between 31346d1 and d2cba80.

📒 Files selected for processing (13)
  • apps/website/e2e/models-sign-in-draft.spec.ts
  • apps/website/package.json
  • apps/website/scripts/audit-catalogue-overlap.test.ts
  • apps/website/scripts/audit-catalogue-overlap.ts
  • apps/website/src/components/ui/copy-text-button/CopyTextButton.test.ts
  • apps/website/src/components/ui/copy-text-button/CopyTextButton.vue
  • apps/website/src/components/workshop/HeaderAccount.test.ts
  • apps/website/src/components/workshop/HeaderAccountMenu.vue
  • apps/website/src/components/workshop/HeaderWorkspaceMenu.vue
  • apps/website/src/components/workshop/ModelDetail.vue
  • apps/website/src/styles/global.css
  • docs/adr/README.md
  • docs/adr/WEBSITE-CATALOGUE-0032-models-and-workflows-browse-as-two-catalogues.md

📝 Walkthrough

Walkthrough

Changes

Catalogue audit and architecture record

Layer / File(s) Summary
Catalogue overlap audit
apps/website/scripts/audit-catalogue-overlap.ts
Adds overlap metrics, report formatting, and direct execution against hub data.
Audit command and validation
apps/website/package.json, apps/website/scripts/audit-catalogue-overlap.test.ts
Adds the hub:audit-overlap command and tests the audit results.
Catalogue architecture decision
docs/adr/README.md, docs/adr/WEBSITE-CATALOGUE-0032-models-and-workflows-browse-as-two-catalogues.md
Documents the proposed separation of models and workflow catalogues and records audit findings.ate

Account menu interaction and layout

Layer / File(s) Summary
Workspace submenu positioning
apps/website/src/components/workshop/HeaderWorkspaceMenu.vue
Computes the submenu offset from the account menu panel and trigger positions.
Account menu sign-out presentation
apps/website/src/components/workshop/HeaderAccountMenu.vue
Updates menu spacing and shows the sign-out label on hover or focus.
Account menu validation
apps/website/e2e/models-sign-in-draft.spec.ts, apps/website/src/components/workshop/HeaderAccount.test.ts
Tests submenu separation and responsive sign-out label visibility.

Copy button styling

Layer / File(s) Summary
Copy icon class override
apps/website/src/components/ui/copy-text-button/CopyTextButton.vue, apps/website/src/components/ui/copy-text-button/CopyTextButton.test.ts
Adds an icon class prop and tests default and overridden icon sizing.
Copy icon and workspace mark consumers
apps/website/src/components/workshop/ModelDetail.vue, apps/website/src/styles/global.css
Uses the smaller copy icon for router request IDs and changes the workspace mark token to a translucent tint.

Estimated code review effort: 3 (Moderate) | ~30 minutes

Change: Other

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mariana/v2-catalogue-decision

Warning

Some tools did not complete. Review the errors below.

🔧 Biome (2.5.11)
apps/website/src/styles/global.css

File contains syntax errors that prevent linting: Line 68: Tailwind-specific syntax is disabled.; Line 69: Tailwind-specific syntax is disabled.; Line 71: Tailwind-specific syntax is disabled.; Line 124: Tailwind-specific syntax is disabled.; Line 129: Tailwind-specific syntax is disabled.; Line 134: Tailwind-specific syntax is disabled.; Line 142: Tailwind-specific syntax is disabled.; Line 163: Tailwind-specific syntax is disabled.; Line 187: Tailwind-specific syntax is disabled.; Line 216: Tailwind-specific syntax is disabled.; Line 222: Tailwind-specific syntax is disabled.; Line 244: Tailwind-specific syntax is disabled.; Line 261: Tailwind-specific syntax is disabled.; Line 276: Tailwind-specific syntax is disabled.; Line 286: Tailwind-specific syntax is disabled.; Line 316: Tailwind-specific syntax is disabled.; Line 322: Tailwind-specific syntax is disabled.; Line 328: Tailwind-specific syntax is disabled.; Line 334: Tailwind-specific syntax is disabled.; Line 365: Tailwind-specific syntax is disabled.; Line 386: Tailwind-specific syntax is disabled.; Line 408: Tailwind-specific syntax is disabled.; Line 416: Tailwind-specific syntax is disabled.; Line 436: Tailwind-specific syntax is disabled.; Line 467: Tailwind-specific syntax is disabled.


Comment @coderabbitai help to get the list of available commands.

@mariana953 mariana953 closed this Sep 16, 2026
@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 16, 2026
@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...te/src/components/workshop/HeaderWorkspaceMenu.vue 87.50% 0 Missing and 1 partial ⚠️
@@           Coverage Diff           @@
##             main   #17790   +/-   ##
=======================================
  Coverage   82.50%   82.50%           
=======================================
  Files        2820     2820           
  Lines      141424   141433    +9     
  Branches    36405    36406    +1     
=======================================
+ Hits       116686   116694    +8     
  Misses      23531    23531           
- Partials     1207     1208    +1     
Flag Coverage Δ
website-unit 74.57% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../components/ui/copy-text-button/CopyTextButton.vue 100.00% <100.00%> (ø)
...site/src/components/workshop/HeaderAccountMenu.vue 98.03% <100.00%> (+0.03%) ⬆️
...ps/website/src/components/workshop/ModelDetail.vue 90.10% <ø> (ø)
...te/src/components/workshop/HeaderWorkspaceMenu.vue 97.67% <87.50%> (-2.33%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant