Repository navigation
docs(models): V2 keeps models and workflows in two catalogues - #17790
mariana953 wants to merge 7 commits into
Conversation
The log out control lost its text in #17743 and kept only an aria-label, so the door icon said nothing to anyone looking at it. The label returns on hover as before, and now on focus too, so a keyboard reaches it. The workspace monogram reads as a lighter step of the panel rather than a colour of its own, so it takes the translucent white the menu already builds with instead of the ocean step. The workspace row sat on a 12px gutter while the credits row and the footer sat on 16, which crowded the top of the menu and left the monogram out of line with the coins under it. It joins them, and the space below the credits gives back what the top now takes.
The email row carried a full 16px band above and below a single line of text, which read as a gap under the address. The space under the credits goes back to what it was.
The reveal is hover and focus state in the browser, which a component test cannot exercise. The spec opens the menu on a real session and holds that the label is hidden at rest, appears when the footer row is hovered, goes again when the pointer leaves, and appears on keyboard focus. Verified in reverse: with the reveal classes removed the case fails on the hover assertion while the other eight in the file pass.
The switcher used to be a full width row, so a submenu placed to its left cleared the menu. #17743 made it a 32px button at the right edge, and the submenu has been landing on top of the menu ever since, covering the very workspace it is offered from. The offset is measured from the menu's own left edge rather than the button's, so it follows the menu if its width changes instead of pinning a number that would rot. Covered against a real signed-in session: the list's right edge stays at or before the menu's left edge. Verified in reverse by restoring the old offset, which fails that case.
The button was sized to its line in #17756 but the icon inside it was not, so a 20px glyph sat beside 11px text and read as the loudest thing in the row. CopyTextButton takes an optional icon class, merged over its own default the way the button's class already is, so the four other callers keep the size they have.
The point of passing the size through cn is that the caller's size wins rather than sitting beside the default and leaving the outcome to stylesheet order. Verified in reverse: with the merge replaced by a plain class list, the icon carries both size-5 and size-3.5 and that case fails.
The V2 prototype built one merged list. The case against shipping it is a set of numbers about the committed catalogue, and numbers quoted in a document rot the moment the template snapshot is refreshed. So the argument goes in an ADR and the numbers come from a script beside it: 610 templates against 145 models, 72 of them routable to a model page, 101 naming one, four titles that are a model name letter for letter, 78 needing custom nodes, and every workflow already landing in the eight use cases the models use. The script separates the two counts that are easy to confuse: what navigation can route, and what merely names a model. The second is the one that says how often a merged list would repeat itself.
🌐 Website E2ETip All tests passed.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughChangesCatalogue audit and architecture record
Account menu interaction and layout
Copy button styling
Estimated code review effort: 3 (Moderate) | ~30 minutes Change: Other ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Biome (2.5.11)apps/website/src/styles/global.cssFile contains syntax errors that prevent linting: Line 68: Tailwind-specific syntax is disabled.; Line 69: Tailwind-specific syntax is disabled.; Line 71: Tailwind-specific syntax is disabled.; Line 124: Tailwind-specific syntax is disabled.; Line 129: Tailwind-specific syntax is disabled.; Line 134: Tailwind-specific syntax is disabled.; Line 142: Tailwind-specific syntax is disabled.; Line 163: Tailwind-specific syntax is disabled.; Line 187: Tailwind-specific syntax is disabled.; Line 216: Tailwind-specific syntax is disabled.; Line 222: Tailwind-specific syntax is disabled.; Line 244: Tailwind-specific syntax is disabled.; Line 261: Tailwind-specific syntax is disabled.; Line 276: Tailwind-specific syntax is disabled.; Line 286: Tailwind-specific syntax is disabled.; Line 316: Tailwind-specific syntax is disabled.; Line 322: Tailwind-specific syntax is disabled.; Line 328: Tailwind-specific syntax is disabled.; Line 334: Tailwind-specific syntax is disabled.; Line 365: Tailwind-specific syntax is disabled.; Line 386: Tailwind-specific syntax is disabled.; Line 408: Tailwind-specific syntax is disabled.; Line 416: Tailwind-specific syntax is disabled.; Line 436: Tailwind-specific syntax is disabled.; Line 467: Tailwind-specific syntax is disabled. Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #17790 +/- ##
=======================================
Coverage 82.50% 82.50%
=======================================
Files 2820 2820
Lines 141424 141433 +9
Branches 36405 36406 +1
=======================================
+ Hits 116686 116694 +8
Misses 23531 23531
- Partials 1207 1208 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Branched off
mariana/account-menu-polishby mistake, so it carried that PR's six commits alongside the ADR. Reopened clean offmainas #17791.