Repository navigation
test: harden flaky vue combo undo/redo e2e - #17735
MaanilVerma wants to merge 1 commit into
Conversation
🎭 Playwright: ✅ 2011 passed, 0 failed · 4 flaky📊 Browser Reports
📦 Bundle: 10 MB gzip 🔴 +129 kBDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +12.6 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 128 kB) • 🔴 +4.05 kBTop-level views, pages, and routed surfaces
Status: 17 added / 17 removed / 1 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 26.2 kB (baseline 28.9 kB) • 🟢 -2.68 kBAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 3 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +745 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 123 kB (baseline 118 kB) • 🔴 +5.66 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.72 MB (baseline 3.64 MB) • 🔴 +76.1 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 560 kB (baseline 558 kB) • 🔴 +2.63 kBHelpers, composables, and utility bundles
Status: 28 added / 27 removed / 9 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • 🔴 +13 kBExternal libraries and shared vendor chunks
Status: 7 added / 7 removed / 11 unchanged Other — 17.5 MB (baseline 17 MB) • 🔴 +511 kBBundles that do not match a named category
Status: 171 added / 171 removed / 125 unchanged ⚡ Performance
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe combo widget test now clicks the KSampler node title before undo and redo. This flushes the combo edit into the undo history and moves focus away from the combobox. ChangesCombo undo and redo
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change stabilizes the combo undo and redo test without introducing a production behavior risk. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17735 +/- ##
==========================================
+ Coverage 82.71% 83.77% +1.06%
==========================================
Files 2782 2132 -650
Lines 139995 124223 -15772
Branches 37536 33148 -4388
==========================================
- Hits 115790 104074 -11716
+ Misses 23118 19967 -3151
+ Partials 1087 182 -905
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
The
Vue Combo Widget › a combo value tracks undo and redoe2e test flakes on main and is turning open PRs red (for example #17643). This makes the spec push the combo edit onto the undo stack before it presses undo, so the first undo stops being a no-op.Changes
comboWidget.spec.tsnow clicks the KSampler node title after selectingkarrasand before the undo keystrokes. That click is a real windowmouseup, which is what the change tracker insrc/scripts/changeTracker.tslistens for to record the edit into history.page.keyboard.press('Escape')step and its comment, since clicking the node already moves focus off the combobox.karras, and that redo does not push its own history entry.Review Focus
mouseupon the change tracker's window listener, not through the widget update path.createWidgetUpdateHandlerinsrc/renderer/extensions/vueNodes/composables/processedWidgetRenderModel.ts:235setslive.widget.valuebut never captures state. If a later change adds explicit history capture on widget commit, the node click here becomes redundant.QA
oxfmt --check, and comment-hygiene pass on the changed file.@vue-nodes @widgetcombo undo/redo spec passes. This is the gate. The local Vue-node harness does not run in my environment (no local ComfyUI backend, Node version mismatch), so I did not run the spec.schedulerstuck onkarras.