Repository navigation
test: consolidate current user mocks - #17724
Conversation
🎭 Playwright: ✅ 2031 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 10.1 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 34.9 kB (baseline 34.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.83 MB (baseline 3.83 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 562 kB (baseline 562 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-17T21:26:37.112Z",
"gitSha": "cb6a0230068107364511e141c96cbdbbba1a32d8",
"branch": "drjkl/fe-2343-current-user-mocks",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2035.0060000000099,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.170000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.5520000000001,
"heapDeltaBytes": 1741216,
"heapUsedBytes": 63873008,
"domNodes": -264,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 8.008999999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2009.55399999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.415,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.563,
"heapDeltaBytes": 1635928,
"heapUsedBytes": 64182184,
"domNodes": -261,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.851999999999999,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.0160000000096,
"styleRecalcs": 75,
"styleRecalcDurationMs": 21.446,
"layouts": 14,
"layoutDurationMs": 4.09,
"taskDurationMs": 635.308,
"heapDeltaBytes": 22309092,
"heapUsedBytes": 85124604,
"domNodes": 37,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 119.02799999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.035000000099,
"styleRecalcs": 73,
"styleRecalcDurationMs": 19.584,
"layouts": 14,
"layoutDurationMs": 3.57,
"taskDurationMs": 661.036,
"heapDeltaBytes": -6971572,
"heapUsedBytes": 55819228,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 117.095,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.5699999999947,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.406,
"layouts": 6,
"layoutDurationMs": 1.093,
"taskDurationMs": 273.428,
"heapDeltaBytes": 2510912,
"heapUsedBytes": 70430888,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.263,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.3790000000126,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.665,
"layouts": 6,
"layoutDurationMs": 1.1329999999999998,
"taskDurationMs": 273.844,
"heapDeltaBytes": 1871536,
"heapUsedBytes": 64543284,
"domNodes": 75,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.962999999999997,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 516.3099999999758,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.456,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.56199999999995,
"heapDeltaBytes": 17579264,
"heapUsedBytes": 79982060,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 122.74900000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 526.4840000000959,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.143000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.62100000000004,
"heapDeltaBytes": 17893568,
"heapUsedBytes": 80078932,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 129.05999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2021.7289999999934,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.477,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.098,
"heapDeltaBytes": 3417428,
"heapUsedBytes": 83775956,
"domNodes": -243,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 28.357999999999993,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2041.005000000041,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.453,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.3729999999999,
"heapDeltaBytes": -2211516,
"heapUsedBytes": 78573376,
"domNodes": -249,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 31.08299999999999,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2158.38100000002,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.359000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1347.6720000000003,
"heapDeltaBytes": -1570220,
"heapUsedBytes": 79761012,
"domNodes": -247,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 660.029,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2103.5229999999956,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.684999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1243.3039999999996,
"heapDeltaBytes": 17630616,
"heapUsedBytes": 82984996,
"domNodes": 6,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 619.992,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3285.329000000047,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.979,
"layouts": 60,
"layoutDurationMs": 14.413,
"taskDurationMs": 1434.2419999999997,
"heapDeltaBytes": -3997288,
"heapUsedBytes": 78126696,
"domNodes": -267,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 626.914,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3323.851999999988,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.043,
"layouts": 60,
"layoutDurationMs": 14.013000000000002,
"taskDurationMs": 1494.31,
"heapDeltaBytes": -412524,
"heapUsedBytes": 81464224,
"domNodes": -263,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 644.3709999999999,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2245.7239999999956,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.236999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1462.6190000000001,
"heapDeltaBytes": 12783232,
"heapUsedBytes": 96918160,
"domNodes": 12,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 707.097,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2311.16099999997,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.310000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1526.525,
"heapDeltaBytes": 14906820,
"heapUsedBytes": 100139808,
"domNodes": 12,
"jsHeapTotalBytes": 5435392,
"scriptDurationMs": 751.506,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2026.1970000000247,
"styleRecalcs": 9,
"styleRecalcDurationMs": 13.235999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.07899999999995,
"heapDeltaBytes": -11422044,
"heapUsedBytes": 76606996,
"domNodes": -255,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 28.790999999999997,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.8450000000748,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.144999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.48,
"heapDeltaBytes": -11249488,
"heapUsedBytes": 69526700,
"domNodes": -262,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 30.029999999999994,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 510.9790000000203,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.371999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.647,
"heapDeltaBytes": 14338536,
"heapUsedBytes": 78238592,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 102.884,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 521.5600000000222,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.512,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 317.175,
"heapDeltaBytes": 13212720,
"heapUsedBytes": 77169404,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 106.949,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.590000000007,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.639999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.643,
"heapDeltaBytes": -1378360,
"heapUsedBytes": 62632484,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.933000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.2540000000263,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.266999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.392,
"heapDeltaBytes": 6328272,
"heapUsedBytes": 70108372,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.429,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.6970000000238,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.400999999999996,
"layouts": 18,
"layoutDurationMs": 4.5009999999999994,
"taskDurationMs": 645.03,
"heapDeltaBytes": 8004960,
"heapUsedBytes": 71634252,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 82.432,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.4139999999425,
"styleRecalcs": 80,
"styleRecalcDurationMs": 20.502,
"layouts": 18,
"layoutDurationMs": 4.15,
"taskDurationMs": 638.252,
"heapDeltaBytes": 6200940,
"heapUsedBytes": 70035484,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 76.84,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 882.9429999999547,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.426000000000002,
"layouts": 5,
"layoutDurationMs": 8.941,
"taskDurationMs": 694.054,
"heapDeltaBytes": 17863696,
"heapUsedBytes": 95923176,
"domNodes": 13587,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 30.511999999999997,
"eventListeners": 2385,
"totalBlockingTimeMs": 107,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8160.9320000000025,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.121,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4558.030000000001,
"heapDeltaBytes": 9281200,
"heapUsedBytes": 88242932,
"domNodes": -257,
"jsHeapTotalBytes": 1265664,
"scriptDurationMs": 2099.004,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8148.455000000013,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.301,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4523.76,
"heapDeltaBytes": 12927536,
"heapUsedBytes": 92426376,
"domNodes": -259,
"jsHeapTotalBytes": 1003520,
"scriptDurationMs": 2085.277,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13046.52100000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12516.863999999998,
"heapDeltaBytes": -47638456,
"heapUsedBytes": 175187984,
"domNodes": -8061,
"jsHeapTotalBytes": -17850368,
"scriptDurationMs": 200.59199999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12737.55600000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12293.465,
"heapDeltaBytes": -47017028,
"heapUsedBytes": 182010364,
"domNodes": -8065,
"jsHeapTotalBytes": -9945088,
"scriptDurationMs": 210.94100000000003,
"eventListeners": -14926,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.22666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15708.712000000049,
"styleRecalcs": 82,
"styleRecalcDurationMs": 13.900999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15138.969,
"heapDeltaBytes": -38133824,
"heapUsedBytes": 190487984,
"domNodes": -8061,
"jsHeapTotalBytes": -8704000,
"scriptDurationMs": 774.2659999999998,
"eventListeners": -14922,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15593.29200000002,
"styleRecalcs": 79,
"styleRecalcDurationMs": 14.373999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15201.661000000002,
"heapDeltaBytes": -35183316,
"heapUsedBytes": 188732396,
"domNodes": -8061,
"jsHeapTotalBytes": -13496320,
"scriptDurationMs": 760.1830000000001,
"eventListeners": -14924,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4641.357999999968,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.892,
"layouts": 20,
"layoutDurationMs": 23.19299999999999,
"taskDurationMs": 4499.4800000000005,
"heapDeltaBytes": -42257180,
"heapUsedBytes": 179855672,
"domNodes": -8061,
"jsHeapTotalBytes": 14172160,
"scriptDurationMs": 85.70200000000001,
"eventListeners": -14924,
"totalBlockingTimeMs": 123,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4566.145000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.48200000000001,
"layouts": 20,
"layoutDurationMs": 23.093000000000004,
"taskDurationMs": 4445.626000000001,
"heapDeltaBytes": -45946480,
"heapUsedBytes": 169285800,
"domNodes": -8061,
"jsHeapTotalBytes": 12337152,
"scriptDurationMs": 78.167,
"eventListeners": -14926,
"totalBlockingTimeMs": 57,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6369.115000000079,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6150.122999999999,
"heapDeltaBytes": 8693380,
"heapUsedBytes": 195144648,
"domNodes": 0,
"jsHeapTotalBytes": -26476544,
"scriptDurationMs": 116.74000000000007,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6296.063000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6007.553,
"heapDeltaBytes": 7526696,
"heapUsedBytes": 195111828,
"domNodes": 0,
"jsHeapTotalBytes": -23068672,
"scriptDurationMs": 117.11099999999996,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 454.93899999996756,
"styleRecalcs": 18,
"styleRecalcDurationMs": 18.517,
"layouts": 4,
"layoutDurationMs": 1.9229999999999998,
"taskDurationMs": 111.649,
"heapDeltaBytes": 5138576,
"heapUsedBytes": 67386320,
"domNodes": 149,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.619,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 423.5309999999117,
"styleRecalcs": 14,
"styleRecalcDurationMs": 15.934999999999997,
"layouts": 4,
"layoutDurationMs": 1.89,
"taskDurationMs": 89.92100000000002,
"heapDeltaBytes": 4880348,
"heapUsedBytes": 67148112,
"domNodes": 122,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.927,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (28)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe tests replace custom ChangesCurrent-user mock migration
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change is limited to test mock standardization, with no remaining actionable merge risk identified. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #17724 +/- ##
==========================================
+ Coverage 82.63% 83.66% +1.02%
==========================================
Files 2897 2213 -684
Lines 143190 126666 -16524
Branches 36803 32209 -4594
==========================================
- Hits 118327 105971 -12356
+ Misses 23630 20411 -3219
+ Partials 1233 284 -949
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 690 files with indirect coverage changes 🚀 New features to boost your workflow:
|
da8aa4e
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
## Summary Shared `__mocks__` modules restore state `mockReset` never touches (`reactive()` objects, `ref` values, plain fields) by calling `onTestFinished` inside the mock function, and `docs/guidance/vitest.md` documents how reactive mock fields are backed and overridden. ## Changes - **What**: The `useAuthActions` and `useFeatureFlags` mocks register an `onTestFinished` restore on each call (`accessError.value = false`; `Object.assign(flags, defaultFlags())`), so any test that obtains the mock cleans up after itself. The 21 hand-written `flags.x = false` restores in `beforeEach`/`afterEach` across 19 test files are deleted; with the hook stubbed out, 15 tests in 8 of those files fail from leaked flags. No registry, no setup-file hook: each re-evaluated module instance after `vi.resetModules()` registers on its own calls, The mock object itself is one shared instance per file, so tests that configure it must stay sequential (guidance says so). `onTestFinished` throws `Hook onTestFinished() can only be called inside a test` when the mock is called at `describe` scope or in `beforeAll`; that enforces the existing rule to configure mock state in `beforeEach` or in the test. Verified: works inside `beforeEach`; no `.ts` production module calls the five FE-2343 composables at module scope, only `.vue` `<script setup>` (runs at mount). - **Guidance**: "Shared manual mocks" now says one stable object per composable mock (replacing "fresh state from each call", which contradicted the FE-2343 rules and the open PRs), shows the `onTestFinished` restore, and covers three reactive field classes matched to the real contract: writable → `reactive`/`ref` + restore; derived with a real mutator → private source ref, computeds derived from it, mutator implemented against it; derived with no mutator → `vi.spyOn(x, 'value', 'get')` in the test, restored by `restoreMocks`. ## Review Focus - Restore runs after each test (`onTestFinished` fires after `afterEach`), not before. Module-scope configuration is impossible rather than wiped, because the mock throws outside a test body. - `Object.assign(reactiveObj, defaults())` notifies consumer computeds; replacing a `ref`/`computed` field does not, and any consumer that destructured it keeps the old one. The open FE-2343 PRs (Comfy-Org#17724, Comfy-Org#17725, Comfy-Org#17726) currently replace `computed` fields with no reset and will be amended onto this. - `mockReset` in Vitest 4 keeps `vi.fn(impl)` defaults and `restoreMocks` keeps `vi.mockObject({ spy: true })` methods, so no config change. Part of FE-2343. --------- Co-authored-by: Amp <amp@ampcode.com>
## Summary Consolidate 24 `useBillingCapabilities` factories and their setup for FE-2343. None are deferred. The PR removes 175 lines overall. ## Changes - Use complete production-typed defaults, one stable result, and stable async action mocks configured inline with `vi.mocked`. - Remove 102 whole-result overrides and all 182 billing getter spies. Assign scenario computeds directly before creating consumers, following Comfy-Org#17724. - Restore result fields with `onTestFinished` inside the shared mock, following Comfy-Org#17866. Global `mockReset` restores action implementations and history. No suite repeats the 19 former reset-only assignments. ## Review Focus Field replacements happen before consumers capture refs. Live transitions change the existing backing ref after capture. Tests configuring this shared mock must remain sequential, and module-reset tests reacquire the mocked module. Production code, assertion expectations, and payloads are unchanged. Main integrations preserve the dialog-service and current-user consolidations, shared API mocks, and billing SDK-reader tests. Three SDK assertions now use the shared action instead of the removed `mockCapabilitiesRefresh` alias, fixing the earlier integration failure. The latest 27-suite run passes 1,275 tests and reproduces the known AgentPanel onboarding typing flake: expected `Explain this app`, received `Eplain this appx`. Earlier baseline runs reproduced the same character-reordering failure. The checkout suite passes all 162 tests shuffled with seed 2343. Five temporary lifetime proofs passed during cleanup, covering defaults, action identity, one-shot reset, live updates, and module reset. Disabling the shared cleanup made two isolation proofs fail. The latest assertion/payload audit, full typecheck, targeted lint and formatting, Knip, and diff-scoped Fallow pass. Fallow checks all 26 changed files with no introduced findings. Part of FE-2343. --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Consolidate 27
useCurrentUsertest factories and shared action setup for FE-2343, removing 24vi.mock<unknown>escapes and three typed factories.Changes
mockReset.onTestFinishedinside the mocked composable. Adopters assign real computed values directly; no current-user getter spies or local reset hooks are needed.computed(() => value); live scenarios close over a local ref or reactive object.vi.resetModules(). Clear setup-only calls where tests measure composable usage.Review Focus
Check field restoration at test completion, reactive account transitions, and module-reset reacquisition. Configure fields before creating a consumer that captures them. For live transitions, mutate the test-local source rather than replacing a captured ref. Shared overrides require sequential tests.
The assertion audit preserves all 1,824 direct-expect statements, normalizing mock-handle names; it excludes nested expect tokens and awaited expressions. Six focused checks cover field reset, action defaults and rejections, retained-consumer reactivity, and independent watch handles.
All 31 affected suites pass in normal order, with 955 tests. The shuffled run passes 954 tests and hits one unchanged onboarding typing failure in
AgentPanelRoot.test.ts. The same test also fails on untouched main with reordered input text. No assertion was changed to hide it.Before the final main update, the full unit run passed 21,657 tests and failed only that onboarding test, with 12 expected failures and seven skips. The affected suites were rerun after the update. Git-fixture signing was disabled only for the full-suite command; repository Git settings are unchanged.
Formatting, full lint, application/package typechecks, Knip, and diff-scoped Fallow pass. Fallow reports zero introduced findings.
The latest main merge preserves #17866's shared feature-flags cleanup and removes its conflict with the current-user settings tests. The current-user setup follows the later request for direct assignments and shared
onTestFinishedrestoration. See current-head CI for repository-wide checks.Two original factories remain local: Customer.io dispatches callbacks immediately and captures scenario callbacks; the core agent-panel extension shares one user ref between static store imports and a reset dynamic module graph. The shared mock does not provide these lifetimes.
Main also added a local factory in
storeReadinessGate.test.tsafter this batch's original base. This follow-up leaves that factory unchanged; it is separate from the two original deferrals.