Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .fallowrc.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// scripts / CI / tool CLIs / Storybook), not imported from the app graph.
"entry": [
"src/main.ts",
"src/platform/telemetry/__mocks__/index.ts",
"index.html",
"scripts/**/*.{js,ts}",
"apps/website/src/scripts/**/*.ts",
Expand Down
12 changes: 4 additions & 8 deletions src/components/TopMenuSection.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import { computed, defineComponent, h, nextTick, onMounted, ref } from 'vue'
import type { Component } from 'vue'
import { createI18n } from 'vue-i18n'

import { useTelemetry } from '@/platform/telemetry'

import QueueNotificationBannerHost from '@/components/queue/QueueNotificationBannerHost.vue'
import TopMenuSection from '@/components/TopMenuSection.vue'
import type {
Expand Down Expand Up @@ -80,13 +82,7 @@ vi.mock<unknown>(import('@/scripts/app'), () => ({
}
}))

const mockTrackUiButtonClicked = vi.hoisted(() => vi.fn())

vi.mock<unknown>(import('@/platform/telemetry'), () => ({
useTelemetry: () => ({
trackUiButtonClicked: mockTrackUiButtonClicked
})
}))
vi.mock(import('@/platform/telemetry'))

type WrapperOptions = {
pinia?: Pinia
Expand Down Expand Up @@ -284,7 +280,7 @@ describe('TopMenuSection', () => {
screen.getByRole('button', { name: 'Toggle properties panel' })
)

expect(mockTrackUiButtonClicked).toHaveBeenCalledWith({
expect(useTelemetry()?.trackUiButtonClicked).toHaveBeenCalledWith({
button_id: 'right_side_panel_opened',
element_group: 'top_menu'
})
Expand Down
12 changes: 5 additions & 7 deletions src/components/builder/builderViewOptions.test.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
import { beforeEach, describe, expect, it, vi } from 'vitest'

import { useTelemetry } from '@/platform/telemetry'

import { app } from '@/scripts/app'
import { createMockLoadedWorkflow } from '@/utils/__tests__/litegraphTestUtils'

import { setWorkflowDefaultView } from './builderViewOptions'

const mockTrackDefaultViewSet = vi.hoisted(() => vi.fn())

vi.mock(import('@/i18n'), () => ({ t: (key: string) => key }))

vi.mock<unknown>(import('@/platform/telemetry'), () => ({
useTelemetry: () => ({ trackDefaultViewSet: mockTrackDefaultViewSet })
}))
vi.mock(import('@/platform/telemetry'))

vi.mock<unknown>(import('@/scripts/app'), () => {
const rootGraph = { extra: {} }
Expand Down Expand Up @@ -53,12 +51,12 @@ describe('setWorkflowDefaultView', () => {
it('tracks telemetry with correct default_view', () => {
const workflow = createMockLoadedWorkflow()
setWorkflowDefaultView(workflow, true)
expect(mockTrackDefaultViewSet).toHaveBeenCalledWith({
expect(useTelemetry()?.trackDefaultViewSet).toHaveBeenCalledWith({
default_view: 'app'
})

setWorkflowDefaultView(workflow, false)
expect(mockTrackDefaultViewSet).toHaveBeenCalledWith({
expect(useTelemetry()?.trackDefaultViewSet).toHaveBeenCalledWith({
default_view: 'graph'
})
})
Expand Down
20 changes: 8 additions & 12 deletions src/components/builder/useBuilderSave.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import { fromPartial } from '@total-typescript/shoehorn'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { ref } from 'vue'

import { useTelemetry } from '@/platform/telemetry'

import { useWorkflowStore } from '@/platform/workflow/management/stores/workflowStore'
import { useAppModeStore } from '@/stores/appModeStore'
import { useDialogStore } from '@/stores/dialogStore'
Expand All @@ -15,8 +17,7 @@ beforeEach(() => {

const mockSetMode = vi.hoisted(() => vi.fn())
const mockToastErrorHandler = vi.hoisted(() => vi.fn())
const mockTrackEnterLinear = vi.hoisted(() => vi.fn())
const mockTrackDefaultViewSet = vi.hoisted(() => vi.fn())

const mockSaveWorkflow = vi.hoisted(() => vi.fn<() => Promise<void>>())
const mockSaveWorkflowAs = vi.hoisted(() =>
vi.fn<() => Promise<boolean | null>>()
Expand All @@ -38,12 +39,7 @@ vi.mock<unknown>(import('@/composables/useErrorHandling'), () => ({
useErrorHandling: () => ({ toastErrorHandler: mockToastErrorHandler })
}))

vi.mock<unknown>(import('@/platform/telemetry'), () => ({
useTelemetry: () => ({
trackEnterLinear: mockTrackEnterLinear,
trackDefaultViewSet: mockTrackDefaultViewSet
})
}))
vi.mock(import('@/platform/telemetry'))

vi.mock<unknown>(
import('@/platform/workflow/core/services/workflowService'),
Expand Down Expand Up @@ -214,7 +210,7 @@ describe('useBuilderSave', () => {
isApp: true
}
)
expect(mockTrackDefaultViewSet).toHaveBeenCalledWith({
expect(useTelemetry()?.trackDefaultViewSet).toHaveBeenCalledWith({
default_view: 'app'
})
})
Expand All @@ -232,7 +228,7 @@ describe('useBuilderSave', () => {
isApp: false
}
)
expect(mockTrackDefaultViewSet).toHaveBeenCalledWith({
expect(useTelemetry()?.trackDefaultViewSet).toHaveBeenCalledWith({
default_view: 'graph'
})
})
Expand All @@ -243,7 +239,7 @@ describe('useBuilderSave', () => {

await onSave('new-name', false)

expect(mockTrackDefaultViewSet).not.toHaveBeenCalled()
expect(useTelemetry()?.trackDefaultViewSet).not.toHaveBeenCalled()
expect(useDialogStore().closeDialog).not.toHaveBeenCalled()
})

Expand Down Expand Up @@ -355,7 +351,7 @@ describe('useBuilderSave', () => {
expect(useDialogStore().closeDialog).toHaveBeenCalledWith({
key: SUCCESS_DIALOG_KEY
})
expect(mockTrackEnterLinear).toHaveBeenCalledWith({
expect(useTelemetry()?.trackEnterLinear).toHaveBeenCalledWith({
source: 'app_builder'
})
expect(mockSetMode).toHaveBeenCalledWith('app')
Expand Down
13 changes: 6 additions & 7 deletions src/components/common/WorkflowActionsDropdown.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { beforeEach, describe, expect, it, vi } from 'vitest'
import { nextTick } from 'vue'
import { createI18n } from 'vue-i18n'

import { useTelemetry } from '@/platform/telemetry'

import { KeybindingImpl } from '@/platform/keybindings/keybinding'
import { useKeybindingStore } from '@/platform/keybindings/keybindingStore'
import { useAppModeStore } from '@/stores/appModeStore'
Expand All @@ -22,13 +24,10 @@ beforeEach(() => {
})

const spies = vi.hoisted(() => ({
trackUiButtonClicked: vi.fn(),
markAsSeen: vi.fn()
}))

vi.mock<unknown>(import('@/platform/telemetry'), () => ({
useTelemetry: () => ({ trackUiButtonClicked: spies.trackUiButtonClicked })
}))
vi.mock(import('@/platform/telemetry'))

vi.mock<unknown>(import('@/composables/useWorkflowActionsMenu'), async () => {
const { ref } = await import('vue')
Expand Down Expand Up @@ -159,7 +158,7 @@ describe('WorkflowActionsDropdown', () => {
expect(
screen.getByRole('button', { name: /workflow actions/ })
).toHaveAttribute('aria-expanded', 'false')
expect(spies.trackUiButtonClicked).not.toHaveBeenCalled()
expect(useTelemetry()?.trackUiButtonClicked).not.toHaveBeenCalled()
expect(spies.markAsSeen).not.toHaveBeenCalled()
})

Expand All @@ -172,7 +171,7 @@ describe('WorkflowActionsDropdown', () => {
expect(vi.mocked(useCommandStore().execute)).not.toHaveBeenCalled()
expect(active).toHaveAttribute('aria-expanded', 'true')
expect(spies.markAsSeen).toHaveBeenCalled()
expect(spies.trackUiButtonClicked).toHaveBeenCalledWith({
expect(useTelemetry()?.trackUiButtonClicked).toHaveBeenCalledWith({
button_id: 'test',
element_group: 'workflow_actions'
})
Expand Down Expand Up @@ -205,7 +204,7 @@ describe('WorkflowActionsDropdown', () => {
expect(
screen.getByRole('button', { name: /workflow actions/ })
).toHaveAttribute('aria-expanded', 'false')
expect(spies.trackUiButtonClicked).not.toHaveBeenCalled()
expect(useTelemetry()?.trackUiButtonClicked).not.toHaveBeenCalled()
})

it('lets non-trigger keys bubble past the inactive segment', async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import { render, screen } from '@testing-library/vue'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { createI18n } from 'vue-i18n'

import { useTelemetry } from '@/platform/telemetry'

import { AuthStoreError } from '@/stores/authStore'
import { useDialogStore } from '@/stores/dialogStore'

Expand All @@ -11,8 +13,7 @@ import TopUpCreditsDialogContentLegacy from './TopUpCreditsDialogContentLegacy.v
const mockPurchaseCreditsDirect = vi.fn()
const mockShowSettings = vi.fn()
const mockToastAdd = vi.fn()
const mockTrackTopUpPurchase = vi.fn()
const mockTrackBillingEvent = vi.fn()

const mockIsSubscriptionEnabled = vi.fn(() => true)
const mockShouldUseWorkspaceBilling = vi.hoisted(() => ({ value: false }))

Expand Down Expand Up @@ -48,12 +49,7 @@ vi.mock<unknown>(
})
)

vi.mock<unknown>(import('@/platform/telemetry'), () => ({
useTelemetry: () => ({
trackApiCreditTopupButtonPurchaseClicked: mockTrackTopUpPurchase,
trackBillingEvent: mockTrackBillingEvent
})
}))
vi.mock(import('@/platform/telemetry'))

const mockClearPendingTopup = vi.hoisted(() => vi.fn())
vi.mock<unknown>(import('@/composables/billing/usePendingTopup'), () => ({
Expand Down Expand Up @@ -185,7 +181,7 @@ describe('TopUpCreditsDialogContentLegacy', () => {
renderDialog()
await clickBuyCredits()

expect(mockTrackBillingEvent).toHaveBeenCalledWith({
expect(useTelemetry()?.trackBillingEvent).toHaveBeenCalledWith({
operation: 'topup',
stage: 'failed',
outcome: 'failure',
Expand All @@ -210,7 +206,7 @@ describe('TopUpCreditsDialogContentLegacy', () => {
renderDialog()
await clickBuyCredits()

expect(mockTrackBillingEvent).toHaveBeenCalledWith({
expect(useTelemetry()?.trackBillingEvent).toHaveBeenCalledWith({
operation: 'topup',
stage: 'failed',
outcome: 'failure',
Expand All @@ -225,7 +221,7 @@ describe('TopUpCreditsDialogContentLegacy', () => {
renderDialog()
await clickBuyCredits()

expect(mockTrackBillingEvent).toHaveBeenCalledWith({
expect(useTelemetry()?.trackBillingEvent).toHaveBeenCalledWith({
operation: 'topup',
stage: 'failed',
outcome: 'failure',
Expand All @@ -239,7 +235,7 @@ describe('TopUpCreditsDialogContentLegacy', () => {
renderDialog()
await clickBuyCredits()

expect(mockTrackBillingEvent).toHaveBeenCalledWith({
expect(useTelemetry()?.trackBillingEvent).toHaveBeenCalledWith({
operation: 'topup',
stage: 'failed',
outcome: 'failure',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ vi.mock(
})
)

vi.mock<unknown>(import('@/platform/telemetry'), () => ({
useTelemetry: () => ({ trackHelpResourceClicked: vi.fn() })
}))
vi.mock(import('@/platform/telemetry'))

vi.mock<unknown>(import('@/composables/useExternalLink'), () => ({
useExternalLink: () => ({
Expand Down
Loading
Loading