Repository navigation
fix(agent): encode route path identifiers - #17635
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1995 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 10 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 26.2 kB (baseline 26.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 123 kB (baseline 123 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.71 MB (baseline 3.71 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.5 MB (baseline 17.5 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-14T08:00:02.684Z",
"gitSha": "31e04ea3b041e1a6d386bad8c5be9353ab3c852d",
"branch": "christian-byrne/phs-50-encode-agent-route-ids",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2004.0779999999927,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.367999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.789,
"heapDeltaBytes": 6241672,
"heapUsedBytes": 68692240,
"domNodes": -263,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.579,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 1998.7810000000081,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.373000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.10900000000004,
"heapDeltaBytes": -4101556,
"heapUsedBytes": 56988988,
"domNodes": -264,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.671999999999999,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2023.3089999999834,
"styleRecalcs": 79,
"styleRecalcDurationMs": 33.82,
"layouts": 14,
"layoutDurationMs": 5.386,
"taskDurationMs": 1012.864,
"heapDeltaBytes": 12370648,
"heapUsedBytes": 73133092,
"domNodes": -264,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 178.717,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1920.4340000000002,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.078000000000003,
"layouts": 14,
"layoutDurationMs": 5.245,
"taskDurationMs": 891.554,
"heapDeltaBytes": 340236,
"heapUsedBytes": 62572308,
"domNodes": -264,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 160.96099999999998,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.7509999999834,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.527000000000001,
"layouts": 6,
"layoutDurationMs": 1.287,
"taskDurationMs": 338.759,
"heapDeltaBytes": 2086040,
"heapUsedBytes": 64450172,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.690000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.328999999988,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.057000000000002,
"layouts": 6,
"layoutDurationMs": 1.2400000000000002,
"taskDurationMs": 356.591,
"heapDeltaBytes": 2051212,
"heapUsedBytes": 64456784,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.934999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 622.1559999999613,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.746000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.535,
"heapDeltaBytes": 17984060,
"heapUsedBytes": 79820320,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 160.331,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 659.7399999999993,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.659000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.38200000000006,
"heapDeltaBytes": 18132900,
"heapUsedBytes": 79137660,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 158.989,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2005.0339999999665,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.3950000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.38,
"heapDeltaBytes": 20067128,
"heapUsedBytes": 83945436,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.480999999999995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.868000000056,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.415000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 618.9370000000001,
"heapDeltaBytes": 315464,
"heapUsedBytes": 80307592,
"domNodes": -248,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 40.001999999999995,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2254.9589999999853,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.931,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1607.736,
"heapDeltaBytes": -758944,
"heapUsedBytes": 79539964,
"domNodes": -249,
"jsHeapTotalBytes": 1527808,
"scriptDurationMs": 826.2890000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2296.5960000000223,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.873000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1676.7990000000002,
"heapDeltaBytes": 15281036,
"heapUsedBytes": 79094944,
"domNodes": -247,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 839.4159999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3537.69699999998,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.675,
"layouts": 60,
"layoutDurationMs": 14.693999999999999,
"taskDurationMs": 1671.49,
"heapDeltaBytes": 7255104,
"heapUsedBytes": 73823920,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 783.002,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3572.265000000016,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.565,
"layouts": 60,
"layoutDurationMs": 15.211999999999998,
"taskDurationMs": 1706.2829999999997,
"heapDeltaBytes": 7960920,
"heapUsedBytes": 74072288,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 787.4770000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3059.8919999999907,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.438999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1906.3839999999998,
"heapDeltaBytes": 19261436,
"heapUsedBytes": 85098424,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 973.157,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3112.113000000022,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.949,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1978.425,
"heapDeltaBytes": 20496744,
"heapUsedBytes": 86549560,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 992.1569999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2018.7990000000013,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.35,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.851,
"heapDeltaBytes": -4246060,
"heapUsedBytes": 83388412,
"domNodes": -251,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 35.912,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2039.1910000000735,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.0249999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.342,
"heapDeltaBytes": -3660036,
"heapUsedBytes": 83637960,
"domNodes": -249,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 42.666999999999994,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 527.7719999999704,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.378999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.80899999999997,
"heapDeltaBytes": 13801768,
"heapUsedBytes": 76982112,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 145.464,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.0790000000598,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.293999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.429,
"heapDeltaBytes": 13842176,
"heapUsedBytes": 76980440,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.83599999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.5480000000052,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.660000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.46400000000006,
"heapDeltaBytes": 7912576,
"heapUsedBytes": 70534568,
"domNodes": -275,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.851,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2001.621,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.442000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.2369999999999,
"heapDeltaBytes": 4045864,
"heapUsedBytes": 67564804,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.819,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.3419999999874,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.421,
"layouts": 18,
"layoutDurationMs": 5.398,
"taskDurationMs": 774.826,
"heapDeltaBytes": 880236,
"heapUsedBytes": 64270528,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 102.871,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.4839999999613,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.05799999999999,
"layouts": 18,
"layoutDurationMs": 6.635999999999999,
"taskDurationMs": 823.905,
"heapDeltaBytes": 16747664,
"heapUsedBytes": 79993564,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 113.348,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.7630000000208,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.833000000000002,
"layouts": 5,
"layoutDurationMs": 11.684,
"taskDurationMs": 913.0990000000002,
"heapDeltaBytes": -2932736,
"heapUsedBytes": 93920144,
"domNodes": 13587,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 32.004,
"eventListeners": 2387,
"totalBlockingTimeMs": 122,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8208.249999999964,
"styleRecalcs": 248,
"styleRecalcDurationMs": 40.126000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5584.839,
"heapDeltaBytes": -12643132,
"heapUsedBytes": 66770652,
"domNodes": -246,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 2641.178,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8484.34599999996,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.852000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5962.158,
"heapDeltaBytes": -3846688,
"heapUsedBytes": 74981248,
"domNodes": -250,
"jsHeapTotalBytes": 1527808,
"scriptDurationMs": 2759.474,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17959.325999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17536.415999999997,
"heapDeltaBytes": -23162152,
"heapUsedBytes": 190669860,
"domNodes": -6542,
"jsHeapTotalBytes": 6250496,
"scriptDurationMs": 291.96,
"eventListeners": -7476,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17851.27399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17637.231,
"heapDeltaBytes": -10730468,
"heapUsedBytes": 183903768,
"domNodes": -6546,
"jsHeapTotalBytes": 6234112,
"scriptDurationMs": 304.97,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22446.35099999999,
"styleRecalcs": 168,
"styleRecalcDurationMs": 21.953,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22253.130999999998,
"heapDeltaBytes": -34673728,
"heapUsedBytes": 186754232,
"domNodes": -6542,
"jsHeapTotalBytes": -5251072,
"scriptDurationMs": 920.0740000000001,
"eventListeners": -7474,
"totalBlockingTimeMs": 85,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22577.60900000005,
"styleRecalcs": 164,
"styleRecalcDurationMs": 24.899000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22463.088,
"heapDeltaBytes": -19667028,
"heapUsedBytes": 174756320,
"domNodes": -6542,
"jsHeapTotalBytes": 466944,
"scriptDurationMs": 930.5160000000001,
"eventListeners": -7472,
"totalBlockingTimeMs": 56,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6463.984000000039,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.382,
"layouts": 20,
"layoutDurationMs": 26.465000000000003,
"taskDurationMs": 6420.280000000001,
"heapDeltaBytes": -18396376,
"heapUsedBytes": 186371344,
"domNodes": -6542,
"jsHeapTotalBytes": 9338880,
"scriptDurationMs": 138.22600000000003,
"eventListeners": -7474,
"totalBlockingTimeMs": 473,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6608.673999999951,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.877,
"layouts": 20,
"layoutDurationMs": 26.665999999999997,
"taskDurationMs": 6589.41,
"heapDeltaBytes": -145272,
"heapUsedBytes": 195462220,
"domNodes": -6542,
"jsHeapTotalBytes": 21700608,
"scriptDurationMs": 128.01299999999998,
"eventListeners": -7474,
"totalBlockingTimeMs": 558,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8935.520999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8723.506,
"heapDeltaBytes": 11596248,
"heapUsedBytes": 181107360,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 145.19199999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9178.100000000086,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9116.092,
"heapDeltaBytes": -432324,
"heapUsedBytes": 190837320,
"domNodes": 0,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 155.60199999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 123.82900000000063,
"styleRecalcs": 9,
"styleRecalcDurationMs": 20.453,
"layouts": 4,
"layoutDurationMs": 2.1470000000000002,
"taskDurationMs": 90.531,
"heapDeltaBytes": 3205336,
"heapUsedBytes": 64866884,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.839999999999998,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 482.74800000001505,
"styleRecalcs": 16,
"styleRecalcDurationMs": 26.752,
"layouts": 5,
"layoutDurationMs": 2.221,
"taskDurationMs": 135.463,
"heapDeltaBytes": 5002864,
"heapUsedBytes": 67048556,
"domNodes": 144,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.245,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
christian-byrne
left a comment
There was a problem hiding this comment.
Self-review at exact head 04bc208: no findings. All dynamic thread/message path segments are encoded exactly once; the literal new route remains unchanged; hostile slash IDs distinguish correct one-segment routing from the prior implementation. Focused Vitest: 30/30. ESLint, oxfmt, and diff checks: clean.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughAgent REST client routes now URI-encode thread, message, and ask identifiers. Tests verify encoding for message posting, retrieval, cancellation, and ask-answer requests using reserved characters. ChangesAgent route encoding
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The narrowly scoped route-encoding change presents no identified correctness, security, or availability risk blocking merge. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file metadata is available and lists two Resolution Provide the PR title and commit subjects. If either contains bug-fix language, add or update a Playwright regression test under ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17635 +/- ##
==========================================
+ Coverage 82.79% 83.68% +0.89%
==========================================
Files 2756 2127 -629
Lines 138975 123759 -15216
Branches 37562 31429 -6133
==========================================
- Hits 115067 103571 -11496
+ Misses 22815 20006 -2809
+ Partials 1093 182 -911
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 640 files with indirect coverage changes 🚀 New features to boost your workflow:
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Clean: every id the client puts in a route is encoded, pinned with slash ids.
Percent-encode agent thread and message identifiers before interpolating them into REST paths. - **What**: Encodes `threadId` for message, cancellation, and ask routes, plus `messageId` for cancellation; adds hostile-ID route coverage. Confirm server-minted IDs containing reserved characters remain one path segment. This lifts the separable fix from closed #16393 and is distinct from the cloud-side provider ask-ID decoding tracked in christian-byrne/in-app-agent-program row `ecw-139`.
Percent-encode agent thread and message identifiers before interpolating them into REST paths. - **What**: Encodes `threadId` for message, cancellation, and ask routes, plus `messageId` for cancellation; adds hostile-ID route coverage. Confirm server-minted IDs containing reserved characters remain one path segment. This lifts the separable fix from closed #16393 and is distinct from the cloud-side provider ask-ID decoding tracked in christian-byrne/in-app-agent-program row `ecw-139`.
Summary
Percent-encode agent thread and message identifiers before interpolating them into REST paths.
Changes
threadIdfor message, cancellation, and ask routes, plusmessageIdfor cancellation; adds hostile-ID route coverage.Review Focus
Confirm server-minted IDs containing reserved characters remain one path segment. This lifts the separable fix from closed #16393 and is distinct from the cloud-side provider ask-ID decoding tracked in christian-byrne/in-app-agent-program row
ecw-139.