Repository navigation
Austin/backport assets core 1 53 - #17610
Conversation
Migrate the assets sidebar to be backed by the `/assets` endpoint when feasible. This applies to both cloud, and core with the `--enable-assets` launch argument. --------- Co-authored-by: Amp <amp@ampcode.com>
A couple of small high priority follow-ups to #15381 - Conditionally update type when `temp` is included as a tag on an asset. - Removed spreads which break getters - Fix several instances of where migrating `PagedList` was broken by calls dropped the `this` binding --------- Co-authored-by: Amp <amp@ampcode.com>
VirtualGrid hand rolled infinite scroll. The implementation had some problematic bugs. - If the initial fetch does not fill the screen, `approach-end` would never trigger - An empty initial list would never fill - Only a single `approach-end` would trigger, if this does not increase scroll distance (client side search filtering on Load Image nodes), no further loading would be performed. Initial PR consists of 3 commits that can be individually split out if needed to reduce scope. - Migrate VirtualGrid to `useInfiniteScroll` - Migrate useRegistrySearch to `PagedList` - This dialog did client side sorting over paged queries which is not good. I've removed sorting support ~~and added a failing test~~ - Move sorting out of the search gateways. Neither of them actually supported sorting. Sorting was specifically tied and duplicated in the places it couldn't be used. - ~~Migrates VirtualGrid to use `PagedList`~~ - Pulled this part out. Change was made slightly too early and was making things less clean --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
The local backend implementation has been updated such that performing a delete operation is allowed but will leave the file on disk. Accordingly, the frontend will no longer skip the actual deletion request when `!flags.assetDeletionEnabled`. Instead a modified confirmation is displayed that states the files will remain on disk.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1893 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-13T20:29:15.608Z",
"gitSha": "9b2348eeac2c78929c804790768f88f69cc67563",
"branch": "austin/backport-assets-core-1-53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2072.301999999979,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.176,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.906,
"heapDeltaBytes": -14026608,
"heapUsedBytes": 55626324,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 13.041999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2051.8069999999398,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.116,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 595.4689999999999,
"heapDeltaBytes": -10751624,
"heapUsedBytes": 58896524,
"domNodes": -282,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.755000000000003,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2066.1289999999894,
"styleRecalcs": 83,
"styleRecalcDurationMs": 49.78399999999999,
"layouts": 14,
"layoutDurationMs": 5.5729999999999995,
"taskDurationMs": 1101.598,
"heapDeltaBytes": -6197696,
"heapUsedBytes": 64153468,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 185.11299999999997,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.3110000000106,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.875,
"layouts": 14,
"layoutDurationMs": 4.63,
"taskDurationMs": 921.375,
"heapDeltaBytes": -7856016,
"heapUsedBytes": 62536056,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 165.997,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.424000000009,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.92,
"layouts": 6,
"layoutDurationMs": 1.2699999999999998,
"taskDurationMs": 401.47299999999996,
"heapDeltaBytes": 4428460,
"heapUsedBytes": 74911224,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 14.185,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1680.5630000000065,
"styleRecalcs": 29,
"styleRecalcDurationMs": 18.316,
"layouts": 6,
"layoutDurationMs": 1.2260000000000002,
"taskDurationMs": 421.03499999999997,
"heapDeltaBytes": 4467672,
"heapUsedBytes": 74932368,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 15.284000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 708.6689999999862,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.514999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.66799999999995,
"heapDeltaBytes": 17857120,
"heapUsedBytes": 88055508,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 165.423,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 693.4009999999944,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.336,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.09899999999993,
"heapDeltaBytes": 18856744,
"heapUsedBytes": 88695240,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 167.759,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.3700000000385,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 753.732,
"heapDeltaBytes": 10469556,
"heapUsedBytes": 86438360,
"domNodes": -270,
"jsHeapTotalBytes": -1916928,
"scriptDurationMs": 43.49700000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2029.2770000000928,
"styleRecalcs": 4,
"styleRecalcDurationMs": 5.100999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.875,
"heapDeltaBytes": 22255696,
"heapUsedBytes": 87301284,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.021,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2681.142999999963,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.588999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1756.254,
"heapDeltaBytes": 25967892,
"heapUsedBytes": 91695036,
"domNodes": -276,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 852.5440000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2407.2170000000597,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.434000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1706.137,
"heapDeltaBytes": 18189348,
"heapUsedBytes": 84145392,
"domNodes": -275,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 834.442,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3665.9369999999853,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.414,
"layouts": 60,
"layoutDurationMs": 12.722000000000001,
"taskDurationMs": 1795.481,
"heapDeltaBytes": 11818456,
"heapUsedBytes": 79722236,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 817.511,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3845.3909999999496,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.842999999999998,
"layouts": 60,
"layoutDurationMs": 13.237,
"taskDurationMs": 1890.9350000000002,
"heapDeltaBytes": 9621276,
"heapUsedBytes": 76011692,
"domNodes": -282,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 842.0210000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3182.933999999989,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.169999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2044.861,
"heapDeltaBytes": 26032780,
"heapUsedBytes": 93046300,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1001.857,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3204.26400000008,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.2339999999999955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2093.3109999999997,
"heapDeltaBytes": 575756,
"heapUsedBytes": 67865800,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1037.2219999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2040.0840000000358,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.407999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 720.5249999999999,
"heapDeltaBytes": 11194400,
"heapUsedBytes": 87154360,
"domNodes": -272,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 38.217,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2009.7150000000283,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.0440000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 695.2249999999999,
"heapDeltaBytes": 21797072,
"heapUsedBytes": 87705740,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.714,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.1209999999924,
"styleRecalcs": 44,
"styleRecalcDurationMs": 9.306999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.362,
"heapDeltaBytes": 14995332,
"heapUsedBytes": 87313452,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.46200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 640.933999999902,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.706000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.937,
"heapDeltaBytes": 15014652,
"heapUsedBytes": 87982536,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.598,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.9730000000072,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.11,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.249,
"heapDeltaBytes": -8286740,
"heapUsedBytes": 64366544,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 10.609999999999998,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.9880000000549,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.121999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.422,
"heapDeltaBytes": 3144140,
"heapUsedBytes": 75670200,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.214,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.4430000000139,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.056999999999995,
"layouts": 18,
"layoutDurationMs": 5.889,
"taskDurationMs": 904.2589999999999,
"heapDeltaBytes": 2361124,
"heapUsedBytes": 75158920,
"domNodes": -300,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 122.84999999999998,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1774.4050000000016,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.104,
"layouts": 18,
"layoutDurationMs": 6.278,
"taskDurationMs": 938.3770000000001,
"heapDeltaBytes": -12654644,
"heapUsedBytes": 60256416,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 123.419,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.7629999999226,
"styleRecalcs": 18,
"styleRecalcDurationMs": 34.665,
"layouts": 14,
"layoutDurationMs": 16.887,
"taskDurationMs": 992.639,
"heapDeltaBytes": 21100648,
"heapUsedBytes": 108633540,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 33.157,
"eventListeners": 2381,
"totalBlockingTimeMs": 150,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9379.076999999996,
"styleRecalcs": 246,
"styleRecalcDurationMs": 39.461999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6214.695,
"heapDeltaBytes": -16261972,
"heapUsedBytes": 84913208,
"domNodes": -272,
"jsHeapTotalBytes": -1425408,
"scriptDurationMs": 2822.889,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9694.109000000026,
"styleRecalcs": 246,
"styleRecalcDurationMs": 37.661,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6418.009000000001,
"heapDeltaBytes": -12038640,
"heapUsedBytes": 89051964,
"domNodes": -270,
"jsHeapTotalBytes": -1425408,
"scriptDurationMs": 2913.4550000000004,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17912.21200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17231.226999999995,
"heapDeltaBytes": -39343224,
"heapUsedBytes": 174237644,
"domNodes": -6548,
"jsHeapTotalBytes": -9625600,
"scriptDurationMs": 348.855,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18111.647999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17429.355,
"heapDeltaBytes": -41612072,
"heapUsedBytes": 175737016,
"domNodes": -6548,
"jsHeapTotalBytes": -2105344,
"scriptDurationMs": 316.34999999999997,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21982.236,
"styleRecalcs": 170,
"styleRecalcDurationMs": 22.428000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21732.578,
"heapDeltaBytes": -17784828,
"heapUsedBytes": 180785696,
"domNodes": -6548,
"jsHeapTotalBytes": 2801664,
"scriptDurationMs": 968.6839999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 108,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21794.277999999962,
"styleRecalcs": 175,
"styleRecalcDurationMs": 22.616000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21483.864,
"heapDeltaBytes": -39662668,
"heapUsedBytes": 162818504,
"domNodes": -6548,
"jsHeapTotalBytes": 2617344,
"scriptDurationMs": 972.8720000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 64,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6327.266000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.84199999999997,
"layouts": 20,
"layoutDurationMs": 24.256999999999987,
"taskDurationMs": 6212.8679999999995,
"heapDeltaBytes": -28498772,
"heapUsedBytes": 181313872,
"domNodes": -6548,
"jsHeapTotalBytes": 12144640,
"scriptDurationMs": 121.017,
"eventListeners": -7471,
"totalBlockingTimeMs": 385,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6574.143000000049,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.065,
"layouts": 20,
"layoutDurationMs": 39.702,
"taskDurationMs": 6491.435,
"heapDeltaBytes": -34672224,
"heapUsedBytes": 175036528,
"domNodes": -6548,
"jsHeapTotalBytes": 5402624,
"scriptDurationMs": 168.141,
"eventListeners": -7469,
"totalBlockingTimeMs": 615,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 472.93200000001434,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.004000000000005,
"layouts": 3,
"layoutDurationMs": 1.43,
"taskDurationMs": 117.846,
"heapDeltaBytes": 5195052,
"heapUsedBytes": 73508812,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.350000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 111.14100000008875,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.797999999999998,
"layouts": 2,
"layoutDurationMs": 0.5889999999999999,
"taskDurationMs": 82.16399999999999,
"heapDeltaBytes": 3160124,
"heapUsedBytes": 71053984,
"domNodes": 110,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.131,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
A bundled backport of PRs for the assets backed assets panel and fixes associated fixes: #15381 #16622 #16719 #17165