Repository navigation
fix(website): preserve model inputs and provide runnable SDK examples - #17606
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1997 passed, 0 failed · 1 flaky📊 Browser Reports
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-17606.vercel.app Includes the unreleased Workshop feature ( This commit: https://website-frontend-qgw0sxgix-comfyui.vercel.app Last updated: 2026-09-13T19:03:31Z for 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-13T18:28:10.712Z",
"gitSha": "22efff73d89f670f85536171f03bc49e36d575d6",
"branch": "ben/workshop-sdk-examples",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.8019999999983,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.939000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.30699999999996,
"heapDeltaBytes": 7201192,
"heapUsedBytes": 69185484,
"domNodes": -265,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.051000000000002,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2004.5529999999872,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.796999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.681,
"heapDeltaBytes": 8180248,
"heapUsedBytes": 70284108,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.810999999999998,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.4330000000168,
"styleRecalcs": 73,
"styleRecalcDurationMs": 26.295000000000005,
"layouts": 14,
"layoutDurationMs": 4.7410000000000005,
"taskDurationMs": 745.1779999999999,
"heapDeltaBytes": 1008476,
"heapUsedBytes": 63131036,
"domNodes": -262,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 163.817,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.9769999999803,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.633999999999997,
"layouts": 14,
"layoutDurationMs": 4.454,
"taskDurationMs": 821.92,
"heapDeltaBytes": 18220644,
"heapUsedBytes": 80334384,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 159.54399999999998,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.7250000000254,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.188000000000002,
"layouts": 6,
"layoutDurationMs": 1.1969999999999998,
"taskDurationMs": 335.878,
"heapDeltaBytes": 2121212,
"heapUsedBytes": 64469124,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.465000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.8960000000152,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.602000000000002,
"layouts": 6,
"layoutDurationMs": 1.284,
"taskDurationMs": 328.44800000000004,
"heapDeltaBytes": 2163264,
"heapUsedBytes": 64509152,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.469,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 616.0639999999944,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.877999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.79900000000004,
"heapDeltaBytes": 17533776,
"heapUsedBytes": 79903464,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 166.088,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 625.5220000000463,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.399000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.92800000000005,
"heapDeltaBytes": 17880356,
"heapUsedBytes": 80172420,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 160.794,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2051.6210000000115,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.096000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.5300000000001,
"heapDeltaBytes": 1146284,
"heapUsedBytes": 80750348,
"domNodes": -253,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 34.524000000000015,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2033.8479999999208,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.276999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.1059999999999,
"heapDeltaBytes": 3185552,
"heapUsedBytes": 83087848,
"domNodes": -249,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 30.846,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2324.2870000000266,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.485999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1700.3290000000002,
"heapDeltaBytes": -6056216,
"heapUsedBytes": 74670880,
"domNodes": -228,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 878.723,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2246.70500000002,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.905999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1631.863,
"heapDeltaBytes": 19256772,
"heapUsedBytes": 83469032,
"domNodes": -253,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 846.038,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3543.063000000018,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.489999999999998,
"layouts": 60,
"layoutDurationMs": 12.812000000000001,
"taskDurationMs": 1687.639,
"heapDeltaBytes": 8469276,
"heapUsedBytes": 74239156,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 804.1819999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3534.6739999999954,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.315,
"layouts": 60,
"layoutDurationMs": 12.692000000000002,
"taskDurationMs": 1729.097,
"heapDeltaBytes": -7690744,
"heapUsedBytes": 73987844,
"domNodes": -260,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 793.3009999999999,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3101.6109999999912,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.771000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1918.5020000000002,
"heapDeltaBytes": 20177152,
"heapUsedBytes": 86660784,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 988.8349999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3101.1179999999285,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.778000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1921.9360000000001,
"heapDeltaBytes": 23911412,
"heapUsedBytes": 88731136,
"domNodes": -259,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 989.7770000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2022.232000000031,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.632000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.58,
"heapDeltaBytes": -3847736,
"heapUsedBytes": 83622616,
"domNodes": -247,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 35.639,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.9469999999792,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.129999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.28,
"heapDeltaBytes": -7779616,
"heapUsedBytes": 79572604,
"domNodes": -257,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 33.276,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.6429999999955,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.081,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.046,
"heapDeltaBytes": 14162408,
"heapUsedBytes": 77391388,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.83200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.747000000003,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.224,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.8539999999999,
"heapDeltaBytes": 13994772,
"heapUsedBytes": 77331688,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 150.66400000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2003.8710000000037,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.212,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.19200000000006,
"heapDeltaBytes": 16188016,
"heapUsedBytes": 79478064,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.358,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.9690000000405,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.210000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.08000000000004,
"heapDeltaBytes": -3568704,
"heapUsedBytes": 59812280,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.85,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.0939999999932,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.460000000000004,
"layouts": 18,
"layoutDurationMs": 5.037,
"taskDurationMs": 781.308,
"heapDeltaBytes": -565540,
"heapUsedBytes": 62920796,
"domNodes": -273,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 106.157,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1699.9379999999746,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.779,
"layouts": 18,
"layoutDurationMs": 5.303000000000001,
"taskDurationMs": 773.0749999999999,
"heapDeltaBytes": 15557408,
"heapUsedBytes": 78761196,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 109.069,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.8549999999786,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.693999999999996,
"layouts": 5,
"layoutDurationMs": 12.875999999999998,
"taskDurationMs": 884.3799999999998,
"heapDeltaBytes": 19255460,
"heapUsedBytes": 101405116,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.898999999999994,
"eventListeners": 2387,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8361.97100000004,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.072,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5830.558,
"heapDeltaBytes": -3644324,
"heapUsedBytes": 75572352,
"domNodes": -247,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 2839.9480000000003,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999975,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8508.019999999988,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.263000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6020.646,
"heapDeltaBytes": -10110212,
"heapUsedBytes": 69882232,
"domNodes": -248,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 2936.722,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16810.643999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16279.957,
"heapDeltaBytes": -22004616,
"heapUsedBytes": 179059904,
"domNodes": -6546,
"jsHeapTotalBytes": -581632,
"scriptDurationMs": 288.35,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16794.573000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16291.312999999998,
"heapDeltaBytes": -30232300,
"heapUsedBytes": 187930352,
"domNodes": -6542,
"jsHeapTotalBytes": -1671168,
"scriptDurationMs": 261.347,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20610.222000000023,
"styleRecalcs": 166,
"styleRecalcDurationMs": 17.554999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20307.524999999998,
"heapDeltaBytes": -40251340,
"heapUsedBytes": 176552508,
"domNodes": -6542,
"jsHeapTotalBytes": 151552,
"scriptDurationMs": 864.698,
"eventListeners": -7474,
"totalBlockingTimeMs": 61,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20735.311000000023,
"styleRecalcs": 167,
"styleRecalcDurationMs": 17.116999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20408.982,
"heapDeltaBytes": -19313076,
"heapUsedBytes": 176649892,
"domNodes": -6543,
"jsHeapTotalBytes": -634880,
"scriptDurationMs": 874.654,
"eventListeners": -7474,
"totalBlockingTimeMs": 25,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6098.253,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.86600000000003,
"layouts": 20,
"layoutDurationMs": 23.64100000000001,
"taskDurationMs": 5992.063,
"heapDeltaBytes": -24573792,
"heapUsedBytes": 176846528,
"domNodes": -6542,
"jsHeapTotalBytes": 15409152,
"scriptDurationMs": 110.09500000000001,
"eventListeners": -7476,
"totalBlockingTimeMs": 403,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6163.273000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.27399999999999,
"layouts": 20,
"layoutDurationMs": 22.35100000000001,
"taskDurationMs": 6091.420999999999,
"heapDeltaBytes": -39231340,
"heapUsedBytes": 179721772,
"domNodes": -6542,
"jsHeapTotalBytes": 13271040,
"scriptDurationMs": 114.75200000000001,
"eventListeners": -7476,
"totalBlockingTimeMs": 440,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8474.74699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8287.653999999999,
"heapDeltaBytes": -11209620,
"heapUsedBytes": 167577044,
"domNodes": 0,
"jsHeapTotalBytes": -6291456,
"scriptDurationMs": 126.25399999999998,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8381.115999999907,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8152.884,
"heapDeltaBytes": -2599444,
"heapUsedBytes": 167304628,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 132.892,
"eventListeners": -15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 492.588000000012,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.031,
"layouts": 5,
"layoutDurationMs": 2.422,
"taskDurationMs": 140.855,
"heapDeltaBytes": 5286136,
"heapUsedBytes": 66988528,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.883000000000001,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 100.61199999995551,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.534,
"layouts": 5,
"layoutDurationMs": 2.327,
"taskDurationMs": 79.484,
"heapDeltaBytes": 3028600,
"heapUsedBytes": 64697080,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.5649999999999995,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## ben/workshop-production-followup #17606 +/- ##
====================================================================
- Coverage 82.71% 82.66% -0.06%
====================================================================
Files 2728 2730 +2
Lines 137326 137620 +294
Branches 35259 37199 +1940
====================================================================
+ Hits 113586 113758 +172
- Misses 22754 22852 +98
- Partials 986 1010 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
12e7e6b to
1162e24
Compare
1162e24
into
ben/workshop-production-followup
Summary
Fix Models input recovery and copied API examples from Christian's and Alex's review feedback. Visitors can choose media before signing in, retain it through login, and copy executable examples using the published SDKs. Follow-up to #17431; stacked on #17604 (merge that PR first).
Changes
models.runand SDK assets for URL inputs; cURL creates a fresh key at execution. All languages check credentials before input access. Default remote and embedded media remain usable; inline-only inputs retain their native bytes/MIME. Binary endpoints keep an HTTP fallback because SDK 0.2.0 only decodes JSON.@comfyorg/sdk@0.2.0andmime-types@3.0.2execute generated examples in tests; neither adds browser imports.Review Focus
IndexedDB drafts preserve real bytes and source provenance, consume on return, validate against the current schema, and expire after one hour. Writes prune to four drafts (100 MiB each). Storage has a five-second deadline and component cancellation; failed storage permits login and requests file reselection on return. Repeated sign-in clicks share one save, and late completion cannot redirect a departed page. No files upload during sign-in.
Reference replacement with the same filename sends changed bytes and a new idempotency key. Retrying the failed request retains its body/key. SDK URL substitution remains limited to URL-capable mappings; preparing the API tab never reads private files or downloads media.
Validation: 4,447 website unit tests and 26 Models browser tests pass against a TEST-enabled build. Offline schema preflight covers all 139 published pages (100 Router models), with zero invalid initial forms and no published 3D pages. Permanent tests execute cURL and the real TypeScript SDK under mocked transport; generated Python was executed with published
comfy-sdk==0.2.0, including uploads, embedded inputs, MIME, binary output and missing credentials. Normal commit hooks, types, lint, formatting, Knip and Fallow pass. No paid model sweep repeated.TEST provider credentials remain the separate cloud #9008 dependency; these checks do not certify its deployment or provider availability.