Skip to content

test: 5/14 cover real Cloud saved-card top-ups - #17539

Closed
huang47 wants to merge 16 commits into
codex/billing-topup-idempotencyfrom
codex/billing-e2e-saved-card-topup
Closed

huang47 wants to merge 16 commits into
codex/billing-topup-idempotencyfrom
codex/billing-e2e-saved-card-topup

Conversation

@huang47

@huang47 huang47 commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by #17538 in the six-PR billing E2E consolidation. Coverage is preserved there; the original description below is historical.

Depends on #17538. Next: #17540.

Summary

Verify a saved-card top-up succeeds and grants exactly 1,000 cents.

Validation

CLOUD_ACCOUNT_EMAIL="$WITH_CARD_EMAIL" CLOUD_ACCOUNT_PASSWORD="$WITH_CARD_PASSWORD" pnpm exec cross-env DISTRIBUTION=cloud PLAYWRIGHT_CLOUD_LIVE=1 pnpm exec playwright test --project=cloud-live-paid --workers=1

Requires sandbox URLs and a dedicated account with a saved Stripe test card.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 47591f80-9fb9-4d49-8f35-73072e43ce37

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/14/2026, 06:12:00 PM UTC

Links

🎭 Playwright: ✅ 1997 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1976 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance

⚠️ Performance tests failed. Check the CI workflow logs.

🔬 E2E Coverage

⚠️ Coverage collection failed. Check the CI workflow logs.

@codecov

codecov Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                         Coverage Diff                         @@
##           codex/billing-topup-idempotency   #17539      +/-   ##
===================================================================
- Coverage                            83.68%   83.67%   -0.01%     
===================================================================
  Files                                 2127     2127              
  Lines                               123756   123755       -1     
  Branches                             31429    31429              
===================================================================
- Hits                                103567   103556      -11     
- Misses                               20007    20017      +10     
  Partials                               182      182              
Flag Coverage Δ
e2e 66.70% <ø> (-0.02%) ⬇️
unit 78.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 12, 2026
@huang47 huang47 changed the title [3/x] test: cover real Cloud saved-card top-ups [3/12] test: cover real Cloud saved-card top-ups Sep 12, 2026
@huang47 huang47 changed the title [3/12] test: cover real Cloud saved-card top-ups test: 3/12 cover real Cloud saved-card top-ups Sep 12, 2026
@huang47
huang47 force-pushed the codex/billing-topup-idempotency branch from bae85af to a1f6057 Compare September 12, 2026 21:21
@huang47
huang47 force-pushed the codex/billing-e2e-saved-card-topup branch from 41894ef to 2b3f6fe Compare September 12, 2026 21:21
@huang47
huang47 force-pushed the codex/billing-topup-idempotency branch from a1f6057 to ee31bcc Compare September 14, 2026 18:09
@huang47
huang47 force-pushed the codex/billing-e2e-saved-card-topup branch from 2b3f6fe to a0afaaf Compare September 14, 2026 18:09
@huang47
huang47 force-pushed the codex/billing-topup-idempotency branch from ee31bcc to 98c451b Compare September 14, 2026 18:23
@huang47
huang47 force-pushed the codex/billing-e2e-saved-card-topup branch from a0afaaf to caf9602 Compare September 14, 2026 18:23
@github-actions github-actions Bot added risk:high PR risk grade (advisory shadow check; grader-owned) and removed risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Sep 14, 2026
@huang47
huang47 force-pushed the codex/billing-topup-idempotency branch from 98c451b to 1514152 Compare September 14, 2026 18:41
@huang47
huang47 force-pushed the codex/billing-e2e-saved-card-topup branch from caf9602 to e0e7a94 Compare September 14, 2026 18:41
@huang47 huang47 changed the title test: 3/12 cover real Cloud saved-card top-ups test: 5/14 cover real Cloud saved-card top-ups Sep 14, 2026
@huang47
huang47 force-pushed the codex/billing-topup-idempotency branch from 1514152 to d9966af Compare September 16, 2026 23:30
@huang47 huang47 closed this Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant