Repository navigation
test: cover subgraph UI lifecycle boundaries #17516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christian-byrne
wants to merge
32
commits into
main
Choose a base branch
from
test/ecs-qa-subgraph-gaps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
a010330
test: cover subgraph UI lifecycle boundaries
christian-byrne 7f551bb
[automated] Apply ESLint and Oxfmt fixes
actions-user bd706d6
test: address subgraph scenario review feedback
christian-byrne a1e87e5
test: correct subgraph lifecycle contracts
christian-byrne 6b813db
test: fix subgraph deletion target
christian-byrne c9874ea
Merge branch 'main' into test/ecs-qa-subgraph-gaps
DrJKL d9aae63
test: strengthen subgraph host lifecycle scenarios
christian-byrne 87bcf4d
Merge remote-tracking branch 'origin/main' into test/ecs-qa-subgraph-…
christian-byrne 7b854c9
test: use canvas geometry helper for replacement
christian-byrne 5e402eb
test: move promoted widget lookup to node reference
christian-byrne f17bd0c
test: copy subgraph hosts through node reference
christian-byrne c589644
test: delete selected host with focused keyboard helper
christian-byrne 1de5e6d
test: isolate root undo from nested navigation
christian-byrne 36d64c3
test: name subgraph user phases in traces
christian-byrne 9ea823c
test: cover blank promoted widget save
christian-byrne ba24b55
Revert "test: cover blank promoted widget save"
christian-byrne 8a3b7f3
test: preserve cleared promoted widget labels across reload
christian-byrne a32b72c
test: promote widget through UI before clearing its label
christian-byrne 6a244e4
Merge branch 'main' into test/ecs-qa-subgraph-gaps
DrJKL e431e30
test: structure subgraph scenarios as user stories
ampagent 4ea70f8
test: sort subgraph links explicitly
ampagent fd14fdb
test: harden subgraph workflow helpers
ampagent d1c2145
test: cover promoted advanced widget values
christian-byrne 7599fe6
test: remove unresolved promoted widget contract
christian-byrne 10f91e7
test: persist promoted values after duplicate deletion
christian-byrne 6ec053b
test: reuse promoted widget lookup in survivor assertions
christian-byrne cf30662
test: assert independently specified survivor values
christian-byrne fb0e853
test: persist independent subgraph host values
christian-byrne 9146041
test: cover remaining ECS widget contracts
christian-byrne 722e255
test: strengthen ECS widget lifecycle contracts
christian-byrne 7f8302c
test: isolate promoted widget persistence from default graph
christian-byrne 86f1978
Merge remote-tracking branch 'origin/main' into amp/pr17516-merge-main
DrJKL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import type { GraphTopology } from '@e2e/fixtures/helpers/SubgraphHelper' | ||
|
|
||
| export const nestedSubgraphTopologies = { | ||
| root: { | ||
| nodes: ['10', '8', '9'], | ||
| links: [ | ||
| ['10', 0, '8', 0], | ||
| ['10', 1, '8', 1], | ||
| ['8', 0, '9', 0] | ||
| ] | ||
| }, | ||
| outer: { | ||
| nodes: ['11', '3', '6'], | ||
| links: [ | ||
| ['11', 0, '3', 2], | ||
| ['11', 1, '3', 3], | ||
| ['11', 2, '3', 0], | ||
| ['11', 3, '6', 0], | ||
| ['11', 4, '-20', 1], | ||
| ['3', 0, '-20', 0], | ||
| ['6', 0, '3', 1] | ||
| ] | ||
| }, | ||
| inner: { | ||
| nodes: ['4', '5', '7'], | ||
| links: [ | ||
| ['4', 0, '-20', 2], | ||
| ['4', 1, '-20', 3], | ||
| ['4', 1, '7', 0], | ||
| ['4', 2, '-20', 4], | ||
| ['5', 0, '-20', 1], | ||
| ['7', 0, '-20', 0] | ||
| ] | ||
| } | ||
| } satisfies Record<'root' | 'outer' | 'inner', GraphTopology> | ||
|
|
||
| export const outerSubgraphBreadcrumbId = | ||
| 'subgraph-8beb610f-ddd1-4489-ae0d-2f732a4042ae' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2][non-blocking] Wait for the selected workflow to finish loading.
reloadAndWaitForApp()deliberately restores the graph the user left, so the following survivor and promoted-value assertions can observe that restored graph before this click has finished opening the saved item. The existing sidebar-open helper andswitchToTab()both wait for workflow idle at this boundary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed: persisted workflow opening waits for workflow idle.
Full context for agent readers
The current commit adds
await this.waitForWorkflowIdle()after the persisted-item click, before the workflows tab closes.