Skip to content

fix: address dev agent harness reviewer findings - #17514

Merged
christian-byrne merged 2 commits into
fix/dev-agent-supervised-spawnfrom
christian/dev-agent-harness-lifecycle-fixes
Sep 12, 2026
Merged

christian-byrne merged 2 commits into
fix/dev-agent-supervised-spawnfrom
christian/dev-agent-harness-lifecycle-fixes

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor
  • Carries the remaining reviewer fixes without rewriting the original author's branch.
  • Rejects non-workspace multi-player dependencies and lookalike service images.
  • Stacked on PR 16877; merge after that PR.
Full context for agent readers

This carries fixes for reviewer findings on PR 16877 to a contributor-owned branch.

Findings addressed

  • Require @comfyorg/comfy-multi-player to use the workspace: protocol so the harness cannot silently bypass the source-tree hot-reload contract.
  • Match the requested Postgres or Redis image repository exactly while still accepting tags and digests, preventing lookalike images from being selected for identity seeding.
  • Preserve the base branch's shared teardown behavior: every repeated stop() call awaits the same cleanup promise before returning.

Verification

  • pnpm typecheck — passed
  • focused supervisor and record-mode unit tests — 18/18 passed
  • changed-file ESLint — passed

Stack

Base: fix/dev-agent-supervised-spawn from PR 16877, whose harness implementation is not on main. This PR should merge after PR 16877; alternatively, PR 16877 can be closed in favor of a separately rebased full carrier.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: d55b0d5d-d586-4ec0-8c21-86a700d37fc9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1919 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1898 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 134ms TBT · 104.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.0 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.8 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 31ms TBT · 169.7 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 254ms TBT · 170.3 MB heap
vue-zoom-out-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 161.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 586ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.1 MB
canvas-idle: DOM nodes -277
canvas-idle: event listeners -174
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 43ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 1058ms
canvas-mouse-sweep: script duration 164ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.0 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -161
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 20ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 415ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.7 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 485ms
dom-widget-clipping: script duration 161ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.3 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 690ms
large-graph-idle: script duration 39ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.2 MB
large-graph-idle: DOM nodes -271
large-graph-idle: event listeners -158
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1763ms
large-graph-pan: script duration 810ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 85.5 MB
large-graph-pan: DOM nodes -276
large-graph-pan: event listeners -172
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1804ms
large-graph-zoom: script duration 777ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.7 MB
large-graph-zoom: DOM nodes -141
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2040ms
legacy-node-drag: script duration 975ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 89.4 MB
legacy-node-drag: DOM nodes -140
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 675ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.3 MB
minimap-idle: DOM nodes -275
minimap-idle: event listeners -174
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 445ms
subgraph-dom-widget-clipping: script duration 146ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 80.3 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 577ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.7 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -205
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 41ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 937ms
subgraph-mouse-sweep: script duration 109ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 66.6 MB
subgraph-mouse-sweep: DOM nodes -292
subgraph-mouse-sweep: event listeners -190
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 970ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 134ms
subgraph-transition-enter: heap used 104.0 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 6384ms
viewport-pan-sweep: script duration 2772ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 90.0 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -140
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15241ms
vue-large-graph-idle: script duration 262ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.8 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 138
vue-large-graph-pan: task duration 18681ms
vue-large-graph-pan: script duration 918ms
vue-large-graph-pan: TBT 31ms
vue-large-graph-pan: heap used 169.7 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 31ms
vue-node-resize-workload: style recalc duration 85ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5584ms
vue-node-resize-workload: script duration 106ms
vue-node-resize-workload: TBT 254ms
vue-node-resize-workload: heap used 170.3 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7473
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7651ms
vue-zoom-out-idle: script duration 138ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 161.4 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 24ms
workflow-execution: layout count 3
workflow-execution: style recalc count 11
workflow-execution: task duration 117ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.8 MB
workflow-execution: DOM nodes 125
workflow-execution: event listeners 43
Raw data
{
  "timestamp": "2026-09-12T03:56:04.487Z",
  "gitSha": "4412dbd9d05ce7e1b2dc4306e2539ace76da0a8e",
  "branch": "christian/dev-agent-harness-lifecycle-fixes",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2067.422000000022,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.718,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 584.0369999999999,
      "heapDeltaBytes": -13298372,
      "heapUsedBytes": 57768156,
      "domNodes": -277,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 11.697999999999997,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2054.634999999962,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.688999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 587.1010000000001,
      "heapDeltaBytes": -4159500,
      "heapUsedBytes": 66126076,
      "domNodes": -277,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.973,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2131.1000000000035,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 50.202999999999996,
      "layouts": 14,
      "layoutDurationMs": 5.401,
      "taskDurationMs": 1164.3120000000001,
      "heapDeltaBytes": -9631040,
      "heapUsedBytes": 61386832,
      "domNodes": -280,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 178.41199999999998,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1833.913999999993,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 36.287,
      "layouts": 14,
      "layoutDurationMs": 4.354,
      "taskDurationMs": 952.4300000000001,
      "heapDeltaBytes": 8964948,
      "heapUsedBytes": 79179948,
      "domNodes": -278,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 148.95799999999997,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1679.0390000000457,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 19.918000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.198,
      "taskDurationMs": 407.6979999999999,
      "heapDeltaBytes": 4415368,
      "heapUsedBytes": 74643320,
      "domNodes": 79,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 13.553000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.7360000000463,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 19.105999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.2730000000000001,
      "taskDurationMs": 422.216,
      "heapDeltaBytes": 4642744,
      "heapUsedBytes": 75707132,
      "domNodes": 76,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 13.639999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 714.616000000035,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.294,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.866,
      "heapDeltaBytes": -7863696,
      "heapUsedBytes": 63142148,
      "domNodes": 20,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 164.745,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 698.0369999999994,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.020999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.756,
      "heapDeltaBytes": 18236184,
      "heapUsedBytes": 88468280,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 156.705,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2061.243999999988,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 7.366000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 703.4209999999999,
      "heapDeltaBytes": -15504000,
      "heapUsedBytes": 87331328,
      "domNodes": -268,
      "jsHeapTotalBytes": 458752,
      "scriptDurationMs": 43.290000000000006,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2043.8040000000228,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.683000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 676.307,
      "heapDeltaBytes": 10931572,
      "heapUsedBytes": 87084740,
      "domNodes": -274,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 34.704,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2699.0880000000175,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.897,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1751.7289999999998,
      "heapDeltaBytes": 12680124,
      "heapUsedBytes": 90007992,
      "domNodes": -277,
      "jsHeapTotalBytes": -1974272,
      "scriptDurationMs": 808.242,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2689.8889999999938,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.711,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1774.3799999999999,
      "heapDeltaBytes": 12039452,
      "heapUsedBytes": 89331548,
      "domNodes": -275,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 811.506,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3748.111999999992,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.334999999999997,
      "layouts": 60,
      "layoutDurationMs": 12.627000000000002,
      "taskDurationMs": 1785.6089999999997,
      "heapDeltaBytes": 10227008,
      "heapUsedBytes": 76450792,
      "domNodes": -281,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 767.073,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3792.4490000000333,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.341000000000003,
      "layouts": 60,
      "layoutDurationMs": 12.919999999999998,
      "taskDurationMs": 1822.399,
      "heapDeltaBytes": 12160180,
      "heapUsedBytes": 80184292,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 787.903,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3177.278000000001,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.372000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2049.8340000000003,
      "heapDeltaBytes": 27334436,
      "heapUsedBytes": 94684440,
      "domNodes": -279,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 978.677,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3137.6279999999497,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.554000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2029.8700000000003,
      "heapDeltaBytes": 25276436,
      "heapUsedBytes": 92762308,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 971.171,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2047.1900000000005,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.9079999999999973,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 671.408,
      "heapDeltaBytes": 10489788,
      "heapUsedBytes": 87213444,
      "domNodes": -275,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 36.324999999999996,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2038.9900000000125,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.7780000000000027,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 678.826,
      "heapDeltaBytes": 10796060,
      "heapUsedBytes": 87521236,
      "domNodes": -274,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 36.147999999999996,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 674.1880000000151,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 12.063999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.029,
      "heapDeltaBytes": 14130572,
      "heapUsedBytes": 79879752,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 145.41,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 670.6689999999753,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 10.292,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.43600000000004,
      "heapDeltaBytes": 15249124,
      "heapUsedBytes": 88490328,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 145.726,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.9089999999983,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.021999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 583.6519999999999,
      "heapDeltaBytes": -14751164,
      "heapUsedBytes": 58509360,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.511000000000003,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.4740000000165,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.951,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 570.022,
      "heapDeltaBytes": -3628184,
      "heapUsedBytes": 68781672,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.162999999999998,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1756.1130000000276,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 41.46900000000001,
      "layouts": 18,
      "layoutDurationMs": 6.012,
      "taskDurationMs": 934.8810000000001,
      "heapDeltaBytes": -15334484,
      "heapUsedBytes": 57024604,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 109.865,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1734.884999999963,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 40.106,
      "layouts": 18,
      "layoutDurationMs": 5.865,
      "taskDurationMs": 938.981,
      "heapDeltaBytes": 9460336,
      "heapUsedBytes": 82629504,
      "domNodes": -290,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 108.059,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.246999999979,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 30.362000000000002,
      "layouts": 15,
      "layoutDurationMs": 14.452000000000004,
      "taskDurationMs": 970.2109999999999,
      "heapDeltaBytes": 21141012,
      "heapUsedBytes": 109008880,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 32.131,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 134,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9279.703999999982,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 36.629000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6330.065,
      "heapDeltaBytes": 28454804,
      "heapUsedBytes": 93912348,
      "domNodes": -269,
      "jsHeapTotalBytes": 454656,
      "scriptDurationMs": 2746.3569999999995,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9549.666000000001,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 36.80700000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6438.22,
      "heapDeltaBytes": 18946540,
      "heapUsedBytes": 94745116,
      "domNodes": -273,
      "jsHeapTotalBytes": -434176,
      "scriptDurationMs": 2796.965,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15759.349999999984,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15200.206999999999,
      "heapDeltaBytes": -34851000,
      "heapUsedBytes": 176615500,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3903488,
      "scriptDurationMs": 279.13699999999994,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15898.739999999976,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15282.532,
      "heapDeltaBytes": -36597668,
      "heapUsedBytes": 177464584,
      "domNodes": -6548,
      "jsHeapTotalBytes": -7536640,
      "scriptDurationMs": 245.07399999999998,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19055.932999999983,
      "styleRecalcs": 138,
      "styleRecalcDurationMs": 18.57500000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18833.002,
      "heapDeltaBytes": -49815616,
      "heapUsedBytes": 164285920,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5271552,
      "scriptDurationMs": 908.912,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 30,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18786.70199999999,
      "styleRecalcs": 138,
      "styleRecalcDurationMs": 18.374000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18528.412,
      "heapDeltaBytes": -16627644,
      "heapUsedBytes": 191585380,
      "domNodes": -6548,
      "jsHeapTotalBytes": 921600,
      "scriptDurationMs": 927.502,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 31,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5635.322000000031,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 75.38999999999996,
      "layouts": 20,
      "layoutDurationMs": 25.365,
      "taskDurationMs": 5591.5740000000005,
      "heapDeltaBytes": -25571204,
      "heapUsedBytes": 182293080,
      "domNodes": -6548,
      "jsHeapTotalBytes": 19079168,
      "scriptDurationMs": 109.28999999999998,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 265,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5653.920999999968,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 93.84199999999998,
      "layouts": 20,
      "layoutDurationMs": 37.05900000000001,
      "taskDurationMs": 5575.929999999999,
      "heapDeltaBytes": -30056160,
      "heapUsedBytes": 174857188,
      "domNodes": -6548,
      "jsHeapTotalBytes": 8744960,
      "scriptDurationMs": 102.18299999999999,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 242,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7807.425000000023,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7604.075999999999,
      "heapDeltaBytes": -5416032,
      "heapUsedBytes": 162132456,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 154.65699999999993,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8011.602000000039,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7697.863,
      "heapDeltaBytes": 13298348,
      "heapUsedBytes": 176295132,
      "domNodes": 0,
      "jsHeapTotalBytes": -11534336,
      "scriptDurationMs": 122.06800000000007,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 166.65399999999408,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 27.839000000000002,
      "layouts": 2,
      "layoutDurationMs": 1.53,
      "taskDurationMs": 125.12099999999998,
      "heapDeltaBytes": 3016592,
      "heapUsedBytes": 71936900,
      "domNodes": 132,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.955000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 451.1619999999539,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 20.535,
      "layouts": 3,
      "layoutDurationMs": 0.8750000000000001,
      "taskDurationMs": 108.408,
      "heapDeltaBytes": 4805252,
      "heapUsedBytes": 72296148,
      "domNodes": 117,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.241000000000001,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 49808 74502 66.9% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.4% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 79.0% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 12, 2026
@codecov

codecov Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                        Coverage Diff                         @@
##           fix/dev-agent-supervised-spawn   #17514      +/-   ##
==================================================================
- Coverage                           83.25%   82.99%   -0.26%     
==================================================================
  Files                                2065     2056       -9     
  Lines                              120532   119882     -650     
  Branches                            34386    34049     -337     
==================================================================
- Hits                               100349    99498     -851     
- Misses                              20003    20204     +201     
  Partials                              180      180              
Flag Coverage Δ
e2e 66.88% <ø> (-0.16%) ⬇️
unit 77.59% <ø> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 226 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit b272d0e into fix/dev-agent-supervised-spawn Sep 12, 2026
99 of 100 checks passed
@christian-byrne
christian-byrne deleted the christian/dev-agent-harness-lifecycle-fixes branch September 12, 2026 20:40
@DrJKL DrJKL added the agent Comfy Agent product, integration, tests or product documentation label Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation flag-exempt risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants