Repository navigation
test: add e2e coverage for identity-scoped draft persistence - #17502
christian-byrne wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1963 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T08:56:31.008Z",
"gitSha": "b1ca4511ce54b912ba7e3d1615855c4134e1be03",
"branch": "test/draft-persistence-e2e",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2028.7040000000047,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.498000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.11499999999995,
"heapDeltaBytes": 11526928,
"heapUsedBytes": 72191504,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 14.184,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2000.7400000000075,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.549000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 262.49999999999994,
"heapDeltaBytes": -5833920,
"heapUsedBytes": 54951252,
"domNodes": -259,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.218,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.2500000000086,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.59,
"layouts": 14,
"layoutDurationMs": 4.697000000000001,
"taskDurationMs": 779.353,
"heapDeltaBytes": 15499544,
"heapUsedBytes": 77137880,
"domNodes": -259,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 146.645,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.1800000000367,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.754,
"layouts": 14,
"layoutDurationMs": 4.469000000000001,
"taskDurationMs": 614.432,
"heapDeltaBytes": 438360,
"heapUsedBytes": 62738808,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 116.016,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.755999999994,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.435,
"layouts": 6,
"layoutDurationMs": 1.15,
"taskDurationMs": 238.609,
"heapDeltaBytes": 2170816,
"heapUsedBytes": 64282276,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.286,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.3129999999992,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.149000000000001,
"layouts": 6,
"layoutDurationMs": 1.0539999999999998,
"taskDurationMs": 211.979,
"heapDeltaBytes": 2179148,
"heapUsedBytes": 64300548,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.689,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 523.6600000000067,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.4079999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.85,
"heapDeltaBytes": 17542804,
"heapUsedBytes": 79778052,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 127.42600000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 507.42400000001453,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.464000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 317.693,
"heapDeltaBytes": 17594884,
"heapUsedBytes": 79749436,
"domNodes": 19,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 112.54499999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2013.967999999977,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.650000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.01,
"heapDeltaBytes": 19708368,
"heapUsedBytes": 83472184,
"domNodes": -245,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.147000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.032999999984,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.28,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.893,
"heapDeltaBytes": 3940672,
"heapUsedBytes": 82863876,
"domNodes": -243,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 33.135999999999996,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2754.6330000000125,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.681000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1324.3559999999998,
"heapDeltaBytes": 2203832,
"heapUsedBytes": 83004464,
"domNodes": -248,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 632.3539999999999,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2171.248999999989,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.499,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1167.8039999999999,
"heapDeltaBytes": -5905604,
"heapUsedBytes": 74151060,
"domNodes": -248,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 574.878,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3231.0169999999516,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.005000000000004,
"layouts": 60,
"layoutDurationMs": 13.468999999999998,
"taskDurationMs": 1257.964,
"heapDeltaBytes": -3772724,
"heapUsedBytes": 77476400,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 546.154,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3140.9119999999575,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.306,
"layouts": 60,
"layoutDurationMs": 13.17,
"taskDurationMs": 1185.239,
"heapDeltaBytes": 9419172,
"heapUsedBytes": 74715132,
"domNodes": 8,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 521.119,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2765.172000000007,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.521000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1600.457,
"heapDeltaBytes": -10478384,
"heapUsedBytes": 80379800,
"domNodes": -253,
"jsHeapTotalBytes": 708608,
"scriptDurationMs": 790.365,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2358.5480000000416,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.711000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1478.8990000000001,
"heapDeltaBytes": -10338008,
"heapUsedBytes": 79876968,
"domNodes": -251,
"jsHeapTotalBytes": 708608,
"scriptDurationMs": 701.808,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.229999999965,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.108999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.249,
"heapDeltaBytes": -5416540,
"heapUsedBytes": 81901992,
"domNodes": -242,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 27.572000000000006,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.9369999999135,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.530000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.654,
"heapDeltaBytes": -7251920,
"heapUsedBytes": 79769632,
"domNodes": -251,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 30.681,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 494.8760000000334,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.322999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.57900000000006,
"heapDeltaBytes": 13640936,
"heapUsedBytes": 76959196,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 100.63,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 463.2799999999406,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.655,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.97700000000003,
"heapDeltaBytes": 13418928,
"heapUsedBytes": 76847692,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 102.42299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.0820000000058,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.176000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.64099999999996,
"heapDeltaBytes": 18184280,
"heapUsedBytes": 81155888,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.135,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.2029999999613,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.33,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.92800000000005,
"heapDeltaBytes": 15074284,
"heapUsedBytes": 78331680,
"domNodes": -272,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.083999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.1049999999987,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.745,
"layouts": 18,
"layoutDurationMs": 6.712999999999999,
"taskDurationMs": 682.153,
"heapDeltaBytes": 9255516,
"heapUsedBytes": 72284696,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 102.443,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.4770000000008,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.75,
"layouts": 18,
"layoutDurationMs": 5.502,
"taskDurationMs": 613.934,
"heapDeltaBytes": -3532832,
"heapUsedBytes": 59880252,
"domNodes": -274,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 91.88499999999999,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 850.5739999999946,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.755000000000003,
"layouts": 5,
"layoutDurationMs": 8.129000000000001,
"taskDurationMs": 617.9030000000001,
"heapDeltaBytes": 17826652,
"heapUsedBytes": 99300260,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 23.280999999999995,
"eventListeners": 2385,
"totalBlockingTimeMs": 72,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8676.354000000003,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.178000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4405.35,
"heapDeltaBytes": -12185464,
"heapUsedBytes": 66949516,
"domNodes": -241,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 2056.4790000000003,
"eventListeners": -136,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8672.196000000098,
"styleRecalcs": 250,
"styleRecalcDurationMs": 50.912,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4444.769,
"heapDeltaBytes": -11390848,
"heapUsedBytes": 67471428,
"domNodes": -214,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 2063.241,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11820.605999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11352.293,
"heapDeltaBytes": -28096344,
"heapUsedBytes": 180262104,
"domNodes": -6542,
"jsHeapTotalBytes": 4734976,
"scriptDurationMs": 170.362,
"eventListeners": -7482,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12000.357000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11104.916,
"heapDeltaBytes": -28437236,
"heapUsedBytes": 180160208,
"domNodes": -6542,
"jsHeapTotalBytes": 6307840,
"scriptDurationMs": 167.356,
"eventListeners": -7480,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14381.029000000013,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.185000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14193.669,
"heapDeltaBytes": -51778592,
"heapUsedBytes": 163492244,
"domNodes": -6542,
"jsHeapTotalBytes": 278528,
"scriptDurationMs": 683.254,
"eventListeners": -7476,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14299.372999999945,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.945999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14045.814,
"heapDeltaBytes": -36421136,
"heapUsedBytes": 162264892,
"domNodes": -6542,
"jsHeapTotalBytes": 1851392,
"scriptDurationMs": 653.058,
"eventListeners": -7478,
"totalBlockingTimeMs": 28,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4406.988000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.70900000000001,
"layouts": 20,
"layoutDurationMs": 34.249,
"taskDurationMs": 4341.866,
"heapDeltaBytes": -14664744,
"heapUsedBytes": 187748260,
"domNodes": -6542,
"jsHeapTotalBytes": 10502144,
"scriptDurationMs": 74.43299999999999,
"eventListeners": -7476,
"totalBlockingTimeMs": 124,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4201.529999999934,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.99800000000002,
"layouts": 20,
"layoutDurationMs": 22.08600000000001,
"taskDurationMs": 4170.942,
"heapDeltaBytes": -28327228,
"heapUsedBytes": 187060696,
"domNodes": -6542,
"jsHeapTotalBytes": 17842176,
"scriptDurationMs": 69.10900000000001,
"eventListeners": -7478,
"totalBlockingTimeMs": 76,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5978.425000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5832.077,
"heapDeltaBytes": 11726696,
"heapUsedBytes": 189364636,
"domNodes": 0,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 85.68400000000004,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6112.923000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5657.764,
"heapDeltaBytes": 9646996,
"heapUsedBytes": 177377908,
"domNodes": 0,
"jsHeapTotalBytes": -17563648,
"scriptDurationMs": 76.816,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 419.2939999999794,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.073,
"layouts": 4,
"layoutDurationMs": 1.8350000000000002,
"taskDurationMs": 91.533,
"heapDeltaBytes": 4946696,
"heapUsedBytes": 66823344,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.712,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 68.40799999997671,
"styleRecalcs": 5,
"styleRecalcDurationMs": 10.96,
"layouts": 3,
"layoutDurationMs": 1.506,
"taskDurationMs": 55.214,
"heapDeltaBytes": 3002056,
"heapUsedBytes": 64907188,
"domNodes": 122,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.389,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## fix/draft-persistence-identity-gate #17502 +/- ##
======================================================================
Coverage ? 83.19%
======================================================================
Files ? 2110
Lines ? 122489
Branches ? 30573
======================================================================
Hits ? 101909
Misses ? 20401
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Picking up the red (Claiming it out loud because two of us have collided on triage before: on #17511 I spent a tick reproducing and fixing a |
|
Diagnosed. This is a CI configuration gap, not a defect in this PR — and it needs a maintainer decision, so I have not changed anything. The check's own text says "No current-head risk grade; a maintainer must re-run grading." I re-ran grading via Same three outcomes as the original run at 01:53. So the remedy the check names does not work, and re-running will never fix it. Why. if: needs.gate.outputs.enabled == 'true' && inputs.check_run && !cancelled()The gate resolves true — the dispatch log shows with:
workflows_ref: df10491…
enabled: true
label_map: 'R0=risk:low,…'
pr_number: …
pr_numbers: …So no Check Run carrying the grade is ever created on any head commit, The one-line fix is I have deliberately not made that change: it alters CI behaviour for every PR in the repo (a new Check Run on every head commit), which is a maintainer call rather than something to slip in while triaging one spec PR. Happy to open it as its own PR if that is wanted. Nothing to change on this branch. cc @DrJKL |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Closing because the behavior under test is tied to a product implementation that was rejected and closed unmerged. This PR is based on |
Stacked on pull request 17313.
Adds cloud e2e coverage for scoped writes, logout fencing, and legacy migration.
New fixture:
identityScopedDraftFixture.Full context for agent readers
The cloud Playwright spec verifies that graph changes write only under the signed-in user and workspace scope, that logout clears the departing scope and prevents a queued graph change from writing afterward, and that a legacy workspace-keyed draft moves to the identity-scoped destination with its source removed and completion recorded. Reload coverage verifies the migrated payload and completion record remain unchanged.
The fixture boots the existing fully mocked cloud auth and workspace harness, provides deterministic graph touches, seeds and reads localStorage, and drives the real logout UI.
Run locally with a cloud-distribution dev server and backend:
Known gap: this suite covers the personal workspace scope and does not drive a team-workspace or second-user switch. Those paths share the same scope resolver exercised by the scoped-write assertion.