Skip to content

test: add e2e coverage for identity-scoped draft persistence - #17502

Closed
christian-byrne wants to merge 2 commits into
fix/draft-persistence-identity-gatefrom
test/draft-persistence-e2e
Closed

christian-byrne wants to merge 2 commits into
fix/draft-persistence-identity-gatefrom
test/draft-persistence-e2e

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Stacked on pull request 17313.
Adds cloud e2e coverage for scoped writes, logout fencing, and legacy migration.
New fixture: identityScopedDraftFixture.

Full context for agent readers

The cloud Playwright spec verifies that graph changes write only under the signed-in user and workspace scope, that logout clears the departing scope and prevents a queued graph change from writing afterward, and that a legacy workspace-keyed draft moves to the identity-scoped destination with its source removed and completion recorded. Reload coverage verifies the migrated payload and completion record remain unchanged.

The fixture boots the existing fully mocked cloud auth and workspace harness, provides deterministic graph touches, seeds and reads localStorage, and drives the real logout UI.

Run locally with a cloud-distribution dev server and backend:

PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://localhost:5199 PLAYWRIGHT_SETUP_API_URL=http://127.0.0.1:8188 DISTRIBUTION=cloud pnpm exec playwright test browser_tests/tests/workspace/identityScopedDraftPersistence.spec.ts --project=cloud --workers=1

Known gap: this suite covers the personal workspace scope and does not drive a team-workspace or second-user switch. Those paths share the same scope resolver exercised by the scoped-write assertion.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 82005a8e-ace7-4872-b4c2-cd1bd5fb6806

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1963 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1942 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 72ms TBT · 94.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.1 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.9 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 14ms TBT · 155.3 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 100ms TBT · 178.7 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 174.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 320ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.6 MB
canvas-idle: DOM nodes -260
canvas-idle: event listeners -169
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 27ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 697ms
canvas-mouse-sweep: script duration 131ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.7 MB
canvas-mouse-sweep: DOM nodes -260
canvas-mouse-sweep: event listeners -168
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 225ms
canvas-zoom-sweep: script duration 9ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 61.3 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 337ms
dom-widget-clipping: script duration 120ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 76.1 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 464ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.3 MB
large-graph-idle: DOM nodes -244
large-graph-idle: event listeners -166
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1246ms
large-graph-pan: script duration 604ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 74.9 MB
large-graph-pan: DOM nodes -248
large-graph-pan: event listeners -181
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1222ms
large-graph-zoom: script duration 534ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.6 MB
large-graph-zoom: DOM nodes -127
large-graph-zoom: event listeners -89
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 11ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1540ms
legacy-node-drag: script duration 746ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 76.4 MB
legacy-node-drag: DOM nodes -252
legacy-node-drag: event listeners 0
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 417ms
minimap-idle: script duration 29ms
minimap-idle: TBT 0ms
minimap-idle: heap used 77.1 MB
minimap-idle: DOM nodes -247
minimap-idle: event listeners -182
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 297ms
subgraph-dom-widget-clipping: script duration 102ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 73.3 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 318ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 76.0 MB
subgraph-idle: DOM nodes -275
subgraph-idle: event listeners -198
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 648ms
subgraph-mouse-sweep: script duration 97ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 63.0 MB
subgraph-mouse-sweep: DOM nodes -274
subgraph-mouse-sweep: event listeners -215
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 8ms
subgraph-transition-enter: style recalc duration 20ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 618ms
subgraph-transition-enter: script duration 23ms
subgraph-transition-enter: TBT 72ms
subgraph-transition-enter: heap used 94.7 MB
subgraph-transition-enter: DOM nodes 13587
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 47ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4425ms
viewport-pan-sweep: script duration 2060ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 64.1 MB
viewport-pan-sweep: DOM nodes -228
viewport-pan-sweep: event listeners -151
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11229ms
vue-large-graph-idle: script duration 169ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.9 MB
vue-large-graph-idle: DOM nodes -6542
vue-large-graph-idle: event listeners -7481
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 71
vue-large-graph-pan: task duration 14120ms
vue-large-graph-pan: script duration 668ms
vue-large-graph-pan: TBT 14ms
vue-large-graph-pan: heap used 155.3 MB
vue-large-graph-pan: DOM nodes -6542
vue-large-graph-pan: event listeners -7477
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 28ms
vue-node-resize-workload: style recalc duration 57ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4256ms
vue-node-resize-workload: script duration 72ms
vue-node-resize-workload: TBT 100ms
vue-node-resize-workload: heap used 178.7 MB
vue-node-resize-workload: DOM nodes -6542
vue-node-resize-workload: event listeners -7477
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5745ms
vue-zoom-out-idle: script duration 81ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 174.9 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -8
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 4
workflow-execution: style recalc count 9
workflow-execution: task duration 73ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 62.8 MB
workflow-execution: DOM nodes 123
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-09-23T08:56:31.008Z",
  "gitSha": "b1ca4511ce54b912ba7e3d1615855c4134e1be03",
  "branch": "test/draft-persistence-e2e",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2028.7040000000047,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.498000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 378.11499999999995,
      "heapDeltaBytes": 11526928,
      "heapUsedBytes": 72191504,
      "domNodes": -260,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 14.184,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2000.7400000000075,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.549000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 262.49999999999994,
      "heapDeltaBytes": -5833920,
      "heapUsedBytes": 54951252,
      "domNodes": -259,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.218,
      "eventListeners": -184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1759.2500000000086,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 28.59,
      "layouts": 14,
      "layoutDurationMs": 4.697000000000001,
      "taskDurationMs": 779.353,
      "heapDeltaBytes": 15499544,
      "heapUsedBytes": 77137880,
      "domNodes": -259,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 146.645,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1710.1800000000367,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 25.754,
      "layouts": 14,
      "layoutDurationMs": 4.469000000000001,
      "taskDurationMs": 614.432,
      "heapDeltaBytes": 438360,
      "heapUsedBytes": 62738808,
      "domNodes": -260,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 116.016,
      "eventListeners": -184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.755999999994,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.435,
      "layouts": 6,
      "layoutDurationMs": 1.15,
      "taskDurationMs": 238.609,
      "heapDeltaBytes": 2170816,
      "heapUsedBytes": 64282276,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.286,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.3129999999992,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 13.149000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.0539999999999998,
      "taskDurationMs": 211.979,
      "heapDeltaBytes": 2179148,
      "heapUsedBytes": 64300548,
      "domNodes": 78,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 8.689,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 523.6600000000067,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.4079999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 356.85,
      "heapDeltaBytes": 17542804,
      "heapUsedBytes": 79778052,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 127.42600000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 507.42400000001453,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.464000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 317.693,
      "heapDeltaBytes": 17594884,
      "heapUsedBytes": 79749436,
      "domNodes": 19,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 112.54499999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2013.967999999977,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.650000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 510.01,
      "heapDeltaBytes": 19708368,
      "heapUsedBytes": 83472184,
      "domNodes": -245,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.147000000000002,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2026.032999999984,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.28,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.893,
      "heapDeltaBytes": 3940672,
      "heapUsedBytes": 82863876,
      "domNodes": -243,
      "jsHeapTotalBytes": -270336,
      "scriptDurationMs": 33.135999999999996,
      "eventListeners": -180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2754.6330000000125,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.681000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1324.3559999999998,
      "heapDeltaBytes": 2203832,
      "heapUsedBytes": 83004464,
      "domNodes": -248,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 632.3539999999999,
      "eventListeners": -180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2171.248999999989,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.499,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1167.8039999999999,
      "heapDeltaBytes": -5905604,
      "heapUsedBytes": 74151060,
      "domNodes": -248,
      "jsHeapTotalBytes": 217088,
      "scriptDurationMs": 574.878,
      "eventListeners": -182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3231.0169999999516,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.005000000000004,
      "layouts": 60,
      "layoutDurationMs": 13.468999999999998,
      "taskDurationMs": 1257.964,
      "heapDeltaBytes": -3772724,
      "heapUsedBytes": 77476400,
      "domNodes": -262,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 546.154,
      "eventListeners": -186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3140.9119999999575,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.306,
      "layouts": 60,
      "layoutDurationMs": 13.17,
      "taskDurationMs": 1185.239,
      "heapDeltaBytes": 9419172,
      "heapUsedBytes": 74715132,
      "domNodes": 8,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 521.119,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2765.172000000007,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.521000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1600.457,
      "heapDeltaBytes": -10478384,
      "heapUsedBytes": 80379800,
      "domNodes": -253,
      "jsHeapTotalBytes": 708608,
      "scriptDurationMs": 790.365,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2358.5480000000416,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.711000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1478.8990000000001,
      "heapDeltaBytes": -10338008,
      "heapUsedBytes": 79876968,
      "domNodes": -251,
      "jsHeapTotalBytes": 708608,
      "scriptDurationMs": 701.808,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2025.229999999965,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.108999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.249,
      "heapDeltaBytes": -5416540,
      "heapUsedBytes": 81901992,
      "domNodes": -242,
      "jsHeapTotalBytes": -1544192,
      "scriptDurationMs": 27.572000000000006,
      "eventListeners": -182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.9369999999135,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.530000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 432.654,
      "heapDeltaBytes": -7251920,
      "heapUsedBytes": 79769632,
      "domNodes": -251,
      "jsHeapTotalBytes": -757760,
      "scriptDurationMs": 30.681,
      "eventListeners": -182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 494.8760000000334,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.322999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 295.57900000000006,
      "heapDeltaBytes": 13640936,
      "heapUsedBytes": 76959196,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 100.63,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 463.2799999999406,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.655,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 297.97700000000003,
      "heapDeltaBytes": 13418928,
      "heapUsedBytes": 76847692,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 102.42299999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.0820000000058,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.176000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 338.64099999999996,
      "heapDeltaBytes": 18184280,
      "heapUsedBytes": 81155888,
      "domNodes": -278,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 11.135,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.2029999999613,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.33,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 297.92800000000005,
      "heapDeltaBytes": 15074284,
      "heapUsedBytes": 78331680,
      "domNodes": -272,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.083999999999998,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.1049999999987,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.745,
      "layouts": 18,
      "layoutDurationMs": 6.712999999999999,
      "taskDurationMs": 682.153,
      "heapDeltaBytes": 9255516,
      "heapUsedBytes": 72284696,
      "domNodes": -274,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 102.443,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1675.4770000000008,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 26.75,
      "layouts": 18,
      "layoutDurationMs": 5.502,
      "taskDurationMs": 613.934,
      "heapDeltaBytes": -3532832,
      "heapUsedBytes": 59880252,
      "domNodes": -274,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 91.88499999999999,
      "eventListeners": -230,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 850.5739999999946,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 19.755000000000003,
      "layouts": 5,
      "layoutDurationMs": 8.129000000000001,
      "taskDurationMs": 617.9030000000001,
      "heapDeltaBytes": 17826652,
      "heapUsedBytes": 99300260,
      "domNodes": 13587,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 23.280999999999995,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 72,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8676.354000000003,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 43.178000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4405.35,
      "heapDeltaBytes": -12185464,
      "heapUsedBytes": 66949516,
      "domNodes": -241,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 2056.4790000000003,
      "eventListeners": -136,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8672.196000000098,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 50.912,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4444.769,
      "heapDeltaBytes": -11390848,
      "heapUsedBytes": 67471428,
      "domNodes": -214,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 2063.241,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11820.605999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11352.293,
      "heapDeltaBytes": -28096344,
      "heapUsedBytes": 180262104,
      "domNodes": -6542,
      "jsHeapTotalBytes": 4734976,
      "scriptDurationMs": 170.362,
      "eventListeners": -7482,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12000.357000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11104.916,
      "heapDeltaBytes": -28437236,
      "heapUsedBytes": 180160208,
      "domNodes": -6542,
      "jsHeapTotalBytes": 6307840,
      "scriptDurationMs": 167.356,
      "eventListeners": -7480,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14381.029000000013,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 15.185000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14193.669,
      "heapDeltaBytes": -51778592,
      "heapUsedBytes": 163492244,
      "domNodes": -6542,
      "jsHeapTotalBytes": 278528,
      "scriptDurationMs": 683.254,
      "eventListeners": -7476,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14299.372999999945,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.945999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14045.814,
      "heapDeltaBytes": -36421136,
      "heapUsedBytes": 162264892,
      "domNodes": -6542,
      "jsHeapTotalBytes": 1851392,
      "scriptDurationMs": 653.058,
      "eventListeners": -7478,
      "totalBlockingTimeMs": 28,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4406.988000000012,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.70900000000001,
      "layouts": 20,
      "layoutDurationMs": 34.249,
      "taskDurationMs": 4341.866,
      "heapDeltaBytes": -14664744,
      "heapUsedBytes": 187748260,
      "domNodes": -6542,
      "jsHeapTotalBytes": 10502144,
      "scriptDurationMs": 74.43299999999999,
      "eventListeners": -7476,
      "totalBlockingTimeMs": 124,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4201.529999999934,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 53.99800000000002,
      "layouts": 20,
      "layoutDurationMs": 22.08600000000001,
      "taskDurationMs": 4170.942,
      "heapDeltaBytes": -28327228,
      "heapUsedBytes": 187060696,
      "domNodes": -6542,
      "jsHeapTotalBytes": 17842176,
      "scriptDurationMs": 69.10900000000001,
      "eventListeners": -7478,
      "totalBlockingTimeMs": 76,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5978.425000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5832.077,
      "heapDeltaBytes": 11726696,
      "heapUsedBytes": 189364636,
      "domNodes": 0,
      "jsHeapTotalBytes": -2883584,
      "scriptDurationMs": 85.68400000000004,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6112.923000000023,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5657.764,
      "heapDeltaBytes": 9646996,
      "heapUsedBytes": 177377908,
      "domNodes": 0,
      "jsHeapTotalBytes": -17563648,
      "scriptDurationMs": 76.816,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 419.2939999999794,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 19.073,
      "layouts": 4,
      "layoutDurationMs": 1.8350000000000002,
      "taskDurationMs": 91.533,
      "heapDeltaBytes": 4946696,
      "heapUsedBytes": 66823344,
      "domNodes": 124,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.712,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 68.40799999997671,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 10.96,
      "layouts": 3,
      "layoutDurationMs": 1.506,
      "taskDurationMs": 55.214,
      "heapDeltaBytes": 3002056,
      "heapUsedBytes": 64907188,
      "domNodes": 122,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.389,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50639 75845 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.6% 1160
src/LGraphNode.ts 69.9% 388
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/workspaceAuthStore.ts 33.5% 326
src/platform/workspace/stores/billingOperationStore.ts 8.0% 309
src/LGraph.ts 79.2% 266
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 12, 2026
@codecov

codecov Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                          Coverage Diff                           @@
##             fix/draft-persistence-identity-gate   #17502   +/-   ##
======================================================================
  Coverage                                       ?   83.19%           
======================================================================
  Files                                          ?     2110           
  Lines                                          ?   122489           
  Branches                                       ?    30573           
======================================================================
  Hits                                           ?   101909           
  Misses                                         ?    20401           
  Partials                                       ?      179           
Flag Coverage Δ
e2e 66.87% <ø> (?)
unit 78.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Picking up the red feature-flag-policy check on this PR now — diagnosing, will report back here either way.

(Claiming it out loud because two of us have collided on triage before: on #17511 I spent a tick reproducing and fixing a fallow finding that the PR author fixed independently in the same window. The push rejection was the only thing that caught it.)

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Diagnosed. This is a CI configuration gap, not a defect in this PR — and it needs a maintainer decision, so I have not changed anything.

The check's own text says "No current-head risk grade; a maintainer must re-run grading." I re-ran grading via workflow_dispatch (run 34724255560). It succeeded — and the grade still was not published:

pr-risk / Resolve enablement      -> success
pr-risk / Grade PR risk           -> success
pr-risk / Publish the risk Check Run -> skipped

Same three outcomes as the original run at 01:53. So the remedy the check names does not work, and re-running will never fix it.

Why. publish-check in the pinned reusable workflow
(pr-risk.yml@df10491) is gated on:

if: needs.gate.outputs.enabled == 'true' && inputs.check_run && !cancelled()

The gate resolves true — the dispatch log shows pr-risk enabled=true (decided by the caller's reviewed enabled: input). The second half is what fails: check_run is type: boolean, default: false upstream, and .github/workflows/ci-pr-risk.yml on main does not pass it:

with:
  workflows_ref: df10491…
  enabled: true
  label_map: 'R0=risk:low,…'
  pr_number: …
  pr_numbers: …

So no Check Run carrying the grade is ever created on any head commit, ci-feature-flag-policy.yaml finds no current-head grade, and returns inconclusive.

The one-line fix is check_run: true in that with: block. The checks: write permission it requires is already granted there, with a comment explaining it is mandatory for every caller regardless of the input — so the grant side is done.

I have deliberately not made that change: it alters CI behaviour for every PR in the repo (a new Check Run on every head commit), which is a maintainer call rather than something to slip in while triaging one spec PR. Happy to open it as its own PR if that is wanted.

Nothing to change on this branch. cc @DrJKL

@vercel

vercel Bot commented Sep 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 8:47am UTC

Request Review

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing because the behavior under test is tied to a product implementation that was rejected and closed unmerged. This PR is based on fix/draft-persistence-identity-gate; its parent frontend #17313 closed with reproduced cross-tab data-loss races and never reached main. The child cannot reach main or exercise the current persistence architecture without being rewritten as a new current-main test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flag-exempt risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants