Skip to content

docs(adr): add AGENT-SESSION-0028 compose turn origin and account generation - #17483

Merged
christian-byrne merged 1 commit into
mainfrom
christian-byrne/phs-49-agent-session-scope-adr
Sep 12, 2026
Merged

christian-byrne merged 1 commit into
mainfrom
christian-byrne/phs-49-agent-session-scope-adr

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Adds docs/adr/AGENT-SESSION-0028-compose-turn-origin-and-account-generation.md and its README index row.

This ADR was drafted on 2026-09-05 inside a conflict-resolution merge (282fdcbdd845c3a7d809ad2b1b4b0535acfc45ea in a local integration checkout) that never reached main or any live PR head. This PR re-expresses it onto main and amends it with a second dimension the original text missed:

Amendment decision recorded: the composite scope is canonical; #16768's purge/generation guards are retained but fed by the composite scope; Comfy.Agent.ThreadOwnerId is dropped in favour of the composite key; a single telemetry slug agent_session_storage_access_failed is used; whichever of #16768/#17324 lands second rebases onto the first.

Evidence

pair result
main × #16949 clean
main × #17324 conflict: useAgentSession.ts
main × #16768 conflict: useAgentSession.ts, agentWorkflowTabBindingStore.ts
main × #16856 conflict: AgentPanelRoot.vue, AgentPanelRoot.test.ts, useComposer.ts
#16768 × #17324 conflict: AgentPanelRoot.vue, useAgentSession.ts, useAgentSession.test.ts, agentChatHistoryStore.ts
#16949 × #17324 conflict: useAgentSession.ts
#16768 × #16856 conflict: useAgentSession.test.ts
#16768 × #16949, #16856 × #16949, #16856 × #17324 clean

Docs-only change; no runtime behaviour affected.

Refs #16768 #16840 #16949 #17324 (supersedes #16393).

Authored by an agent (role: hard-problem solver) on behalf of christian-byrne.

…eration

Re-expresses the ADR drafted 2026-09-05 in a conflict-resolution merge that
never reached main, and amends it: persisted session scope has two
dimensions (account and workspace); the composite storage scope from #17324
is canonical and #16768's generation guards are retained.

Refs #16768 #16840 #16949 #17324
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

On-demand reviews are free for the next 28 days. After that, they cost $0.25 per reviewed file.

Or wait 13 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: f5dda9a1-87c4-4908-bfc6-ad834ffdd4e1

📥 Commits

Reviewing files that changed from the base of the PR and between b632879 and cd85620.

📒 Files selected for processing (2)
  • docs/adr/AGENT-SESSION-0028-compose-turn-origin-and-account-generation.md
  • docs/adr/README.md

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 11, 2026

@CodeJuggernaut CodeJuggernaut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claims check out against the #17324 head; index row is in the right slot.

@christian-byrne
christian-byrne added this pull request to the merge queue Sep 12, 2026
Merged via the queue into main with commit 973b0f8 Sep 12, 2026
65 checks passed
@christian-byrne
christian-byrne deleted the christian-byrne/phs-49-agent-session-scope-adr branch September 12, 2026 00:58
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-docs Agent product architecture, contracts or documentation agent-session Agent sessions, history, turn lifecycle or workflow binding labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-docs Agent product architecture, contracts or documentation agent-session Agent sessions, history, turn lifecycle or workflow binding risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants