Repository navigation
docs(adr): add AGENT-SESSION-0028 compose turn origin and account generation - #17483
Merged
christian-byrne merged 1 commit intoSep 12, 2026
Merged
Conversation
…eration Re-expresses the ADR drafted 2026-09-05 in a conflict-resolution merge that never reached main, and amends it: persisted session scope has two dimensions (account and workspace); the composite storage scope from #17324 is canonical and #16768's generation guards are retained. Refs #16768 #16840 #16949 #17324
Contributor
|
Warning Review limit reached
On-demand reviews are free for the next 28 days. After that, they cost $0.25 per reviewed file. Or wait 13 minutes for your next included review. View limit detailsLimit details: You’ve used all 8 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
This was referenced Sep 11, 2026
Contributor
|
No description provided. |
CodeJuggernaut
approved these changes
Sep 12, 2026
CodeJuggernaut
left a comment
Contributor
There was a problem hiding this comment.
Claims check out against the #17324 head; index row is in the right slot.
christian-byrne
deleted the
christian-byrne/phs-49-agent-session-scope-adr
branch
September 12, 2026 00:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
docs/adr/AGENT-SESSION-0028-compose-turn-origin-and-account-generation.mdand its README index row.This ADR was drafted on 2026-09-05 inside a conflict-resolution merge (
282fdcbdd845c3a7d809ad2b1b4b0535acfc45eain a local integration checkout) that never reachedmainor any live PR head. This PR re-expresses it ontomainand amends it with a second dimension the original text missed:${encodeURIComponent(userId)}/${encodeURIComponent(workspaceId)}(slash separator, verified against the FE-2057: fix: isolate agent sessions and history (org-branch re-carry) #17324 head40a3731ad5e5542b90a947b4fe203de423f9bd5a).Amendment decision recorded: the composite scope is canonical; #16768's purge/generation guards are retained but fed by the composite scope;
Comfy.Agent.ThreadOwnerIdis dropped in favour of the composite key; a single telemetry slugagent_session_storage_access_failedis used; whichever of #16768/#17324 lands second rebases onto the first.Evidence
282fdcbdd845c3a7d809ad2b1b4b0535acfc45ea(local integration bare repo; absent fromorigin/mainb632879f33c44d55414e84010b82a7095c1c4572and from PR heads FE-2057: purge state when identity changes #167680ab384b2cbbf39099618bce7874b5a2c8fc9a30e, fix(agent): ignore stale ask answer failures #1694972d3c2cfb61793b3203b17933a948510a8216e3c, FE-2057: fix: isolate agent sessions and history (org-branch re-carry) #1732440a3731ad5e5542b90a947b4fe203de423f9bd5a).pnpm adr:checkpasses on this branch; lint-stagedoxfmtran in pre-commit.origin/main(2026-09-11):useAgentSession.tsuseAgentSession.ts,agentWorkflowTabBindingStore.tsAgentPanelRoot.vue,AgentPanelRoot.test.ts,useComposer.tsAgentPanelRoot.vue,useAgentSession.ts,useAgentSession.test.ts,agentChatHistoryStore.tsuseAgentSession.tsuseAgentSession.test.tsDocs-only change; no runtime behaviour affected.
Refs #16768 #16840 #16949 #17324 (supersedes #16393).
Authored by an agent (role: hard-problem solver) on behalf of christian-byrne.