Repository navigation
test: add undo/redo e2e coverage for the ECS migration QA plan #17455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christian-byrne
wants to merge
42
commits into
main
Choose a base branch
from
test/ecs-qa-undo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
8c4c5d4
test: add undo/redo e2e coverage for the ECS migration QA plan
christian-byrne f5eed59
test: assert undo is a no-op in fresh tab and Tab A history survives …
christian-byrne 6e5e70e
test: move undo coverage under workflow ownership
christian-byrne f962d15
test: assert every mixed edit after each history step
christian-byrne 6377430
test: clean saved workflows after undo scenarios
christian-byrne c4e4c28
test: read tab undo positions through node reference
christian-byrne 0bf64b6
test: narrow newly created workflow tab explicitly
christian-byrne 4da6c67
test: load only each undo scenario fixture
christian-byrne 2cd52cf
test: tag widget and Vue undo scenarios
christian-byrne dd27386
test: let Vue fixture own mixed history setup
christian-byrne f375d78
test: enter the numeric editor before recording mixed undo history
christian-byrne 38e7e5b
test: complete renderer and tab history coverage
christian-byrne bf171a0
test: cover compound ECS undo history
christian-byrne 84f229e
test: keep undo redo link targets separated
christian-byrne 94fd4cc
test: assert contained node group movement
christian-byrne b57b5e5
test: await history before snapshots
christian-byrne c0b38b0
test: await workflow tab switches
christian-byrne 2211d9c
test: use group drag action
christian-byrne ee53aa2
test: share Vue number commit action
christian-byrne 90a1aa3
test: seed workflow settings at startup
christian-byrne f9b063b
test: name undo scenario phases
christian-byrne bdea171
test: rely on Vue node fixture settings
christian-byrne 5385a8c
test: use input link count assertions
christian-byrne 7cfae95
test: remove duplicate final snapshot check
christian-byrne 69b6f9b
test: remove duplicate tab graph snapshots
christian-byrne 76ea038
fixup! test: share Vue number commit action
christian-byrne 3e964ff
fixup! test: await history before snapshots
christian-byrne 6c413d3
fixup! test: name undo scenario phases
christian-byrne 29f6445
fixup! test: await history before snapshots
christian-byrne 00e3bfd
fixup! test: await history before snapshots
christian-byrne e157306
fixup! test: share Vue number commit action
christian-byrne 06473e2
fixup! test: name undo scenario phases
christian-byrne fce69eb
test: finish undo redo scenario phases
ampagent b6c9092
[automated] Apply ESLint and Oxfmt fixes
actions-user 84a9079
test: add semantic undo and redo steps
christian-byrne a1e2bfe
test: use maintained empty canvas helper
christian-byrne 1be80b8
test: remove premature widget frame wait
christian-byrne 5bb2f57
test: remove redundant fresh-tab comment
christian-byrne 3490d0e
test: keep empty canvas click clear of overlays
christian-byrne ea360f3
test: scope undo click coordinates to scenario
christian-byrne 8439337
test: stabilize undo renderer interactions
christian-byrne 7c073fe
test: handle repeated undo workflow saves
christian-byrne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P3] Keep
clickEmptySpace()parameterless and use the existingcanvasOps.click(position)for the three scenario-specific coordinates. Both methods otherwise perform the same canvas click plus next-frame wait, so this optional parameter creates two APIs for identical behavior and lets a method namedclickEmptySpaceaccept any point.