Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
8c4c5d4
test: add undo/redo e2e coverage for the ECS migration QA plan
christian-byrne Sep 11, 2026
f5eed59
test: assert undo is a no-op in fresh tab and Tab A history survives …
christian-byrne Sep 11, 2026
6e5e70e
test: move undo coverage under workflow ownership
christian-byrne Sep 11, 2026
f962d15
test: assert every mixed edit after each history step
christian-byrne Sep 11, 2026
6377430
test: clean saved workflows after undo scenarios
christian-byrne Sep 11, 2026
c4e4c28
test: read tab undo positions through node reference
christian-byrne Sep 11, 2026
0bf64b6
test: narrow newly created workflow tab explicitly
christian-byrne Sep 11, 2026
4da6c67
test: load only each undo scenario fixture
christian-byrne Sep 11, 2026
2cd52cf
test: tag widget and Vue undo scenarios
christian-byrne Sep 11, 2026
dd27386
test: let Vue fixture own mixed history setup
christian-byrne Sep 12, 2026
f375d78
test: enter the numeric editor before recording mixed undo history
christian-byrne Sep 12, 2026
38e7e5b
test: complete renderer and tab history coverage
christian-byrne Sep 12, 2026
bf171a0
test: cover compound ECS undo history
christian-byrne Sep 12, 2026
84f229e
test: keep undo redo link targets separated
christian-byrne Sep 12, 2026
94fd4cc
test: assert contained node group movement
christian-byrne Sep 12, 2026
b57b5e5
test: await history before snapshots
christian-byrne Sep 12, 2026
c0b38b0
test: await workflow tab switches
christian-byrne Sep 12, 2026
2211d9c
test: use group drag action
christian-byrne Sep 12, 2026
ee53aa2
test: share Vue number commit action
christian-byrne Sep 12, 2026
90a1aa3
test: seed workflow settings at startup
christian-byrne Sep 12, 2026
f9b063b
test: name undo scenario phases
christian-byrne Sep 12, 2026
bdea171
test: rely on Vue node fixture settings
christian-byrne Sep 12, 2026
5385a8c
test: use input link count assertions
christian-byrne Sep 12, 2026
7cfae95
test: remove duplicate final snapshot check
christian-byrne Sep 12, 2026
69b6f9b
test: remove duplicate tab graph snapshots
christian-byrne Sep 12, 2026
76ea038
fixup! test: share Vue number commit action
christian-byrne Sep 12, 2026
3e964ff
fixup! test: await history before snapshots
christian-byrne Sep 12, 2026
6c413d3
fixup! test: name undo scenario phases
christian-byrne Sep 12, 2026
29f6445
fixup! test: await history before snapshots
christian-byrne Sep 12, 2026
00e3bfd
fixup! test: await history before snapshots
christian-byrne Sep 12, 2026
e157306
fixup! test: share Vue number commit action
christian-byrne Sep 12, 2026
06473e2
fixup! test: name undo scenario phases
christian-byrne Sep 12, 2026
fce69eb
test: finish undo redo scenario phases
ampagent Sep 13, 2026
b6c9092
[automated] Apply ESLint and Oxfmt fixes
actions-user Sep 13, 2026
84a9079
test: add semantic undo and redo steps
christian-byrne Sep 13, 2026
a1e2bfe
test: use maintained empty canvas helper
christian-byrne Sep 13, 2026
1be80b8
test: remove premature widget frame wait
christian-byrne Sep 13, 2026
5bb2f57
test: remove redundant fresh-tab comment
christian-byrne Sep 13, 2026
3490d0e
test: keep empty canvas click clear of overlays
christian-byrne Sep 13, 2026
ea360f3
test: scope undo click coordinates to scenario
christian-byrne Sep 13, 2026
8439337
test: stabilize undo renderer interactions
christian-byrne Sep 13, 2026
7c073fe
test: handle repeated undo workflow saves
christian-byrne Sep 13, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions browser_tests/fixtures/VueNodeHelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,34 @@ export class VueNodeHelpers {
}
}

async editAndCommitNumber(
nodeTitle: string,
widgetName: string,
value: string
): Promise<void> {
const nodeId = await this.getNodeIdByTitle(nodeTitle)
const node = this.getNodeLocator(nodeId)
const widget = node.getByLabel(widgetName, { exact: true })
const { input } = this.getInputNumberControls(widget)
const fixture = new VueNodeFixture(node)
await widget.click()
await input.fill(value)
await input.press('Enter')
await expect
.poll(() =>
this.page.evaluate(
({ nodeId, widgetName }) =>
window
.app!.graph.getNodeById(nodeId)
?.widgets?.find((widget) => widget.name === widgetName)?.value,
{ nodeId: toNodeId(nodeId), widgetName }
)
)
.toBe(Number(value))
await fixture.title.click()
await expect(input).toHaveValue(value)
}

/**
* Locator for the Enter Subgraph footer button.
*/
Expand Down
2 changes: 1 addition & 1 deletion browser_tests/fixtures/components/Topbar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ export class Topbar {
await this.menuLocator.waitFor({ state: 'visible' })
// Re-hover on top-level menu to trigger submenu
await topLevelMenu.hover()
await submenu.waitFor({ state: 'visible', timeout: 1000 })
await submenu.waitFor({ state: 'visible' })
}

let currentMenu = topLevelMenu
Expand Down
6 changes: 4 additions & 2 deletions browser_tests/fixtures/helpers/CanvasHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,10 @@ export class CanvasHelper {
await nextFrame(this.page)
}

async clickEmptySpace(): Promise<void> {
await this.canvas.click({ position: DefaultGraphPositions.emptySpaceClick })
async clickEmptySpace(
position: Position = DefaultGraphPositions.emptySpaceClick

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] Keep clickEmptySpace() parameterless and use the existing canvasOps.click(position) for the three scenario-specific coordinates. Both methods otherwise perform the same canvas click plus next-frame wait, so this optional parameter creates two APIs for identical behavior and lets a method named clickEmptySpace accept any point.

): Promise<void> {
await this.canvas.click({ position })
await nextFrame(this.page)
}

Expand Down
Loading
Loading