Repository navigation
fix: reject malformed subgraph links before unpacking (1.53 backport) - #17405
Conversation
Fixes #16335 - Unpacking a subgraph that contains a malformed link (input link missing its output slot) no longer half-applies the mutation; unpack is rejected up front and the graph is left unchanged. - Preflight runs before `beforeChange()`, so no change event fires and no undo entry is created for a rejected unpack. - Red/green regression test covers both the malformed-link rejection and the intact-subgraph success path. <details><summary>Full context for agent readers</summary> **Root cause:** `LGraph.unpackSubgraph()` began mutating the parent graph (`beforeChange()`, node removal, link re-creation) before validating the subgraph's internal links. A link whose `origin_slot` did not resolve to an output caused a throw mid-mutation, leaving the graph in a partially unpacked state. **Fix:** `unpackSubgraph()` now returns `boolean`. It calls a private `_findMalformedSubgraphLink(subgraphNode)` first; if a malformed link is found it logs a `console.error` and returns `false` without touching the graph. Otherwise it proceeds through the existing implementation (`_unpackSubgraphImpl`) and returns `true`. Existing callers ignore the return value, so this is non-breaking. **Tests:** `src/lib/litegraph/src/subgraph/SubgraphConversion.test.ts` - malformed link → returns `false`, node count / link count / subgraph node all untouched, no `beforeChange` emitted - intact subgraph → returns `true`, unpack completes as before **Verification:** `pnpm vitest run src/lib/litegraph/src/subgraph/SubgraphConversion.test.ts` 13/13 pass; `pnpm oxlint` 0 errors; `pnpm knip` clean; `pnpm typecheck` clean. **Backport:** carries `needs-backport`, `core/1.53`, `cloud/1.53` per ECS release policy. <!-- authored-by:agent supreme-operator w3-520-followup --> </details> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> (cherry picked from commit c8ddb60)
🎭 Playwright: ✅ 1894 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-11T01:22:54.426Z",
"gitSha": "4670b91b622fffdf1fc5c26ff7e6840c66bc4e0f",
"branch": "christian-byrne/backport-17330-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.033999999982,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.155,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.529,
"heapDeltaBytes": -12089936,
"heapUsedBytes": 58528384,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.489999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2070.9000000000515,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.034000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.3259999999999,
"heapDeltaBytes": -11988612,
"heapUsedBytes": 57647520,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.194999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2048.1060000000184,
"styleRecalcs": 80,
"styleRecalcDurationMs": 51.774,
"layouts": 14,
"layoutDurationMs": 5.181,
"taskDurationMs": 1059.147,
"heapDeltaBytes": 4393468,
"heapUsedBytes": 74797876,
"domNodes": -284,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 169.569,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1889.0729999999394,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.521,
"layouts": 14,
"layoutDurationMs": 4.732,
"taskDurationMs": 888.1569999999998,
"heapDeltaBytes": -8873880,
"heapUsedBytes": 61785240,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 145.66500000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.8600000000147,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.168,
"layouts": 6,
"layoutDurationMs": 1.1549999999999998,
"taskDurationMs": 365.381,
"heapDeltaBytes": 4468256,
"heapUsedBytes": 74994856,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.181,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.5780000000177,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.907999999999998,
"layouts": 6,
"layoutDurationMs": 1.309,
"taskDurationMs": 361.663,
"heapDeltaBytes": 4745780,
"heapUsedBytes": 75099416,
"domNodes": 75,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.906,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 678.1159999999886,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.309999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.01000000000005,
"heapDeltaBytes": 17867436,
"heapUsedBytes": 88057076,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 160.145,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 694.5450000000619,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.386999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.13300000000004,
"heapDeltaBytes": -7822384,
"heapUsedBytes": 62787668,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 160.56599999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.8999999999837,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.9830000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.926,
"heapDeltaBytes": -13816056,
"heapUsedBytes": 87231452,
"domNodes": -268,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 34.82299999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2064.885000000004,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.135000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.946,
"heapDeltaBytes": -13516980,
"heapUsedBytes": 87057364,
"domNodes": -272,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 35.440999999999995,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2226.0109999999713,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.134,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1590.0030000000002,
"heapDeltaBytes": 20805996,
"heapUsedBytes": 87062028,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 765.428,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2235.3950000000395,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.377000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1624.504,
"heapDeltaBytes": 19052560,
"heapUsedBytes": 84479148,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 780.267,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3561.378999999988,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.289,
"layouts": 60,
"layoutDurationMs": 13.259,
"taskDurationMs": 1735.652,
"heapDeltaBytes": 9190320,
"heapUsedBytes": 75646608,
"domNodes": -282,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 771.788,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3800.161000000003,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.553999999999998,
"layouts": 60,
"layoutDurationMs": 13.539000000000003,
"taskDurationMs": 1878.4870000000003,
"heapDeltaBytes": 10403828,
"heapUsedBytes": 76497392,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 837.8520000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3119.2780000000084,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.405,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1963.517,
"heapDeltaBytes": 23076092,
"heapUsedBytes": 92633872,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 960.0210000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3112.7310000000534,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.8350000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2030.9619999999998,
"heapDeltaBytes": 18552768,
"heapUsedBytes": 85976948,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 999.037,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.3640000000155,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.757,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.368,
"heapDeltaBytes": -15462640,
"heapUsedBytes": 87008920,
"domNodes": -269,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 39.183,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2000.0239999999394,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.9039999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.484,
"heapDeltaBytes": 22134544,
"heapUsedBytes": 87978200,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.001000000000005,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.9300000000144,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.395999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.15599999999995,
"heapDeltaBytes": 14820576,
"heapUsedBytes": 87480188,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 139.23999999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.9820000000827,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.320999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.25300000000004,
"heapDeltaBytes": 14818792,
"heapUsedBytes": 87624548,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.541,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.2209999999923,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.914000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.562,
"heapDeltaBytes": -122904,
"heapUsedBytes": 71179440,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.132000000000001,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2030.3669999999556,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.105,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.85699999999997,
"heapDeltaBytes": -6184616,
"heapUsedBytes": 66410124,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.496999999999998,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.7559999999958,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.327999999999996,
"layouts": 18,
"layoutDurationMs": 6.0809999999999995,
"taskDurationMs": 863.769,
"heapDeltaBytes": -11362220,
"heapUsedBytes": 61293824,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 111.297,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1774.2359999999735,
"styleRecalcs": 79,
"styleRecalcDurationMs": 41.38,
"layouts": 18,
"layoutDurationMs": 5.785,
"taskDurationMs": 847.5250000000001,
"heapDeltaBytes": -11687736,
"heapUsedBytes": 60706300,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 107.981,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.7489999999952,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.782000000000004,
"layouts": 13,
"layoutDurationMs": 14.829000000000002,
"taskDurationMs": 989.593,
"heapDeltaBytes": -1790268,
"heapUsedBytes": 95401252,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.422000000000004,
"eventListeners": 2381,
"totalBlockingTimeMs": 126,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8534.478999999976,
"styleRecalcs": 247,
"styleRecalcDurationMs": 42.481,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5956.918,
"heapDeltaBytes": 9588052,
"heapUsedBytes": 85128100,
"domNodes": -273,
"jsHeapTotalBytes": -1167360,
"scriptDurationMs": 2627.824,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9432.531999999923,
"styleRecalcs": 246,
"styleRecalcDurationMs": 40.660000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6438.283,
"heapDeltaBytes": -2490524,
"heapUsedBytes": 97978288,
"domNodes": -270,
"jsHeapTotalBytes": 1720320,
"scriptDurationMs": 2912.743,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18019.19700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17672.378,
"heapDeltaBytes": -43841984,
"heapUsedBytes": 169719788,
"domNodes": -6548,
"jsHeapTotalBytes": -8146944,
"scriptDurationMs": 298.57,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18095.429999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17473.069,
"heapDeltaBytes": -37684148,
"heapUsedBytes": 175888788,
"domNodes": -6548,
"jsHeapTotalBytes": -6574080,
"scriptDurationMs": 300.942,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22303.567000000043,
"styleRecalcs": 164,
"styleRecalcDurationMs": 22.56600000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22038.243000000002,
"heapDeltaBytes": -12675684,
"heapUsedBytes": 189904604,
"domNodes": -6548,
"jsHeapTotalBytes": 2809856,
"scriptDurationMs": 916.5779999999999,
"eventListeners": -7467,
"totalBlockingTimeMs": 244,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22139.87499999996,
"styleRecalcs": 166,
"styleRecalcDurationMs": 20.353999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21884.296,
"heapDeltaBytes": -19667692,
"heapUsedBytes": 190077968,
"domNodes": -6548,
"jsHeapTotalBytes": -5701632,
"scriptDurationMs": 912.292,
"eventListeners": -7467,
"totalBlockingTimeMs": 145,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6597.662000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.567,
"layouts": 20,
"layoutDurationMs": 26.257,
"taskDurationMs": 6541.758000000001,
"heapDeltaBytes": -5128612,
"heapUsedBytes": 198019388,
"domNodes": -6548,
"jsHeapTotalBytes": 20967424,
"scriptDurationMs": 127.173,
"eventListeners": -7471,
"totalBlockingTimeMs": 435,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6583.429000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.558,
"layouts": 20,
"layoutDurationMs": 24.881999999999987,
"taskDurationMs": 6497.888000000001,
"heapDeltaBytes": -36019168,
"heapUsedBytes": 177612912,
"domNodes": -6548,
"jsHeapTotalBytes": -974848,
"scriptDurationMs": 122.914,
"eventListeners": -7469,
"totalBlockingTimeMs": 450,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 119.23500000000331,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.421,
"layouts": 2,
"layoutDurationMs": 1.461,
"taskDurationMs": 79.39999999999999,
"heapDeltaBytes": 3150000,
"heapUsedBytes": 71567212,
"domNodes": 132,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.061,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 105.85900000000947,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.512,
"layouts": 2,
"layoutDurationMs": 1.3239999999999998,
"taskDurationMs": 77.81200000000001,
"heapDeltaBytes": 3124728,
"heapUsedBytes": 71627156,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.138999999999999,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.53 #17405 +/- ##
=============================================
+ Coverage 83.34% 83.35% +0.01%
=============================================
Files 2025 2025
Lines 117262 117351 +89
Branches 32540 32572 +32
=============================================
+ Hits 97730 97823 +93
+ Misses 19172 19170 -2
+ Partials 360 358 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 28 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #17330 to the 1.53 release line.
Full context for agent readers
Source: #17330 (merged to main as c8ddb60).
Conflict resolution on this branch:
useSubgraphOperations.ts: kept the 1.53let changed/if (changed) workflowStore.activeWorkflow?.changeTracker.captureCanvasState()structure; only the malformed-link guard was ported.SubgraphConversion.test.ts: kept the 1.53-onlyuseWidgetValueStoreimport. The new assertion usestoBeUndefined()rather thantoBeNull()becauseLGraph.getNodeByIdreturnsundefinedon 1.53 (main returnsnull). No change togetNodeByIditself on this branch.Verification:
pnpm typecheckclean;SubgraphConversion.test.ts25/25 passing in the worktree.