Repository navigation
feat(billing): collect billing address in embedded Stripe checkout - #17397
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1994 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-15T11:13:03.385Z",
"gitSha": "5f798e811474aa6a170272d0f70a66ec804b0155",
"branch": "luke/collect-billing-address-embedded-checkout",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2019.7860000000105,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.904,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.78999999999996,
"heapDeltaBytes": -1897252,
"heapUsedBytes": 60113324,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.2150000000000025,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2004.9860000000308,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.220000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.524,
"heapDeltaBytes": -5185120,
"heapUsedBytes": 56887052,
"domNodes": -264,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.700000000000002,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1768.2970000000182,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.018,
"layouts": 14,
"layoutDurationMs": 4.239000000000001,
"taskDurationMs": 831.492,
"heapDeltaBytes": 7308832,
"heapUsedBytes": 69579480,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 162.329,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1839.4609999999147,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.4,
"layouts": 14,
"layoutDurationMs": 4.583,
"taskDurationMs": 819.4189999999999,
"heapDeltaBytes": 9840488,
"heapUsedBytes": 72130216,
"domNodes": -264,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 159.988,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.4420000000246,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.087999999999997,
"layouts": 6,
"layoutDurationMs": 1.142,
"taskDurationMs": 356.135,
"heapDeltaBytes": 2194948,
"heapUsedBytes": 64451096,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.303999999999995,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.8519999999799,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.441999999999997,
"layouts": 6,
"layoutDurationMs": 1.189,
"taskDurationMs": 353.31199999999995,
"heapDeltaBytes": 2217656,
"heapUsedBytes": 64295820,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.889000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 653.6739999999668,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.8999999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.73600000000005,
"heapDeltaBytes": 17991080,
"heapUsedBytes": 79657348,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 175.05499999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 617.7030000000059,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.957999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.49099999999993,
"heapDeltaBytes": 17892028,
"heapUsedBytes": 80053592,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 166.433,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2020.922999999982,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.2520000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.582,
"heapDeltaBytes": 4441340,
"heapUsedBytes": 83572480,
"domNodes": -247,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 37.00800000000001,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.6730000000307,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.607000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.53600000000006,
"heapDeltaBytes": 3632680,
"heapUsedBytes": 82588672,
"domNodes": -245,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 33.973000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2288.8659999999845,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.714000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1634.175,
"heapDeltaBytes": 14947620,
"heapUsedBytes": 79271972,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 870.2959999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2209.457999999927,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.214999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1604.5790000000002,
"heapDeltaBytes": -832056,
"heapUsedBytes": 79341740,
"domNodes": -249,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 826.3900000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3555.088000000012,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.782000000000002,
"layouts": 60,
"layoutDurationMs": 13.003999999999998,
"taskDurationMs": 1689.7530000000002,
"heapDeltaBytes": 7238948,
"heapUsedBytes": 73804056,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 789.828,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3487.707999999998,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.289000000000001,
"layouts": 60,
"layoutDurationMs": 12.746999999999998,
"taskDurationMs": 1654.92,
"heapDeltaBytes": 8401888,
"heapUsedBytes": 74399596,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 787.5989999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3130.426,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.554000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1972.3829999999998,
"heapDeltaBytes": -4240884,
"heapUsedBytes": 79313036,
"domNodes": -258,
"jsHeapTotalBytes": 671744,
"scriptDurationMs": 999.9299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3020.108999999934,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.437000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1897.361,
"heapDeltaBytes": 16139928,
"heapUsedBytes": 81789764,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 966.1769999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.7600000000093,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.7910000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.3800000000001,
"heapDeltaBytes": 20014260,
"heapUsedBytes": 84953832,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.932,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2025.716999999986,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.562999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.2299999999999,
"heapDeltaBytes": -3130796,
"heapUsedBytes": 83645296,
"domNodes": -251,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 37.11600000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.7430000000077,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.081999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.315,
"heapDeltaBytes": 14004432,
"heapUsedBytes": 77329912,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.299,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 548.9269999999351,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.399000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.9030000000001,
"heapDeltaBytes": 13994448,
"heapUsedBytes": 76991284,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 141.458,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1989.912000000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.322999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.64,
"heapDeltaBytes": 14398140,
"heapUsedBytes": 77402444,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.8229999999999995,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1995.632999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.347999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.38500000000005,
"heapDeltaBytes": -2712832,
"heapUsedBytes": 60219084,
"domNodes": -277,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.950999999999999,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.5469999999768,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.273,
"layouts": 18,
"layoutDurationMs": 5.739,
"taskDurationMs": 793.956,
"heapDeltaBytes": 13356856,
"heapUsedBytes": 76428144,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 111.37600000000002,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.955999999962,
"styleRecalcs": 78,
"styleRecalcDurationMs": 25.678,
"layouts": 18,
"layoutDurationMs": 5.119000000000001,
"taskDurationMs": 748.5509999999999,
"heapDeltaBytes": -3570464,
"heapUsedBytes": 60047236,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 104.92599999999999,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 916.2680000000591,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.038999999999994,
"layouts": 5,
"layoutDurationMs": 12.792000000000002,
"taskDurationMs": 700.2590000000002,
"heapDeltaBytes": -6404760,
"heapUsedBytes": 80824304,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 25.565000000000005,
"eventListeners": 2385,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8363.995999999986,
"styleRecalcs": 246,
"styleRecalcDurationMs": 36.56,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5761.790999999999,
"heapDeltaBytes": -4516512,
"heapUsedBytes": 75230088,
"domNodes": -250,
"jsHeapTotalBytes": -307200,
"scriptDurationMs": 2744.9629999999997,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8310.277000000042,
"styleRecalcs": 246,
"styleRecalcDurationMs": 32.525,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5680.0599999999995,
"heapDeltaBytes": -12749016,
"heapUsedBytes": 66783192,
"domNodes": -250,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 2749.7039999999997,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16910.409000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16403.257,
"heapDeltaBytes": -30015888,
"heapUsedBytes": 185313412,
"domNodes": -6542,
"jsHeapTotalBytes": 319488,
"scriptDurationMs": 291.05899999999997,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17348.239000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16960.308,
"heapDeltaBytes": -27096308,
"heapUsedBytes": 173941596,
"domNodes": -6542,
"jsHeapTotalBytes": -1630208,
"scriptDurationMs": 283.836,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20366.41100000003,
"styleRecalcs": 167,
"styleRecalcDurationMs": 16.825000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20013.072,
"heapDeltaBytes": -33314232,
"heapUsedBytes": 187330356,
"domNodes": -6542,
"jsHeapTotalBytes": -3997696,
"scriptDurationMs": 857.408,
"eventListeners": -7474,
"totalBlockingTimeMs": 39,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16047.46799999998,
"styleRecalcs": 90,
"styleRecalcDurationMs": 14.416000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15622.402,
"heapDeltaBytes": -26052616,
"heapUsedBytes": 175119104,
"domNodes": -6542,
"jsHeapTotalBytes": 3612672,
"scriptDurationMs": 851.862,
"eventListeners": -7476,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6118.843999999967,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.57600000000001,
"layouts": 20,
"layoutDurationMs": 22.53200000000001,
"taskDurationMs": 5996.215,
"heapDeltaBytes": -8179320,
"heapUsedBytes": 193470716,
"domNodes": -6542,
"jsHeapTotalBytes": 19865600,
"scriptDurationMs": 111.30299999999998,
"eventListeners": -7476,
"totalBlockingTimeMs": 357,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6220.237999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.30999999999999,
"layouts": 20,
"layoutDurationMs": 23.28200000000001,
"taskDurationMs": 6122.88,
"heapDeltaBytes": -21595152,
"heapUsedBytes": 172581100,
"domNodes": -6542,
"jsHeapTotalBytes": 18292736,
"scriptDurationMs": 119.83500000000001,
"eventListeners": -7478,
"totalBlockingTimeMs": 435,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8418.632000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8075.1410000000005,
"heapDeltaBytes": -10926984,
"heapUsedBytes": 185349304,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 154.35699999999997,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8881.01800000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8570.670999999998,
"heapDeltaBytes": 24825860,
"heapUsedBytes": 183380012,
"domNodes": 0,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 148.6430000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33666666666674,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 135.12299999990773,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.112,
"layouts": 3,
"layoutDurationMs": 1.116,
"taskDurationMs": 99.46,
"heapDeltaBytes": 3298120,
"heapUsedBytes": 64821484,
"domNodes": 114,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.92,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 126.02700000002187,
"styleRecalcs": 7,
"styleRecalcDurationMs": 17.163,
"layouts": 3,
"layoutDurationMs": 1.8290000000000002,
"taskDurationMs": 93.43499999999999,
"heapDeltaBytes": 3030208,
"heapUsedBytes": 64838212,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.749999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## feat/embedded-checkout-journey-instrumentation #17397 +/- ##
==================================================================================
- Coverage 83.79% 83.76% -0.03%
==================================================================================
Files 2133 2133
Lines 124523 124538 +15
Branches 33267 31428 -1839
==================================================================================
- Hits 104339 104318 -21
- Misses 20002 20038 +36
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 19 files with indirect coverage changes 🚀 New features to boost your workflow:
|
50fd808 to
fab14fe
Compare
a802771 to
56c6b25
Compare
7907047 to
1189efc
Compare
|
Taking ownership of this PR from @luke-mino-altherr. Rebased onto the rewritten base branch and resolved the one review finding I had on it. Rebase. The branch was stacked on an older revision of The Address Element was indistinguishable from the Payment Element in telemetry. This is the open item the description raised under "Product decisions to confirm", and I think reusing the phases as-is costs more than it saves. Both elements share one Elements group, so both fire Rather than adding address-specific phases (which would fork the funnel), both phases now carry a required Verified, not changed. Gates: Note that this still targets |
1189efc to
497f7dd
Compare
dante01yoon
left a comment
There was a problem hiding this comment.
CI green on 497f7dd, mergeStateStatus: CLEAN.
fallow— passes. Two findings this PR introduced against its base are resolved: theonMountedarrow (CRAP 31.6) after extracting each element's mount, and the duplicated init-failure handling.complexity_introduced: 0. The one remainingstyling_introducedentry is theicon-[lucide--shield-check]iconify class atwarnseverity — the repo's standard iconify pattern, pre-existing content the diff only shifted, and not a gating tier.test,lint-and-format,codecov/patch, and the full Playwright suite (16 chromium shards pluscloud,mobile-chrome,mobile-safari,chromium-0.5x,chromium-2x) all green.
Regression surface I checked specifically:
- The
onMountedextraction is behaviour-preserving with two deliberate simplifications: the!publishableKeyand!paymentMethodConfigurationIdguards are merged (same outcome, same telemetry), andfailElementInit()now checksisUnmountedin every branch rather than only the post-awaitone. The first two guards run before anyawait, so that check is never false there — it just removes an asymmetry. - Making
elementrequired on the twopayment_element_*phases means a future element cannot mount untagged without failing the build; all six existing emit sites were named by the compiler, not by hand. elements.submit()validating every mounted element in the group is what makes the "no extra gate needed" claim hold — confirmed in the submit path rather than taken from the description.
Merge order: this targets feat/embedded-checkout-journey-instrumentation, so #17348 goes first.
Disclosure: I took this PR over from @luke-mino-altherr and wrote the last two commits, so this approval reflects verification rather than independent review of my own changes.
7970c6f to
8492c33
Compare
f50c608 to
4218815
Compare
The embedded PaymentElement collected no billing address, so cards reached
issuers with no AVS data (address_line1_check / address_postal_code_check
unchecked). That raised declines for legitimate customers on the
initial_subscription path and removed the anti-abuse friction the hosted
Checkout page had.
Add a Stripe Address Element in billing mode, created from the same Elements
group as the PaymentElement. In billing mode every address field is required,
and because both share one Elements group createConfirmationToken folds the
address into the token's billing_details automatically — so the resulting
PaymentIntent has billing_details.address populated and AVS runs. The existing
elements.submit() gate already validates the mounted Address Element, blocking
token creation until the address is complete.
The subscription mode, off_session setupFutureUsage, paymentMethodConfiguration,
terms:{card:'never'}, theme-aware appearance (shared across the Elements group),
and redirect/hosted control path are all unchanged. The Address Element mirrors
the PaymentElement's ready/loaderror telemetry handlers and is destroyed on
unmount.
…hases The Address Element shares the Elements group with the Payment Element, so both report 'ready' and 'loaderror'. Without a discriminator the funnel counts payment_element_ready twice per journey and cannot attribute a mount failure, which defeats the arm comparison these phases exist for.
Adding the Address Element pushed the 158-line onMounted past the complexity gate; each element now owns its creation, mount and telemetry wiring.
…cted The Payment Element defaults fields.billingDetails to 'auto', so card also rendered its own country and postal inputs above the new Address Element. A customer filling the two differently would send the issuer an address that contradicts the one collected for AVS — the opposite of this change's purpose.
4218815 to
93d34d9
Compare
e448f20
into
feat/embedded-checkout-journey-instrumentation
Linear: FE-2195
Why
Part of the embedded-checkout rollback/re-ramp work. The embedded PaymentElement (behind
embedded_checked_enabled) collected no billing address, so cards reached issuers with no AVS data (address_line1_check/address_postal_code_check= unchecked). RCA of raw Stripe PaymentIntents tied the address-lessinitial_subscriptionpath to a spike ingeneric_decline/do_not_honordeclines and to the loss of the anti-abuse friction the hosted Checkout page had (a Macau/HK card-testing attack). This restores full-address collection so AVS data flows to the issuer and Radar.What
UnifiedStripePaymentSelector.vue, created from the sameelementsgroup as the PaymentElement.elementsgroup,stripe.createConfirmationToken({ elements })automatically folds the address into the token'sbilling_details(verified against Stripe docs for@stripe/stripe-js9.12.x). The resulting PaymentIntent therefore hasbilling_details.addresspopulated and AVS runs.elements.submit()already validates the mounted Address Element — so token creation is blocked until the address is complete. No extra gate needed.ready/loaderrortelemetry handlers and is destroyed on unmount.subscription.preview.billingAddressheading (src/locales/en/main.json).Unchanged (control path preserved)
mode:'subscription',setupFutureUsage:'off_session',paymentMethodConfiguration,terms:{card:'never'}, the theme-awareappearance(shared across the Elements group, so the address form inherits styling), and the redirect/hosted checkout path.Product decisions to confirm
payment_element_ready/payment_element_failed(element_phase: 'mount') phases rather than introducing address-specific events, per the "preserve existing phases / mirror the handlers" guidance. Per-journey funnel analysis dedupes, but rawpayment_element_readycounts can now fire twice per journey.Base branch
Targets
feat/embedded-checkout-journey-instrumentation— the embedded-checkout code lives there, not onmain.Tests
UnifiedStripePaymentSelector.test.ts: Address Element created in billing mode from the shared group, submission blocked until the address is valid, addressloaderrortelemetry, both elements destroyed on unmount, and the existing confirmation-token flow still emitsconfirm.pnpm test:unit(24 pass),pnpm typecheck,pnpm lint,pnpm knip,pnpm build.