Skip to content

fix(billing): pay waits for the payment element to actually paint - #17343

Closed
comfydesigner wants to merge 1 commit into
comfydesigner/capture-provider-unreachablefrom
comfydesigner/pay-disabled-until-ready
Closed

comfydesigner wants to merge 1 commit into
comfydesigner/capture-provider-unreachablefrom
comfydesigner/pay-disabled-until-ready

Conversation

@comfydesigner

Copy link
Copy Markdown
Contributor

On a cold load, Pay and subscribe enabled the moment Stripe Elements was constructed — before the payment element's iframe painted — so a fast click landed on a blank form region. The button now waits for Stripe's own ready event, and the legal fine print below it waits the same way (nothing to pay with, nothing to agree to).

  • The selector tracks ready from the mounted element and folds it into the pay CTA's disabled state; failure cleanups and retries reset it, so a remounted element re-earns the enabled state.
  • A new elementReadyChange emit lets the host hold SubscriptionTermsNote until the form is real — closing the during-load window flagged in review on feat(billing): tell the customer payments are down before they type a card #16846 and deliberately scoped to this change.
  • Amount changes flow through elements.update() without a remount, so ready survives re-quotes.

Tests: pay stays disabled until ready and drops back on element failure; the retry path re-earns enabled; the terms note follows ready/unreachable through the full round trip.

Stacked on #16846 (same file, same lifecycle); diff is against that branch.

Path notes

  • Ready gating applies only to the selector's own CTA. Saved-method and zero-dollar paths render their own pay controls in the host and mount no element — unchanged.
  • UnifiedStripePaymentSelector has exactly one host today (SubscriptionAddPaymentPreviewWorkspace); the new emit is additive for any future host.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e9181816-222b-4eea-9b41-dcd73347e47d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1940 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1919 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/10/2026, 05:36:42 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 141ms TBT · 95.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.8 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 164.0 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 48ms TBT · 161.2 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 244ms TBT · 174.9 MB heap
vue-zoom-out-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 161.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 472ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 56.1 MB
canvas-idle: DOM nodes -265
canvas-idle: event listeners -185
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 828ms
canvas-mouse-sweep: script duration 150ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.8 MB
canvas-mouse-sweep: DOM nodes -263
canvas-mouse-sweep: event listeners -171
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 357ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 61.3 MB
canvas-zoom-sweep: DOM nodes 74
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 438ms
dom-widget-clipping: script duration 154ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 76.4 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 592ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.4 MB
large-graph-idle: DOM nodes -247
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1574ms
large-graph-pan: script duration 770ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 77.2 MB
large-graph-pan: DOM nodes -125
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1674ms
large-graph-zoom: script duration 739ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.0 MB
large-graph-zoom: DOM nodes -129
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1916ms
legacy-node-drag: script duration 911ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 84.0 MB
legacy-node-drag: DOM nodes -131
legacy-node-drag: event listeners 94
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 590ms
minimap-idle: script duration 38ms
minimap-idle: TBT 0ms
minimap-idle: heap used 78.4 MB
minimap-idle: DOM nodes -253
minimap-idle: event listeners -184
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 394ms
subgraph-dom-widget-clipping: script duration 135ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 73.1 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 440ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.1 MB
subgraph-idle: DOM nodes -275
subgraph-idle: event listeners -217
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 30ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 850ms
subgraph-mouse-sweep: script duration 110ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 73.6 MB
subgraph-mouse-sweep: DOM nodes -273
subgraph-mouse-sweep: event listeners -200
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 25ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 852ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 141ms
subgraph-transition-enter: heap used 95.6 MB
subgraph-transition-enter: DOM nodes 13587
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 45ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5693ms
viewport-pan-sweep: script duration 2588ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 73.8 MB
viewport-pan-sweep: DOM nodes -247
viewport-pan-sweep: event listeners -137
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 12296ms
vue-large-graph-idle: script duration 225ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 164.0 MB
vue-large-graph-idle: DOM nodes -6542
vue-large-graph-idle: event listeners -7479
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 132
vue-large-graph-pan: task duration 17332ms
vue-large-graph-pan: script duration 882ms
vue-large-graph-pan: TBT 48ms
vue-large-graph-pan: heap used 161.2 MB
vue-large-graph-pan: DOM nodes -6545
vue-large-graph-pan: event listeners -7473
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 71ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5275ms
vue-node-resize-workload: script duration 105ms
vue-node-resize-workload: TBT 244ms
vue-node-resize-workload: heap used 174.9 MB
vue-node-resize-workload: DOM nodes -6544
vue-node-resize-workload: event listeners -7475
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7099ms
vue-zoom-out-idle: script duration 126ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 161.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -9
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 5
workflow-execution: style recalc count 14
workflow-execution: task duration 115ms
workflow-execution: script duration 13ms
workflow-execution: TBT 0ms
workflow-execution: heap used 62.8 MB
workflow-execution: DOM nodes 137
workflow-execution: event listeners 50
Raw data
{
  "timestamp": "2026-09-10T05:46:06.938Z",
  "gitSha": "0cba529b0a345b0848fb049c0fcf03558d288712",
  "branch": "comfydesigner/pay-disabled-until-ready",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2054.794999999956,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.599,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 525.857,
      "heapDeltaBytes": -3367604,
      "heapUsedBytes": 58622216,
      "domNodes": -266,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 12.246,
      "eventListeners": -186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2008.9110000000119,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.195999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.4390000000001,
      "heapDeltaBytes": -1821988,
      "heapUsedBytes": 58978768,
      "domNodes": -264,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 11.848999999999998,
      "eventListeners": -184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1840.167000000008,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.52,
      "layouts": 14,
      "layoutDurationMs": 4.8870000000000005,
      "taskDurationMs": 864.516,
      "heapDeltaBytes": 2443116,
      "heapUsedBytes": 64536532,
      "domNodes": -261,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 148.83,
      "eventListeners": -186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1827.6989999999387,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 29.957000000000004,
      "layouts": 14,
      "layoutDurationMs": 5.375,
      "taskDurationMs": 791.213,
      "heapDeltaBytes": 14431560,
      "heapUsedBytes": 75548796,
      "domNodes": -265,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 152.15300000000002,
      "eventListeners": -156,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.4829999999638,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.709000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.3940000000000001,
      "taskDurationMs": 357.03000000000003,
      "heapDeltaBytes": 2197644,
      "heapUsedBytes": 64214000,
      "domNodes": 74,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 14.209,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1734.7519999999577,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.857000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.1010000000000002,
      "taskDurationMs": 356.92799999999994,
      "heapDeltaBytes": 2171356,
      "heapUsedBytes": 64286868,
      "domNodes": 73,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 13.990999999999996,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 690.4140000000325,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.743,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 444.73799999999994,
      "heapDeltaBytes": 17910348,
      "heapUsedBytes": 80168040,
      "domNodes": 16,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 157.119,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 690.5120000000124,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.308999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.558,
      "heapDeltaBytes": 18143368,
      "heapUsedBytes": 80097208,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 149.93900000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2030.9219999999755,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.932,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 612.1280000000002,
      "heapDeltaBytes": 3934828,
      "heapUsedBytes": 83206392,
      "domNodes": -247,
      "jsHeapTotalBytes": -270336,
      "scriptDurationMs": 33.93299999999999,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2027.708999999959,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.630000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 572.3490000000002,
      "heapDeltaBytes": 3909752,
      "heapUsedBytes": 83269788,
      "domNodes": -246,
      "jsHeapTotalBytes": -794624,
      "scriptDurationMs": 32.302000000000014,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2318.624,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 11.710999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1595.119,
      "heapDeltaBytes": 18241752,
      "heapUsedBytes": 82812384,
      "domNodes": 4,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 782.586,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2258.3059999999477,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 11.23,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1553.559,
      "heapDeltaBytes": 14775724,
      "heapUsedBytes": 79183380,
      "domNodes": -253,
      "jsHeapTotalBytes": 1798144,
      "scriptDurationMs": 756.512,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3660.7030000000123,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 12.953000000000003,
      "layouts": 60,
      "layoutDurationMs": 14.179,
      "taskDurationMs": 1666.1529999999998,
      "heapDeltaBytes": 8381172,
      "heapUsedBytes": 73909260,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 729.821,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3709.073999999987,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 12.754000000000001,
      "layouts": 60,
      "layoutDurationMs": 14.088,
      "taskDurationMs": 1681.155,
      "heapDeltaBytes": 10068704,
      "heapUsedBytes": 75075212,
      "domNodes": -259,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 748.587,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3152.2990000000277,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 6.022999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1914.056,
      "heapDeltaBytes": 22364792,
      "heapUsedBytes": 88195276,
      "domNodes": 0,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 914.646,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3165.5250000000024,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 8.920000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1918.6899999999998,
      "heapDeltaBytes": -2153040,
      "heapUsedBytes": 88025812,
      "domNodes": -261,
      "jsHeapTotalBytes": 708608,
      "scriptDurationMs": 907.376,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2076.65099999997,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 8.111,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 625.8170000000001,
      "heapDeltaBytes": -7461676,
      "heapUsedBytes": 80262504,
      "domNodes": -253,
      "jsHeapTotalBytes": -757760,
      "scriptDurationMs": 35.44,
      "eventListeners": -184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.7279999999719,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.3089999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 554.032,
      "heapDeltaBytes": 20068828,
      "heapUsedBytes": 84252136,
      "domNodes": -253,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 39.983999999999995,
      "eventListeners": -184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 626.4509999999746,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.809,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 404.278,
      "heapDeltaBytes": 13196888,
      "heapUsedBytes": 76498580,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 138.492,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 594.5080000000189,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.673999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 383.33599999999996,
      "heapDeltaBytes": 13505144,
      "heapUsedBytes": 76790216,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 131.296,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2003.3919999999625,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.656,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 396.90900000000005,
      "heapDeltaBytes": -1770876,
      "heapUsedBytes": 61175432,
      "domNodes": -276,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 10.338999999999997,
      "eventListeners": -232,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.9640000000063,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.862,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 482.696,
      "heapDeltaBytes": 7861860,
      "heapUsedBytes": 71191536,
      "domNodes": -273,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.632000000000003,
      "eventListeners": -202,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1727.0049999999628,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 29.726000000000003,
      "layouts": 18,
      "layoutDurationMs": 5.946,
      "taskDurationMs": 877.2120000000001,
      "heapDeltaBytes": 17169024,
      "heapUsedBytes": 79824292,
      "domNodes": -274,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 114.572,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1705.4239999999936,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 29.925,
      "layouts": 18,
      "layoutDurationMs": 5.675,
      "taskDurationMs": 823.037,
      "heapDeltaBytes": 11204712,
      "heapUsedBytes": 74435856,
      "domNodes": -272,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 104.848,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1350.9200000000305,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 25.307000000000002,
      "layouts": 5,
      "layoutDurationMs": 10.128,
      "taskDurationMs": 851.7070000000002,
      "heapDeltaBytes": 19683404,
      "heapUsedBytes": 100242540,
      "domNodes": 13587,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 28.537,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8427.517999999964,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 42.830999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5787.759,
      "heapDeltaBytes": 11477560,
      "heapUsedBytes": 75024256,
      "domNodes": -249,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 2654.375,
      "eventListeners": -138,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8329.246999999896,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 46.577000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5597.88,
      "heapDeltaBytes": -121404,
      "heapUsedBytes": 79647920,
      "domNodes": -245,
      "jsHeapTotalBytes": 479232,
      "scriptDurationMs": 2521.119,
      "eventListeners": -136,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11410.765000000027,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10689.170999999998,
      "heapDeltaBytes": -16330512,
      "heapUsedBytes": 178480876,
      "domNodes": -6542,
      "jsHeapTotalBytes": 7974912,
      "scriptDurationMs": 212.82700000000003,
      "eventListeners": -7480,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14332.71400000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13902.495000000003,
      "heapDeltaBytes": -29675116,
      "heapUsedBytes": 165355920,
      "domNodes": -6542,
      "jsHeapTotalBytes": 6926336,
      "scriptDurationMs": 236.483,
      "eventListeners": -7478,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17625.116999999987,
      "styleRecalcs": 131,
      "styleRecalcDurationMs": 20.25599999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17455.449,
      "heapDeltaBytes": -52834476,
      "heapUsedBytes": 162509432,
      "domNodes": -6542,
      "jsHeapTotalBytes": 1159168,
      "scriptDurationMs": 879.1869999999999,
      "eventListeners": -7474,
      "totalBlockingTimeMs": 84,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17427.56699999995,
      "styleRecalcs": 133,
      "styleRecalcDurationMs": 20.024999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17208.267,
      "heapDeltaBytes": -32791308,
      "heapUsedBytes": 175655840,
      "domNodes": -6547,
      "jsHeapTotalBytes": -3842048,
      "scriptDurationMs": 884.1859999999999,
      "eventListeners": -7472,
      "totalBlockingTimeMs": 11,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5371.087999999986,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.022,
      "layouts": 20,
      "layoutDurationMs": 26.447,
      "taskDurationMs": 5274.210000000001,
      "heapDeltaBytes": -26225736,
      "heapUsedBytes": 175025268,
      "domNodes": -6546,
      "jsHeapTotalBytes": 5230592,
      "scriptDurationMs": 104.425,
      "eventListeners": -7474,
      "totalBlockingTimeMs": 297,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5362.186000000065,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 68.66700000000003,
      "layouts": 20,
      "layoutDurationMs": 24.117999999999988,
      "taskDurationMs": 5276.177000000001,
      "heapDeltaBytes": -23312712,
      "heapUsedBytes": 191847196,
      "domNodes": -6542,
      "jsHeapTotalBytes": 17534976,
      "scriptDurationMs": 105.209,
      "eventListeners": -7476,
      "totalBlockingTimeMs": 191,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7222.302999999954,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7037.355,
      "heapDeltaBytes": -31184280,
      "heapUsedBytes": 159703132,
      "domNodes": 0,
      "jsHeapTotalBytes": -7864320,
      "scriptDurationMs": 118.32900000000002,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7326.0139999999865,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7159.897999999998,
      "heapDeltaBytes": -18815292,
      "heapUsedBytes": 179073912,
      "domNodes": 0,
      "jsHeapTotalBytes": -14680064,
      "scriptDurationMs": 132.98799999999994,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 479.58899999997584,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 25.689,
      "layouts": 6,
      "layoutDurationMs": 3.0280000000000005,
      "taskDurationMs": 147.27,
      "heapDeltaBytes": 5335016,
      "heapUsedBytes": 67124000,
      "domNodes": 147,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 18.695,
      "eventListeners": 83,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 120.01800000007279,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 16.232999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.849,
      "taskDurationMs": 81.82999999999998,
      "heapDeltaBytes": 2995392,
      "heapUsedBytes": 64553424,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.701999999999998,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50154 74821 67.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.7% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.0% 309
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 79.1% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 10, 2026
@codecov

codecov Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                             Coverage Diff                             @@
##           comfydesigner/capture-provider-unreachable   #17343   +/-   ##
===========================================================================
  Coverage                                       83.25%   83.25%           
===========================================================================
  Files                                            2064     2064           
  Lines                                          120516   120523    +7     
  Branches                                        32288    32295    +7     
===========================================================================
+ Hits                                           100337   100347   +10     
+ Misses                                          20000    19997    -3     
  Partials                                          179      179           
Flag Coverage Δ
e2e 67.03% <ø> (+<0.01%) ⬆️
unit 78.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ponents/SubscriptionAddPaymentPreviewWorkspace.vue 91.11% <100.00%> (+0.41%) ⬆️
...kspace/components/UnifiedStripePaymentSelector.vue 95.83% <100.00%> (+0.21%) ⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfydesigner

Copy link
Copy Markdown
Contributor Author

Closing: FE-2165 is covered by the full-page checkout on billing-web, which enables Pay only after the payment element reports ready (useFullPageCheckout elementReady). The parent PR #16846 is closed too, and the in-app embedded dialog this edits is removed at M3-10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant