Repository navigation
fix(billing): pay waits for the payment element to actually paint - #17343
comfydesigner wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1940 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-10T05:46:06.938Z",
"gitSha": "0cba529b0a345b0848fb049c0fcf03558d288712",
"branch": "comfydesigner/pay-disabled-until-ready",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.794999999956,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.599,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.857,
"heapDeltaBytes": -3367604,
"heapUsedBytes": 58622216,
"domNodes": -266,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 12.246,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.9110000000119,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.195999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.4390000000001,
"heapDeltaBytes": -1821988,
"heapUsedBytes": 58978768,
"domNodes": -264,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.848999999999998,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1840.167000000008,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.52,
"layouts": 14,
"layoutDurationMs": 4.8870000000000005,
"taskDurationMs": 864.516,
"heapDeltaBytes": 2443116,
"heapUsedBytes": 64536532,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 148.83,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1827.6989999999387,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.957000000000004,
"layouts": 14,
"layoutDurationMs": 5.375,
"taskDurationMs": 791.213,
"heapDeltaBytes": 14431560,
"heapUsedBytes": 75548796,
"domNodes": -265,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 152.15300000000002,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.4829999999638,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.709000000000003,
"layouts": 6,
"layoutDurationMs": 1.3940000000000001,
"taskDurationMs": 357.03000000000003,
"heapDeltaBytes": 2197644,
"heapUsedBytes": 64214000,
"domNodes": 74,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 14.209,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.7519999999577,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.857000000000001,
"layouts": 6,
"layoutDurationMs": 1.1010000000000002,
"taskDurationMs": 356.92799999999994,
"heapDeltaBytes": 2171356,
"heapUsedBytes": 64286868,
"domNodes": 73,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 13.990999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 690.4140000000325,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.743,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.73799999999994,
"heapDeltaBytes": 17910348,
"heapUsedBytes": 80168040,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 157.119,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 690.5120000000124,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.308999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.558,
"heapDeltaBytes": 18143368,
"heapUsedBytes": 80097208,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 149.93900000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2030.9219999999755,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.932,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.1280000000002,
"heapDeltaBytes": 3934828,
"heapUsedBytes": 83206392,
"domNodes": -247,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 33.93299999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2027.708999999959,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.630000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.3490000000002,
"heapDeltaBytes": 3909752,
"heapUsedBytes": 83269788,
"domNodes": -246,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 32.302000000000014,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2318.624,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.710999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1595.119,
"heapDeltaBytes": 18241752,
"heapUsedBytes": 82812384,
"domNodes": 4,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 782.586,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2258.3059999999477,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.23,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1553.559,
"heapDeltaBytes": 14775724,
"heapUsedBytes": 79183380,
"domNodes": -253,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 756.512,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3660.7030000000123,
"styleRecalcs": 61,
"styleRecalcDurationMs": 12.953000000000003,
"layouts": 60,
"layoutDurationMs": 14.179,
"taskDurationMs": 1666.1529999999998,
"heapDeltaBytes": 8381172,
"heapUsedBytes": 73909260,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 729.821,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3709.073999999987,
"styleRecalcs": 61,
"styleRecalcDurationMs": 12.754000000000001,
"layouts": 60,
"layoutDurationMs": 14.088,
"taskDurationMs": 1681.155,
"heapDeltaBytes": 10068704,
"heapUsedBytes": 75075212,
"domNodes": -259,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 748.587,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3152.2990000000277,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.022999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1914.056,
"heapDeltaBytes": 22364792,
"heapUsedBytes": 88195276,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 914.646,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3165.5250000000024,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.920000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1918.6899999999998,
"heapDeltaBytes": -2153040,
"heapUsedBytes": 88025812,
"domNodes": -261,
"jsHeapTotalBytes": 708608,
"scriptDurationMs": 907.376,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2076.65099999997,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.111,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 625.8170000000001,
"heapDeltaBytes": -7461676,
"heapUsedBytes": 80262504,
"domNodes": -253,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 35.44,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2010.7279999999719,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.3089999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.032,
"heapDeltaBytes": 20068828,
"heapUsedBytes": 84252136,
"domNodes": -253,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.983999999999995,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.4509999999746,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.809,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.278,
"heapDeltaBytes": 13196888,
"heapUsedBytes": 76498580,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.492,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.5080000000189,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.673999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.33599999999996,
"heapDeltaBytes": 13505144,
"heapUsedBytes": 76790216,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 131.296,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.3919999999625,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.656,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.90900000000005,
"heapDeltaBytes": -1770876,
"heapUsedBytes": 61175432,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.338999999999997,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.9640000000063,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.862,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.696,
"heapDeltaBytes": 7861860,
"heapUsedBytes": 71191536,
"domNodes": -273,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.632000000000003,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.0049999999628,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.726000000000003,
"layouts": 18,
"layoutDurationMs": 5.946,
"taskDurationMs": 877.2120000000001,
"heapDeltaBytes": 17169024,
"heapUsedBytes": 79824292,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 114.572,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.4239999999936,
"styleRecalcs": 79,
"styleRecalcDurationMs": 29.925,
"layouts": 18,
"layoutDurationMs": 5.675,
"taskDurationMs": 823.037,
"heapDeltaBytes": 11204712,
"heapUsedBytes": 74435856,
"domNodes": -272,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 104.848,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1350.9200000000305,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.307000000000002,
"layouts": 5,
"layoutDurationMs": 10.128,
"taskDurationMs": 851.7070000000002,
"heapDeltaBytes": 19683404,
"heapUsedBytes": 100242540,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 28.537,
"eventListeners": 2387,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8427.517999999964,
"styleRecalcs": 246,
"styleRecalcDurationMs": 42.830999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5787.759,
"heapDeltaBytes": 11477560,
"heapUsedBytes": 75024256,
"domNodes": -249,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 2654.375,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8329.246999999896,
"styleRecalcs": 248,
"styleRecalcDurationMs": 46.577000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5597.88,
"heapDeltaBytes": -121404,
"heapUsedBytes": 79647920,
"domNodes": -245,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 2521.119,
"eventListeners": -136,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11410.765000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10689.170999999998,
"heapDeltaBytes": -16330512,
"heapUsedBytes": 178480876,
"domNodes": -6542,
"jsHeapTotalBytes": 7974912,
"scriptDurationMs": 212.82700000000003,
"eventListeners": -7480,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 14332.71400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13902.495000000003,
"heapDeltaBytes": -29675116,
"heapUsedBytes": 165355920,
"domNodes": -6542,
"jsHeapTotalBytes": 6926336,
"scriptDurationMs": 236.483,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17625.116999999987,
"styleRecalcs": 131,
"styleRecalcDurationMs": 20.25599999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17455.449,
"heapDeltaBytes": -52834476,
"heapUsedBytes": 162509432,
"domNodes": -6542,
"jsHeapTotalBytes": 1159168,
"scriptDurationMs": 879.1869999999999,
"eventListeners": -7474,
"totalBlockingTimeMs": 84,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17427.56699999995,
"styleRecalcs": 133,
"styleRecalcDurationMs": 20.024999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17208.267,
"heapDeltaBytes": -32791308,
"heapUsedBytes": 175655840,
"domNodes": -6547,
"jsHeapTotalBytes": -3842048,
"scriptDurationMs": 884.1859999999999,
"eventListeners": -7472,
"totalBlockingTimeMs": 11,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5371.087999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.022,
"layouts": 20,
"layoutDurationMs": 26.447,
"taskDurationMs": 5274.210000000001,
"heapDeltaBytes": -26225736,
"heapUsedBytes": 175025268,
"domNodes": -6546,
"jsHeapTotalBytes": 5230592,
"scriptDurationMs": 104.425,
"eventListeners": -7474,
"totalBlockingTimeMs": 297,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5362.186000000065,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.66700000000003,
"layouts": 20,
"layoutDurationMs": 24.117999999999988,
"taskDurationMs": 5276.177000000001,
"heapDeltaBytes": -23312712,
"heapUsedBytes": 191847196,
"domNodes": -6542,
"jsHeapTotalBytes": 17534976,
"scriptDurationMs": 105.209,
"eventListeners": -7476,
"totalBlockingTimeMs": 191,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7222.302999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7037.355,
"heapDeltaBytes": -31184280,
"heapUsedBytes": 159703132,
"domNodes": 0,
"jsHeapTotalBytes": -7864320,
"scriptDurationMs": 118.32900000000002,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7326.0139999999865,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7159.897999999998,
"heapDeltaBytes": -18815292,
"heapUsedBytes": 179073912,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 132.98799999999994,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 479.58899999997584,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.689,
"layouts": 6,
"layoutDurationMs": 3.0280000000000005,
"taskDurationMs": 147.27,
"heapDeltaBytes": 5335016,
"heapUsedBytes": 67124000,
"domNodes": 147,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 18.695,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 120.01800000007279,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.232999999999997,
"layouts": 3,
"layoutDurationMs": 1.849,
"taskDurationMs": 81.82999999999998,
"heapDeltaBytes": 2995392,
"heapUsedBytes": 64553424,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.701999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## comfydesigner/capture-provider-unreachable #17343 +/- ##
===========================================================================
Coverage 83.25% 83.25%
===========================================================================
Files 2064 2064
Lines 120516 120523 +7
Branches 32288 32295 +7
===========================================================================
+ Hits 100337 100347 +10
+ Misses 20000 19997 -3
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Closing: FE-2165 is covered by the full-page checkout on billing-web, which enables Pay only after the payment element reports ready (useFullPageCheckout elementReady). The parent PR #16846 is closed too, and the in-app embedded dialog this edits is removed at M3-10. |
On a cold load, Pay and subscribe enabled the moment Stripe Elements was constructed — before the payment element's iframe painted — so a fast click landed on a blank form region. The button now waits for Stripe's own
readyevent, and the legal fine print below it waits the same way (nothing to pay with, nothing to agree to).readyfrom the mounted element and folds it into the pay CTA's disabled state; failure cleanups and retries reset it, so a remounted element re-earns the enabled state.elementReadyChangeemit lets the host holdSubscriptionTermsNoteuntil the form is real — closing the during-load window flagged in review on feat(billing): tell the customer payments are down before they type a card #16846 and deliberately scoped to this change.elements.update()without a remount, soreadysurvives re-quotes.Tests: pay stays disabled until
readyand drops back on element failure; the retry path re-earns enabled; the terms note follows ready/unreachable through the full round trip.Stacked on #16846 (same file, same lifecycle); diff is against that branch.
Path notes
UnifiedStripePaymentSelectorhas exactly one host today (SubscriptionAddPaymentPreviewWorkspace); the new emit is additive for any future host.