Repository navigation
[backport cloud/1.54] fix: refresh slot labels after rename with ECS node state - #17342
Conversation
Fixes #16642 - Renaming an input or output slot now refreshes the rendered label immediately (regressed when the ECS node state landed in #14246). - Slot descriptors are exposed to the node shell through a reactive view, so any slot field edit propagates; no per-field handlers needed. - Regression test added (fails on main, passes here). <details><summary>Full context for agent readers</summary> **Root cause.** Before ECS, `LGraphCanvas` listened for `node:slot-label:changed` and redrew. The ECS merge removed that handler and instead reads slot data through `createNodeShellState`. The plain objects in `node.inputs` / `node.outputs` are not reactive, so label writes never invalidated the shell state and the Vue node kept the old label. **Fix.** `src/lib/litegraph/src/node/slotDescriptorView.ts` adds a generic `createSlotView<T>` Proxy (exported as `createInputSlotView` / `createOutputSlotView`, plus `resolveInputSlotView` for lookups). `createNodeShellState` in `src/core/graph/nodeShell/nodeShellState.ts` takes the two view factories and derives its slot arrays from them; `LGraphNode.ts` passes them through. Any write to a slot descriptor (label, name, type) now triggers the shell to recompute. **Tests.** `src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts` (5 cases: input rename, output rename, rename after link, rename of a widget-backed input, rename via `renameSlot`). Written TDD: red on `main`, green on this branch. The test lives under `src/core/graph/nodeShell/` to satisfy the layer-boundary lint. `pnpm vitest run` on the three touched test files: 18/18. `pnpm typecheck` clean, `oxlint`/`eslint` clean. **Disclosure.** Knip (pre-push hook) flagged an unused `resolveOutputSlotView` export that I had added for symmetry; I removed it rather than leave dead code. Add it back if a caller appears. **Backport.** Labelled `needs-backport`, `core/1.53`, `cloud/1.53` per program policy (every ECS fix goes to 1.53 before promotion). <!-- authored-by:agent supreme-operator w3-520-followup --> </details> --------- Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit 928cd4a)
🎭 Playwright: ✅ 1920 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-10T05:41:11.508Z",
"gitSha": "f0f06b35011cc196e452e6a9764027b1accb77e7",
"branch": "christian-byrne/backport-17319-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2071.0579999999936,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.629,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.2800000000001,
"heapDeltaBytes": 1003696,
"heapUsedBytes": 69883312,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.712000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2049.393000000009,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.05,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.265,
"heapDeltaBytes": 8682260,
"heapUsedBytes": 78742664,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.538,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1990.0440000000117,
"styleRecalcs": 79,
"styleRecalcDurationMs": 44.28600000000001,
"layouts": 14,
"layoutDurationMs": 5.682,
"taskDurationMs": 946.852,
"heapDeltaBytes": -8138140,
"heapUsedBytes": 62817796,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 166.893,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1803.4470000000056,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.206,
"layouts": 14,
"layoutDurationMs": 4.101000000000001,
"taskDurationMs": 858.5899999999999,
"heapDeltaBytes": -8307944,
"heapUsedBytes": 62509608,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 160.773,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1664.9489999999787,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.343,
"layouts": 6,
"layoutDurationMs": 0.9810000000000001,
"taskDurationMs": 344.39599999999996,
"heapDeltaBytes": 4728736,
"heapUsedBytes": 74797044,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.943,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1664.331000000061,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.755999999999998,
"layouts": 6,
"layoutDurationMs": 0.9910000000000001,
"taskDurationMs": 350.70199999999994,
"heapDeltaBytes": 5066692,
"heapUsedBytes": 75816824,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.215000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 642.1339999999987,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.052000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.5539999999999,
"heapDeltaBytes": -7815128,
"heapUsedBytes": 62932428,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 156.441,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 641.414999999995,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.936,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.03900000000004,
"heapDeltaBytes": 18526456,
"heapUsedBytes": 88613604,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 159.367,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2054.124999999999,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.232000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.1139999999999,
"heapDeltaBytes": 11740584,
"heapUsedBytes": 87123740,
"domNodes": -266,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 32.952,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2060.656999999992,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.6970000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.359,
"heapDeltaBytes": 12368872,
"heapUsedBytes": 88012168,
"domNodes": -272,
"jsHeapTotalBytes": -2723840,
"scriptDurationMs": 30.60299999999999,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2185.8419999999796,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.09,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1581.3709999999999,
"heapDeltaBytes": 20717232,
"heapUsedBytes": 87121276,
"domNodes": 2,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 798.455,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2230.1559999999654,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.312999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1638.613,
"heapDeltaBytes": 12296916,
"heapUsedBytes": 89273152,
"domNodes": -274,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 809.498,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3476.82999999995,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.238000000000001,
"layouts": 60,
"layoutDurationMs": 11.503,
"taskDurationMs": 1680.995,
"heapDeltaBytes": 10234752,
"heapUsedBytes": 76714884,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 764.162,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3489.0960000000177,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.363,
"layouts": 60,
"layoutDurationMs": 11.467999999999998,
"taskDurationMs": 1699.9320000000002,
"heapDeltaBytes": 10635240,
"heapUsedBytes": 77929044,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 798.153,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3153.6179999999945,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.690999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1963.6430000000003,
"heapDeltaBytes": 8425836,
"heapUsedBytes": 88860900,
"domNodes": -283,
"jsHeapTotalBytes": -1519616,
"scriptDurationMs": 951.211,
"eventListeners": 40,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3016.894999999977,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.666999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1858.445,
"heapDeltaBytes": 18321240,
"heapUsedBytes": 85618448,
"domNodes": 0,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 924.3760000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.4399999999896,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.7139999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.338,
"heapDeltaBytes": 22249000,
"heapUsedBytes": 87955460,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.661,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.458999999997,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.6450000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.8409999999999,
"heapDeltaBytes": 22694056,
"heapUsedBytes": 88563016,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.632999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.5369999999925,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.279,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.391,
"heapDeltaBytes": 14368860,
"heapUsedBytes": 86803380,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.19099999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.1790000000674,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.360000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.62600000000003,
"heapDeltaBytes": 14783700,
"heapUsedBytes": 87835272,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.63600000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2037.7720000000181,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.716999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.11800000000005,
"heapDeltaBytes": -1298176,
"heapUsedBytes": 71471712,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.896999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2039.4249999999943,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.361999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.684,
"heapDeltaBytes": -10689760,
"heapUsedBytes": 62310660,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.415,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1730.6259999999725,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.329,
"layouts": 18,
"layoutDurationMs": 4.87,
"taskDurationMs": 799.3249999999999,
"heapDeltaBytes": -12611640,
"heapUsedBytes": 60448204,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 102.61099999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1752.4529999999459,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.939,
"layouts": 18,
"layoutDurationMs": 4.7010000000000005,
"taskDurationMs": 812.808,
"heapDeltaBytes": -12322200,
"heapUsedBytes": 60454764,
"domNodes": -294,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 106.138,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.9600000000019,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.43700000000001,
"layouts": 14,
"layoutDurationMs": 15.083999999999996,
"taskDurationMs": 891.4770000000001,
"heapDeltaBytes": -7282080,
"heapUsedBytes": 86373004,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.075999999999993,
"eventListeners": 2385,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8720.433000000014,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.589,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6071.131,
"heapDeltaBytes": -7770920,
"heapUsedBytes": 94668688,
"domNodes": -266,
"jsHeapTotalBytes": 3829760,
"scriptDurationMs": 2895.8609999999994,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8631.889000000001,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.492999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5919.382,
"heapDeltaBytes": 13270252,
"heapUsedBytes": 88860976,
"domNodes": -273,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 2647.058,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17263.769000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16648.777,
"heapDeltaBytes": -30888656,
"heapUsedBytes": 174785600,
"domNodes": -6548,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 322.23600000000005,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17033.104000000094,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16548.205,
"heapDeltaBytes": -33340248,
"heapUsedBytes": 176430172,
"domNodes": -6548,
"jsHeapTotalBytes": 2347008,
"scriptDurationMs": 257.38500000000005,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20722.700999999972,
"styleRecalcs": 170,
"styleRecalcDurationMs": 17.282999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20296.781000000003,
"heapDeltaBytes": -14999916,
"heapUsedBytes": 190613352,
"domNodes": -6548,
"jsHeapTotalBytes": 1695744,
"scriptDurationMs": 966.4489999999998,
"eventListeners": -7469,
"totalBlockingTimeMs": 81,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20877.882999999998,
"styleRecalcs": 172,
"styleRecalcDurationMs": 17.630000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20462.938000000002,
"heapDeltaBytes": -39948928,
"heapUsedBytes": 163153164,
"domNodes": -6548,
"jsHeapTotalBytes": 2113536,
"scriptDurationMs": 882.937,
"eventListeners": -7469,
"totalBlockingTimeMs": 17,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6181.51899999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 92.443,
"layouts": 20,
"layoutDurationMs": 30.180000000000014,
"taskDurationMs": 6037.368,
"heapDeltaBytes": -30304600,
"heapUsedBytes": 175376100,
"domNodes": -6548,
"jsHeapTotalBytes": 11014144,
"scriptDurationMs": 129.78599999999997,
"eventListeners": -7469,
"totalBlockingTimeMs": 572,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6171.310999999946,
"styleRecalcs": 20,
"styleRecalcDurationMs": 92.696,
"layouts": 20,
"layoutDurationMs": 34.75600000000001,
"taskDurationMs": 6049.9039999999995,
"heapDeltaBytes": -37401472,
"heapUsedBytes": 173519724,
"domNodes": -6548,
"jsHeapTotalBytes": 1921024,
"scriptDurationMs": 103.11099999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 625,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8546.081000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8344.200999999997,
"heapDeltaBytes": 11847440,
"heapUsedBytes": 174728232,
"domNodes": 0,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 174.82299999999995,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8435.292000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8264.362000000001,
"heapDeltaBytes": 23301216,
"heapUsedBytes": 180510140,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 128.328,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 88.7419999999679,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.190000000000001,
"layouts": 2,
"layoutDurationMs": 0.5889999999999999,
"taskDurationMs": 67.018,
"heapDeltaBytes": 3036348,
"heapUsedBytes": 72190132,
"domNodes": 104,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.633000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 482.6859999999442,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.139999999999993,
"layouts": 3,
"layoutDurationMs": 1.2209999999999999,
"taskDurationMs": 117.85199999999999,
"heapDeltaBytes": 4931032,
"heapUsedBytes": 73133084,
"domNodes": 144,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.289000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #17342 +/- ##
=============================================
Coverage ? 82.98%
=============================================
Files ? 2053
Lines ? 119724
Branches ? 30970
=============================================
Hits ? 99347
Misses ? 20197
Partials ? 180
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #17319 to 1.54. Clean cherry-pick of
928cd4a5e5; typecheck and the two slot-label tests green locally.Full context for agent readers
928cd4a5e5).-x;pnpm typecheckexit 0;pnpm vitest run src/lib/litegraph/src/node/slotDescriptorView.test.ts src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts→ 6/6 pass.slotDescriptorView.tson core/1.53 and cloud/1.53 lacks theassignedInputViewsplumbing introduced by fix: resolve assigned input slot positions #16510 (risk:xhigh, no backport labels, no backport PRs). Cherry-picking fix: refresh slot labels after rename with ECS node state #17319 onto 1.53 conflicts; a decision on backporting fix: resolve assigned input slot positions #16510 first (or skipping 1.53) is pending with Christian.