Repository navigation
[backport core/1.54] fix: refresh slot labels after rename with ECS node state - #17341
Conversation
Fixes #16642 - Renaming an input or output slot now refreshes the rendered label immediately (regressed when the ECS node state landed in #14246). - Slot descriptors are exposed to the node shell through a reactive view, so any slot field edit propagates; no per-field handlers needed. - Regression test added (fails on main, passes here). <details><summary>Full context for agent readers</summary> **Root cause.** Before ECS, `LGraphCanvas` listened for `node:slot-label:changed` and redrew. The ECS merge removed that handler and instead reads slot data through `createNodeShellState`. The plain objects in `node.inputs` / `node.outputs` are not reactive, so label writes never invalidated the shell state and the Vue node kept the old label. **Fix.** `src/lib/litegraph/src/node/slotDescriptorView.ts` adds a generic `createSlotView<T>` Proxy (exported as `createInputSlotView` / `createOutputSlotView`, plus `resolveInputSlotView` for lookups). `createNodeShellState` in `src/core/graph/nodeShell/nodeShellState.ts` takes the two view factories and derives its slot arrays from them; `LGraphNode.ts` passes them through. Any write to a slot descriptor (label, name, type) now triggers the shell to recompute. **Tests.** `src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts` (5 cases: input rename, output rename, rename after link, rename of a widget-backed input, rename via `renameSlot`). Written TDD: red on `main`, green on this branch. The test lives under `src/core/graph/nodeShell/` to satisfy the layer-boundary lint. `pnpm vitest run` on the three touched test files: 18/18. `pnpm typecheck` clean, `oxlint`/`eslint` clean. **Disclosure.** Knip (pre-push hook) flagged an unused `resolveOutputSlotView` export that I had added for symmetry; I removed it rather than leave dead code. Add it back if a caller appears. **Backport.** Labelled `needs-backport`, `core/1.53`, `cloud/1.53` per program policy (every ECS fix goes to 1.53 before promotion). <!-- authored-by:agent supreme-operator w3-520-followup --> </details> --------- Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit 928cd4a)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1920 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-10T05:41:22.538Z",
"gitSha": "289b7e8d5a4f34bba55dc0db3480ab100187627b",
"branch": "christian-byrne/backport-17319-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2087.824000000012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.537999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.663,
"heapDeltaBytes": -1119984,
"heapUsedBytes": 69446036,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.726,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2031.3280000000304,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.785000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.884,
"heapDeltaBytes": -11885224,
"heapUsedBytes": 57930956,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.5969999999999995,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2001.9360000000006,
"styleRecalcs": 80,
"styleRecalcDurationMs": 42.908,
"layouts": 14,
"layoutDurationMs": 4.687,
"taskDurationMs": 998.5580000000001,
"heapDeltaBytes": 12467900,
"heapUsedBytes": 83147644,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 185.356,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1901.5080000000353,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.358999999999995,
"layouts": 14,
"layoutDurationMs": 4.539,
"taskDurationMs": 889.3610000000001,
"heapDeltaBytes": 6197084,
"heapUsedBytes": 76825684,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 163.556,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.8660000000232,
"styleRecalcs": 29,
"styleRecalcDurationMs": 17.523999999999997,
"layouts": 6,
"layoutDurationMs": 1.224,
"taskDurationMs": 417.482,
"heapDeltaBytes": 4710652,
"heapUsedBytes": 74815104,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.583000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.354999999956,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.781,
"layouts": 6,
"layoutDurationMs": 1.1019999999999996,
"taskDurationMs": 360.644,
"heapDeltaBytes": 4735940,
"heapUsedBytes": 74694272,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.972000000000001,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 650.4560000000197,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.185,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.633,
"heapDeltaBytes": -8144256,
"heapUsedBytes": 62587376,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 170.33,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 660.2900000000318,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.327000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.75100000000003,
"heapDeltaBytes": 18423376,
"heapUsedBytes": 88538688,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 161.53500000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2043.040000000019,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.213999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.01,
"heapDeltaBytes": -14851600,
"heapUsedBytes": 87737396,
"domNodes": -269,
"jsHeapTotalBytes": -1114112,
"scriptDurationMs": 32.556000000000004,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2052.135000000021,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.231,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.7289999999999,
"heapDeltaBytes": 11994688,
"heapUsedBytes": 87388600,
"domNodes": -267,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 32.029,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2688.3040000000165,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.238000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1774.7640000000001,
"heapDeltaBytes": 26734140,
"heapUsedBytes": 93055816,
"domNodes": -275,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 922.276,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2281.451000000061,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.036000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1663.576,
"heapDeltaBytes": 8656324,
"heapUsedBytes": 85138640,
"domNodes": -271,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 820.8879999999999,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3596.670999999958,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.783,
"layouts": 60,
"layoutDurationMs": 11.873999999999999,
"taskDurationMs": 1765.252,
"heapDeltaBytes": 8047036,
"heapUsedBytes": 76175848,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 827.352,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3628.210000000081,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.397000000000002,
"layouts": 60,
"layoutDurationMs": 11.508000000000001,
"taskDurationMs": 1719.7839999999997,
"heapDeltaBytes": 9502692,
"heapUsedBytes": 76756616,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 800.322,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3324.6999999999503,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.923000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2116.968,
"heapDeltaBytes": 31230580,
"heapUsedBytes": 99002796,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 1093.944,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3149.774999999977,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.876000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1962.3500000000004,
"heapDeltaBytes": 26165308,
"heapUsedBytes": 93841700,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 978.369,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1996.6319999999769,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.9429999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 625.625,
"heapDeltaBytes": 22192880,
"heapUsedBytes": 89021744,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.779999999999994,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2038.8699999999744,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.171000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.88,
"heapDeltaBytes": -16341008,
"heapUsedBytes": 88057960,
"domNodes": -266,
"jsHeapTotalBytes": -1900544,
"scriptDurationMs": 32.736000000000004,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 654.6199999999658,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.52,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.6549999999999,
"heapDeltaBytes": 15168868,
"heapUsedBytes": 88157432,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 151.972,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.3199999999533,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.305,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.98100000000005,
"heapDeltaBytes": 14333768,
"heapUsedBytes": 86305044,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 138.99200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2001.1389999999665,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.093999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.817,
"heapDeltaBytes": -7286816,
"heapUsedBytes": 65490572,
"domNodes": -300,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.363999999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2015.2089999999134,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.041000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.172,
"heapDeltaBytes": -10705600,
"heapUsedBytes": 62300240,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.293000000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.3510000000088,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.545,
"layouts": 18,
"layoutDurationMs": 5.021,
"taskDurationMs": 833.409,
"heapDeltaBytes": 7692144,
"heapUsedBytes": 80820288,
"domNodes": -294,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 115.49900000000002,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.91999999996,
"styleRecalcs": 79,
"styleRecalcDurationMs": 36.88699999999999,
"layouts": 18,
"layoutDurationMs": 5.392,
"taskDurationMs": 845.867,
"heapDeltaBytes": -1619216,
"heapUsedBytes": 69900468,
"domNodes": -294,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 111.337,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.6779999999903,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.098,
"layouts": 15,
"layoutDurationMs": 16.130000000000003,
"taskDurationMs": 997.5169999999999,
"heapDeltaBytes": 21927912,
"heapUsedBytes": 106170584,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 30.532000000000004,
"eventListeners": 2385,
"totalBlockingTimeMs": 157,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9252.948000000004,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.076,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6350.221,
"heapDeltaBytes": 18183756,
"heapUsedBytes": 93789280,
"domNodes": -270,
"jsHeapTotalBytes": -958464,
"scriptDurationMs": 2992.5769999999998,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8748.170999999957,
"styleRecalcs": 246,
"styleRecalcDurationMs": 34.265,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5906.594,
"heapDeltaBytes": 17341860,
"heapUsedBytes": 93499564,
"domNodes": -271,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 2691.338,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17693.287999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16937.439,
"heapDeltaBytes": -40245576,
"heapUsedBytes": 176577784,
"domNodes": -6548,
"jsHeapTotalBytes": 2039808,
"scriptDurationMs": 306.01300000000003,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17038.547000000108,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16504.731,
"heapDeltaBytes": -25688396,
"heapUsedBytes": 175748308,
"domNodes": -6548,
"jsHeapTotalBytes": -4739072,
"scriptDurationMs": 277.46999999999997,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21372.673999999963,
"styleRecalcs": 167,
"styleRecalcDurationMs": 19.151000000000028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20980.705,
"heapDeltaBytes": -12171016,
"heapUsedBytes": 190520556,
"domNodes": -6548,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 1012.0639999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 97,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21145.06300000005,
"styleRecalcs": 173,
"styleRecalcDurationMs": 18.849999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20730.164,
"heapDeltaBytes": -39273864,
"heapUsedBytes": 177067844,
"domNodes": -6548,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 903.6019999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 51,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6157.884999999965,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.66899999999998,
"layouts": 20,
"layoutDurationMs": 23.295999999999996,
"taskDurationMs": 6032.964999999999,
"heapDeltaBytes": -23644476,
"heapUsedBytes": 181486956,
"domNodes": -6548,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 112.98099999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 397,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6205.549000000019,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.546,
"layouts": 20,
"layoutDurationMs": 22.714,
"taskDurationMs": 6094.119,
"heapDeltaBytes": -35736520,
"heapUsedBytes": 174896108,
"domNodes": -6548,
"jsHeapTotalBytes": 3518464,
"scriptDurationMs": 111.24199999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 447,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8551.247999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8302.846000000001,
"heapDeltaBytes": 20078096,
"heapUsedBytes": 177185312,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 146.77000000000007,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8505.95999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8315.367999999999,
"heapDeltaBytes": 5595940,
"heapUsedBytes": 176200144,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 128.18000000000006,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 113.76699999999573,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.953,
"layouts": 2,
"layoutDurationMs": 0.461,
"taskDurationMs": 79.77499999999999,
"heapDeltaBytes": 3130620,
"heapUsedBytes": 72000820,
"domNodes": 111,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.376999999999999,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 107.92800000001534,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.015999999999998,
"layouts": 2,
"layoutDurationMs": 0.6859999999999999,
"taskDurationMs": 68.90699999999998,
"heapDeltaBytes": 3032416,
"heapUsedBytes": 71671836,
"domNodes": 106,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.366,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #17341 +/- ##
============================================
Coverage 82.98% 82.98%
============================================
Files 2053 2053
Lines 119707 119720 +13
Branches 32785 30970 -1815
============================================
+ Hits 99334 99347 +13
Misses 20193 20193
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #17319 to 1.54. Clean cherry-pick of
928cd4a5e5; typecheck and the two slot-label tests green locally.Full context for agent readers
928cd4a5e5).-x;pnpm typecheckexit 0;pnpm vitest run src/lib/litegraph/src/node/slotDescriptorView.test.ts src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts→ 6/6 pass.slotDescriptorView.tson core/1.53 and cloud/1.53 lacks theassignedInputViewsplumbing introduced by fix: resolve assigned input slot positions #16510 (risk:xhigh, no backport labels, no backport PRs). Cherry-picking fix: refresh slot labels after rename with ECS node state #17319 onto 1.53 conflicts; a decision on backporting fix: resolve assigned input slot positions #16510 first (or skipping 1.53) is pending with Christian.