Skip to content

fix(billing): success screen shows the charged total and applied promo - #17311

Closed
comfydesigner wants to merge 3 commits into
comfydesigner/checkout-promo-polishfrom
comfydesigner/success-charged-amount
Closed

comfydesigner wants to merge 3 commits into
comfydesigner/checkout-promo-polishfrom
comfydesigner/success-charged-amount

Conversation

@comfydesigner

Copy link
Copy Markdown
Contributor

Closes FE-2119. Stacked on #15159 (review that first — this extends its success-screen surface).

After a discounted checkout, the success card showed the plan's list-derived price and nothing else — the number on screen wasn't the number charged (full-rollout blocker per the embedded-checkout QA thread; the Stripe invoice was always correct, only the display was wrong).

What changes

  • Paid today row in the plan card, from the quote's amount_due_cents — the charged total, already net of every discount. Renders only when the quote carries the amount.
  • Applied-promo line derives from the quote (promotion_code + renewal amount/date) instead of the promoApplied prop that no caller ever passed — the prop is removed. Renewal date formats through formatSubscriptionDate, the same source the settings panel and banner use.
  • SuccessAllSet story fixture enriched so the full state (paid today + promo + renewal) is the visual reference.

Tests

  • Charged total renders from amount_due_cents ("$268.80").
  • Promo line renders from quote fields; neither line renders without them.
  • 17/17 on the component file.

┆ Linear: FE-2119

The success card showed the plan's list-derived price and nothing else —
after a discounted checkout the number on screen wasn't the number
charged. The card now carries a Paid today row from the quote's
amount_due_cents, and the applied-promo line (code + renewal terms)
derives from the quote instead of a promoApplied prop nothing ever
passed. Both render only when the quote carries the data.
@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 256bb569-0fdc-4e15-9e76-9663b375faa7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/10/2026, 10:59:42 PM UTC

Links

🎭 Playwright: ❌ -1966 passed, 1963 failed

❌ Failed Tests

📊 Browser Reports

📦 Bundle Size

⏳ Size data collection in progress…

🔬 E2E Coverage

⚠️ Coverage collection failed. Check the CI workflow logs.

@codecov

codecov Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                          Coverage Diff                           @@
##             comfydesigner/checkout-promo-polish   #17311   +/-   ##
======================================================================
  Coverage                                       ?   81.60%           
======================================================================
  Files                                          ?     2086           
  Lines                                          ?   151608           
  Branches                                       ?    50413           
======================================================================
  Hits                                           ?   123714           
  Misses                                         ?    27082           
  Partials                                       ?      812           
Flag Coverage Δ
unit 78.01% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...kspace/components/SubscriptionSuccessWorkspace.vue 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 10, 2026
…ish' into comfydesigner/success-charged-amount
@comfydesigner

Copy link
Copy Markdown
Contributor Author

Closing: this edits the old in-app success screen, which now renders from account-ui's CheckoutSuccess (#19100), so it no longer fixes either success screen. FE-2119 still reproduces in the full-page checkout: CheckoutEnding shows new_plan.price_cents, the pre-discount price. What the success card should show under a promo is being designed; the outcome will be recorded in DES-1212.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant