Repository navigation
fix(billing): success screen shows the charged total and applied promo - #17311
comfydesigner wants to merge 3 commits into
Conversation
The success card showed the plan's list-derived price and nothing else — after a discounted checkout the number on screen wasn't the number charged. The card now carries a Paid today row from the quote's amount_due_cents, and the applied-promo line (code + renewal terms) derives from the quote instead of a promoApplied prop nothing ever passed. Both render only when the quote carries the data.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ -1966 passed, 1963 failed❌ Failed Tests📊 Browser Reports
📦 Bundle Size
🔬 E2E Coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## comfydesigner/checkout-promo-polish #17311 +/- ##
======================================================================
Coverage ? 81.60%
======================================================================
Files ? 2086
Lines ? 151608
Branches ? 50413
======================================================================
Hits ? 123714
Misses ? 27082
Partials ? 812
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…ish' into comfydesigner/success-charged-amount
|
Closing: this edits the old in-app success screen, which now renders from account-ui's CheckoutSuccess (#19100), so it no longer fixes either success screen. FE-2119 still reproduces in the full-page checkout: CheckoutEnding shows new_plan.price_cents, the pre-discount price. What the success card should show under a promo is being designed; the outcome will be recorded in DES-1212. |
Closes FE-2119. Stacked on #15159 (review that first — this extends its success-screen surface).
After a discounted checkout, the success card showed the plan's list-derived price and nothing else — the number on screen wasn't the number charged (full-rollout blocker per the embedded-checkout QA thread; the Stripe invoice was always correct, only the display was wrong).
What changes
amount_due_cents— the charged total, already net of every discount. Renders only when the quote carries the amount.promotion_code+ renewal amount/date) instead of thepromoAppliedprop that no caller ever passed — the prop is removed. Renewal date formats throughformatSubscriptionDate, the same source the settings panel and banner use.SuccessAllSetstory fixture enriched so the full state (paid today + promo + renewal) is the visual reference.Tests
amount_due_cents("$268.80").┆ Linear: FE-2119