Repository navigation
fix: order hidden link badges by socket position and reuse hitboxes #17213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0d80540
fix: order hidden link badges by socket position and reuse hitboxes
jaeone94 4355b70
fix: preserve hidden link reveal lifecycle
jaeone94 3bba2a3
chore: merge main into hidden-link badge ordering
jaeone94 ed120fd
fix: preserve link reveals and badge order through interactions
jaeone94 4aa3d7a
fix: scope hidden-link badge PR to slot ordering and hitboxes
jaeone94 3c33856
fix: provide lint CI script for current PR workflow
jaeone94 828d52d
fix: align lint cache script with main
jaeone94 ea13ff5
fix: repair pnpm lockfile
github-actions[bot] bb9c9d6
revert: remove PR-specific lint script and lockfile changes
jaeone94 e4eb466
chore: merge main into slot badge ordering
jaeone94 31956d0
chore: merge main into slot badge ordering
DrJKL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P3] Nit: Keep each table row’s setup explicit. This ternary makes the row compute its own scenario, and the test then loops to hide links. The repository test guidance requires scenario values in the rows and no conditionals or loops in test bodies. Please put the explicit slot order in each row and patch the two links directly, or move that setup into a helper outside the test body. The same new one-layout loops appear in the visibility, context-menu, and badge-layout tests; retrieving the expected layout with
assert.existsbefore drawing would also make an empty map fail at setup.