Repository navigation
[backport cloud/1.53] fix(stores): align collision contracts across entity registries (FE-1811) - #17190
Conversation
…811) (#15720) ## Summary - **`nodeDataStore`**: add `console.error` on id collision — it was the only store that silently rejected without logging, making a real identity bug indistinguishable from a no-op at runtime. Matches the style already used by `linkStore` and `rerouteStore`. - **`widgetValueStore`**: preserve the existing type-mismatch overwrite behavior, but add a comment in the implementation explaining *why* — the rationale previously lived only in a test comment, invisible to extension authors reading the store. Widget keys are slot-addressable and can legitimately change type after a subgraph convert; this is intentionally different from the other three stores where IDs are identity-stable. - **`nodeDataStore.test.ts`**: extend the existing duplicate-id rejection test to assert the error is logged. Closes FE-1811. Answers issue Q5 ("where is that written so an extension author finds it?") by moving the rationale into the implementation. ## Test plan - [ ] Existing `nodeDataStore.test.ts` duplicate-id test now asserts `console.error` is called - [ ] Existing `widgetValueStore.test.ts` type-mismatch test continues to pass (behavior unchanged) - [ ] `pnpm typecheck` passes 🤖 Generated with [Claude Code](https://claude.com/claude-code)
🎭 Playwright: ✅ 1890 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-08T21:32:06.992Z",
"gitSha": "1cf1e8e84b99dda0b130c72b681364b90924d059",
"branch": "backport-15720-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2050.407000000007,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.849,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.184,
"heapDeltaBytes": -570444,
"heapUsedBytes": 69152028,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.901000000000002,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.786000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.7730000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.681,
"heapDeltaBytes": -9559132,
"heapUsedBytes": 60064944,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.555000000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1758.4429999999998,
"styleRecalcs": 73,
"styleRecalcDurationMs": 30.962000000000003,
"layouts": 14,
"layoutDurationMs": 4.252,
"taskDurationMs": 745.202,
"heapDeltaBytes": -8679140,
"heapUsedBytes": 61655124,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 123.32499999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1701.4450000000352,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.715,
"layouts": 14,
"layoutDurationMs": 3.7809999999999997,
"taskDurationMs": 689.744,
"heapDeltaBytes": -8423868,
"heapUsedBytes": 61690784,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 114.78500000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1659.402,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.106,
"layouts": 6,
"layoutDurationMs": 1.006,
"taskDurationMs": 292.66900000000004,
"heapDeltaBytes": 4432564,
"heapUsedBytes": 74802032,
"domNodes": 78,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 9.641000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.1059999999952,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.512999999999998,
"layouts": 6,
"layoutDurationMs": 1.124,
"taskDurationMs": 307.636,
"heapDeltaBytes": 4499272,
"heapUsedBytes": 74637612,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.795,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 542.4339999999575,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.640999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.405,
"heapDeltaBytes": -8187604,
"heapUsedBytes": 62550280,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 127.603,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 544.1629999999122,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.625000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.854,
"heapDeltaBytes": -8166016,
"heapUsedBytes": 62438896,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 123.524,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2028.9089999999987,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.381000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.397,
"heapDeltaBytes": -13019956,
"heapUsedBytes": 87122396,
"domNodes": -266,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 28.452999999999992,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2018.8859999999522,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.289999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.09199999999987,
"heapDeltaBytes": -13485932,
"heapUsedBytes": 87112748,
"domNodes": -267,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 30.329,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2112.5200000000177,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.096,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1271.203,
"heapDeltaBytes": 18264120,
"heapUsedBytes": 84310392,
"domNodes": 8,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 627.308,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2112.7740000000585,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.31,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1263.0829999999999,
"heapDeltaBytes": 17851804,
"heapUsedBytes": 83950796,
"domNodes": 8,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 611.462,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3133.039999999994,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.319,
"layouts": 60,
"layoutDurationMs": 11.224,
"taskDurationMs": 1365.996,
"heapDeltaBytes": 11731548,
"heapUsedBytes": 79441780,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 607.708,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3193.0139999999483,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.451000000000002,
"layouts": 60,
"layoutDurationMs": 11.056,
"taskDurationMs": 1362.792,
"heapDeltaBytes": 8522256,
"heapUsedBytes": 76070380,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 619.053,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2509.4139999999925,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.239999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1530.2250000000001,
"heapDeltaBytes": 13602860,
"heapUsedBytes": 80513704,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 749.7429999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2427.404000000024,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.097999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1575.9030000000002,
"heapDeltaBytes": 14486256,
"heapUsedBytes": 81095000,
"domNodes": 4,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 753.907,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2015.2579999999602,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.066000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.60100000000006,
"heapDeltaBytes": 21777340,
"heapUsedBytes": 87680672,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.301000000000005,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.375999999961,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.685999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.01400000000007,
"heapDeltaBytes": -15617448,
"heapUsedBytes": 86533844,
"domNodes": -265,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 32.941,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.6389999999842,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.476999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.042,
"heapDeltaBytes": 13997224,
"heapUsedBytes": 85666748,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 108.729,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 527.4160000000165,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.741000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.007,
"heapDeltaBytes": 14789956,
"heapUsedBytes": 87412196,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 108.641,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1989.4160000000056,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.102,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.6259999999999,
"heapDeltaBytes": -6908356,
"heapUsedBytes": 65667648,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.544999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.0679999999375,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.363999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.567,
"heapDeltaBytes": -7557252,
"heapUsedBytes": 65041456,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.106000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1729.914000000008,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.517000000000003,
"layouts": 18,
"layoutDurationMs": 5.062,
"taskDurationMs": 675.496,
"heapDeltaBytes": 8387348,
"heapUsedBytes": 80269564,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 92.06800000000001,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.1480000000647,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.577,
"layouts": 18,
"layoutDurationMs": 4.768000000000001,
"taskDurationMs": 656.451,
"heapDeltaBytes": -12853708,
"heapUsedBytes": 59823116,
"domNodes": -298,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 87.57,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 912.3700000000099,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.302000000000007,
"layouts": 16,
"layoutDurationMs": 12.096999999999998,
"taskDurationMs": 728.731,
"heapDeltaBytes": -7430124,
"heapUsedBytes": 85693392,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 22.360999999999994,
"eventListeners": 2381,
"totalBlockingTimeMs": 91,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8200.96000000001,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.289,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4547.625,
"heapDeltaBytes": -11819084,
"heapUsedBytes": 88549440,
"domNodes": -268,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 2060.284,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8166.784000000007,
"styleRecalcs": 243,
"styleRecalcDurationMs": 31.973000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4472.023999999999,
"heapDeltaBytes": 22767376,
"heapUsedBytes": 87986380,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2045.245,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14848.611000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14380.666000000001,
"heapDeltaBytes": -44125612,
"heapUsedBytes": 176135168,
"domNodes": -6548,
"jsHeapTotalBytes": -8089600,
"scriptDurationMs": 213.062,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15015.18400000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14509.000999999998,
"heapDeltaBytes": -45210148,
"heapUsedBytes": 174235900,
"domNodes": -6548,
"jsHeapTotalBytes": -8298496,
"scriptDurationMs": 249.74600000000004,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17599.604,
"styleRecalcs": 147,
"styleRecalcDurationMs": 14.401999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17192.952999999998,
"heapDeltaBytes": -26208544,
"heapUsedBytes": 182270424,
"domNodes": -6548,
"jsHeapTotalBytes": 2191360,
"scriptDurationMs": 721.474,
"eventListeners": -7471,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17221.18499999999,
"styleRecalcs": 132,
"styleRecalcDurationMs": 14.951999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16981.55,
"heapDeltaBytes": -12462280,
"heapUsedBytes": 176339452,
"domNodes": -6548,
"jsHeapTotalBytes": 24576,
"scriptDurationMs": 722.5630000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5276.823000000036,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.18899999999999,
"layouts": 20,
"layoutDurationMs": 20.948999999999995,
"taskDurationMs": 5202.323999999999,
"heapDeltaBytes": -27376740,
"heapUsedBytes": 181028016,
"domNodes": -6548,
"jsHeapTotalBytes": 14774272,
"scriptDurationMs": 86.76100000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 249,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5318.100999999956,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.410999999999994,
"layouts": 20,
"layoutDurationMs": 21.12,
"taskDurationMs": 5290.272,
"heapDeltaBytes": -36920952,
"heapUsedBytes": 178726096,
"domNodes": -6548,
"jsHeapTotalBytes": 16003072,
"scriptDurationMs": 93.50500000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 217,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 90.63900000001013,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.41,
"layouts": 2,
"layoutDurationMs": 0.472,
"taskDurationMs": 61.25600000000001,
"heapDeltaBytes": 3259120,
"heapUsedBytes": 71500964,
"domNodes": 109,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.807,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 431.9160000000011,
"styleRecalcs": 14,
"styleRecalcDurationMs": 17.944000000000003,
"layouts": 2,
"layoutDurationMs": 0.4620000000000001,
"taskDurationMs": 83.87,
"heapDeltaBytes": 5059676,
"heapUsedBytes": 73405352,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.591000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.53 #17190 +/- ##
=============================================
Coverage ? 83.34%
=============================================
Files ? 2025
Lines ? 117255
Branches ? 33357
=============================================
Hits ? 97728
Misses ? 19179
Partials ? 348
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15720 to
cloud/1.53Automatically created by backport workflow.