Skip to content

[backport cloud/1.53] fix(stores): align collision contracts across entity registries (FE-1811) - #17190

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-15720-to-cloud-1.53
Sep 8, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-15720-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #15720 to cloud/1.53

Automatically created by backport workflow.

…811) (#15720)

## Summary

- **`nodeDataStore`**: add `console.error` on id collision — it was the
only store that silently rejected without logging, making a real
identity bug indistinguishable from a no-op at runtime. Matches the
style already used by `linkStore` and `rerouteStore`.
- **`widgetValueStore`**: preserve the existing type-mismatch overwrite
behavior, but add a comment in the implementation explaining *why* — the
rationale previously lived only in a test comment, invisible to
extension authors reading the store. Widget keys are slot-addressable
and can legitimately change type after a subgraph convert; this is
intentionally different from the other three stores where IDs are
identity-stable.
- **`nodeDataStore.test.ts`**: extend the existing duplicate-id
rejection test to assert the error is logged.

Closes FE-1811. Answers issue Q5 ("where is that written so an extension
author finds it?") by moving the rationale into the implementation.

## Test plan

- [ ] Existing `nodeDataStore.test.ts` duplicate-id test now asserts
`console.error` is called
- [ ] Existing `widgetValueStore.test.ts` type-mismatch test continues
to pass (behavior unchanged)
- [ ] `pnpm typecheck` passes

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 8, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 8, 2026 21:19
@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1890 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1869 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/08/2026, 09:21:40 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.2 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 91ms TBT · 81.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.1 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 7ms TBT · 171.0 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 233ms TBT · 171.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 417ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.6 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -171
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 717ms
canvas-mouse-sweep: script duration 119ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.8 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 300ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.3 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 366ms
dom-widget-clipping: script duration 126ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 59.6 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 482ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.1 MB
large-graph-idle: DOM nodes -267
large-graph-idle: event listeners -152
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1267ms
large-graph-pan: script duration 619ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.2 MB
large-graph-pan: DOM nodes 8
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1364ms
large-graph-zoom: script duration 613ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.2 MB
large-graph-zoom: DOM nodes 2
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1553ms
legacy-node-drag: script duration 752ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.1 MB
legacy-node-drag: DOM nodes 4
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 463ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.1 MB
minimap-idle: DOM nodes -270
minimap-idle: event listeners -151
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 325ms
subgraph-dom-widget-clipping: script duration 109ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.5 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 393ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.3 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -201
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 31ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 666ms
subgraph-mouse-sweep: script duration 90ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 66.8 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -216
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 25ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 729ms
subgraph-transition-enter: script duration 22ms
subgraph-transition-enter: TBT 91ms
subgraph-transition-enter: heap used 81.7 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 4510ms
viewport-pan-sweep: script duration 2053ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.2 MB
viewport-pan-sweep: DOM nodes -133
viewport-pan-sweep: event listeners -59
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14445ms
vue-large-graph-idle: script duration 231ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.1 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 140
vue-large-graph-pan: task duration 17087ms
vue-large-graph-pan: script duration 722ms
vue-large-graph-pan: TBT 7ms
vue-large-graph-pan: heap used 171.0 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7471
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 60ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5246ms
vue-node-resize-workload: script duration 90ms
vue-node-resize-workload: TBT 233ms
vue-node-resize-workload: heap used 171.5 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 0ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 2
workflow-execution: style recalc count 10
workflow-execution: task duration 73ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.1 MB
workflow-execution: DOM nodes 117
workflow-execution: event listeners 73
Raw data
{
  "timestamp": "2026-09-08T21:32:06.992Z",
  "gitSha": "1cf1e8e84b99dda0b130c72b681364b90924d059",
  "branch": "backport-15720-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2050.407000000007,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.849,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 435.184,
      "heapDeltaBytes": -570444,
      "heapUsedBytes": 69152028,
      "domNodes": -279,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.901000000000002,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2024.786000000006,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.7730000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 399.681,
      "heapDeltaBytes": -9559132,
      "heapUsedBytes": 60064944,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.555000000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1758.4429999999998,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 30.962000000000003,
      "layouts": 14,
      "layoutDurationMs": 4.252,
      "taskDurationMs": 745.202,
      "heapDeltaBytes": -8679140,
      "heapUsedBytes": 61655124,
      "domNodes": -278,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 123.32499999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1701.4450000000352,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 28.715,
      "layouts": 14,
      "layoutDurationMs": 3.7809999999999997,
      "taskDurationMs": 689.744,
      "heapDeltaBytes": -8423868,
      "heapUsedBytes": 61690784,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 114.78500000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1659.402,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.106,
      "layouts": 6,
      "layoutDurationMs": 1.006,
      "taskDurationMs": 292.66900000000004,
      "heapDeltaBytes": 4432564,
      "heapUsedBytes": 74802032,
      "domNodes": 78,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 9.641000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1686.1059999999952,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 15.512999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.124,
      "taskDurationMs": 307.636,
      "heapDeltaBytes": 4499272,
      "heapUsedBytes": 74637612,
      "domNodes": 79,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.795,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 542.4339999999575,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.640999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.405,
      "heapDeltaBytes": -8187604,
      "heapUsedBytes": 62550280,
      "domNodes": 18,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 127.603,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 544.1629999999122,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.625000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.854,
      "heapDeltaBytes": -8166016,
      "heapUsedBytes": 62438896,
      "domNodes": 20,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 123.524,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.9089999999987,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.381000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.397,
      "heapDeltaBytes": -13019956,
      "heapUsedBytes": 87122396,
      "domNodes": -266,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 28.452999999999992,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2018.8859999999522,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.289999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.09199999999987,
      "heapDeltaBytes": -13485932,
      "heapUsedBytes": 87112748,
      "domNodes": -267,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 30.329,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2112.5200000000177,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.096,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1271.203,
      "heapDeltaBytes": 18264120,
      "heapUsedBytes": 84310392,
      "domNodes": 8,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 627.308,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2112.7740000000585,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.31,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1263.0829999999999,
      "heapDeltaBytes": 17851804,
      "heapUsedBytes": 83950796,
      "domNodes": 8,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 611.462,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3133.039999999994,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.319,
      "layouts": 60,
      "layoutDurationMs": 11.224,
      "taskDurationMs": 1365.996,
      "heapDeltaBytes": 11731548,
      "heapUsedBytes": 79441780,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 607.708,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3193.0139999999483,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 10.451000000000002,
      "layouts": 60,
      "layoutDurationMs": 11.056,
      "taskDurationMs": 1362.792,
      "heapDeltaBytes": 8522256,
      "heapUsedBytes": 76070380,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 619.053,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2509.4139999999925,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.239999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1530.2250000000001,
      "heapDeltaBytes": 13602860,
      "heapUsedBytes": 80513704,
      "domNodes": 4,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 749.7429999999999,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2427.404000000024,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.097999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1575.9030000000002,
      "heapDeltaBytes": 14486256,
      "heapUsedBytes": 81095000,
      "domNodes": 4,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 753.907,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2015.2579999999602,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.066000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.60100000000006,
      "heapDeltaBytes": 21777340,
      "heapUsedBytes": 87680672,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 28.301000000000005,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2024.375999999961,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.685999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 473.01400000000007,
      "heapDeltaBytes": -15617448,
      "heapUsedBytes": 86533844,
      "domNodes": -265,
      "jsHeapTotalBytes": -1355776,
      "scriptDurationMs": 32.941,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 531.6389999999842,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.476999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 327.042,
      "heapDeltaBytes": 13997224,
      "heapUsedBytes": 85666748,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 108.729,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 527.4160000000165,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 9.741000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 322.007,
      "heapDeltaBytes": 14789956,
      "heapUsedBytes": 87412196,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 108.641,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1989.4160000000056,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.102,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 395.6259999999999,
      "heapDeltaBytes": -6908356,
      "heapUsedBytes": 65667648,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 6.544999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.0679999999375,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.363999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 389.567,
      "heapDeltaBytes": -7557252,
      "heapUsedBytes": 65041456,
      "domNodes": -295,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.106000000000002,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1729.914000000008,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 31.517000000000003,
      "layouts": 18,
      "layoutDurationMs": 5.062,
      "taskDurationMs": 675.496,
      "heapDeltaBytes": 8387348,
      "heapUsedBytes": 80269564,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 92.06800000000001,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.1480000000647,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.577,
      "layouts": 18,
      "layoutDurationMs": 4.768000000000001,
      "taskDurationMs": 656.451,
      "heapDeltaBytes": -12853708,
      "heapUsedBytes": 59823116,
      "domNodes": -298,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 87.57,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 912.3700000000099,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 25.302000000000007,
      "layouts": 16,
      "layoutDurationMs": 12.096999999999998,
      "taskDurationMs": 728.731,
      "heapDeltaBytes": -7430124,
      "heapUsedBytes": 85693392,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 22.360999999999994,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 91,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8200.96000000001,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 36.289,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4547.625,
      "heapDeltaBytes": -11819084,
      "heapUsedBytes": 88549440,
      "domNodes": -268,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 2060.284,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8166.784000000007,
      "styleRecalcs": 243,
      "styleRecalcDurationMs": 31.973000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4472.023999999999,
      "heapDeltaBytes": 22767376,
      "heapUsedBytes": 87986380,
      "domNodes": 2,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 2045.245,
      "eventListeners": 20,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14848.611000000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14380.666000000001,
      "heapDeltaBytes": -44125612,
      "heapUsedBytes": 176135168,
      "domNodes": -6548,
      "jsHeapTotalBytes": -8089600,
      "scriptDurationMs": 213.062,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15015.18400000009,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14509.000999999998,
      "heapDeltaBytes": -45210148,
      "heapUsedBytes": 174235900,
      "domNodes": -6548,
      "jsHeapTotalBytes": -8298496,
      "scriptDurationMs": 249.74600000000004,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17599.604,
      "styleRecalcs": 147,
      "styleRecalcDurationMs": 14.401999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17192.952999999998,
      "heapDeltaBytes": -26208544,
      "heapUsedBytes": 182270424,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2191360,
      "scriptDurationMs": 721.474,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 8,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17221.18499999999,
      "styleRecalcs": 132,
      "styleRecalcDurationMs": 14.951999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16981.55,
      "heapDeltaBytes": -12462280,
      "heapUsedBytes": 176339452,
      "domNodes": -6548,
      "jsHeapTotalBytes": 24576,
      "scriptDurationMs": 722.5630000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 5,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5276.823000000036,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.18899999999999,
      "layouts": 20,
      "layoutDurationMs": 20.948999999999995,
      "taskDurationMs": 5202.323999999999,
      "heapDeltaBytes": -27376740,
      "heapUsedBytes": 181028016,
      "domNodes": -6548,
      "jsHeapTotalBytes": 14774272,
      "scriptDurationMs": 86.76100000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 249,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5318.100999999956,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 59.410999999999994,
      "layouts": 20,
      "layoutDurationMs": 21.12,
      "taskDurationMs": 5290.272,
      "heapDeltaBytes": -36920952,
      "heapUsedBytes": 178726096,
      "domNodes": -6548,
      "jsHeapTotalBytes": 16003072,
      "scriptDurationMs": 93.50500000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 217,
      "frameDurationMs": 18.329999999999988,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 90.63900000001013,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 9.41,
      "layouts": 2,
      "layoutDurationMs": 0.472,
      "taskDurationMs": 61.25600000000001,
      "heapDeltaBytes": 3259120,
      "heapUsedBytes": 71500964,
      "domNodes": 109,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 4.807,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 431.9160000000011,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 17.944000000000003,
      "layouts": 2,
      "layoutDurationMs": 0.4620000000000001,
      "taskDurationMs": 83.87,
      "heapDeltaBytes": 5059676,
      "heapUsedBytes": 73405352,
      "domNodes": 125,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.591000000000001,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48114 70663 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.8% 255
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/renderer/core/canvas/pathRenderer.ts 24.7% 192

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 8, 2026
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #17190   +/-   ##
=============================================
  Coverage              ?   83.34%           
=============================================
  Files                 ?     2025           
  Lines                 ?   117255           
  Branches              ?    33357           
=============================================
  Hits                  ?    97728           
  Misses                ?    19179           
  Partials              ?      348           
Flag Coverage Δ
e2e 66.59% <100.00%> (?)
unit 76.70% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/core/graph/nodeShell/nodeShellLifecycle.ts 93.33% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit a8a9351 into cloud/1.53 Sep 8, 2026
107 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-15720-to-cloud-1.53 branch September 8, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants