Skip to content

[backport cloud/1.53] fix: hand extension configure hooks a shallow copy of the serialized object - #17189

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16956-to-cloud-1.53
Sep 8, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16956-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16956 to cloud/1.53

Automatically created by backport workflow.

…object (#16956)

Extension `configure()` hooks now receive a shallow copy of the
serialized node/graph object instead of the caller's live reference, so
a hook that reassigns or adds top-level fields (or the payload promotion
itself) no longer pollutes the caller's workflow JSON. No serialization
boundary is introduced inside `configure`: live `NodeInputSlot`
instances and other callback value shapes pass through untouched. Split
out of #16508 at the reviewer's request.

<details><summary>Full context for agent readers</summary>

## Summary

`extensionConfigureView` `Object.assign`'d the namespaced/legacy
extension payload directly onto the caller's live serialized object and
handed that object to `onConfigure`. Any hook mutation of its argument,
and the promotion of namespaced keys to top-level fields, leaked back
into the caller's data. Flagged in review of #15924
(#15924 (comment))
and tracked in #15973.

## Change

`extensionConfigureView` now builds the view as `Object.assign({
...canonical }, structuredClone(namespaced), structuredClone(legacy))`
and hands that to `onConfigure`. This is a shallow copy of the canonical
object: it isolates object identity and keeps promoted extension keys
off the caller's object (the two consequences raised in the #15924
review), without re-encoding anything. Nested values (`inputs`, `pos`,
`properties`, `widgets_values`, ...) stay shared with the caller by
design; in-place mutation of those still reaches the caller's data, and
the migration doc says so and points extensions at `node.properties` /
`graph.extra` for their own state.

An earlier revision of this PR used a JSON round trip for a deep copy.
That was dropped after review: `JSON.stringify` is a new failure and
representation boundary in the middle of `configure` (circular
references and BigInt throw; `undefined`, dates and class instances are
rewritten), and `configure` previously guaranteed the callback saw the
supported value shapes. The extension payloads themselves are still
validated as JSON and `structuredClone`d as before; the
`cloneSerialised` helper is gone.

## Tests

- `extensionPersistence.test.ts` (new): `onConfigure` receives a copy,
not the caller's object, and top-level adds/reassigns/deletes on the
view do not reach the caller (including `size` and `extensions`); a
serialized object holding live slot instances configures without
throwing and the hook sees the same `inputs` array and slot instance the
caller passed; serialize does not promote namespaced keys to top-level
fields; a missing-node placeholder stays free of promoted keys after
`onConfigure` mutates its view.
- `LGraph.serialise.test.ts`: the existing "passes the original
serialized object" test now asserts the hook gets a copy and that a
top-level field added by the hook is absent from the saved workflow.

No test asserts JSON-derived shapes. Verified green for
`src/lib/litegraph/src/extensionPersistence.test.ts
src/lib/litegraph/src/LGraph.serialise.test.ts
src/services/litegraphService.lateRegistration.test.ts` (28 tests), plus
typecheck, lint and format.

## Provenance

Extracted from #16508 (head f210e61) in response to the request to
split the configure-isolation fix from the coverage-only work. #16508
keeps the dynamic-widget fix and the `getNodeOnPos` coverage. Sibling
split: the `removeNode` `keep-values` fix.

Addresses #15973 (isolation for extension `configure()`).

</details>

<!-- authored-by:agent w3-w29 -->

---------

Co-authored-by: Amp <amp@ampcode.com>
@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1894 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1873 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/08/2026, 09:21:33 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 144ms TBT · 103.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.0 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 74ms TBT · 171.7 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 484ms TBT · 168.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 575ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 56.8 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 45ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 1021ms
canvas-mouse-sweep: script duration 182ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.6 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -185
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 2ms
canvas-zoom-sweep: style recalc duration 33ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 532ms
canvas-zoom-sweep: script duration 22ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.7 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 469ms
dom-widget-clipping: script duration 164ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.1 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 669ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.7 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -168
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1672ms
large-graph-pan: script duration 816ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.8 MB
large-graph-pan: DOM nodes -271
large-graph-pan: event listeners -168
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1831ms
large-graph-zoom: script duration 816ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.9 MB
large-graph-zoom: DOM nodes -142
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2051ms
legacy-node-drag: script duration 1003ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 84.7 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 1ms
minimap-idle: layout count 0
minimap-idle: style recalc count 1
minimap-idle: task duration 636ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.0 MB
minimap-idle: DOM nodes -138
minimap-idle: event listeners -74
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 15ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 44
subgraph-dom-widget-clipping: task duration 516ms
subgraph-dom-widget-clipping: script duration 174ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.0 MB
subgraph-dom-widget-clipping: DOM nodes 13
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 538ms
subgraph-idle: script duration 11ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.3 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -201
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 40ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 918ms
subgraph-mouse-sweep: script duration 122ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 72.1 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -232
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 1051ms
subgraph-transition-enter: script duration 34ms
subgraph-transition-enter: TBT 144ms
subgraph-transition-enter: heap used 103.5 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 6430ms
viewport-pan-sweep: script duration 2887ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.8 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -55
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17131ms
vue-large-graph-idle: script duration 303ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.0 MB
vue-large-graph-idle: DOM nodes -6563
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 171
vue-large-graph-pan: task duration 21216ms
vue-large-graph-pan: script duration 940ms
vue-large-graph-pan: TBT 74ms
vue-large-graph-pan: heap used 171.7 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7468
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 82ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6158ms
vue-node-resize-workload: script duration 119ms
vue-node-resize-workload: TBT 484ms
vue-node-resize-workload: heap used 168.6 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7472
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 3
workflow-execution: style recalc count 16
workflow-execution: task duration 119ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.2 MB
workflow-execution: DOM nodes 137
workflow-execution: event listeners 99
Raw data
{
  "timestamp": "2026-09-08T21:33:46.764Z",
  "gitSha": "b00f154c38c5cae828af2e52624808bb7f211b85",
  "branch": "backport-16956-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2067.830000000015,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.874999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 524.1769999999999,
      "heapDeltaBytes": -10371056,
      "heapUsedBytes": 59238988,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.425,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2035.7189999999719,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.876,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 625.502,
      "heapDeltaBytes": -10542784,
      "heapUsedBytes": 59906660,
      "domNodes": -283,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 14.015,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2076.2339999999995,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 46.375,
      "layouts": 14,
      "layoutDurationMs": 4.995,
      "taskDurationMs": 1056.943,
      "heapDeltaBytes": 4910800,
      "heapUsedBytes": 75579840,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 188.974,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1936.9599999999991,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 43.683,
      "layouts": 14,
      "layoutDurationMs": 4.739,
      "taskDurationMs": 985.655,
      "heapDeltaBytes": 6327820,
      "heapUsedBytes": 76716016,
      "domNodes": -279,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 174.373,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.1209999999546,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 20.443,
      "layouts": 6,
      "layoutDurationMs": 1.394,
      "taskDurationMs": 443.943,
      "heapDeltaBytes": 4500332,
      "heapUsedBytes": 75051316,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 16.249000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1941.5840000000344,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 45.043,
      "layouts": 6,
      "layoutDurationMs": 3.0360000000000005,
      "taskDurationMs": 620.664,
      "heapDeltaBytes": 4710132,
      "heapUsedBytes": 75382240,
      "domNodes": 75,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 27.436000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 704.1990000000169,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.686999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 473.90200000000004,
      "heapDeltaBytes": -7783940,
      "heapUsedBytes": 62989720,
      "domNodes": 18,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 165.42600000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 676.4170000000149,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.075000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.61699999999996,
      "heapDeltaBytes": 18757768,
      "heapUsedBytes": 88306536,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 163.048,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2052.1790000000237,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.4649999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 667.8360000000001,
      "heapDeltaBytes": -13686344,
      "heapUsedBytes": 86730688,
      "domNodes": -271,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 35.925,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.318999999964,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.274,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 669.3560000000001,
      "heapDeltaBytes": 10948860,
      "heapUsedBytes": 86806876,
      "domNodes": -272,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 35.931000000000004,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2471.3840000000005,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.545999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1739.398,
      "heapDeltaBytes": 8889416,
      "heapUsedBytes": 84764320,
      "domNodes": -272,
      "jsHeapTotalBytes": 143360,
      "scriptDurationMs": 831.208,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2211.3620000000083,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.134000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1603.825,
      "heapDeltaBytes": 19318820,
      "heapUsedBytes": 84600980,
      "domNodes": -270,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 801.0690000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3840.2920000000336,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.599999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.896999999999998,
      "taskDurationMs": 1826.198,
      "heapDeltaBytes": 12032152,
      "heapUsedBytes": 79532892,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 819.508,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3793.2179999999107,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.654999999999998,
      "layouts": 60,
      "layoutDurationMs": 13.002999999999997,
      "taskDurationMs": 1835.6789999999999,
      "heapDeltaBytes": 8036008,
      "heapUsedBytes": 75371312,
      "domNodes": -283,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 812.212,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3248.2609999999568,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 6.013000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2063.4049999999997,
      "heapDeltaBytes": 20485520,
      "heapUsedBytes": 87595176,
      "domNodes": 0,
      "jsHeapTotalBytes": 1728512,
      "scriptDurationMs": 996.817,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3165.661,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.174000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2038.237,
      "heapDeltaBytes": 23122948,
      "heapUsedBytes": 89965552,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 1009.517,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2016.9519999999466,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 1.3469999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 636.0100000000001,
      "heapDeltaBytes": 21781988,
      "heapUsedBytes": 87907404,
      "domNodes": -277,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.904,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 1997.7790000000368,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.8540000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 636.1519999999999,
      "heapDeltaBytes": 22116364,
      "heapUsedBytes": 88192756,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 36.425,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 637.1030000000246,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.460999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 440.42099999999994,
      "heapDeltaBytes": 14799484,
      "heapUsedBytes": 87259648,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 146.09,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 829.4409999999743,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 19.472000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 590.662,
      "heapDeltaBytes": 15105972,
      "heapUsedBytes": 86889436,
      "domNodes": 8,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 202.09099999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.9459999999808,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.146,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 541.0590000000001,
      "heapDeltaBytes": -6359596,
      "heapUsedBytes": 66238476,
      "domNodes": -298,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.724999999999998,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.6000000000586,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.427,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 534.261,
      "heapDeltaBytes": -9912504,
      "heapUsedBytes": 62402880,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.378000000000002,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1733.7830000000167,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 37.86,
      "layouts": 18,
      "layoutDurationMs": 4.9030000000000005,
      "taskDurationMs": 886.047,
      "heapDeltaBytes": 3117908,
      "heapUsedBytes": 75935656,
      "domNodes": -297,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 117.921,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1774.2339999999786,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 42.592999999999996,
      "layouts": 18,
      "layoutDurationMs": 6.09,
      "taskDurationMs": 949.249,
      "heapDeltaBytes": 2396884,
      "heapUsedBytes": 75253596,
      "domNodes": -294,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 125.99,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1418.0939999999964,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 33.60800000000001,
      "layouts": 16,
      "layoutDurationMs": 16.475000000000005,
      "taskDurationMs": 1050.658,
      "heapDeltaBytes": 21043260,
      "heapUsedBytes": 108520860,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 33.82599999999999,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 144,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9620.917999999961,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 42.05,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6383.991,
      "heapDeltaBytes": -15234964,
      "heapUsedBytes": 85195688,
      "domNodes": -267,
      "jsHeapTotalBytes": -1425408,
      "scriptDurationMs": 2852.38,
      "eventListeners": -135,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10019.159000000058,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 37.638999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6475.225,
      "heapDeltaBytes": 23483596,
      "heapUsedBytes": 88550392,
      "domNodes": -272,
      "jsHeapTotalBytes": 454656,
      "scriptDurationMs": 2921.4410000000003,
      "eventListeners": 26,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18053.86999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17305.713,
      "heapDeltaBytes": -34085468,
      "heapUsedBytes": 175953792,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2908160,
      "scriptDurationMs": 292.47399999999993,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17715.963999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16956.119000000002,
      "heapDeltaBytes": -34523316,
      "heapUsedBytes": 174176928,
      "domNodes": -6577,
      "jsHeapTotalBytes": -5115904,
      "scriptDurationMs": 314.11100000000005,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22165.52899999999,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 22.24100000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21810.098,
      "heapDeltaBytes": -21898084,
      "heapUsedBytes": 180383052,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1822720,
      "scriptDurationMs": 970.0500000000001,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 131,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21042.672999999922,
      "styleRecalcs": 166,
      "styleRecalcDurationMs": 16.720000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20621.161999999997,
      "heapDeltaBytes": -26247404,
      "heapUsedBytes": 179708216,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3837952,
      "scriptDurationMs": 909.2269999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 16,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6288.349000000039,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 83.656,
      "layouts": 20,
      "layoutDurationMs": 24.360000000000007,
      "taskDurationMs": 6189.870999999999,
      "heapDeltaBytes": -22581168,
      "heapUsedBytes": 178898912,
      "domNodes": -6548,
      "jsHeapTotalBytes": 16502784,
      "scriptDurationMs": 118.476,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 532,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6242.618999999991,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.82100000000003,
      "layouts": 20,
      "layoutDurationMs": 21.823000000000008,
      "taskDurationMs": 6126.866000000001,
      "heapDeltaBytes": -29416964,
      "heapUsedBytes": 174719912,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10997760,
      "scriptDurationMs": 120.431,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 436,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 470.56399999996756,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 25.727000000000004,
      "layouts": 4,
      "layoutDurationMs": 2.0159999999999996,
      "taskDurationMs": 128.764,
      "heapDeltaBytes": 5360868,
      "heapUsedBytes": 73717504,
      "domNodes": 153,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 14.161,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 467.71000000012464,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 19.069999999999997,
      "layouts": 2,
      "layoutDurationMs": 0.613,
      "taskDurationMs": 108.30199999999999,
      "heapDeltaBytes": 5055508,
      "heapUsedBytes": 73508528,
      "domNodes": 121,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.87,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48100 70635 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.8% 255
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 8, 2026
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #17189   +/-   ##
=============================================
  Coverage              ?   83.35%           
=============================================
  Files                 ?     2025           
  Lines                 ?   117251           
  Branches              ?    32758           
=============================================
  Hits                  ?    97736           
  Misses                ?    19166           
  Partials              ?      349           
Flag Coverage Δ
e2e 66.59% <ø> (?)
unit 76.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/extensionPersistence.ts 94.28% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit bec5dd5 into cloud/1.53 Sep 8, 2026
106 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16956-to-cloud-1.53 branch September 8, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants