Repository navigation
[backport core/1.53] fix(stores): align collision contracts across entity registries (FE-1811) - #17188
Conversation
…811) (#15720) ## Summary - **`nodeDataStore`**: add `console.error` on id collision — it was the only store that silently rejected without logging, making a real identity bug indistinguishable from a no-op at runtime. Matches the style already used by `linkStore` and `rerouteStore`. - **`widgetValueStore`**: preserve the existing type-mismatch overwrite behavior, but add a comment in the implementation explaining *why* — the rationale previously lived only in a test comment, invisible to extension authors reading the store. Widget keys are slot-addressable and can legitimately change type after a subgraph convert; this is intentionally different from the other three stores where IDs are identity-stable. - **`nodeDataStore.test.ts`**: extend the existing duplicate-id rejection test to assert the error is logged. Closes FE-1811. Answers issue Q5 ("where is that written so an extension author finds it?") by moving the rationale into the implementation. ## Test plan - [ ] Existing `nodeDataStore.test.ts` duplicate-id test now asserts `console.error` is called - [ ] Existing `widgetValueStore.test.ts` type-mismatch test continues to pass (behavior unchanged) - [ ] `pnpm typecheck` passes 🤖 Generated with [Claude Code](https://claude.com/claude-code)
🎭 Playwright: ✅ 1894 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-08T21:33:22.623Z",
"gitSha": "6fc29b2e3033b6f2c5220196e5a7c4ca2d35fdd7",
"branch": "backport-15720-to-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2056.069999999977,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.001999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.303,
"heapDeltaBytes": -1895236,
"heapUsedBytes": 67817332,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.938,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2033.2819999999856,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.666,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.803,
"heapDeltaBytes": -11421820,
"heapUsedBytes": 58271796,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.424999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2074.7649999999567,
"styleRecalcs": 82,
"styleRecalcDurationMs": 54.23500000000001,
"layouts": 14,
"layoutDurationMs": 5.208,
"taskDurationMs": 1094.179,
"heapDeltaBytes": -8718184,
"heapUsedBytes": 61683928,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 199.548,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1836.341999999945,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.519,
"layouts": 14,
"layoutDurationMs": 4.473000000000001,
"taskDurationMs": 874.888,
"heapDeltaBytes": -5864528,
"heapUsedBytes": 64168632,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 157.994,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.7330000000188,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.42,
"layouts": 6,
"layoutDurationMs": 0.9780000000000001,
"taskDurationMs": 373.80800000000005,
"heapDeltaBytes": 4359832,
"heapUsedBytes": 75048340,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.685,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1663.1700000000365,
"styleRecalcs": 29,
"styleRecalcDurationMs": 16.276,
"layouts": 6,
"layoutDurationMs": 1.032,
"taskDurationMs": 375.173,
"heapDeltaBytes": 4419476,
"heapUsedBytes": 75106416,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.221000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 724.2320000000291,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.547,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.2700000000001,
"heapDeltaBytes": -7888672,
"heapUsedBytes": 62835604,
"domNodes": 22,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 164.425,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 710.6159999999591,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.761,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.743,
"heapDeltaBytes": 17758020,
"heapUsedBytes": 87582064,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 165.008,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2050.693000000024,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.211,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.233,
"heapDeltaBytes": 10688908,
"heapUsedBytes": 86648956,
"domNodes": -269,
"jsHeapTotalBytes": -1130496,
"scriptDurationMs": 37.307,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2003.5980000000109,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.6650000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.3360000000001,
"heapDeltaBytes": 22214836,
"heapUsedBytes": 87302612,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.75399999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2238.1090000000086,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.247999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1627.495,
"heapDeltaBytes": 10974100,
"heapUsedBytes": 87301940,
"domNodes": -276,
"jsHeapTotalBytes": -643072,
"scriptDurationMs": 789.374,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2264.2060000000583,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.247000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1668.9989999999998,
"heapDeltaBytes": -13492312,
"heapUsedBytes": 87714768,
"domNodes": -277,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 798.636,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3623.7390000000005,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.860999999999999,
"layouts": 60,
"layoutDurationMs": 11.983999999999998,
"taskDurationMs": 1717.2099999999998,
"heapDeltaBytes": 8493912,
"heapUsedBytes": 75410928,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 773.5320000000002,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3639.5390000000134,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.903999999999996,
"layouts": 60,
"layoutDurationMs": 11.780000000000001,
"taskDurationMs": 1720.477,
"heapDeltaBytes": 9049412,
"heapUsedBytes": 76101804,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 780.535,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3095.4270000000292,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.809999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1953.005,
"heapDeltaBytes": 26912272,
"heapUsedBytes": 93728716,
"domNodes": -281,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 956.163,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3100.969999999961,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.774999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1948.779,
"heapDeltaBytes": 23114904,
"heapUsedBytes": 89789748,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 954.582,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2026.8839999999955,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.817000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.5890000000002,
"heapDeltaBytes": -15579928,
"heapUsedBytes": 87039280,
"domNodes": -273,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 31.07,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.5120000000397,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.478,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.4789999999999,
"heapDeltaBytes": -15152764,
"heapUsedBytes": 87005368,
"domNodes": -268,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 32.254999999999995,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.5969999999929,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.433000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.795,
"heapDeltaBytes": 14094132,
"heapUsedBytes": 85945172,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 139.933,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.3600000000042,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.576000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.03600000000006,
"heapDeltaBytes": 14851432,
"heapUsedBytes": 87324464,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.566,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2047.1360000000232,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.447999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.774,
"heapDeltaBytes": -9886056,
"heapUsedBytes": 62555068,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 10.492999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.3359999999957,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.367,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.975,
"heapDeltaBytes": 255344,
"heapUsedBytes": 71839284,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.106000000000002,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.8170000000114,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.482,
"layouts": 18,
"layoutDurationMs": 5.173,
"taskDurationMs": 850.682,
"heapDeltaBytes": 1783212,
"heapUsedBytes": 74538620,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 111.182,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.024000000025,
"styleRecalcs": 79,
"styleRecalcDurationMs": 43.518,
"layouts": 18,
"layoutDurationMs": 5.417,
"taskDurationMs": 866.2109999999998,
"heapDeltaBytes": -13437148,
"heapUsedBytes": 58989448,
"domNodes": -295,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 116.60399999999998,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.5309999999636,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.82700000000001,
"layouts": 15,
"layoutDurationMs": 19.154,
"taskDurationMs": 1018.6109999999999,
"heapDeltaBytes": 21913668,
"heapUsedBytes": 104844764,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 33.856,
"eventListeners": 2381,
"totalBlockingTimeMs": 153,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8508.015999999998,
"styleRecalcs": 245,
"styleRecalcDurationMs": 32.565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5789.5779999999995,
"heapDeltaBytes": -11731048,
"heapUsedBytes": 88896824,
"domNodes": -272,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 2618.9500000000003,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8765.266999999994,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.369,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6014.158,
"heapDeltaBytes": -8314216,
"heapUsedBytes": 92234112,
"domNodes": -271,
"jsHeapTotalBytes": 442368,
"scriptDurationMs": 2802.949,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17507.456999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16905.837000000003,
"heapDeltaBytes": -35354348,
"heapUsedBytes": 178174148,
"domNodes": -6548,
"jsHeapTotalBytes": -8052736,
"scriptDurationMs": 289.95300000000003,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17124.02099999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16654.288,
"heapDeltaBytes": -36125996,
"heapUsedBytes": 179747196,
"domNodes": -6548,
"jsHeapTotalBytes": 8122368,
"scriptDurationMs": 273.53099999999995,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20807.55099999999,
"styleRecalcs": 171,
"styleRecalcDurationMs": 18.19900000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20411.55,
"heapDeltaBytes": -40511640,
"heapUsedBytes": 166276408,
"domNodes": -6548,
"jsHeapTotalBytes": -696320,
"scriptDurationMs": 902.806,
"eventListeners": -7467,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20817.132000000016,
"styleRecalcs": 159,
"styleRecalcDurationMs": 16.629999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20497.406000000003,
"heapDeltaBytes": -14367300,
"heapUsedBytes": 189986420,
"domNodes": -6548,
"jsHeapTotalBytes": 2232320,
"scriptDurationMs": 890.525,
"eventListeners": -7469,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6302.8350000000155,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.19300000000001,
"layouts": 20,
"layoutDurationMs": 24.036000000000016,
"taskDurationMs": 6163.072,
"heapDeltaBytes": -30120372,
"heapUsedBytes": 179750888,
"domNodes": -6548,
"jsHeapTotalBytes": 10092544,
"scriptDurationMs": 113.43299999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 543,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6121.613000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.08999999999999,
"layouts": 20,
"layoutDurationMs": 22.664999999999992,
"taskDurationMs": 6015.247,
"heapDeltaBytes": -35894496,
"heapUsedBytes": 179257112,
"domNodes": -6548,
"jsHeapTotalBytes": 13574144,
"scriptDurationMs": 106.813,
"eventListeners": -7471,
"totalBlockingTimeMs": 408,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 111.8020000000115,
"styleRecalcs": 6,
"styleRecalcDurationMs": 17.953000000000003,
"layouts": 2,
"layoutDurationMs": 1.4130000000000003,
"taskDurationMs": 87.477,
"heapDeltaBytes": 3133868,
"heapUsedBytes": 71512760,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.695,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 101.8460000000232,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.281,
"layouts": 2,
"layoutDurationMs": 0.8039999999999999,
"taskDurationMs": 73.39899999999999,
"heapDeltaBytes": 3148752,
"heapUsedBytes": 70861848,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.834999999999999,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.53 #17188 +/- ##
=============================================
+ Coverage 83.33% 83.35% +0.01%
=============================================
Files 2025 2025
Lines 117212 117258 +46
Branches 33115 32538 -577
=============================================
+ Hits 97675 97736 +61
+ Misses 19177 19173 -4
+ Partials 360 349 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 27 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #15720 to
core/1.53Automatically created by backport workflow.