Repository navigation
Conversation
Missing AUTO_RUN_WIDGET_INPUTS rows serialize as undefined, Playwright
drops them on evaluate, and Object.entries throws. Default those rows
to {} at the payload build site. Retarget detection-proof row-02/row-03
onto the current widget process and restore loops.
Co-authored-by: ShihChi Huang <huge.huang+github@gmail.com>
🎭 Playwright: ✅ 1921 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.83 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 128 kB (baseline 128 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 28.9 kB (baseline 28.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.62 MB (baseline 3.62 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-08T10:08:21.356Z",
"gitSha": "6b3e315049cc79002c2f065d2cc0b3d231426b56",
"branch": "cursor/custom-nodes-e2e-s9-887e",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2048.956999999973,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.064000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.1869999999999,
"heapDeltaBytes": -4407228,
"heapUsedBytes": 65444888,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.765000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2048.7190000000055,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.904000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.021,
"heapDeltaBytes": -11281100,
"heapUsedBytes": 59665988,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.896000000000003,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2111.1270000000104,
"styleRecalcs": 83,
"styleRecalcDurationMs": 45.693,
"layouts": 14,
"layoutDurationMs": 4.899000000000001,
"taskDurationMs": 1048.916,
"heapDeltaBytes": 8662904,
"heapUsedBytes": 79460884,
"domNodes": -279,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 178.209,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.6900000000437,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.751,
"layouts": 14,
"layoutDurationMs": 4.467,
"taskDurationMs": 922.3900000000001,
"heapDeltaBytes": 252268,
"heapUsedBytes": 64266192,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 155.355,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.6290000000363,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.351999999999997,
"layouts": 6,
"layoutDurationMs": 1.367,
"taskDurationMs": 373.59,
"heapDeltaBytes": 4320416,
"heapUsedBytes": 74367184,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.114000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.1709999999657,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.639,
"layouts": 6,
"layoutDurationMs": 1.159,
"taskDurationMs": 376.831,
"heapDeltaBytes": 4645048,
"heapUsedBytes": 74970944,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.619000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 725.9010000000217,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.7459999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.8450000000001,
"heapDeltaBytes": -7510828,
"heapUsedBytes": 62971916,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 158.281,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 656.7330000000311,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.2559999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.76899999999995,
"heapDeltaBytes": 18599536,
"heapUsedBytes": 88826788,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 156.861,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2054.576000000054,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.348999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.4309999999999,
"heapDeltaBytes": 10721380,
"heapUsedBytes": 86721132,
"domNodes": -267,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 35.743,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2031.2509999999975,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.071999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.0139999999999,
"heapDeltaBytes": 11202032,
"heapUsedBytes": 87441284,
"domNodes": -271,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 31.517999999999997,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2250.430999999992,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.029999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1641.8490000000002,
"heapDeltaBytes": 25234416,
"heapUsedBytes": 90727148,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 819.712,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2251.8780000000334,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.143,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1666.9799999999998,
"heapDeltaBytes": 11473760,
"heapUsedBytes": 88970652,
"domNodes": -276,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 807.48,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3595.9330000000023,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.885000000000002,
"layouts": 60,
"layoutDurationMs": 13.276999999999997,
"taskDurationMs": 1713.5020000000002,
"heapDeltaBytes": 8188348,
"heapUsedBytes": 75637564,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 762.6080000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3638.4109999999055,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.273999999999996,
"layouts": 60,
"layoutDurationMs": 13.465000000000002,
"taskDurationMs": 1757.752,
"heapDeltaBytes": 9598452,
"heapUsedBytes": 76447572,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 782.414,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3138.1210000000124,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.446000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1998.412,
"heapDeltaBytes": -6424132,
"heapUsedBytes": 73811732,
"domNodes": 2,
"jsHeapTotalBytes": 4841472,
"scriptDurationMs": 1006.8839999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 37,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3067.690000000084,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.137999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1939.163,
"heapDeltaBytes": 23332764,
"heapUsedBytes": 90720608,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 968.942,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2022.2500000000423,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.3759999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.0269999999999,
"heapDeltaBytes": 22294664,
"heapUsedBytes": 88175976,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.53500000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.3260000000255,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.467999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.167,
"heapDeltaBytes": 22243496,
"heapUsedBytes": 87955852,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.291999999999994,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.319999999972,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.675999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.647,
"heapDeltaBytes": 14477968,
"heapUsedBytes": 86877932,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 140.606,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.9729999999818,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.915999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.14199999999994,
"heapDeltaBytes": 14036700,
"heapUsedBytes": 86476268,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.27700000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.4259999999626,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.1240000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.526,
"heapDeltaBytes": -8763088,
"heapUsedBytes": 64288996,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.543999999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2014.5989999999756,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.695,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.2090000000001,
"heapDeltaBytes": 9950968,
"heapUsedBytes": 83095276,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.851999999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1765.3159999999843,
"styleRecalcs": 77,
"styleRecalcDurationMs": 45.631,
"layouts": 18,
"layoutDurationMs": 5.781,
"taskDurationMs": 874.9620000000001,
"heapDeltaBytes": -3144400,
"heapUsedBytes": 69220928,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 111.16199999999998,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.8990000000267,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.288000000000004,
"layouts": 18,
"layoutDurationMs": 5.863999999999999,
"taskDurationMs": 841.9369999999999,
"heapDeltaBytes": -12606200,
"heapUsedBytes": 60526316,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 108.64599999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.5409999999756,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.289999999999992,
"layouts": 15,
"layoutDurationMs": 14.296,
"taskDurationMs": 930.7050000000002,
"heapDeltaBytes": -5312924,
"heapUsedBytes": 84773768,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.105,
"eventListeners": 2385,
"totalBlockingTimeMs": 126,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8514.295000000004,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.34799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5642.724,
"heapDeltaBytes": -13337244,
"heapUsedBytes": 89814828,
"domNodes": -265,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 2536.0429999999997,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8638.129999999932,
"styleRecalcs": 248,
"styleRecalcDurationMs": 41.937999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6003.82,
"heapDeltaBytes": 15156628,
"heapUsedBytes": 91576968,
"domNodes": -268,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 2683.0619999999994,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18071.581999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17507.892,
"heapDeltaBytes": -35012156,
"heapUsedBytes": 176747124,
"domNodes": -6548,
"jsHeapTotalBytes": 2039808,
"scriptDurationMs": 325.0690000000001,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18360.65700000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17784.628,
"heapDeltaBytes": -25784024,
"heapUsedBytes": 184579632,
"domNodes": -6548,
"jsHeapTotalBytes": -2756608,
"scriptDurationMs": 335.901,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21847.545999999966,
"styleRecalcs": 167,
"styleRecalcDurationMs": 19.428,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21535.874,
"heapDeltaBytes": -11738244,
"heapUsedBytes": 177897648,
"domNodes": -6548,
"jsHeapTotalBytes": 2637824,
"scriptDurationMs": 892.257,
"eventListeners": -7471,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22823.8980000001,
"styleRecalcs": 173,
"styleRecalcDurationMs": 22.66800000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22568.514,
"heapDeltaBytes": -22190572,
"heapUsedBytes": 187125460,
"domNodes": -6548,
"jsHeapTotalBytes": -5070848,
"scriptDurationMs": 923.5479999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 96,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6216.129000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.54700000000003,
"layouts": 20,
"layoutDurationMs": 24.343000000000004,
"taskDurationMs": 6157.3769999999995,
"heapDeltaBytes": -40703896,
"heapUsedBytes": 163027640,
"domNodes": -6548,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 112.79400000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 546,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6491.170999999895,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.64399999999999,
"layouts": 20,
"layoutDurationMs": 23.771,
"taskDurationMs": 6395.025,
"heapDeltaBytes": -21663264,
"heapUsedBytes": 182629348,
"domNodes": -6548,
"jsHeapTotalBytes": 19218432,
"scriptDurationMs": 120.61300000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 360,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8949.568999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8575.979,
"heapDeltaBytes": 7464192,
"heapUsedBytes": 170419112,
"domNodes": 0,
"jsHeapTotalBytes": -6553600,
"scriptDurationMs": 139.64100000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9315.175000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9051.265,
"heapDeltaBytes": -9211672,
"heapUsedBytes": 163332556,
"domNodes": 0,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 150.40600000000003,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 117.3909999999978,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.78,
"layouts": 2,
"layoutDurationMs": 1.365,
"taskDurationMs": 75.506,
"heapDeltaBytes": 3089016,
"heapUsedBytes": 72028864,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.8790000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 125.22999999998774,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.12,
"layouts": 2,
"layoutDurationMs": 0.8800000000000001,
"taskDurationMs": 78.767,
"heapDeltaBytes": 3037828,
"heapUsedBytes": 72144944,
"domNodes": 108,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.669,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe changes update custom-node detection-proof patches, adjust widget persistence behavior for S2 and S3 tiers, prevent missing batch inputs from causing errors, and validate patch applicability in CI. ChangesCustom-node detection proof
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to Custom-node batch evaluation no longer fails when widget inputs are absent, while detection-proof behavior and patch validity are updated for current sources. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17162 +/- ##
==========================================
+ Coverage 81.48% 82.98% +1.50%
==========================================
Files 2486 2056 -430
Lines 127490 119823 -7667
Branches 32873 32835 -38
==========================================
- Hits 103881 99439 -4442
+ Misses 23095 20204 -2891
+ Partials 514 180 -334
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Superseded by tip-based draft #17243 ( This branch is CONFLICTING with Closing this draft in favor of #17243. |
Draft — do not mark ready. Do not enable auto-merge. Custom Nodes nightly does not run on PRs; humans must dispatch the verify path below.
Supersedes conflicting #17067 (same S9/
?? {}+ row-02/row-03 retarget, rebased ontomaintipfc793a4e0e). Does not reopen #16537. NumberWidget/toFixedis not in this PR: tip already routes display throughformatNumericWidgetValue/coerceNumericWidgetValue, and nightly 34210213667 S3 packs (including VueNodes=false) were already green.Summary
Restores the S9 evaluate payload default and retargets two stale detection-proof patches so Custom Nodes nightly can apply its independence proofs again.
Characterization
fc793a4e0eallNodes.spec.ts:61/allNodesExecutionTier.ts:329Object.entries(spec.widgetInputs)TypeError: Cannot convert undefined or null to objecton KJNodes, essentials, VideoHelperSuite /comfyui-videohelpersuite, Custom-Scripts (run 34210213667 shards(2/5, 0),(core:1/2, 0),(core:2/2, 0),(2/5, 9))allNodesExecutionTier.ts:310default missing ledger rows to{}#16802deletedspec.widgetInputs ?? {}.AUTO_RUN_WIDGET_INPUTSonly lists Impact-Pack + VHS upload widgets; other runnable nodes have no row. Playwright evaluate dropsundefined, soObject.entriesthrows.git apply --check …/row-02-mount-v2-vue-widget-dropped.patchuseProcessedWidgets.ts:316; nightly(4/5, 2)git apply --check … exited 1processWidgetatprocessedWidgetRenderModel.ts:356computeProcessedWidgetsmoved. Not product.git apply --check …/row-03-persistence-offbyone.patchLGraphNode.ts:987; nightly(4/5, 3)git apply --check … exited 1LGraphNode.ts:1191(positionalIndexrestore)toFixedbasic_data_handling, KJNodes, essentials, VHS, Custom-Scripts, …)NumberWidget._displayValue. Re-applying#17067'sNumber(value).toFixedhunk would conflict and change nothing.No product behavior change for numeric values that are already numbers, or for nodes that already have ledger rows.
Changes
widgetInputsto{}at the payload build site; retarget row-02/row-03; addgit apply --checkcoverage so the next src move fails in unit instead of nightly.Review Focus
The
?? {}belongs atallNodesExecutionTier.ts:310, not atObject.entries. Playwright's evaluate serialization is the boundary:undefinednever arrives in the page. Do not delete the default again because theRecordindex type looks always-defined — that is the#16802hole.Test Plan
git apply --checkon all four detection-proof source patches (alsogit applyin a throwaway worktree; each changessrc/)pnpm test:unit scripts/cicd/custom-node-proof.test.ts— 3 passedpnpm lint(Node 25) — 0 errorspnpm typecheck— greenpnpm format:check— greenCI: Tests Custom Nodesdoes not run on PRs)Verify (human)
From repo root on this branch:
Expected: both
git apply --checkcommands exit 0; the proof unit file is green (3 tests, including source patches apply); lint and typecheck green.Focused Custom Nodes path (Actions → CI: Tests Custom Nodes → Run workflow),
branch=cursor/custom-nodes-e2e-s9-887e:detection_proof_row=9— S9 witness shard. Expected: suite green except the deliberate VHS execution break; independence assert passes.detection_proof_row=2and3— patches apply; S2/S3 witness red and every other tier on that shard stays green.detection_proof_row=0oncore:1/2and2/5— S9 (and S3, including VueNodes=false console) green.Expected: those shards/cases green; no other product behavior change.