Repository navigation
refactor: back item.selected with the selection store - #17103
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughSelection state for graph nodes, groups, reroutes, and subgraph I/O nodes now uses the scoped selection store. Graph attachment and removal, canvas selection operations, and related tests use the updated selection behavior. ChangesGraph selection store integration
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to The identified selection regressions are addressed, and no new merge-blocking behavior was established. This change is ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2130 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 10 MB gzip 🔴 +304 kBDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.73 kB) • 🔴 +38 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.43 MB) • 🔴 +22.4 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 134 kB (baseline 124 kB) • 🔴 +9.77 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.5 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 39.4 kB (baseline 27.8 kB) • 🔴 +11.6 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +690 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 125 kB (baseline 117 kB) • 🔴 +8.01 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.98 MB (baseline 3.6 MB) • 🔴 +376 kBStores, services, APIs, and repositories
Status: 15 added / 16 removed Utilities & Hooks — 576 kB (baseline 559 kB) • 🔴 +17.6 kBHelpers, composables, and utility bundles
Status: 30 added / 30 removed / 6 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -686 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.9 MB (baseline 16.4 MB) • 🔴 +1.49 MBBundles that do not match a named category
Status: 179 added / 174 removed / 122 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T07:52:17.311Z",
"gitSha": "e6101086cf3ee894f0631e27ecb7e52370c0deee",
"branch": "drjkl/fe-2040-selection-item-selected",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.8230000000922,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.7649999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.162,
"heapDeltaBytes": 25655968,
"heapUsedBytes": 86885204,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.661000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1992.2659999999723,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.813000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.854,
"heapDeltaBytes": 7552536,
"heapUsedBytes": 69778804,
"domNodes": -228,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.302,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.1999999999334,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.272999999999998,
"layouts": 12,
"layoutDurationMs": 3.8619999999999997,
"taskDurationMs": 651.6990000000001,
"heapDeltaBytes": -4289484,
"heapUsedBytes": 58287160,
"domNodes": -228,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 117.682,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.875999999993,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.161,
"layouts": 12,
"layoutDurationMs": 3.687,
"taskDurationMs": 673.6569999999999,
"heapDeltaBytes": -1948864,
"heapUsedBytes": 60474992,
"domNodes": -228,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 123.274,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.177999999989,
"styleRecalcs": 30,
"styleRecalcDurationMs": 7.494000000000001,
"layouts": 6,
"layoutDurationMs": 0.9859999999999999,
"taskDurationMs": 262.551,
"heapDeltaBytes": 2100556,
"heapUsedBytes": 64467556,
"domNodes": 53,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.438000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.0619999999644,
"styleRecalcs": 30,
"styleRecalcDurationMs": 7.4460000000000015,
"layouts": 6,
"layoutDurationMs": 1.032,
"taskDurationMs": 274.049,
"heapDeltaBytes": 2243544,
"heapUsedBytes": 64430284,
"domNodes": 53,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.901,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 515.1389999999765,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.6420000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.44699999999995,
"heapDeltaBytes": 18613800,
"heapUsedBytes": 80529216,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 122.28200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 527.5050000000192,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.606999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.43500000000006,
"heapDeltaBytes": 18475388,
"heapUsedBytes": 80288756,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 121.97399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1026.5070000000378,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.2860000000001,
"heapDeltaBytes": 34757108,
"heapUsedBytes": 99876168,
"domNodes": -229,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 49.377,
"eventListeners": -185,
"totalBlockingTimeMs": 421,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1020.0610000000552,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 643.9390000000001,
"heapDeltaBytes": 8372036,
"heapUsedBytes": 86027628,
"domNodes": 0,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 45.582,
"eventListeners": 0,
"totalBlockingTimeMs": 428,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 736.152000000061,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.56399999999996,
"heapDeltaBytes": 13929932,
"heapUsedBytes": 89014476,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.478,
"eventListeners": 0,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 733.0050000000483,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.16199999999986,
"heapDeltaBytes": 13060424,
"heapUsedBytes": 89855072,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.874,
"eventListeners": 0,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7794.584999999984,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.308000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6960.217000000001,
"heapDeltaBytes": 10118996,
"heapUsedBytes": 88030968,
"domNodes": -228,
"jsHeapTotalBytes": 8904704,
"scriptDurationMs": 5422.363,
"eventListeners": -164,
"totalBlockingTimeMs": 77,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6853.755999999976,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2669999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6174.033,
"heapDeltaBytes": 8893408,
"heapUsedBytes": 86501580,
"domNodes": -228,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 4773.565,
"eventListeners": -164,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7614.164999999957,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6910000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6873.952,
"heapDeltaBytes": -3076980,
"heapUsedBytes": 74867132,
"domNodes": -228,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 5383.906,
"eventListeners": -164,
"totalBlockingTimeMs": 103,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6847.2189999999955,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8300000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6200.602,
"heapDeltaBytes": 16925932,
"heapUsedBytes": 94739904,
"domNodes": -228,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 4813.53,
"eventListeners": -164,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2014.4010000000208,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.546999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.6889999999999,
"heapDeltaBytes": -3650584,
"heapUsedBytes": 83173468,
"domNodes": -228,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.151,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2026.642000000038,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3870000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.59799999999996,
"heapDeltaBytes": -5869540,
"heapUsedBytes": 74017608,
"domNodes": -228,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 29.139999999999993,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2114.8809999999685,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.122,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1173.311,
"heapDeltaBytes": 16194040,
"heapUsedBytes": 80630164,
"domNodes": -228,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 640.744,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2131.3450000000103,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.899,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1277.2969999999998,
"heapDeltaBytes": 15744564,
"heapUsedBytes": 80123836,
"domNodes": -228,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 633.658,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3317.5260000000435,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.938,
"layouts": 60,
"layoutDurationMs": 14.257,
"taskDurationMs": 1360.5530000000003,
"heapDeltaBytes": 7991140,
"heapUsedBytes": 74195320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 606.063,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3293.735999999967,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.008000000000001,
"layouts": 60,
"layoutDurationMs": 13.59,
"taskDurationMs": 1376.5629999999999,
"heapDeltaBytes": -11234264,
"heapUsedBytes": 77973852,
"domNodes": -228,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 602.884,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2237.9880000000867,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.581000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1506.3460000000002,
"heapDeltaBytes": 17583896,
"heapUsedBytes": 84032484,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 744.366,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2283.709999999928,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.305999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1484.623,
"heapDeltaBytes": 18463172,
"heapUsedBytes": 84429312,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 730.13,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 1994.1619999999602,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.2080000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.723,
"heapDeltaBytes": 19326120,
"heapUsedBytes": 84255588,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.281000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2048.6660000000256,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2520000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.501,
"heapDeltaBytes": -12994568,
"heapUsedBytes": 75622964,
"domNodes": -228,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 28.677000000000007,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 477.1580000000313,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.481000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 299.65999999999997,
"heapDeltaBytes": 13173700,
"heapUsedBytes": 76746772,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 104.781,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 494.03700000004847,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.099000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.925,
"heapDeltaBytes": 13692512,
"heapUsedBytes": 77240044,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 110.61200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2001.9049999999652,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.89,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.914,
"heapDeltaBytes": -14863908,
"heapUsedBytes": 55045352,
"domNodes": 0,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.037999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.4610000000484,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.753,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.27200000000005,
"heapDeltaBytes": -6193072,
"heapUsedBytes": 57524368,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.2349999999999985,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.813000000001,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.711999999999998,
"layouts": 16,
"layoutDurationMs": 4.34,
"taskDurationMs": 621.1150000000001,
"heapDeltaBytes": -9614636,
"heapUsedBytes": 60154840,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 76.471,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1686.9699999999739,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.713000000000001,
"layouts": 16,
"layoutDurationMs": 4.926,
"taskDurationMs": 590.403,
"heapDeltaBytes": 18557548,
"heapUsedBytes": 81294412,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 76.24000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 883.3859999999731,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.98,
"layouts": 5,
"layoutDurationMs": 8.817,
"taskDurationMs": 703.2410000000002,
"heapDeltaBytes": 21644340,
"heapUsedBytes": 103433564,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 22.378000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 112,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8152.377999999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.088,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4430.513,
"heapDeltaBytes": 3403632,
"heapUsedBytes": 84559544,
"domNodes": -228,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 2019.5090000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8185.547000000042,
"styleRecalcs": 249,
"styleRecalcDurationMs": 28.967000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4550.27,
"heapDeltaBytes": 5598648,
"heapUsedBytes": 85225180,
"domNodes": -228,
"jsHeapTotalBytes": 1003520,
"scriptDurationMs": 2086.132,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12559.907000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11765.513,
"heapDeltaBytes": -35490700,
"heapUsedBytes": 176975044,
"domNodes": -8049,
"jsHeapTotalBytes": -10469376,
"scriptDurationMs": 183.59300000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12515.89899999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11575.517,
"heapDeltaBytes": -35364752,
"heapUsedBytes": 189863316,
"domNodes": -8049,
"jsHeapTotalBytes": -17309696,
"scriptDurationMs": 189.63000000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15282.722999999918,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.269000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14815.721,
"heapDeltaBytes": -52171248,
"heapUsedBytes": 168148096,
"domNodes": -8049,
"jsHeapTotalBytes": -20512768,
"scriptDurationMs": 704.6060000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15681.652999999984,
"styleRecalcs": 85,
"styleRecalcDurationMs": 13.866000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15200.482000000002,
"heapDeltaBytes": -62393220,
"heapUsedBytes": 164811360,
"domNodes": -8049,
"jsHeapTotalBytes": -22482944,
"scriptDurationMs": 784.09,
"eventListeners": -14923,
"totalBlockingTimeMs": 70,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4622.329000000036,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.66500000000003,
"layouts": 20,
"layoutDurationMs": 23.046999999999997,
"taskDurationMs": 4516.005,
"heapDeltaBytes": -61859084,
"heapUsedBytes": 179222480,
"domNodes": -8049,
"jsHeapTotalBytes": 7925760,
"scriptDurationMs": 81.629,
"eventListeners": -14923,
"totalBlockingTimeMs": 151,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4496.860999999967,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.98999999999999,
"layouts": 20,
"layoutDurationMs": 21.028999999999993,
"taskDurationMs": 4363.469,
"heapDeltaBytes": -46705348,
"heapUsedBytes": 175948152,
"domNodes": -8049,
"jsHeapTotalBytes": 2650112,
"scriptDurationMs": 75.65,
"eventListeners": -14923,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6452.058000000079,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6204.145999999998,
"heapDeltaBytes": -18974568,
"heapUsedBytes": 170341192,
"domNodes": 0,
"jsHeapTotalBytes": -25427968,
"scriptDurationMs": 112.46000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6234.36300000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5804.267,
"heapDeltaBytes": 10979016,
"heapUsedBytes": 190486748,
"domNodes": 0,
"jsHeapTotalBytes": -16252928,
"scriptDurationMs": 90.09800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 463.92500000001746,
"styleRecalcs": 19,
"styleRecalcDurationMs": 15.321000000000002,
"layouts": 5,
"layoutDurationMs": 2.41,
"taskDurationMs": 115.989,
"heapDeltaBytes": 5229660,
"heapUsedBytes": 67099492,
"domNodes": 129,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.932,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 453.0099999999493,
"styleRecalcs": 20,
"styleRecalcDurationMs": 15.915000000000003,
"layouts": 5,
"layoutDurationMs": 2.4010000000000002,
"taskDurationMs": 116.32500000000002,
"heapDeltaBytes": 5057000,
"heapUsedBytes": 67142612,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.585,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since facbca7658dd361ff5f5edaf5ff5404d582e0a64
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #17103 +/- ##
==========================================
+ Coverage 83.93% 84.89% +0.96%
==========================================
Files 3061 2304 -757
Lines 151399 132361 -19038
Branches 39194 35723 -3471
==========================================
- Hits 127078 112369 -14709
+ Misses 22898 19694 -3204
+ Partials 1423 298 -1125
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 773 files with indirect coverage changes 🚀 New features to boost your workflow:
|
f8f37e1 to
bf93ba9
Compare
4ebb852 to
871f533
Compare
871f533 to
873e587
Compare
873e587 to
a56268d
Compare
a56268d to
27e1303
Compare
27e1303 to
69e422b
Compare
69e422b to
da52c2b
Compare
da52c2b to
487ad47
Compare
487ad47 to
3ef5f6c
Compare
3ef5f6c to
d7be306
Compare
|
Thanks @coderabbitai — the foreign same-ID group removal finding in review 5313135942 was valid. Fixed in fefaa71 by rejecting a group that is not an actual member before any canvas, selection-store, layout, or graph mutation. Added the reported regression; the focused selection suite passes (73 passed, 7 expected failures), and commit-hook lint/typecheck passed. |
|
Tip For best results, initiate chat on the files or code changes.
You are interacting with an AI system. |
jaeone94
left a comment
There was a problem hiding this comment.
One selection-publication ordering issue remains in the detached-node attachment path. Details and a focused reproduction are inline.
| attachNodeToStores(this, node, () => | ||
| mintNodeId(state, nodeIdMintModeFor(this)) | ||
| ) | ||
| if (selected) node.selected = true |
There was a problem hiding this comment.
[P2] Register the node before publishing its adopted selection
For node.selected = true; graph.add(node), this write updates the selection store before the node is inserted into _nodes_by_id. A synchronous observer of canvasStore.selectedItems then reevaluates that computed, but resolveSelectable() cannot find the node yet, so it caches an empty selection. The later non-reactive node registration does not invalidate that computed. After attachment, node.selected is true and canvas.selectedItems contains the node, while canvasStore.selectedItems remains empty. The Agent selection composable uses synchronous selection watchers, so this can leave its Vue selection view out of sync with the canvas.
Could we move this assignment below _nodes.push(node) and _nodes_by_id[node.id] = node, while keeping it after attachNodeToStores and before onAdded? That preserves the ID-remint fix and publishes a resolvable node.
I reproduced this with the real canvas/store and a flush: 'sync' watcher, checking the Vue selection after nextTick(). It fails on this head and passes with that ordering change. The existing detached-write test only checks the item and canvas views; please also cover the synchronous Vue observer.
There was a problem hiding this comment.
Thank you for the precise synchronous-observer repro — this was valid. Fixed in 76a5282 by publishing the adopted selection only after _nodes and _nodes_by_id contain the final reminted node, while still doing so before onAdded. Added a real canvas-store regression with a flush: sync watcher; canvasStore.test.ts passes (12/12), and commit-hook lint/typecheck passed.
26cb95d to
76a5282
Compare
jaeone94
left a comment
There was a problem hiding this comment.
Thanks for addressing the previous finding. A further agent review found one additional blocking regression, and I verified it with a focused test that passes on this PR's base and fails on the current head. Details are inline.
| ): void { | ||
| // LEGACY: This was changed from constructor === LiteGraph.LGraphGroup | ||
| if (node instanceof LGraphGroup) { | ||
| const index = this._groups.indexOf(node) |
There was a problem hiding this comment.
[P2] Recompute the group index after deselection callbacks
This index is now captured before canvas.deselect(node), which can synchronously run child-node callbacks. If one of those callbacks removes an earlier group, the saved index no longer identifies the target.
Reproduction: enable canvas.groupSelectChildren, create disjoint groups in the order [earlier, target, later] with A inside target, select target, set A.onDeselected = () => graph.remove(earlier), then call graph.remove(target). The callback leaves [target, later], but the outer splice(1, 1) removes later. target remains registered with its graph cleared, while the unrelated group disappears without its removal cleanup.
The same test passes on base ff47d1e436 and fails on head 76a5282b64. The base looked up the index after the callbacks, so this is introduced by the ordering change here. Could we retain the early foreign-group guard but recompute and validate the index immediately before splicing, with a regression test for this callback case?
There was a problem hiding this comment.
Thank you for the callback-order repro — this was valid. Fixed in 3819756 by retaining the early foreign-group guard but recomputing and validating the target index after synchronous deselection callbacks, immediately before splicing. Added the reported three-group regression; the focused selection suite passes (74 passed, 7 expected failures), and commit-hook lint/typecheck plus Fallow pass.
There was a problem hiding this comment.
Follow-up: I simplified the final fix in 716330b to avoid index-based mutation entirely. After callbacks, group removal filters _groups by object identity and uses the length change to detect re-entrant removal; the early membership guard remains. The same focused regression and checks pass, and #17105 has been restacked unchanged on this head.
jaeone94
left a comment
There was a problem hiding this comment.
Thanks for the re-review request. I checked the latest head, but it is still 76a5282b64, unchanged since my previous review. The group-removal index issue remains unresolved: a deselection callback can shift the group array before the saved index is used, causing an unrelated group to be removed.
The earlier selection-publication fix is already accounted for; this is the separate finding from the follow-up review:
#17103 (comment)
Keeping changes requested until that issue is addressed. Please request another review once the fix is pushed.
76a5282 to
3819756
Compare
Node, group, reroute and subgraph IO selected flags are now accessors over the selection store, so the canvas no longer mirrors membership into the items. The item accessors read the store's key sets directly and bypass pinia's action wrapper (3.4us -> 1.1us per read). Part of FE-2040. Amp-Thread-ID: https://ampcode.com/threads/T-01a0d5a2-3108-720d-88bb-a14136deafde
3819756 to
716330b
Compare
jaeone94
left a comment
There was a problem hiding this comment.
Thanks for the fixes. Re-reviewed at 716330b804: the selection-publication ordering and callback-driven group-removal issues are addressed. No remaining blockers found. LGTM.
Summary
Step 4 (final mirror) of ADR CANVAS-SELECTION-0028:
item.selectedonLGraphNode,LGraphGroup,RerouteandSubgraphIONodeBasebecomes an accessor over the selection store. The canvas no longer writes the flag, so membership has exactly one home.isSelectedIn(scope, key); writes callsetSelectedIn(scope, key, bool), which dispatchesselection.add/selection.removefor the item's own graph scope. Legacy extension code doingnode.selected = truetherefore lands in the store and shows up incanvas.selectedItems,selected_nodesand the Vue views.LGraphCanvasguards collapse fromitem.selected && this.#isSelected(item)tothis.#isSelected(item);#setSelectedonly dispatches;clear()anddeselectAll()drop their flag loops.onSelected/onDeselectedemission counts are unchanged (harnessafterEachstill asserts store keys ==selectedItems).drawNode, so they bypass pinia's repeated store lookup: the store instance is memoized per active pinia and membership is read from the store's read-onlyrootsstate.src/core/selection, removing the newsrc/lib → rendererimports from the item classes.Stacked on #17101. Part of FE-2040.
Behavior notes for review
graph.add()transfers a pendingselected = truewrite into the graph-scoped store.canvas.graphscope while an item's accessor usesitem.graphscope. They agree whenever the item belongs to the displayed graph. Passing a foreign item tocanvas.selectwas already inconsistent (theselectedItemsview resolves keys throughcanvas.graph), and is not made worse here.LGraphNode.is_selectednow returnsbooleaninstead ofboolean | undefined.rootsis exposed from the store as aReadonlyMaptype so the accessor lane can read it; all mutation still goes throughapply.selectItems()batching into one command remains the perf follow-up (selectItems(2000)≈ 115 ms).Checklist
pnpm exec vitest runsweep over canvas/composables/litegraph/stores/extensions: 543 files, 7885 passed, 8 expected fail (same 7 harnessit.fails+ 1 pre-existingLGraph.test.ts)canvas.select/deselect, detached node/group writes survivegraph.add, and removal clears selection without a canvaspnpm typecheck,pnpm knip,pnpm adr:check, oxfmt/oxlint/eslint on touched files