Skip to content

fix(agent): close PR 16957 review findings - #17102

Merged
DrJKL merged 3 commits into
christian-byrne/prhyg-49-subgraph-review-debtfrom
drjkl/pr-16957-review-fixes
Sep 6, 2026
Merged

DrJKL merged 3 commits into
christian-byrne/prhyg-49-subgraph-review-debtfrom
drjkl/pr-16957-review-fixes

Conversation

@DrJKL

@DrJKL DrJKL commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds red-green proof and fixes for the validated review findings on #16957.

Changes

  • ca9c375 and b3cb0da add regression coverage for failed subgraph rollback, malformed CRDT definitions, late definition recovery, and mismatched Yjs roots.
  • 57af8b1 fixes those failures without changing the regression tests.

Verification

Review Focus

This PR targets #16957's source branch. Review the first two commits as the test proof and the final commit as the fix.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 4b65f582-6683-41bd-953e-424b47dac773

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/06/2026, 08:03:33 AM UTC

Links

🎭 Playwright: ✅ 1908 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1887 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 70ms TBT · 100.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.8 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 162.0 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 6ms TBT · 175.9 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 99ms TBT · 189.7 MB heap
vue-zoom-out-idle: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 165.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 479ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 77.4 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -150
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 37ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 771ms
canvas-mouse-sweep: script duration 126ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 64.5 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -179
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 325ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.3 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 21
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 344ms
dom-widget-clipping: script duration 110ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 59.9 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 535ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.9 MB
large-graph-idle: DOM nodes -267
large-graph-idle: event listeners -71
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1300ms
large-graph-pan: script duration 597ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 89.1 MB
large-graph-pan: DOM nodes -133
large-graph-pan: event listeners -68
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 15ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1357ms
large-graph-zoom: script duration 566ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.4 MB
large-graph-zoom: DOM nodes -136
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 9ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1558ms
legacy-node-drag: script duration 742ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 89.2 MB
legacy-node-drag: DOM nodes -133
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 516ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.4 MB
minimap-idle: DOM nodes -131
minimap-idle: event listeners 5
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 345ms
subgraph-dom-widget-clipping: script duration 107ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.8 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 440ms
subgraph-idle: script duration 11ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 57.3 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -210
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 33ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 691ms
subgraph-mouse-sweep: script duration 97ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 62.7 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -211
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 24ms
subgraph-transition-enter: layout count 18
subgraph-transition-enter: style recalc count 22
subgraph-transition-enter: task duration 704ms
subgraph-transition-enter: script duration 23ms
subgraph-transition-enter: TBT 70ms
subgraph-transition-enter: heap used 100.4 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 45ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4821ms
viewport-pan-sweep: script duration 2076ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 76.8 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -124
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 12507ms
vue-large-graph-idle: script duration 217ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 162.0 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7475
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 78
vue-large-graph-pan: task duration 14787ms
vue-large-graph-pan: script duration 721ms
vue-large-graph-pan: TBT 6ms
vue-large-graph-pan: heap used 175.9 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7472
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 57ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4587ms
vue-node-resize-workload: script duration 80ms
vue-node-resize-workload: TBT 99ms
vue-node-resize-workload: heap used 189.7 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7473
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6178ms
vue-zoom-out-idle: script duration 102ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 165.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -9
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 85ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.4 MB
workflow-execution: DOM nodes 137
workflow-execution: event listeners 52
Raw data
{
  "timestamp": "2026-09-06T08:11:43.506Z",
  "gitSha": "741fcfd4d627a444a921d6998a7e39c2019d1212",
  "branch": "drjkl/pr-16957-review-fixes",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2055.5330000000254,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.203999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.73500000000007,
      "heapDeltaBytes": 11303472,
      "heapUsedBytes": 81829536,
      "domNodes": -282,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 12.558,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2039.8989999999912,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.451000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.02099999999996,
      "heapDeltaBytes": 9937668,
      "heapUsedBytes": 80459376,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 12.008,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1845.3369999999722,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 35.951,
      "layouts": 14,
      "layoutDurationMs": 4.638,
      "taskDurationMs": 835.943,
      "heapDeltaBytes": 3448056,
      "heapUsedBytes": 73370336,
      "domNodes": -281,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 134.509,
      "eventListeners": -180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1736.2929999999324,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 37.089999999999996,
      "layouts": 14,
      "layoutDurationMs": 4.420999999999999,
      "taskDurationMs": 705.203,
      "heapDeltaBytes": -8581920,
      "heapUsedBytes": 61884860,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 116.53000000000002,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.7020000000166,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.578000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.1860000000000002,
      "taskDurationMs": 317.5,
      "heapDeltaBytes": 4788980,
      "heapUsedBytes": 74563820,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 14.164,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1658.5190000000694,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 17.043,
      "layouts": 6,
      "layoutDurationMs": 1.259,
      "taskDurationMs": 333.409,
      "heapDeltaBytes": 4438832,
      "heapUsedBytes": 74887116,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 14.456,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 515.8490000000029,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 340.372,
      "heapDeltaBytes": -8109384,
      "heapUsedBytes": 62657064,
      "domNodes": 20,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 110.50200000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 535.4990000000726,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.636,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 348.052,
      "heapDeltaBytes": -7474084,
      "heapUsedBytes": 62900548,
      "domNodes": 20,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 110.103,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2027.1949999999492,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.77,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.062,
      "heapDeltaBytes": -14107020,
      "heapUsedBytes": 87588536,
      "domNodes": -267,
      "jsHeapTotalBytes": -1638400,
      "scriptDurationMs": 29.971000000000004,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2036.5289999999732,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 7.799,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 574.4540000000001,
      "heapDeltaBytes": 22991304,
      "heapUsedBytes": 88389516,
      "domNodes": -267,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 33.102,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3063.8059999999996,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.854000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1322.328,
      "heapDeltaBytes": 27949768,
      "heapUsedBytes": 94086496,
      "domNodes": -271,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 614.539,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3007.7139999999645,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 12.831,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1277.254,
      "heapDeltaBytes": 26736636,
      "heapUsedBytes": 92823292,
      "domNodes": 6,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 579.542,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3848.867000000041,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 14.059000000000003,
      "layouts": 60,
      "layoutDurationMs": 14.955000000000002,
      "taskDurationMs": 1327.9450000000002,
      "heapDeltaBytes": 9185516,
      "heapUsedBytes": 76214952,
      "domNodes": -275,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 547.2819999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3895.1829999999745,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 13.285000000000002,
      "layouts": 60,
      "layoutDurationMs": 14.71,
      "taskDurationMs": 1385.408,
      "heapDeltaBytes": 8069088,
      "heapUsedBytes": 75666720,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 585.5219999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3052.077000000054,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.7299999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1553.6889999999999,
      "heapDeltaBytes": 25794456,
      "heapUsedBytes": 92859044,
      "domNodes": -279,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 741.9429999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3116.847000000007,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.418000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1563.032,
      "heapDeltaBytes": -1089024,
      "heapUsedBytes": 94203252,
      "domNodes": 14,
      "jsHeapTotalBytes": 6483968,
      "scriptDurationMs": 742.239,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2003.165000000024,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 2.945999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.226,
      "heapDeltaBytes": 22132680,
      "heapUsedBytes": 88378228,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.23600000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2003.8670000000138,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.533999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 541.3959999999998,
      "heapDeltaBytes": 22550848,
      "heapUsedBytes": 88720232,
      "domNodes": -270,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.613000000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 574.2440000000215,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.301,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 358.902,
      "heapDeltaBytes": 14934076,
      "heapUsedBytes": 87801132,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 110.559,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 528.7119999999277,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.293000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 331.71399999999994,
      "heapDeltaBytes": 14870244,
      "heapUsedBytes": 87852984,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 103.9,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.5999999999585,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.434000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.053,
      "heapDeltaBytes": -9456704,
      "heapUsedBytes": 62411268,
      "domNodes": -295,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.822000000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2026.6759999999522,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.62,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 462.091,
      "heapDeltaBytes": -14321204,
      "heapUsedBytes": 57810640,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 11.317,
      "eventListeners": -224,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.5710000000063,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 32.78,
      "layouts": 18,
      "layoutDurationMs": 5.404,
      "taskDurationMs": 692.366,
      "heapDeltaBytes": 324264,
      "heapUsedBytes": 73354100,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 95.77,
      "eventListeners": -226,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1691.8739999999843,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 33.164,
      "layouts": 18,
      "layoutDurationMs": 5.311,
      "taskDurationMs": 690.33,
      "heapDeltaBytes": -14917748,
      "heapUsedBytes": 58161928,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 98.086,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 934.319999999957,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 24.264999999999993,
      "layouts": 18,
      "layoutDurationMs": 12.158999999999997,
      "taskDurationMs": 704.385,
      "heapDeltaBytes": 21841264,
      "heapUsedBytes": 105257504,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 23.380000000000006,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 70,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 11087.146000000019,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 45.153,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4799.03,
      "heapDeltaBytes": 28358980,
      "heapUsedBytes": 93637348,
      "domNodes": -269,
      "jsHeapTotalBytes": 192512,
      "scriptDurationMs": 2079.357,
      "eventListeners": -124,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 11333.370000000059,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 45.455,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4842.1449999999995,
      "heapDeltaBytes": -33805024,
      "heapUsedBytes": 67525828,
      "domNodes": -267,
      "jsHeapTotalBytes": -851968,
      "scriptDurationMs": 2071.919,
      "eventListeners": -124,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12753.152,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12215.313999999998,
      "heapDeltaBytes": -47997416,
      "heapUsedBytes": 163129068,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1298432,
      "scriptDurationMs": 194.33899999999997,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.216666666666665,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13416.41900000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12798.402000000002,
      "heapDeltaBytes": -33505324,
      "heapUsedBytes": 176582644,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5668864,
      "scriptDurationMs": 239.70899999999997,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.216666666666665,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14926.919999999995,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 16.651,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14688.311,
      "heapDeltaBytes": -18848552,
      "heapUsedBytes": 192237820,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6311936,
      "scriptDurationMs": 730.198,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 8,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15373.843999999963,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 16.555000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14885.107000000002,
      "heapDeltaBytes": -34132168,
      "heapUsedBytes": 176593592,
      "domNodes": -6548,
      "jsHeapTotalBytes": -8536064,
      "scriptDurationMs": 711.927,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4582.1770000000015,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 54.67100000000003,
      "layouts": 20,
      "layoutDurationMs": 25.339,
      "taskDurationMs": 4518.828,
      "heapDeltaBytes": -10077640,
      "heapUsedBytes": 199984252,
      "domNodes": -6548,
      "jsHeapTotalBytes": 17625088,
      "scriptDurationMs": 79.21199999999999,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 56,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4744.298000000072,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 59.28899999999998,
      "layouts": 20,
      "layoutDurationMs": 26.011999999999993,
      "taskDurationMs": 4655.835,
      "heapDeltaBytes": -12584720,
      "heapUsedBytes": 197839300,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10862592,
      "scriptDurationMs": 80.985,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6400.490000000047,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6201.173000000001,
      "heapDeltaBytes": 7032452,
      "heapUsedBytes": 173196940,
      "domNodes": 0,
      "jsHeapTotalBytes": -1048576,
      "scriptDurationMs": 92.90200000000004,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6350.841999999943,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6153.839,
      "heapDeltaBytes": -3851012,
      "heapUsedBytes": 174514116,
      "domNodes": 0,
      "jsHeapTotalBytes": -3932160,
      "scriptDurationMs": 111.02400000000002,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 121.0439999999835,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 21.232,
      "layouts": 4,
      "layoutDurationMs": 1.9819999999999998,
      "taskDurationMs": 90.67199999999998,
      "heapDeltaBytes": 3355912,
      "heapUsedBytes": 71759088,
      "domNodes": 152,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.714000000000001,
      "eventListeners": 38,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 426.14500000001954,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 17.136000000000003,
      "layouts": 2,
      "layoutDurationMs": 0.5449999999999999,
      "taskDurationMs": 79.94500000000001,
      "heapDeltaBytes": 4787560,
      "heapUsedBytes": 73808956,
      "domNodes": 121,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 7.3199999999999985,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 49621 74395 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.2% 1185
src/LGraphNode.ts 69.4% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.4% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.7% 251
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 6, 2026
@codecov

codecov Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib/litegraph/src/LGraph.ts 66.66% 4 Missing ⚠️
@@                               Coverage Diff                                @@
##           christian-byrne/prhyg-49-subgraph-review-debt   #17102     +/-   ##
================================================================================
  Coverage                                          82.79%   82.79%             
================================================================================
  Files                                               2046     2046             
  Lines                                             119519   119523      +4     
  Branches                                           32058    30221   -1837     
================================================================================
+ Hits                                               98951    98962     +11     
+ Misses                                             20388    20381      -7     
  Partials                                             180      180             
Flag Coverage Δ
e2e 66.69% <69.23%> (+0.02%) ⬆️
unit 77.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...form/workflow/validation/schemas/workflowSchema.ts 97.56% <100.00%> (+0.03%) ⬆️
...nch/extensions/agent/crdt/agentNodeMaterializer.ts 97.67% <100.00%> (-2.33%) ⬇️
.../extensions/agent/crdt/agentSubgraphDefinitions.ts 98.27% <100.00%> (-0.36%) ⬇️
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 97.91% <100.00%> (+0.61%) ⬆️
src/lib/litegraph/src/LGraph.ts 78.43% <66.66%> (-0.21%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added risk:xhigh PR risk grade (advisory shadow check; grader-owned) and removed risk:high PR risk grade (advisory shadow check; grader-owned) labels Sep 6, 2026
@DrJKL
DrJKL marked this pull request as ready for review September 6, 2026 08:16
@DrJKL
DrJKL merged commit cfe694b into christian-byrne/prhyg-49-subgraph-review-debt Sep 6, 2026
91 checks passed
@DrJKL
DrJKL deleted the drjkl/pr-16957-review-fixes branch September 6, 2026 08:40
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants