Skip to content

[backport cloud/1.53] fix: retry filmstrip frame capture when the video frame is not yet decodable - #17082

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16348-to-cloud-1.53
Sep 5, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16348-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16348 to cloud/1.53

Automatically created by backport workflow.

…codable (#16348)

## Summary
createImageBitmap(video) can transiently throw InvalidStateError right
after workflow execution, when node preview videos compete for decoder
resources.
The failure was swallowed, leaving the trim timeline permanently blank
with no error or skeleton. Poll for a decodable frame before giving up.

Perf: the poll only starts after an empty capture, so the happy path is
unchanged. A failing createImageBitmap call costs ~5us and does not
trigger decoding, so worst case is ~20 no-op calls per node spread over
the 5s budget, and the poll aborts with the load. Measured 48 concurrent
filmstrip loads succeeding on first attempt in ~0.8s with no main-thread
long tasks; the transient failure only appears under decoder contention
spikes, not from filmstrip count.

After a seek the element can report HAVE_ENOUGH_DATA while the decoder
has not produced the frame yet (decoder contention), making captureFrame
come back empty. No event announces the frame becoming available, so
poll for it.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 5, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 5, 2026 16:10
@github-actions

github-actions Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1890 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1869 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/05/2026, 04:12:21 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 144ms TBT · 79.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.1 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.3 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 107ms TBT · 156.7 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 275ms TBT · 174.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 517ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.4 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 45ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 80
canvas-mouse-sweep: task duration 995ms
canvas-mouse-sweep: script duration 175ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.6 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -170
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 377ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.1 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 455ms
dom-widget-clipping: script duration 161ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.9 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 588ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.0 MB
large-graph-idle: DOM nodes -271
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1691ms
large-graph-pan: script duration 826ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.6 MB
large-graph-pan: DOM nodes -277
large-graph-pan: event listeners -89
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1683ms
large-graph-zoom: script duration 757ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.8 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1929ms
legacy-node-drag: script duration 957ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 82.7 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 579ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.4 MB
minimap-idle: DOM nodes -275
minimap-idle: event listeners -91
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 420ms
subgraph-dom-widget-clipping: script duration 144ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.4 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 519ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.8 MB
subgraph-idle: DOM nodes -298
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 823ms
subgraph-mouse-sweep: script duration 110ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.8 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 948ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 144ms
subgraph-transition-enter: heap used 79.0 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5946ms
viewport-pan-sweep: script duration 2729ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.1 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -137
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16574ms
vue-large-graph-idle: script duration 297ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.3 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 162
vue-large-graph-pan: task duration 20667ms
vue-large-graph-pan: script duration 928ms
vue-large-graph-pan: TBT 107ms
vue-large-graph-pan: heap used 156.7 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7468
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 28ms
vue-node-resize-workload: style recalc duration 87ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5466ms
vue-node-resize-workload: script duration 111ms
vue-node-resize-workload: TBT 275ms
vue-node-resize-workload: heap used 174.8 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7473
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 4
workflow-execution: style recalc count 14
workflow-execution: task duration 105ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.9 MB
workflow-execution: DOM nodes 141
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-09-05T16:24:06.419Z",
  "gitSha": "708cf96cefa4344489bdd4445c6cc9a19dff92a1",
  "branch": "backport-16348-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2027.4289999999837,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.657000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 506.07599999999996,
      "heapDeltaBytes": 261964,
      "heapUsedBytes": 69928104,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.711,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2047.5440000000162,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.205999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 527.908,
      "heapDeltaBytes": -11547512,
      "heapUsedBytes": 58877792,
      "domNodes": -279,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.184,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2073.0310000000145,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 47.81399999999999,
      "layouts": 14,
      "layoutDurationMs": 5.098,
      "taskDurationMs": 1045.786,
      "heapDeltaBytes": 5022164,
      "heapUsedBytes": 74893536,
      "domNodes": -281,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 184.713,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1872.478000000001,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 42.583999999999996,
      "layouts": 14,
      "layoutDurationMs": 4.696,
      "taskDurationMs": 943.2789999999999,
      "heapDeltaBytes": -7264492,
      "heapUsedBytes": 62762544,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 165.756,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.5330000000222,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.183,
      "layouts": 6,
      "layoutDurationMs": 0.9440000000000002,
      "taskDurationMs": 368.5109999999999,
      "heapDeltaBytes": 4442420,
      "heapUsedBytes": 74763080,
      "domNodes": 77,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 11.835999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.8020000000406,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.406,
      "layouts": 6,
      "layoutDurationMs": 1.0539999999999998,
      "taskDurationMs": 385.15599999999995,
      "heapDeltaBytes": 4431884,
      "heapUsedBytes": 74377672,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 15.561999999999996,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 644.4859999999721,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.883999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.829,
      "heapDeltaBytes": -7758992,
      "heapUsedBytes": 62864688,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 158.86,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 711.1210000000483,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.08,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 462.22999999999996,
      "heapDeltaBytes": 17879028,
      "heapUsedBytes": 88012712,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 163.97899999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2062.5350000000253,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 624.4519999999999,
      "heapDeltaBytes": -13426388,
      "heapUsedBytes": 86907232,
      "domNodes": -270,
      "jsHeapTotalBytes": -831488,
      "scriptDurationMs": 34.668000000000006,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2015.2930000000424,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.9099999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 552.2990000000001,
      "heapDeltaBytes": 22224184,
      "heapUsedBytes": 87117244,
      "domNodes": -271,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.79,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2613.1129999999985,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.679000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1722.4499999999998,
      "heapDeltaBytes": 8747636,
      "heapUsedBytes": 84607812,
      "domNodes": -277,
      "jsHeapTotalBytes": -905216,
      "scriptDurationMs": 826.703,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2252.2240000000693,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 11.332000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1659.007,
      "heapDeltaBytes": 18921528,
      "heapUsedBytes": 84368784,
      "domNodes": -277,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 825.731,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3453.6370000000147,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.128,
      "layouts": 60,
      "layoutDurationMs": 11.333,
      "taskDurationMs": 1650.495,
      "heapDeltaBytes": 11744388,
      "heapUsedBytes": 79504856,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 746.7589999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3610.605000000078,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.031999999999996,
      "layouts": 60,
      "layoutDurationMs": 12.087,
      "taskDurationMs": 1715.598,
      "heapDeltaBytes": 7696112,
      "heapUsedBytes": 75361060,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 766.8960000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3036.5830000000074,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.828000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1875.834,
      "heapDeltaBytes": 17337956,
      "heapUsedBytes": 84258440,
      "domNodes": 2,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 932.753,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3119.7310000000016,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.820999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1982.7210000000002,
      "heapDeltaBytes": 22267796,
      "heapUsedBytes": 89169432,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 981.117,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2025.148999999999,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.323000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 586.0009999999999,
      "heapDeltaBytes": 9988404,
      "heapUsedBytes": 86989572,
      "domNodes": -274,
      "jsHeapTotalBytes": -1916928,
      "scriptDurationMs": 35.18399999999999,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.140999999976,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 3.0039999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 572.036,
      "heapDeltaBytes": 21735376,
      "heapUsedBytes": 87876376,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.615,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 606.6570000000411,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.270999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 421.933,
      "heapDeltaBytes": 14788936,
      "heapUsedBytes": 87425464,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 144.789,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 604.1359999999258,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.822000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.18,
      "heapDeltaBytes": 14851284,
      "heapUsedBytes": 87463992,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 143.868,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.6859999999883,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.453999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.78900000000004,
      "heapDeltaBytes": -2069996,
      "heapUsedBytes": 69016740,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.5600000000000005,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.8399999999974,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.584,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 551.6920000000001,
      "heapDeltaBytes": -9959840,
      "heapUsedBytes": 62656060,
      "domNodes": -298,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.489999999999998,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1721.9840000000204,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 35.262,
      "layouts": 18,
      "layoutDurationMs": 4.858,
      "taskDurationMs": 811.769,
      "heapDeltaBytes": -9977520,
      "heapUsedBytes": 62627324,
      "domNodes": -298,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 106.734,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.0000000000364,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 38.994,
      "layouts": 18,
      "layoutDurationMs": 5.636,
      "taskDurationMs": 834.46,
      "heapDeltaBytes": -11954892,
      "heapUsedBytes": 60647912,
      "domNodes": -296,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 113.695,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.4870000000356,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 32.00399999999999,
      "layouts": 14,
      "layoutDurationMs": 15.141999999999996,
      "taskDurationMs": 948.189,
      "heapDeltaBytes": -7160200,
      "heapUsedBytes": 82791368,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 31.715999999999994,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 144,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8502.060000000029,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 34.825,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5751.378,
      "heapDeltaBytes": -11861172,
      "heapUsedBytes": 88194416,
      "domNodes": -267,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 2627.241,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8918.917999999961,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.099,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6141.173999999999,
      "heapDeltaBytes": 25414192,
      "heapUsedBytes": 90321580,
      "domNodes": -269,
      "jsHeapTotalBytes": 454656,
      "scriptDurationMs": 2831.36,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16976.850999999955,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16561.423,
      "heapDeltaBytes": -36428416,
      "heapUsedBytes": 176918784,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5001216,
      "scriptDurationMs": 292.60400000000004,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17051.964,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16587.369,
      "heapDeltaBytes": -35726304,
      "heapUsedBytes": 173946776,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1515520,
      "scriptDurationMs": 301.55600000000004,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20789.633999999976,
      "styleRecalcs": 161,
      "styleRecalcDurationMs": 18.448999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20444.750000000004,
      "heapDeltaBytes": -47638696,
      "heapUsedBytes": 162514024,
      "domNodes": -6548,
      "jsHeapTotalBytes": -7507968,
      "scriptDurationMs": 928.801,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 16,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21229.618999999955,
      "styleRecalcs": 163,
      "styleRecalcDurationMs": 19.594,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20889.288,
      "heapDeltaBytes": -42478348,
      "heapUsedBytes": 166129196,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4935680,
      "scriptDurationMs": 927.2560000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 198,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4774.022000000059,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.24500000000002,
      "layouts": 20,
      "layoutDurationMs": 22.852999999999984,
      "taskDurationMs": 4637.450000000001,
      "heapDeltaBytes": -16696304,
      "heapUsedBytes": 185565000,
      "domNodes": -6548,
      "jsHeapTotalBytes": 18608128,
      "scriptDurationMs": 96.428,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 94,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6419.522000000029,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 91.30500000000002,
      "layouts": 20,
      "layoutDurationMs": 32.172999999999995,
      "taskDurationMs": 6293.742,
      "heapDeltaBytes": -28674468,
      "heapUsedBytes": 181087132,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2183168,
      "scriptDurationMs": 124.819,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 455,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 470.8909999999378,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 26.543999999999997,
      "layouts": 4,
      "layoutDurationMs": 1.5259999999999998,
      "taskDurationMs": 126.25200000000001,
      "heapDeltaBytes": 5364004,
      "heapUsedBytes": 73695748,
      "domNodes": 153,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 13.363000000000001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 112.38400000002002,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 17.584,
      "layouts": 3,
      "layoutDurationMs": 1.8139999999999998,
      "taskDurationMs": 82.984,
      "heapDeltaBytes": 3061528,
      "heapUsedBytes": 70836628,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.384,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48084 70624 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.8% 255
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions
github-actions Bot requested a review from DrJKL September 5, 2026 16:10
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 5, 2026
@codecov

codecov Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #17082   +/-   ##
=============================================
  Coverage              ?   83.34%           
=============================================
  Files                 ?     2023           
  Lines                 ?   117195           
  Branches              ?    32508           
=============================================
  Hits                  ?    97679           
  Misses                ?    19158           
  Partials              ?      358           
Flag Coverage Δ
e2e 66.58% <ø> (?)
unit 76.70% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/video/useVideoFilmstrip.ts 96.89% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit d084f87 into cloud/1.53 Sep 5, 2026
108 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16348-to-cloud-1.53 branch September 5, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants