Skip to content

[backport cloud/1.53] feat(widgets): add RESOLUTION_PREVIEW readout w… - #17076

Merged
jtydhr88 merged 1 commit into
cloud/1.53from
backport-16511-to-cloud-1.53
Sep 5, 2026
Merged

jtydhr88 merged 1 commit into
cloud/1.53from
backport-16511-to-cloud-1.53

Conversation

@jtydhr88

@jtydhr88 jtydhr88 commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

…idget (#16511)

Display-only widget for the ResolutionSelector node showing the width/height computed from the sibling aspect_ratio/megapixels/multiple widgets, updating live as they change. Reads sibling values reactively via widgetValueStore and mirrors the backend rounding math.

Follows the CURVE/VIDEO_EDIT rails: input spec in nodeDefSchemaV2, constructor in widgets.ts map, Vue component via widgetRegistry. The widget sets serialize=false on both the widget (widgets_values) and its options (API prompt), so workflow files and prompts are unchanged.

Need BE Comfy-Org/ComfyUI#16013

Backport notes

Conflict in nodeDefSchemaV2.ts: main's trailing type guards (isColorInputSpec / isTextareaInputSpec / isGalleriaInputSpec) are not on cloud/1.53, so only isResolutionPreviewInputSpec was added.

…idget (#16511)

Display-only widget for the ResolutionSelector node showing the
width/height computed from the sibling aspect_ratio/megapixels/multiple
widgets, updating live as they change. Reads sibling values reactively
via widgetValueStore and mirrors the backend rounding math.

Follows the CURVE/VIDEO_EDIT rails: input spec in nodeDefSchemaV2,
constructor in widgets.ts map, Vue component via widgetRegistry. The
widget sets serialize=false on both the widget (widgets_values) and its
options (API prompt), so workflow files and prompts are unchanged.

Need BE Comfy-Org/ComfyUI#16013

## Backport notes

Conflict in nodeDefSchemaV2.ts: main's trailing type guards
(isColorInputSpec / isTextareaInputSpec / isGalleriaInputSpec) are not on
cloud/1.53, so only isResolutionPreviewInputSpec was added.
@jtydhr88
jtydhr88 requested a review from a team as a code owner September 5, 2026 15:05
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: af2c000d-2cc1-4718-9907-d562c53ee023

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/05/2026, 03:07:30 PM UTC

Links

🎭 Playwright: ✅ 1892 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1871 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 133ms TBT · 82.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.9 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.7 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 54ms TBT · 165.1 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 347ms TBT · 163.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 530ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 54.4 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -156
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 38ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 880ms
canvas-mouse-sweep: script duration 161ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.0 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 19ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 393ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.1 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 445ms
dom-widget-clipping: script duration 160ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 83.9 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 588ms
large-graph-idle: script duration 31ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.6 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1602ms
large-graph-pan: script duration 799ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.0 MB
large-graph-pan: DOM nodes -273
large-graph-pan: event listeners -153
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 9ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1649ms
large-graph-zoom: script duration 753ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.5 MB
large-graph-zoom: DOM nodes -142
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1882ms
legacy-node-drag: script duration 938ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.1 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 568ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.3 MB
minimap-idle: DOM nodes -271
minimap-idle: event listeners -76
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 421ms
subgraph-dom-widget-clipping: script duration 147ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.4 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 474ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.0 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 36ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 809ms
subgraph-mouse-sweep: script duration 106ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 57.4 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 900ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 133ms
subgraph-transition-enter: heap used 82.0 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5829ms
viewport-pan-sweep: script duration 2663ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 86.9 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -153
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16704ms
vue-large-graph-idle: script duration 294ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.7 MB
vue-large-graph-idle: DOM nodes -6564
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 168
vue-large-graph-pan: task duration 20852ms
vue-large-graph-pan: script duration 933ms
vue-large-graph-pan: TBT 54ms
vue-large-graph-pan: heap used 165.1 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7468
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 29ms
vue-node-resize-workload: style recalc duration 90ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5581ms
vue-node-resize-workload: script duration 123ms
vue-node-resize-workload: TBT 347ms
vue-node-resize-workload: heap used 163.7 MB
vue-node-resize-workload: DOM nodes -6550
vue-node-resize-workload: event listeners -7472
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 3
workflow-execution: style recalc count 12
workflow-execution: task duration 109ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.0 MB
workflow-execution: DOM nodes 122
workflow-execution: event listeners 99
Raw data
{
  "timestamp": "2026-09-05T15:19:18.360Z",
  "gitSha": "5b630b7a797ce5ffc6355f8f0c29c3ac778c1f43",
  "branch": "backport-16511-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2071.442999999931,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.602000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 569.411,
      "heapDeltaBytes": -12283196,
      "heapUsedBytes": 57115640,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.013999999999998,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.6369999999943,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.223999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.75100000000003,
      "heapDeltaBytes": -13270968,
      "heapUsedBytes": 56942172,
      "domNodes": -282,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.048,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1847.1110000000408,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 38.216,
      "layouts": 14,
      "layoutDurationMs": 4.543,
      "taskDurationMs": 882.3639999999999,
      "heapDeltaBytes": -8934452,
      "heapUsedBytes": 61251808,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 160.303,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1858.9849999999615,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 37.757,
      "layouts": 14,
      "layoutDurationMs": 4.356999999999999,
      "taskDurationMs": 877.5260000000001,
      "heapDeltaBytes": -8030764,
      "heapUsedBytes": 62461720,
      "domNodes": -280,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 161.573,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.726999999979,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.026,
      "layouts": 6,
      "layoutDurationMs": 1.2020000000000002,
      "taskDurationMs": 384.21000000000004,
      "heapDeltaBytes": 4456660,
      "heapUsedBytes": 74567696,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.880999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.295000000131,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.708999999999996,
      "layouts": 6,
      "layoutDurationMs": 1.1209999999999998,
      "taskDurationMs": 402.13999999999993,
      "heapDeltaBytes": 4402028,
      "heapUsedBytes": 74564664,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 13.937000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 655.1010000000588,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.968999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.35699999999997,
      "heapDeltaBytes": 17843292,
      "heapUsedBytes": 88147496,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 157.316,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 632.88399999999,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.487,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.91499999999996,
      "heapDeltaBytes": 18100900,
      "heapUsedBytes": 87806492,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 162.549,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.6650000000136,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.96,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 594.502,
      "heapDeltaBytes": -13705428,
      "heapUsedBytes": 86731524,
      "domNodes": -265,
      "jsHeapTotalBytes": -831488,
      "scriptDurationMs": 33.24100000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.9709999999704,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.460999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 581.455,
      "heapDeltaBytes": -13484172,
      "heapUsedBytes": 86576076,
      "domNodes": -273,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 29.298000000000005,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2245.5159999999523,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.733999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1615.949,
      "heapDeltaBytes": -13170312,
      "heapUsedBytes": 87705224,
      "domNodes": -271,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 796.163,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2255.7509999999183,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 8.992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1587.098,
      "heapDeltaBytes": 18558716,
      "heapUsedBytes": 84349448,
      "domNodes": -275,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 801.6869999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3555.9389999999667,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.324999999999996,
      "layouts": 60,
      "layoutDurationMs": 11.36,
      "taskDurationMs": 1660.9080000000001,
      "heapDeltaBytes": 9463220,
      "heapUsedBytes": 76167508,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 763.4449999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3515.7500000000255,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.075,
      "layouts": 60,
      "layoutDurationMs": 11.505999999999998,
      "taskDurationMs": 1636.9530000000002,
      "heapDeltaBytes": 9434476,
      "heapUsedBytes": 75861400,
      "domNodes": -283,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 743.457,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3033.0549999999903,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.715000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1881.224,
      "heapDeltaBytes": 22257776,
      "heapUsedBytes": 89184656,
      "domNodes": 0,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 926.807,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3069.5109999999204,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.011999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1882.689,
      "heapDeltaBytes": 22228984,
      "heapUsedBytes": 89223836,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 949.65,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2003.6910000000034,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 2.121999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 550.9470000000001,
      "heapDeltaBytes": 21408156,
      "heapUsedBytes": 87184452,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 35.214000000000006,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.825000000068,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.6699999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 585.149,
      "heapDeltaBytes": 21805348,
      "heapUsedBytes": 87548120,
      "domNodes": -268,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 35.704,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 598.1980000000249,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.660000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.98799999999994,
      "heapDeltaBytes": 14755788,
      "heapUsedBytes": 87409888,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 144.822,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.3670000000438,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.199,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 424.1940000000001,
      "heapDeltaBytes": 14734428,
      "heapUsedBytes": 87562732,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 148.198,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.3499999999976,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.536000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.32099999999997,
      "heapDeltaBytes": -13310256,
      "heapUsedBytes": 58551388,
      "domNodes": -296,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 6.970000000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.8170000000364,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.132,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.12000000000006,
      "heapDeltaBytes": 2863168,
      "heapUsedBytes": 75613880,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 7.191,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1719.1480000000183,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 34.543000000000006,
      "layouts": 18,
      "layoutDurationMs": 4.731,
      "taskDurationMs": 795.243,
      "heapDeltaBytes": -12123552,
      "heapUsedBytes": 60406752,
      "domNodes": -297,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 104.73599999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1775.043000000096,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 37.066,
      "layouts": 18,
      "layoutDurationMs": 5.757,
      "taskDurationMs": 822.895,
      "heapDeltaBytes": -12515232,
      "heapUsedBytes": 59879672,
      "domNodes": -293,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 106.45,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.1910000000635,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.130000000000006,
      "layouts": 15,
      "layoutDurationMs": 15.722,
      "taskDurationMs": 899.6979999999999,
      "heapDeltaBytes": -7379712,
      "heapUsedBytes": 86029736,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 30.305,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 133,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8631.694999999923,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.051,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5919.307,
      "heapDeltaBytes": 18299936,
      "heapUsedBytes": 93402360,
      "domNodes": -273,
      "jsHeapTotalBytes": 929792,
      "scriptDurationMs": 2679.708,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8490.114999999832,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 34.171,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5738.013,
      "heapDeltaBytes": -11444724,
      "heapUsedBytes": 88817704,
      "domNodes": -267,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 2645.477,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17078.51400000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16502.126,
      "heapDeltaBytes": -34489744,
      "heapUsedBytes": 179000664,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5431296,
      "scriptDurationMs": 288.979,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17590.5130000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16906.206000000002,
      "heapDeltaBytes": -30411960,
      "heapUsedBytes": 178999844,
      "domNodes": -6580,
      "jsHeapTotalBytes": 7356416,
      "scriptDurationMs": 298.648,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20842.19500000006,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 17.50500000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20454.565,
      "heapDeltaBytes": -24913532,
      "heapUsedBytes": 179963760,
      "domNodes": -6548,
      "jsHeapTotalBytes": 696320,
      "scriptDurationMs": 930.25,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 56,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21526.084000000083,
      "styleRecalcs": 164,
      "styleRecalcDurationMs": 20.43299999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21248.547,
      "heapDeltaBytes": -38120484,
      "heapUsedBytes": 166216984,
      "domNodes": -6548,
      "jsHeapTotalBytes": 991232,
      "scriptDurationMs": 936.261,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 51,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6213.758999999982,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.241,
      "layouts": 20,
      "layoutDurationMs": 22.150000000000002,
      "taskDurationMs": 6104.684,
      "heapDeltaBytes": -38811848,
      "heapUsedBytes": 168513464,
      "domNodes": -6548,
      "jsHeapTotalBytes": 7938048,
      "scriptDurationMs": 108.09900000000002,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 391,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5152.585000000045,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 103.55200000000004,
      "layouts": 20,
      "layoutDurationMs": 36.341,
      "taskDurationMs": 5057.601999999999,
      "heapDeltaBytes": -29356964,
      "heapUsedBytes": 174788832,
      "domNodes": -6552,
      "jsHeapTotalBytes": 9269248,
      "scriptDurationMs": 138.79899999999998,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 303,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 462.1589999999287,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 20.996999999999996,
      "layouts": 3,
      "layoutDurationMs": 0.9919999999999998,
      "taskDurationMs": 103.236,
      "heapDeltaBytes": 5081524,
      "heapUsedBytes": 73801900,
      "domNodes": 124,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.084,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 462.1779999999944,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 20.151,
      "layouts": 3,
      "layoutDurationMs": 1.5530000000000002,
      "taskDurationMs": 113.77900000000002,
      "heapDeltaBytes": 5070112,
      "heapUsedBytes": 72971404,
      "domNodes": 119,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.835,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48076 70635 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.8% 255
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions
github-actions Bot requested a review from DrJKL September 5, 2026 15:06
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 5, 2026
@codecov

codecov Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.14286% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../widgets/composables/useResolutionPreviewWidget.ts 22.22% 7 Missing ⚠️
src/schemas/nodeDef/nodeDefSchemaV2.ts 50.00% 2 Missing ⚠️
...nsions/vueNodes/widgets/registry/widgetRegistry.ts 50.00% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.53   #17076   +/-   ##
=============================================
  Coverage              ?   83.34%           
=============================================
  Files                 ?     2025           
  Lines                 ?   117239           
  Branches              ?    33115           
=============================================
  Hits                  ?    97708           
  Misses                ?    19173           
  Partials              ?      358           
Flag Coverage Δ
e2e 66.56% <45.45%> (?)
unit 76.70% <82.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/types/widgets.ts 66.66% <ø> (ø)
...des/widgets/components/WidgetResolutionPreview.vue 100.00% <100.00%> (ø)
src/scripts/widgets.ts 88.31% <ø> (ø)
...nsions/vueNodes/widgets/registry/widgetRegistry.ts 64.10% <50.00%> (ø)
src/schemas/nodeDef/nodeDefSchemaV2.ts 89.58% <50.00%> (ø)
.../widgets/composables/useResolutionPreviewWidget.ts 22.22% <22.22%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — faithful backport of #16511 to cloud/1.53.

What I verified

  • Backport fidelity: diffed this PR's full diff against the merged #16511 diff. Byte-identical to the merged change apart from hunk offsets — no content deviation at all, and correctly no null -> undefined compat fix, since this branch does not need it.
  • BE dependency: Comfy-Org/ComfyUI#16013 (Add live resolution preview widget to ResolutionSelector) merged 2026-09-02, so the RESOLUTION_PREVIEW input spec this consumes actually exists on the backend.
  • Schema union ordering: zResolutionPreviewInputSpec is inserted before zCustomInputSpec in zInputSpec. That ordering matters — zCustomInputSpec has type: z.string() and would otherwise swallow the spec. Correct here, same as main.
  • CI: green (unit test, 16 Playwright chromium shards, storybook build, licenses, fonts, scan).

I left one non-blocking note on #17069 about the frontend duplicating the backend's resolution math (// keep the math in sync with the backend). It applies to this PR's code too, but it is a follow-up for main, not a backport concern — no action needed here.

@jtydhr88
jtydhr88 merged commit 17d6eab into cloud/1.53 Sep 5, 2026
128 of 130 checks passed
@jtydhr88
jtydhr88 deleted the backport-16511-to-cloud-1.53 branch September 5, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants