Skip to content

[backport cloud/1.52] feat(widgets): add RESOLUTION_PREVIEW readout w… - #17074

Merged
jtydhr88 merged 1 commit into
cloud/1.52from
backport-16511-to-cloud-1.52
Sep 5, 2026
Merged

jtydhr88 merged 1 commit into
cloud/1.52from
backport-16511-to-cloud-1.52

Conversation

@jtydhr88

@jtydhr88 jtydhr88 commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

…idget (#16511)

Display-only widget for the ResolutionSelector node showing the width/height computed from the sibling aspect_ratio/megapixels/multiple widgets, updating live as they change. Reads sibling values reactively via widgetValueStore and mirrors the backend rounding math.

Follows the CURVE/VIDEO_EDIT rails: input spec in nodeDefSchemaV2, constructor in widgets.ts map, Vue component via widgetRegistry. The widget sets serialize=false on both the widget (widgets_values) and its options (API prompt), so workflow files and prompts are unchanged.

Need BE Comfy-Org/ComfyUI#16013

Backport notes

Conflict in nodeDefSchemaV2.ts: main's trailing type guards (isColorInputSpec / isTextareaInputSpec / isGalleriaInputSpec) are not on cloud/1.52, so only isResolutionPreviewInputSpec was added.

Backport-only compatibility fix

cloud/1.52 still types widget values as IBaseWidget<boolean | number | string | object | undefined> and derives TWidgetValue from the IWidget union, so a widget whose value is null does not typecheck (addWidget rejects it and TWidgetValue widening breaks useNodeReplacement). The widget value is undefined on this branch instead of null; the value is never read, so behaviour is unchanged.

…idget (#16511)

Display-only widget for the ResolutionSelector node showing the
width/height computed from the sibling aspect_ratio/megapixels/multiple
widgets, updating live as they change. Reads sibling values reactively
via widgetValueStore and mirrors the backend rounding math.

Follows the CURVE/VIDEO_EDIT rails: input spec in nodeDefSchemaV2,
constructor in widgets.ts map, Vue component via widgetRegistry. The
widget sets serialize=false on both the widget (widgets_values) and its
options (API prompt), so workflow files and prompts are unchanged.

Need BE Comfy-Org/ComfyUI#16013

## Backport notes

Conflict in nodeDefSchemaV2.ts: main's trailing type guards
(isColorInputSpec / isTextareaInputSpec / isGalleriaInputSpec) are not on
cloud/1.52, so only isResolutionPreviewInputSpec was added.

## Backport-only compatibility fix

cloud/1.52 still types widget values as IBaseWidget<boolean | number |
string | object | undefined> and derives TWidgetValue from the IWidget
union, so a widget whose value is `null` does not typecheck (addWidget
rejects it and TWidgetValue widening breaks useNodeReplacement). The
widget value is `undefined` on this branch instead of `null`; the value
is never read, so behaviour is unchanged.
@jtydhr88
jtydhr88 requested a review from a team as a code owner September 5, 2026 14:38
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: f96ad807-06df-4881-89c3-fa7b69c27cbd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/05/2026, 02:40:51 PM UTC

Links

🎭 Playwright: ✅ 1985 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1964 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 129ms TBT · 82.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.5 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 164.8 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 233ms TBT · 174.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 652ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 74.2 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -167
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 42ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 936ms
canvas-mouse-sweep: script duration 113ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.6 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -167
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 392ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 62.8 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 395ms
dom-widget-clipping: script duration 59ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.1 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 706ms
large-graph-idle: script duration 20ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 68.8 MB
large-graph-idle: DOM nodes -280
large-graph-idle: event listeners -150
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 16ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1302ms
large-graph-pan: script duration 335ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 67.9 MB
large-graph-pan: DOM nodes -282
large-graph-pan: event listeners -149
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 9ms
large-graph-zoom: style recalc duration 17ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1500ms
large-graph-zoom: script duration 412ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 67.1 MB
large-graph-zoom: DOM nodes -287
large-graph-zoom: event listeners -169
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 11ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1572ms
legacy-node-drag: script duration 499ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 67.0 MB
legacy-node-drag: DOM nodes 10
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 693ms
minimap-idle: script duration 20ms
minimap-idle: TBT 0ms
minimap-idle: heap used 69.2 MB
minimap-idle: DOM nodes -282
minimap-idle: event listeners -149
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 406ms
subgraph-dom-widget-clipping: script duration 122ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 71.1 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 7
subgraph-idle: task duration 565ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 76.0 MB
subgraph-idle: DOM nodes -283
subgraph-idle: event listeners -151
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 40ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 857ms
subgraph-mouse-sweep: script duration 92ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 75.9 MB
subgraph-mouse-sweep: DOM nodes -280
subgraph-mouse-sweep: event listeners -151
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 950ms
subgraph-transition-enter: script duration 17ms
subgraph-transition-enter: TBT 129ms
subgraph-transition-enter: heap used 82.2 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2373
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 45ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4454ms
viewport-pan-sweep: script duration 1055ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 73.5 MB
viewport-pan-sweep: DOM nodes -279
viewport-pan-sweep: event listeners -134
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18308ms
vue-large-graph-idle: script duration 129ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 164.8 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16389
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 26ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 180
vue-large-graph-pan: task duration 23749ms
vue-large-graph-pan: script duration 444ms
vue-large-graph-pan: TBT 233ms
vue-large-graph-pan: heap used 174.4 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16382
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 5
workflow-execution: style recalc count 8
workflow-execution: task duration 96ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 62.6 MB
workflow-execution: DOM nodes 122
workflow-execution: event listeners 37
Raw data
{
  "timestamp": "2026-09-05T14:52:16.404Z",
  "gitSha": "83e914803b7234190d8cc3403063428ea09ab40f",
  "branch": "backport-16511-to-cloud-1.52",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2121.7450000000044,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.613999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 770.0579999999999,
      "heapDeltaBytes": 16493700,
      "heapUsedBytes": 78789584,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 15.552,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2045.566000000008,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.091000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 533.467,
      "heapDeltaBytes": 15343144,
      "heapUsedBytes": 76891500,
      "domNodes": -283,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 8.363000000000003,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1987.967000000026,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 46.944,
      "layouts": 12,
      "layoutDurationMs": 4.096,
      "taskDurationMs": 974.9689999999999,
      "heapDeltaBytes": 6308228,
      "heapUsedBytes": 68684144,
      "domNodes": -280,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 116.71900000000001,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1822.7960000000394,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 37.779999999999994,
      "layouts": 12,
      "layoutDurationMs": 3.575,
      "taskDurationMs": 896.83,
      "heapDeltaBytes": -6886744,
      "heapUsedBytes": 56234820,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 109.074,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1715.7629999999813,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.726,
      "layouts": 6,
      "layoutDurationMs": 0.72,
      "taskDurationMs": 394.34000000000003,
      "heapDeltaBytes": 3433844,
      "heapUsedBytes": 65216772,
      "domNodes": 75,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 12.107,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1694.5869999999559,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.457,
      "layouts": 6,
      "layoutDurationMs": 0.699,
      "taskDurationMs": 388.97700000000003,
      "heapDeltaBytes": 3663364,
      "heapUsedBytes": 66563928,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.947,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 611.7300000000228,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.659,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 399.49800000000005,
      "heapDeltaBytes": 10929320,
      "heapUsedBytes": 73902684,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 57.476000000000006,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 622.9149999999208,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.617999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 390.70700000000005,
      "heapDeltaBytes": 10972812,
      "heapUsedBytes": 73160624,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 61.12,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2085.16800000001,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.399999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 740.525,
      "heapDeltaBytes": -4948488,
      "heapUsedBytes": 72428028,
      "domNodes": -282,
      "jsHeapTotalBytes": -1056768,
      "scriptDurationMs": 21.201999999999998,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.10199999992,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.567000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 671.5710000000001,
      "heapDeltaBytes": -5287852,
      "heapUsedBytes": 71818096,
      "domNodes": -278,
      "jsHeapTotalBytes": -1843200,
      "scriptDurationMs": 18.616999999999997,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2161.666999999966,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 15.379999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1322.03,
      "heapDeltaBytes": -6130476,
      "heapUsedBytes": 72112408,
      "domNodes": -280,
      "jsHeapTotalBytes": -307200,
      "scriptDurationMs": 331.891,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2183.1470000000763,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 16.227999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1281.9099999999999,
      "heapDeltaBytes": -8113204,
      "heapUsedBytes": 70234904,
      "domNodes": -284,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 338.52,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3248.416999999961,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 16.6,
      "layouts": 60,
      "layoutDurationMs": 8.899000000000001,
      "taskDurationMs": 1468.7350000000001,
      "heapDeltaBytes": -9948580,
      "heapUsedBytes": 69281504,
      "domNodes": -288,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 400.826,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3278.381999999965,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 17.268,
      "layouts": 60,
      "layoutDurationMs": 9.568,
      "taskDurationMs": 1530.9819999999997,
      "heapDeltaBytes": -6961760,
      "heapUsedBytes": 71453064,
      "domNodes": -286,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 423.033,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2260.2190000000064,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 10.812,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1552.6909999999998,
      "heapDeltaBytes": -14377112,
      "heapUsedBytes": 70236056,
      "domNodes": 10,
      "jsHeapTotalBytes": 7639040,
      "scriptDurationMs": 497.00600000000003,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2544.3370000000414,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 10.926000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1591.914,
      "heapDeltaBytes": -14372480,
      "heapUsedBytes": 70206468,
      "domNodes": 10,
      "jsHeapTotalBytes": 9211904,
      "scriptDurationMs": 500.42900000000003,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2042.2889999999825,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.294999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 689.617,
      "heapDeltaBytes": -12062120,
      "heapUsedBytes": 71311664,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 20.702,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2089.431999999988,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.386,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 695.4689999999999,
      "heapDeltaBytes": -11351744,
      "heapUsedBytes": 73873852,
      "domNodes": -282,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 18.615,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 593.6489999999708,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 10.256999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.78700000000003,
      "heapDeltaBytes": 11902808,
      "heapUsedBytes": 74730176,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 122.043,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 595.6479999999829,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.982000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.52,
      "heapDeltaBytes": 11906536,
      "heapUsedBytes": 74470172,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 122.369,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2035.69600000003,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.7529999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 605.4699999999999,
      "heapDeltaBytes": 17642208,
      "heapUsedBytes": 80482120,
      "domNodes": -284,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.953,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.7479999999687,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 524.713,
      "heapDeltaBytes": 17093932,
      "heapUsedBytes": 78847256,
      "domNodes": -282,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 8.12,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1732.0399999999836,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 39.144,
      "layouts": 16,
      "layoutDurationMs": 4.872,
      "taskDurationMs": 872.899,
      "heapDeltaBytes": 15984304,
      "heapUsedBytes": 79089340,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 90.904,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1750.8619999999837,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 40.443,
      "layouts": 16,
      "layoutDurationMs": 4.829,
      "taskDurationMs": 841.4010000000001,
      "heapDeltaBytes": 17594460,
      "heapUsedBytes": 80134152,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 93.014,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1385.2190000000064,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 32.887,
      "layouts": 14,
      "layoutDurationMs": 13.260000000000002,
      "taskDurationMs": 949.6279999999999,
      "heapDeltaBytes": -8027872,
      "heapUsedBytes": 86192528,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15204352,
      "scriptDurationMs": 17.299000000000003,
      "eventListeners": 2373,
      "totalBlockingTimeMs": 129,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8447.055000000035,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 44.267,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4553.842000000001,
      "heapDeltaBytes": -732512,
      "heapUsedBytes": 76027168,
      "domNodes": -280,
      "jsHeapTotalBytes": -307200,
      "scriptDurationMs": 1097.3120000000001,
      "eventListeners": -135,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8212.63799999997,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 45.733999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4354.5160000000005,
      "heapDeltaBytes": 872960,
      "heapUsedBytes": 78140808,
      "domNodes": -277,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 1013.385,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19037.684000000012,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18342.367,
      "heapDeltaBytes": -67217212,
      "heapUsedBytes": 165001848,
      "domNodes": -8312,
      "jsHeapTotalBytes": -21434368,
      "scriptDurationMs": 137.23999999999998,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18976.052999999978,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18272.767000000003,
      "heapDeltaBytes": -46792848,
      "heapUsedBytes": 180512104,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11190272,
      "scriptDurationMs": 121.72400000000002,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24546.429999999986,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 28.62500000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23972.987,
      "heapDeltaBytes": -42150480,
      "heapUsedBytes": 189983536,
      "domNodes": -8312,
      "jsHeapTotalBytes": -23060480,
      "scriptDurationMs": 455.726,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 319,
      "frameDurationMs": 17.77333333333348,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24293.808999999896,
      "styleRecalcs": 179,
      "styleRecalcDurationMs": 24.112999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23524.207000000002,
      "heapDeltaBytes": -43377764,
      "heapUsedBytes": 175691352,
      "domNodes": -8312,
      "jsHeapTotalBytes": -22155264,
      "scriptDurationMs": 431.5089999999999,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 147,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999995634
    },
    {
      "name": "workflow-execution",
      "durationMs": 121.38100000004215,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 21.462000000000003,
      "layouts": 7,
      "layoutDurationMs": 2.091,
      "taskDurationMs": 89.53499999999998,
      "heapDeltaBytes": 3108824,
      "heapUsedBytes": 65874412,
      "domNodes": 131,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.7299999999999995,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 141.88900000010563,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 20.180000000000003,
      "layouts": 3,
      "layoutDurationMs": 3.124,
      "taskDurationMs": 101.607,
      "heapDeltaBytes": 3160704,
      "heapUsedBytes": 65446372,
      "domNodes": 112,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.571000000000001,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 46451 68691 67.6% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.4% 1212
src/LGraphNode.ts 64.3% 464
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/LGraph.ts 73.0% 312
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 38.0% 258
src/scripts/app.ts 71.2% 241
src/scripts/pnginfo.ts 21.5% 219
src/renderer/core/canvas/pathRenderer.ts 24.7% 192

@github-actions
github-actions Bot requested a review from DrJKL September 5, 2026 14:40
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 5, 2026
@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.14286% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../widgets/composables/useResolutionPreviewWidget.ts 22.22% 7 Missing ⚠️
src/schemas/nodeDef/nodeDefSchemaV2.ts 50.00% 2 Missing ⚠️
...nsions/vueNodes/widgets/registry/widgetRegistry.ts 50.00% 1 Missing ⚠️
@@              Coverage Diff               @@
##           cloud/1.52   #17074      +/-   ##
==============================================
+ Coverage       79.65%   82.05%   +2.39%     
==============================================
  Files            2242     1914     -328     
  Lines          115125   110181    -4944     
  Branches        32908    32230     -678     
==============================================
- Hits            91703    90408    -1295     
+ Misses          22927    19430    -3497     
+ Partials          495      343     -152     
Flag Coverage Δ
e2e 66.13% <45.45%> (+0.01%) ⬆️
unit 74.08% <82.14%> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/types/widgets.ts 83.33% <ø> (ø)
...des/widgets/components/WidgetResolutionPreview.vue 100.00% <100.00%> (ø)
src/scripts/widgets.ts 86.84% <ø> (ø)
...nsions/vueNodes/widgets/registry/widgetRegistry.ts 63.63% <50.00%> (-0.37%) ⬇️
src/schemas/nodeDef/nodeDefSchemaV2.ts 89.58% <50.00%> (-3.60%) ⬇️
.../widgets/composables/useResolutionPreviewWidget.ts 22.22% <22.22%> (ø)

... and 349 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — faithful backport of #16511 to cloud/1.52.

What I verified

  • Backport fidelity: diffed this PR's full diff against the merged #16511 diff. Identical apart from hunk offsets and the documented null -> undefined swap in 6 places.
  • BE dependency: Comfy-Org/ComfyUI#16013 (Add live resolution preview widget to ResolutionSelector) merged 2026-09-02, so the RESOLUTION_PREVIEW input spec this consumes actually exists on the backend.
  • Schema union ordering: zResolutionPreviewInputSpec is inserted before zCustomInputSpec in zInputSpec. That ordering matters — zCustomInputSpec has type: z.string() and would otherwise swallow the spec. Correct here, same as main.
  • CI: green (unit test, 16 Playwright chromium shards, storybook build, licenses, fonts, scan).

On the null → undefined compat change

I checked the "the value is never read" claim rather than taking it at face value, and it holds:

  • WidgetResolutionPreview.vue only ever touches widget.name and widget.options?.{ratio,megapixels,multiple}_widget. There is no widget.value read anywhere in the feature.
  • useResolutionPreviewWidget sets serialize: false on the options and rawWidget.serialize = false on the widget, so the value never reaches widgets_values or the API prompt.

So the swap is inert for behaviour, and it buys typecheck compatibility with this branch's IBaseWidget<boolean | number | string | object | undefined>. Good call keeping the backport type-safe instead of loosening the base type on a release branch.

I left one non-blocking note on #17069 about the frontend duplicating the backend's resolution math (// keep the math in sync with the backend). It applies to this PR's code too, but it is a follow-up for main, not a backport concern — no action needed here.

@jtydhr88
jtydhr88 added this pull request to the merge queue Sep 5, 2026
Merged via the queue into cloud/1.52 with commit 450eac2 Sep 5, 2026
82 checks passed
@jtydhr88
jtydhr88 deleted the backport-16511-to-cloud-1.52 branch September 5, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants