Skip to content

[backport cloud/1.52] fix(load3d): gate camera custom up on explicit useCustomUp flag - #17073

Merged
comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-15957-to-cloud-1.52
Sep 5, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-15957-to-cloud-1.52

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #15957 to cloud/1.52

Automatically created by backport workflow.

## Summary
setCameraState treated any quaternion-bearing state as a custom up and
auto-enabled it, so restoring a node's own saved orbit state tilted the
camera up vector and compounded roll on every save/restore cycle.

Custom up now applies only when the state explicitly carries
useCustomUp, which getCameraState round-trips once a custom up has been
captured. The camera_info producer (CreateCameraInfo backend) sets the
flag. Add the Custom up / Natural up toggle to the menubar camera group
so flagged states can be switched back to the world up.

Need BE Comfy-Org/ComfyUI#14964
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 5, 2026
@comfy-pr-bot
comfy-pr-bot requested review from a team and jtydhr88 as code owners September 5, 2026 14:34
@github-actions

github-actions Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/05/2026, 02:36:41 PM UTC

Links

🎭 Playwright: ✅ 1985 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1964 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 137ms TBT · 100.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.2 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.1 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 33ms TBT · 175.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 543ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 75.0 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -152
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 44ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 1020ms
canvas-mouse-sweep: script duration 112ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.2 MB
canvas-mouse-sweep: DOM nodes -284
canvas-mouse-sweep: event listeners -167
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 19ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 408ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 62.8 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 382ms
dom-widget-clipping: script duration 53ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.2 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 9ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 668ms
large-graph-idle: script duration 14ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 68.6 MB
large-graph-idle: DOM nodes -277
large-graph-idle: event listeners -149
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 15ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1287ms
large-graph-pan: script duration 335ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 76.0 MB
large-graph-pan: DOM nodes -285
large-graph-pan: event listeners -178
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1475ms
large-graph-zoom: script duration 394ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 65.8 MB
large-graph-zoom: DOM nodes -287
large-graph-zoom: event listeners -154
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 10ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1505ms
legacy-node-drag: script duration 448ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 76.8 MB
legacy-node-drag: DOM nodes 11
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 688ms
minimap-idle: script duration 15ms
minimap-idle: TBT 0ms
minimap-idle: heap used 65.2 MB
minimap-idle: DOM nodes -285
minimap-idle: event listeners -178
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 403ms
subgraph-dom-widget-clipping: script duration 119ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 71.4 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 541ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 77.1 MB
subgraph-idle: DOM nodes -279
subgraph-idle: event listeners -152
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 41ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 891ms
subgraph-mouse-sweep: script duration 85ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.0 MB
subgraph-mouse-sweep: DOM nodes -284
subgraph-mouse-sweep: event listeners -167
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 919ms
subgraph-transition-enter: script duration 17ms
subgraph-transition-enter: TBT 137ms
subgraph-transition-enter: heap used 100.5 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 41ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4738ms
viewport-pan-sweep: script duration 1078ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 73.2 MB
viewport-pan-sweep: DOM nodes -275
viewport-pan-sweep: event listeners -147
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15480ms
vue-large-graph-idle: script duration 115ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 173.1 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16393
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 157
vue-large-graph-pan: task duration 18650ms
vue-large-graph-pan: script duration 408ms
vue-large-graph-pan: TBT 33ms
vue-large-graph-pan: heap used 175.2 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16390
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 4
workflow-execution: style recalc count 9
workflow-execution: task duration 104ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 62.6 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 26
Raw data
{
  "timestamp": "2026-09-05T14:47:17.007Z",
  "gitSha": "97e4e2080a36cf5b1539bd2e58e1e56627aa997c",
  "branch": "backport-15957-to-cloud-1.52",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2042.667999999992,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.112,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.205,
      "heapDeltaBytes": 15127632,
      "heapUsedBytes": 77354536,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.712999999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2061.3520000000563,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.066000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 586.5219999999999,
      "heapDeltaBytes": 18239724,
      "heapUsedBytes": 79893256,
      "domNodes": -281,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 9.353999999999997,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2052.9490000000123,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 45.072,
      "layouts": 12,
      "layoutDurationMs": 3.8720000000000003,
      "taskDurationMs": 1060.282,
      "heapDeltaBytes": 4759576,
      "heapUsedBytes": 66949484,
      "domNodes": -285,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 112.883,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1908.9769999999362,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 43.49,
      "layouts": 12,
      "layoutDurationMs": 3.882,
      "taskDurationMs": 978.9549999999999,
      "heapDeltaBytes": -4655152,
      "heapUsedBytes": 57218108,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 110.906,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1730.2270000000135,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.603,
      "layouts": 6,
      "layoutDurationMs": 0.7850000000000001,
      "taskDurationMs": 377.994,
      "heapDeltaBytes": 3290772,
      "heapUsedBytes": 66304772,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.488,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1748.6880000000156,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 20.669000000000004,
      "layouts": 6,
      "layoutDurationMs": 0.619,
      "taskDurationMs": 437.55,
      "heapDeltaBytes": 3378028,
      "heapUsedBytes": 65390208,
      "domNodes": 77,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 12.823,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 630.7110000000193,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.264,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 369.286,
      "heapDeltaBytes": 11004808,
      "heapUsedBytes": 73464184,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 49.910999999999994,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 608.1010000000333,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.382000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 394.744,
      "heapDeltaBytes": 10903456,
      "heapUsedBytes": 73805092,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 55.41599999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2056.3169999999786,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.633999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 626.6089999999999,
      "heapDeltaBytes": -3359748,
      "heapUsedBytes": 73770848,
      "domNodes": -272,
      "jsHeapTotalBytes": -2891776,
      "scriptDurationMs": 13.995000000000005,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.760999999985,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.767999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 708.557,
      "heapDeltaBytes": -7480536,
      "heapUsedBytes": 70053584,
      "domNodes": -281,
      "jsHeapTotalBytes": -532480,
      "scriptDurationMs": 14.446999999999997,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2179.333999999983,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.883999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1332.341,
      "heapDeltaBytes": -7116336,
      "heapUsedBytes": 70136016,
      "domNodes": -285,
      "jsHeapTotalBytes": 479232,
      "scriptDurationMs": 334.852,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2182.596999999987,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.383,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1240.975,
      "heapDeltaBytes": 12187280,
      "heapUsedBytes": 89308728,
      "domNodes": -284,
      "jsHeapTotalBytes": 4673536,
      "scriptDurationMs": 336.03099999999995,
      "eventListeners": -177,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3311.585999999977,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.449000000000002,
      "layouts": 60,
      "layoutDurationMs": 8.244000000000002,
      "taskDurationMs": 1498.1930000000002,
      "heapDeltaBytes": -8222356,
      "heapUsedBytes": 71407468,
      "domNodes": -286,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 395.453,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3182.4029999999084,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.506000000000002,
      "layouts": 60,
      "layoutDurationMs": 7.736999999999999,
      "taskDurationMs": 1451.6370000000002,
      "heapDeltaBytes": -13121380,
      "heapUsedBytes": 66637592,
      "domNodes": -287,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 392.838,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2425.6349999999998,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.932999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1548.1930000000002,
      "heapDeltaBytes": -17378616,
      "heapUsedBytes": 69843616,
      "domNodes": 12,
      "jsHeapTotalBytes": 9998336,
      "scriptDurationMs": 458.382,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2225.4120000000057,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.149000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1460.972,
      "heapDeltaBytes": 11241188,
      "heapUsedBytes": 91270196,
      "domNodes": 10,
      "jsHeapTotalBytes": 7270400,
      "scriptDurationMs": 437.449,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2042.695999999978,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.760999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 649.6709999999999,
      "heapDeltaBytes": -12159436,
      "heapUsedBytes": 71511112,
      "domNodes": -283,
      "jsHeapTotalBytes": 3661824,
      "scriptDurationMs": 13.898000000000001,
      "eventListeners": -177,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.3800000000792,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.32,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 727.1349999999999,
      "heapDeltaBytes": -13232240,
      "heapUsedBytes": 65266196,
      "domNodes": -286,
      "jsHeapTotalBytes": 3399680,
      "scriptDurationMs": 16.106999999999996,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 591.1869999999908,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.482,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 390.44,
      "heapDeltaBytes": 12017144,
      "heapUsedBytes": 74757116,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 116.33300000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 638.781999999992,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.731000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.52899999999994,
      "heapDeltaBytes": 11826600,
      "heapUsedBytes": 74926564,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 121.628,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.2420000000056,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.12,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 508.03299999999996,
      "heapDeltaBytes": 19058556,
      "heapUsedBytes": 82038240,
      "domNodes": -279,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 7.2139999999999995,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2053.890000000024,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.719000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 573.288,
      "heapDeltaBytes": 16647080,
      "heapUsedBytes": 79665976,
      "domNodes": -279,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.592000000000002,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1746.3480000000118,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 39.711000000000006,
      "layouts": 16,
      "layoutDurationMs": 4.625,
      "taskDurationMs": 839.053,
      "heapDeltaBytes": 3799448,
      "heapUsedBytes": 66974828,
      "domNodes": -286,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 81.315,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1790.5209999998988,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 42.88699999999999,
      "layouts": 16,
      "layoutDurationMs": 4.872,
      "taskDurationMs": 943.805,
      "heapDeltaBytes": 19093104,
      "heapUsedBytes": 81823552,
      "domNodes": -282,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 88.215,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.4209999999944,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 28.421999999999997,
      "layouts": 14,
      "layoutDurationMs": 12.684,
      "taskDurationMs": 919.1409999999997,
      "heapDeltaBytes": 22163652,
      "heapUsedBytes": 105347328,
      "domNodes": 13673,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 17.243000000000002,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 137,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8313.370999999961,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 40.123999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4637.67,
      "heapDeltaBytes": -4477928,
      "heapUsedBytes": 72910332,
      "domNodes": -280,
      "jsHeapTotalBytes": 3887104,
      "scriptDurationMs": 1059.3970000000002,
      "eventListeners": -163,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8247.364999999945,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 42.569,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4837.7080000000005,
      "heapDeltaBytes": 3274924,
      "heapUsedBytes": 80663428,
      "domNodes": -270,
      "jsHeapTotalBytes": 217088,
      "scriptDurationMs": 1096.756,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16707.605,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15639.371000000001,
      "heapDeltaBytes": -50661516,
      "heapUsedBytes": 181253836,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15667200,
      "scriptDurationMs": 116.396,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.33666666666662,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16380.587999999989,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15319.895999999999,
      "heapDeltaBytes": -43487204,
      "heapUsedBytes": 181826404,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9740288,
      "scriptDurationMs": 114.32099999999998,
      "eventListeners": -16395,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18907.844000000012,
      "styleRecalcs": 155,
      "styleRecalcDurationMs": 18.042,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18423.789999999997,
      "heapDeltaBytes": -39210784,
      "heapUsedBytes": 193083956,
      "domNodes": -8312,
      "jsHeapTotalBytes": -20967424,
      "scriptDurationMs": 398.56800000000004,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 23,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19393.941999999923,
      "styleRecalcs": 159,
      "styleRecalcDurationMs": 20.230000000000025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18876.213999999996,
      "heapDeltaBytes": -41444836,
      "heapUsedBytes": 174413740,
      "domNodes": -8312,
      "jsHeapTotalBytes": -18112512,
      "scriptDurationMs": 417.43699999999995,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 43,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 148.11199999996916,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 27.307000000000002,
      "layouts": 6,
      "layoutDurationMs": 2.199,
      "taskDurationMs": 120.63499999999999,
      "heapDeltaBytes": 3164012,
      "heapUsedBytes": 65710212,
      "domNodes": 127,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.817,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 117.07200000000739,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 16.532,
      "layouts": 2,
      "layoutDurationMs": 1.037,
      "taskDurationMs": 87.08200000000002,
      "heapDeltaBytes": 2943256,
      "heapUsedBytes": 65655768,
      "domNodes": 127,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 3.981000000000002,
      "eventListeners": 27,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 46413 68692 67.6% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.4% 1212
src/LGraphNode.ts 64.3% 464
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/LGraph.ts 73.0% 312
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 38.0% 258
src/scripts/app.ts 71.2% 241
src/scripts/pnginfo.ts 21.5% 219
src/stores/assetsStore.ts 45.0% 203

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 5, 2026
@comfy-pr-bot
comfy-pr-bot added this pull request to the merge queue Sep 5, 2026
@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff               @@
##           cloud/1.52   #17073      +/-   ##
==============================================
+ Coverage       79.65%   82.05%   +2.39%     
==============================================
  Files            2242     1912     -330     
  Lines          115125   110151    -4974     
  Branches        32908    32223     -685     
==============================================
- Hits            91703    90379    -1324     
+ Misses          22927    19419    -3508     
+ Partials          495      353     -142     
Flag Coverage Δ
e2e 66.07% <25.00%> (-0.05%) ⬇️
unit 74.08% <100.00%> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/load3d/menubar/CameraMenuGroup.vue 95.55% <100.00%> (+6.26%) ⬆️
src/extensions/core/load3d/CameraManager.ts 90.96% <100.00%> (-0.12%) ⬇️

... and 339 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into cloud/1.52 with commit 72f5def Sep 5, 2026
91 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-15957-to-cloud-1.52 branch September 5, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants