Repository navigation
[backport cloud/1.52] fix(load3d): gate camera custom up on explicit useCustomUp flag - #17073
Conversation
## Summary setCameraState treated any quaternion-bearing state as a custom up and auto-enabled it, so restoring a node's own saved orbit state tilted the camera up vector and compounded roll on every save/restore cycle. Custom up now applies only when the state explicitly carries useCustomUp, which getCameraState round-trips once a custom up has been captured. The camera_info producer (CreateCameraInfo backend) sets the flag. Add the Custom up / Natural up toggle to the menubar camera group so flagged states can be switched back to the world up. Need BE Comfy-Org/ComfyUI#14964
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1985 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-05T14:47:17.007Z",
"gitSha": "97e4e2080a36cf5b1539bd2e58e1e56627aa997c",
"branch": "backport-15957-to-cloud-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2042.667999999992,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.112,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.205,
"heapDeltaBytes": 15127632,
"heapUsedBytes": 77354536,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.712999999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2061.3520000000563,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.066000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.5219999999999,
"heapDeltaBytes": 18239724,
"heapUsedBytes": 79893256,
"domNodes": -281,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.353999999999997,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2052.9490000000123,
"styleRecalcs": 76,
"styleRecalcDurationMs": 45.072,
"layouts": 12,
"layoutDurationMs": 3.8720000000000003,
"taskDurationMs": 1060.282,
"heapDeltaBytes": 4759576,
"heapUsedBytes": 66949484,
"domNodes": -285,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 112.883,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1908.9769999999362,
"styleRecalcs": 75,
"styleRecalcDurationMs": 43.49,
"layouts": 12,
"layoutDurationMs": 3.882,
"taskDurationMs": 978.9549999999999,
"heapDeltaBytes": -4655152,
"heapUsedBytes": 57218108,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 110.906,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.2270000000135,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.603,
"layouts": 6,
"layoutDurationMs": 0.7850000000000001,
"taskDurationMs": 377.994,
"heapDeltaBytes": 3290772,
"heapUsedBytes": 66304772,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.488,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1748.6880000000156,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.669000000000004,
"layouts": 6,
"layoutDurationMs": 0.619,
"taskDurationMs": 437.55,
"heapDeltaBytes": 3378028,
"heapUsedBytes": 65390208,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.823,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 630.7110000000193,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.264,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.286,
"heapDeltaBytes": 11004808,
"heapUsedBytes": 73464184,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 49.910999999999994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 608.1010000000333,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.382000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.744,
"heapDeltaBytes": 10903456,
"heapUsedBytes": 73805092,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 55.41599999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.3169999999786,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.633999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.6089999999999,
"heapDeltaBytes": -3359748,
"heapUsedBytes": 73770848,
"domNodes": -272,
"jsHeapTotalBytes": -2891776,
"scriptDurationMs": 13.995000000000005,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.760999999985,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.767999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 708.557,
"heapDeltaBytes": -7480536,
"heapUsedBytes": 70053584,
"domNodes": -281,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 14.446999999999997,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2179.333999999983,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.883999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1332.341,
"heapDeltaBytes": -7116336,
"heapUsedBytes": 70136016,
"domNodes": -285,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 334.852,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2182.596999999987,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.383,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1240.975,
"heapDeltaBytes": 12187280,
"heapUsedBytes": 89308728,
"domNodes": -284,
"jsHeapTotalBytes": 4673536,
"scriptDurationMs": 336.03099999999995,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3311.585999999977,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.449000000000002,
"layouts": 60,
"layoutDurationMs": 8.244000000000002,
"taskDurationMs": 1498.1930000000002,
"heapDeltaBytes": -8222356,
"heapUsedBytes": 71407468,
"domNodes": -286,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 395.453,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3182.4029999999084,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.506000000000002,
"layouts": 60,
"layoutDurationMs": 7.736999999999999,
"taskDurationMs": 1451.6370000000002,
"heapDeltaBytes": -13121380,
"heapUsedBytes": 66637592,
"domNodes": -287,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 392.838,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2425.6349999999998,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.932999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1548.1930000000002,
"heapDeltaBytes": -17378616,
"heapUsedBytes": 69843616,
"domNodes": 12,
"jsHeapTotalBytes": 9998336,
"scriptDurationMs": 458.382,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2225.4120000000057,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.149000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1460.972,
"heapDeltaBytes": 11241188,
"heapUsedBytes": 91270196,
"domNodes": 10,
"jsHeapTotalBytes": 7270400,
"scriptDurationMs": 437.449,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.695999999978,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.760999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 649.6709999999999,
"heapDeltaBytes": -12159436,
"heapUsedBytes": 71511112,
"domNodes": -283,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 13.898000000000001,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.3800000000792,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.32,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 727.1349999999999,
"heapDeltaBytes": -13232240,
"heapUsedBytes": 65266196,
"domNodes": -286,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 16.106999999999996,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.1869999999908,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.482,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.44,
"heapDeltaBytes": 12017144,
"heapUsedBytes": 74757116,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 116.33300000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 638.781999999992,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.731000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.52899999999994,
"heapDeltaBytes": 11826600,
"heapUsedBytes": 74926564,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 121.628,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.2420000000056,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.12,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.03299999999996,
"heapDeltaBytes": 19058556,
"heapUsedBytes": 82038240,
"domNodes": -279,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.2139999999999995,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2053.890000000024,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.719000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.288,
"heapDeltaBytes": 16647080,
"heapUsedBytes": 79665976,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.592000000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1746.3480000000118,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.711000000000006,
"layouts": 16,
"layoutDurationMs": 4.625,
"taskDurationMs": 839.053,
"heapDeltaBytes": 3799448,
"heapUsedBytes": 66974828,
"domNodes": -286,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 81.315,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1790.5209999998988,
"styleRecalcs": 75,
"styleRecalcDurationMs": 42.88699999999999,
"layouts": 16,
"layoutDurationMs": 4.872,
"taskDurationMs": 943.805,
"heapDeltaBytes": 19093104,
"heapUsedBytes": 81823552,
"domNodes": -282,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 88.215,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.4209999999944,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.421999999999997,
"layouts": 14,
"layoutDurationMs": 12.684,
"taskDurationMs": 919.1409999999997,
"heapDeltaBytes": 22163652,
"heapUsedBytes": 105347328,
"domNodes": 13673,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 17.243000000000002,
"eventListeners": 2375,
"totalBlockingTimeMs": 137,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8313.370999999961,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.123999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4637.67,
"heapDeltaBytes": -4477928,
"heapUsedBytes": 72910332,
"domNodes": -280,
"jsHeapTotalBytes": 3887104,
"scriptDurationMs": 1059.3970000000002,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8247.364999999945,
"styleRecalcs": 250,
"styleRecalcDurationMs": 42.569,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4837.7080000000005,
"heapDeltaBytes": 3274924,
"heapUsedBytes": 80663428,
"domNodes": -270,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 1096.756,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16707.605,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15639.371000000001,
"heapDeltaBytes": -50661516,
"heapUsedBytes": 181253836,
"domNodes": -8312,
"jsHeapTotalBytes": -15667200,
"scriptDurationMs": 116.396,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16380.587999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15319.895999999999,
"heapDeltaBytes": -43487204,
"heapUsedBytes": 181826404,
"domNodes": -8312,
"jsHeapTotalBytes": -9740288,
"scriptDurationMs": 114.32099999999998,
"eventListeners": -16395,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18907.844000000012,
"styleRecalcs": 155,
"styleRecalcDurationMs": 18.042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18423.789999999997,
"heapDeltaBytes": -39210784,
"heapUsedBytes": 193083956,
"domNodes": -8312,
"jsHeapTotalBytes": -20967424,
"scriptDurationMs": 398.56800000000004,
"eventListeners": -16389,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 19393.941999999923,
"styleRecalcs": 159,
"styleRecalcDurationMs": 20.230000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18876.213999999996,
"heapDeltaBytes": -41444836,
"heapUsedBytes": 174413740,
"domNodes": -8312,
"jsHeapTotalBytes": -18112512,
"scriptDurationMs": 417.43699999999995,
"eventListeners": -16391,
"totalBlockingTimeMs": 43,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 148.11199999996916,
"styleRecalcs": 9,
"styleRecalcDurationMs": 27.307000000000002,
"layouts": 6,
"layoutDurationMs": 2.199,
"taskDurationMs": 120.63499999999999,
"heapDeltaBytes": 3164012,
"heapUsedBytes": 65710212,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.817,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 117.07200000000739,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.532,
"layouts": 2,
"layoutDurationMs": 1.037,
"taskDurationMs": 87.08200000000002,
"heapDeltaBytes": 2943256,
"heapUsedBytes": 65655768,
"domNodes": 127,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 3.981000000000002,
"eventListeners": 27,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.52 #17073 +/- ##
==============================================
+ Coverage 79.65% 82.05% +2.39%
==============================================
Files 2242 1912 -330
Lines 115125 110151 -4974
Branches 32908 32223 -685
==============================================
- Hits 91703 90379 -1324
+ Misses 22927 19419 -3508
+ Partials 495 353 -142
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 339 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #15957 to
cloud/1.52Automatically created by backport workflow.