Repository navigation
[backport core/1.52] fix(load3d): gate camera custom up on explicit useCustomUp flag - #17072
Conversation
## Summary setCameraState treated any quaternion-bearing state as a custom up and auto-enabled it, so restoring a node's own saved orbit state tilted the camera up vector and compounded roll on every save/restore cycle. Custom up now applies only when the state explicitly carries useCustomUp, which getCameraState round-trips once a custom up has been captured. The camera_info producer (CreateCameraInfo backend) sets the flag. Add the Custom up / Natural up toggle to the menubar camera group so flagged states can be switched back to the world up. Need BE Comfy-Org/ComfyUI#14964
🎭 Playwright: ✅ 1980 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-05T14:47:53.919Z",
"gitSha": "cf2fe013e936dc4798b724faf0aa83a2d6cb6dda",
"branch": "backport-15957-to-core-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2028.7440000000174,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.304000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.511,
"heapDeltaBytes": 17935700,
"heapUsedBytes": 80274520,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.547000000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.9330000000136,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.330999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.35699999999997,
"heapDeltaBytes": -473948,
"heapUsedBytes": 61919048,
"domNodes": -280,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 6.757000000000001,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1791.5759999999636,
"styleRecalcs": 71,
"styleRecalcDurationMs": 34.006,
"layouts": 12,
"layoutDurationMs": 3.125,
"taskDurationMs": 836.665,
"heapDeltaBytes": -6075752,
"heapUsedBytes": 56757008,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 104.144,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1798.8100000000031,
"styleRecalcs": 71,
"styleRecalcDurationMs": 33.495999999999995,
"layouts": 12,
"layoutDurationMs": 3.174,
"taskDurationMs": 825.3649999999999,
"heapDeltaBytes": -2901888,
"heapUsedBytes": 59793328,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 106.64500000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.9330000000355,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.183000000000003,
"layouts": 6,
"layoutDurationMs": 0.6809999999999999,
"taskDurationMs": 346.864,
"heapDeltaBytes": 3416932,
"heapUsedBytes": 65849180,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.054,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.0009999999866,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.664000000000001,
"layouts": 6,
"layoutDurationMs": 0.5270000000000001,
"taskDurationMs": 343.962,
"heapDeltaBytes": 3039292,
"heapUsedBytes": 65728120,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.568000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 646.3739999999802,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.172999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.61199999999997,
"heapDeltaBytes": 10855872,
"heapUsedBytes": 73946544,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 56.07599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 561.7149999999356,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.671,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.638,
"heapDeltaBytes": 10132388,
"heapUsedBytes": 72113828,
"domNodes": 14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 53.23500000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.1829999999995,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.476,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.3989999999999,
"heapDeltaBytes": -1028740,
"heapUsedBytes": 75996408,
"domNodes": -272,
"jsHeapTotalBytes": -1576960,
"scriptDurationMs": 14.260999999999996,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.9199999999619,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.26,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 600.8679999999999,
"heapDeltaBytes": -12959780,
"heapUsedBytes": 64332356,
"domNodes": -280,
"jsHeapTotalBytes": 2617344,
"scriptDurationMs": 15.202999999999998,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2159.8730000000046,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.81,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1219.333,
"heapDeltaBytes": -6211904,
"heapUsedBytes": 71932624,
"domNodes": -273,
"jsHeapTotalBytes": -565248,
"scriptDurationMs": 346.8,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2167.147,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.815999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1175.3170000000002,
"heapDeltaBytes": -7994400,
"heapUsedBytes": 70196916,
"domNodes": -274,
"jsHeapTotalBytes": -827392,
"scriptDurationMs": 323.106,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3146.7499999999973,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.828000000000003,
"layouts": 60,
"layoutDurationMs": 6.8420000000000005,
"taskDurationMs": 1344.346,
"heapDeltaBytes": -1565056,
"heapUsedBytes": 77614096,
"domNodes": -276,
"jsHeapTotalBytes": -1576960,
"scriptDurationMs": 378.71500000000003,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3107.2999999998956,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.227,
"layouts": 60,
"layoutDurationMs": 6.864,
"taskDurationMs": 1351.9519999999998,
"heapDeltaBytes": -1750380,
"heapUsedBytes": 77553468,
"domNodes": -276,
"jsHeapTotalBytes": -2101248,
"scriptDurationMs": 376.78599999999994,
"eventListeners": -145,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2355.5770000000393,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1456.716,
"heapDeltaBytes": 10739580,
"heapUsedBytes": 90635000,
"domNodes": 14,
"jsHeapTotalBytes": 7008256,
"scriptDurationMs": 459.301,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2308.932000000027,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.378,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1396.22,
"heapDeltaBytes": -15125736,
"heapUsedBytes": 70640720,
"domNodes": 14,
"jsHeapTotalBytes": 8425472,
"scriptDurationMs": 457.06199999999995,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2045.9650000000238,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.351,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.4730000000001,
"heapDeltaBytes": -11962268,
"heapUsedBytes": 73487308,
"domNodes": -272,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 15.646,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2049.5509999999513,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.772,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.688,
"heapDeltaBytes": -10794172,
"heapUsedBytes": 74436864,
"domNodes": -273,
"jsHeapTotalBytes": 3928064,
"scriptDurationMs": 14.429,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.4469999999687,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.397999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.14599999999996,
"heapDeltaBytes": 11548496,
"heapUsedBytes": 74646424,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 117.796,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.5229999999656,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.80099999999993,
"heapDeltaBytes": 11535596,
"heapUsedBytes": 74557244,
"domNodes": 14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 114.76799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2048.765000000003,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.200000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.2009999999999,
"heapDeltaBytes": 3788216,
"heapUsedBytes": 66327556,
"domNodes": -285,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.635000000000002,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2000.5400000000009,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.272000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.00399999999996,
"heapDeltaBytes": -3888992,
"heapUsedBytes": 58967588,
"domNodes": -282,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 5.668000000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.7240000000156,
"styleRecalcs": 77,
"styleRecalcDurationMs": 44.782000000000004,
"layouts": 16,
"layoutDurationMs": 4.679,
"taskDurationMs": 839.272,
"heapDeltaBytes": 19001636,
"heapUsedBytes": 82003724,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 87.354,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1774.9189999999544,
"styleRecalcs": 74,
"styleRecalcDurationMs": 36.089000000000006,
"layouts": 16,
"layoutDurationMs": 4.536999999999999,
"taskDurationMs": 781.131,
"heapDeltaBytes": -5263964,
"heapUsedBytes": 57432664,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 83.113,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.1769999999478,
"styleRecalcs": 18,
"styleRecalcDurationMs": 33.217999999999996,
"layouts": 13,
"layoutDurationMs": 15.110999999999999,
"taskDurationMs": 956.286,
"heapDeltaBytes": -5921284,
"heapUsedBytes": 87450748,
"domNodes": 13673,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 17.636000000000006,
"eventListeners": 2373,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8297.897999999976,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4162.056,
"heapDeltaBytes": -246004,
"heapUsedBytes": 77089560,
"domNodes": -281,
"jsHeapTotalBytes": -827392,
"scriptDurationMs": 1066.3709999999999,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8380.789999999934,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.316,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4373.668,
"heapDeltaBytes": 905884,
"heapUsedBytes": 77490008,
"domNodes": -282,
"jsHeapTotalBytes": 7299072,
"scriptDurationMs": 1226.739,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16730.49900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16009.467,
"heapDeltaBytes": -34452788,
"heapUsedBytes": 178167340,
"domNodes": -8312,
"jsHeapTotalBytes": -16031744,
"scriptDurationMs": 109.64699999999999,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16752.031999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15958.310999999998,
"heapDeltaBytes": -47889084,
"heapUsedBytes": 179163892,
"domNodes": -8312,
"jsHeapTotalBytes": -17870848,
"scriptDurationMs": 104.605,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20285.864000000005,
"styleRecalcs": 170,
"styleRecalcDurationMs": 16.235,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19734.965,
"heapDeltaBytes": -45452004,
"heapUsedBytes": 173496764,
"domNodes": -8312,
"jsHeapTotalBytes": -23732224,
"scriptDurationMs": 388.69399999999996,
"eventListeners": -16389,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20001.052999999956,
"styleRecalcs": 166,
"styleRecalcDurationMs": 15.69000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19553.796000000002,
"heapDeltaBytes": -28069044,
"heapUsedBytes": 192994800,
"domNodes": -8312,
"jsHeapTotalBytes": -25014272,
"scriptDurationMs": 383.77,
"eventListeners": -16387,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 500.3630000001067,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.365,
"layouts": 3,
"layoutDurationMs": 1.339,
"taskDurationMs": 125.10599999999997,
"heapDeltaBytes": 5114204,
"heapUsedBytes": 67959284,
"domNodes": 148,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.433000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 122.89499999997133,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.546000000000003,
"layouts": 3,
"layoutDurationMs": 1.3850000000000002,
"taskDurationMs": 88.972,
"heapDeltaBytes": 2942448,
"heapUsedBytes": 65048232,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.5849999999999995,
"eventListeners": 27,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.52 #17072 +/- ##
=============================================
- Coverage 81.98% 81.98% -0.01%
=============================================
Files 1906 1906
Lines 108906 108935 +29
Branches 29707 29722 +15
=============================================
+ Hits 89291 89313 +22
- Misses 19265 19276 +11
+ Partials 350 346 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #15957 to
core/1.52Automatically created by backport workflow.