Repository navigation
[backport core/1.52] feat(widgets): add RESOLUTION_PREVIEW readout wi… - #17071
Conversation
…dget (#16511) Display-only widget for the ResolutionSelector node showing the width/height computed from the sibling aspect_ratio/megapixels/multiple widgets, updating live as they change. Reads sibling values reactively via widgetValueStore and mirrors the backend rounding math. Follows the CURVE/VIDEO_EDIT rails: input spec in nodeDefSchemaV2, constructor in widgets.ts map, Vue component via widgetRegistry. The widget sets serialize=false on both the widget (widgets_values) and its options (API prompt), so workflow files and prompts are unchanged. Need BE Comfy-Org/ComfyUI#16013 ## Backport notes Conflict in nodeDefSchemaV2.ts: main's trailing type guards (isColorInputSpec / isTextareaInputSpec / isGalleriaInputSpec) are not on core/1.52, so only isResolutionPreviewInputSpec was added. ## Backport-only compatibility fix core/1.52 still types widget values as IBaseWidget<boolean | number | string | object | undefined> and derives TWidgetValue from the IWidget union, so a widget whose value is `null` does not typecheck (addWidget rejects it and TWidgetValue widening breaks useNodeReplacement). The widget value is `undefined` on this branch instead of `null`; the value is never read, so behaviour is unchanged.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1982 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-05T14:42:18.688Z",
"gitSha": "35faea43ea4f17222a5c602e1b5fb64b5b3a4e09",
"branch": "backport-16511-to-core-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2087.347999999963,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.176,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.21799999999996,
"heapDeltaBytes": 19757532,
"heapUsedBytes": 82092616,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.3309999999999995,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2038.8019999999756,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.975000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.17999999999995,
"heapDeltaBytes": -6786740,
"heapUsedBytes": 55595320,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 5.2829999999999995,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.4539999999938,
"styleRecalcs": 72,
"styleRecalcDurationMs": 22.83,
"layouts": 12,
"layoutDurationMs": 2.291,
"taskDurationMs": 712.415,
"heapDeltaBytes": 4122756,
"heapUsedBytes": 67195884,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 73.60300000000001,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1704.7829999999635,
"styleRecalcs": 72,
"styleRecalcDurationMs": 21.724999999999998,
"layouts": 12,
"layoutDurationMs": 2.068,
"taskDurationMs": 610.8410000000001,
"heapDeltaBytes": 9421888,
"heapUsedBytes": 71915180,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 67.965,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.741999999971,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.770999999999999,
"layouts": 6,
"layoutDurationMs": 0.402,
"taskDurationMs": 270.87,
"heapDeltaBytes": 2964208,
"heapUsedBytes": 65861356,
"domNodes": 78,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 6.657,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.9719999999415,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.773,
"layouts": 6,
"layoutDurationMs": 0.49199999999999994,
"taskDurationMs": 270.262,
"heapDeltaBytes": 3406632,
"heapUsedBytes": 65756996,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.118000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 413.03199999998697,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.563,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 250.37899999999996,
"heapDeltaBytes": 10579608,
"heapUsedBytes": 73475268,
"domNodes": 18,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 34.36,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 435.25700000003553,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.473999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 263.27099999999996,
"heapDeltaBytes": 10501400,
"heapUsedBytes": 71797648,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 34.609,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2022.647999999947,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.662999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.63800000000003,
"heapDeltaBytes": -12187016,
"heapUsedBytes": 64360380,
"domNodes": -279,
"jsHeapTotalBytes": -1052672,
"scriptDurationMs": 8.393,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.543999999974,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.812,
"heapDeltaBytes": -1675488,
"heapUsedBytes": 75395880,
"domNodes": -268,
"jsHeapTotalBytes": -1314816,
"scriptDurationMs": 14.364999999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2112.122999999997,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.017000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 842.5149999999999,
"heapDeltaBytes": -4643984,
"heapUsedBytes": 73380736,
"domNodes": -268,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 216.732,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2093.6910000000353,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.052999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 840.9530000000001,
"heapDeltaBytes": -7212448,
"heapUsedBytes": 70923944,
"domNodes": -268,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 215.143,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3109.7539999999526,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.311,
"layouts": 60,
"layoutDurationMs": 4.953,
"taskDurationMs": 977.992,
"heapDeltaBytes": -16061940,
"heapUsedBytes": 63377768,
"domNodes": 16,
"jsHeapTotalBytes": 5500928,
"scriptDurationMs": 245.037,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3110.351000000037,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.023,
"layouts": 60,
"layoutDurationMs": 5.699,
"taskDurationMs": 1018.276,
"heapDeltaBytes": -16228436,
"heapUsedBytes": 63613836,
"domNodes": 16,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 260.569,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2084.5669999999927,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.078000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 962.9590000000002,
"heapDeltaBytes": 10467536,
"heapUsedBytes": 90476248,
"domNodes": 16,
"jsHeapTotalBytes": 7532544,
"scriptDurationMs": 292.73099999999994,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2109.2459999999846,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.512999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1010.5999999999999,
"heapDeltaBytes": 11681940,
"heapUsedBytes": 91845952,
"domNodes": 14,
"jsHeapTotalBytes": 6746112,
"scriptDurationMs": 314.556,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2033.9539999999943,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.748,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.46099999999996,
"heapDeltaBytes": -12861908,
"heapUsedBytes": 65203788,
"domNodes": -284,
"jsHeapTotalBytes": 3665920,
"scriptDurationMs": 8.091000000000001,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.3260000000782,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.621999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.055,
"heapDeltaBytes": -12558776,
"heapUsedBytes": 71119900,
"domNodes": -282,
"jsHeapTotalBytes": 3403776,
"scriptDurationMs": 10.657,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 446.66599999999335,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.407000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 271.922,
"heapDeltaBytes": 11574276,
"heapUsedBytes": 74275016,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 75.59,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 474.6790000000374,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.501999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 275.24,
"heapDeltaBytes": 11551176,
"heapUsedBytes": 74403776,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 74.694,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.5319999999829,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.367999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.905,
"heapDeltaBytes": -4130144,
"heapUsedBytes": 58709736,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 4.879,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.5120000000293,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.7589999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.96099999999996,
"heapDeltaBytes": -4996120,
"heapUsedBytes": 57767592,
"domNodes": -282,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5.126,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.7189999999791,
"styleRecalcs": 76,
"styleRecalcDurationMs": 23.049,
"layouts": 16,
"layoutDurationMs": 2.4749999999999996,
"taskDurationMs": 589.511,
"heapDeltaBytes": 1554208,
"heapUsedBytes": 64943388,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 49.132,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.0610000000293,
"styleRecalcs": 75,
"styleRecalcDurationMs": 21.662,
"layouts": 16,
"layoutDurationMs": 2.4490000000000003,
"taskDurationMs": 569.2570000000001,
"heapDeltaBytes": 16914088,
"heapUsedBytes": 79916424,
"domNodes": -280,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 49.815,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 882.4299999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.205999999999996,
"layouts": 15,
"layoutDurationMs": 9.333999999999998,
"taskDurationMs": 665.611,
"heapDeltaBytes": -7881392,
"heapUsedBytes": 88930880,
"domNodes": 13673,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 11.31,
"eventListeners": 2373,
"totalBlockingTimeMs": 101,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8088.790000000017,
"styleRecalcs": 249,
"styleRecalcDurationMs": 21.767000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2890.45,
"heapDeltaBytes": -7782316,
"heapUsedBytes": 69602252,
"domNodes": -281,
"jsHeapTotalBytes": 4677632,
"scriptDurationMs": 661.814,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8154.557999999952,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.301,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2943.96,
"heapDeltaBytes": -6299728,
"heapUsedBytes": 70093440,
"domNodes": -282,
"jsHeapTotalBytes": 4939776,
"scriptDurationMs": 682.763,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11037.259000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10449.095,
"heapDeltaBytes": -44041584,
"heapUsedBytes": 182799424,
"domNodes": -8312,
"jsHeapTotalBytes": -11198464,
"scriptDurationMs": 51.99799999999999,
"eventListeners": -16395,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10752.116999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10262.056,
"heapDeltaBytes": -49107864,
"heapUsedBytes": 176039720,
"domNodes": -8312,
"jsHeapTotalBytes": -18391040,
"scriptDurationMs": 53.81300000000002,
"eventListeners": -16395,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13037.532999999996,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.956999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12413.703,
"heapDeltaBytes": -38906588,
"heapUsedBytes": 193132404,
"domNodes": -8312,
"jsHeapTotalBytes": -23568384,
"scriptDurationMs": 269.172,
"eventListeners": -16389,
"totalBlockingTimeMs": 48,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14080.346999999962,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.188000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13396.643000000002,
"heapDeltaBytes": -47218868,
"heapUsedBytes": 179486476,
"domNodes": -8312,
"jsHeapTotalBytes": -18341888,
"scriptDurationMs": 334.38599999999997,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 432.0109999999886,
"styleRecalcs": 20,
"styleRecalcDurationMs": 14.156,
"layouts": 4,
"layoutDurationMs": 1.045,
"taskDurationMs": 85.19100000000002,
"heapDeltaBytes": 5305820,
"heapUsedBytes": 67682528,
"domNodes": 150,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.267000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 439.3079999999827,
"styleRecalcs": 15,
"styleRecalcDurationMs": 13.231000000000002,
"layouts": 3,
"layoutDurationMs": 0.4760000000000001,
"taskDurationMs": 82.09,
"heapDeltaBytes": 4998872,
"heapUsedBytes": 67424004,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.111999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.52 #17071 +/- ##
==========================================
Coverage 81.98% 81.98%
==========================================
Files 1906 1908 +2
Lines 108906 108966 +60
Branches 29707 29729 +22
==========================================
+ Hits 89291 89341 +50
- Misses 19265 19276 +11
+ Partials 350 349 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approved — faithful backport of #16511 to core/1.52.
What I verified
- Backport fidelity: diffed this PR's full diff against the merged #16511 diff. Identical apart from hunk offsets and the documented
null->undefinedswap in 6 places. - BE dependency: Comfy-Org/ComfyUI#16013 (
Add live resolution preview widget to ResolutionSelector) merged 2026-09-02, so theRESOLUTION_PREVIEWinput spec this consumes actually exists on the backend. - Schema union ordering:
zResolutionPreviewInputSpecis inserted beforezCustomInputSpecinzInputSpec. That ordering matters —zCustomInputSpechastype: z.string()and would otherwise swallow the spec. Correct here, same as main. - CI: green (unit
test, 16 Playwright chromium shards, storybook build, licenses, fonts, scan).
On the null → undefined compat change
I checked the "the value is never read" claim rather than taking it at face value, and it holds:
WidgetResolutionPreview.vueonly ever toucheswidget.nameandwidget.options?.{ratio,megapixels,multiple}_widget. There is nowidget.valueread anywhere in the feature.useResolutionPreviewWidgetsetsserialize: falseon the options andrawWidget.serialize = falseon the widget, so the value never reacheswidgets_valuesor the API prompt.
So the swap is inert for behaviour, and it buys typecheck compatibility with this branch's IBaseWidget<boolean | number | string | object | undefined>. Good call keeping the backport type-safe instead of loosening the base type on a release branch.
I left one non-blocking note on #17069 about the frontend duplicating the backend's resolution math (// keep the math in sync with the backend). It applies to this PR's code too, but it is a follow-up for main, not a backport concern — no action needed here.
…dget (#16511)
Display-only widget for the ResolutionSelector node showing the width/height computed from the sibling aspect_ratio/megapixels/multiple widgets, updating live as they change. Reads sibling values reactively via widgetValueStore and mirrors the backend rounding math.
Follows the CURVE/VIDEO_EDIT rails: input spec in nodeDefSchemaV2, constructor in widgets.ts map, Vue component via widgetRegistry. The widget sets serialize=false on both the widget (widgets_values) and its options (API prompt), so workflow files and prompts are unchanged.
Need BE Comfy-Org/ComfyUI#16013
Backport notes
Conflict in nodeDefSchemaV2.ts: main's trailing type guards (isColorInputSpec / isTextareaInputSpec / isGalleriaInputSpec) are not on core/1.52, so only isResolutionPreviewInputSpec was added.
Backport-only compatibility fix
core/1.52 still types widget values as IBaseWidget<boolean | number | string | object | undefined> and derives TWidgetValue from the IWidget union, so a widget whose value is
nulldoes not typecheck (addWidget rejects it and TWidgetValue widening breaks useNodeReplacement). The widget value isundefinedon this branch instead ofnull; the value is never read, so behaviour is unchanged.