Skip to content

[backport cloud/1.51] feat(widgets): add RESOLUTION_PREVIEW readout w… - #17070

Merged
jtydhr88 merged 1 commit into
cloud/1.51from
backport-16511-to-cloud-1.51
Sep 5, 2026
Merged

jtydhr88 merged 1 commit into
cloud/1.51from
backport-16511-to-cloud-1.51

Conversation

@jtydhr88

@jtydhr88 jtydhr88 commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

…idget (#16511)

Display-only widget for the ResolutionSelector node showing the width/height computed from the sibling aspect_ratio/megapixels/multiple widgets, updating live as they change. Reads sibling values reactively via widgetValueStore and mirrors the backend rounding math.

Follows the CURVE/VIDEO_EDIT rails: input spec in nodeDefSchemaV2, constructor in widgets.ts map, Vue component via widgetRegistry. The widget sets serialize=false on both the widget (widgets_values) and its options (API prompt), so workflow files and prompts are unchanged.

Need BE Comfy-Org/ComfyUI#16013

Backport notes

Conflict in nodeDefSchemaV2.ts: main's trailing type guards (isColorInputSpec / isTextareaInputSpec / isGalleriaInputSpec) are not on cloud/1.51, so only isResolutionPreviewInputSpec was added.

Backport-only compatibility fix

cloud/1.51 still types widget values as IBaseWidget<boolean | number | string | object | undefined> and derives TWidgetValue from the IWidget union, so a widget whose value is null does not typecheck (addWidget rejects it and TWidgetValue widening breaks useNodeReplacement). The widget value is undefined on this branch instead of null; the value is never read, so behaviour is unchanged.

…idget (#16511)

Display-only widget for the ResolutionSelector node showing the
width/height computed from the sibling aspect_ratio/megapixels/multiple
widgets, updating live as they change. Reads sibling values reactively
via widgetValueStore and mirrors the backend rounding math.

Follows the CURVE/VIDEO_EDIT rails: input spec in nodeDefSchemaV2,
constructor in widgets.ts map, Vue component via widgetRegistry. The
widget sets serialize=false on both the widget (widgets_values) and its
options (API prompt), so workflow files and prompts are unchanged.

Need BE Comfy-Org/ComfyUI#16013

## Backport notes

Conflict in nodeDefSchemaV2.ts: main's trailing type guards
(isColorInputSpec / isTextareaInputSpec / isGalleriaInputSpec) are not on
cloud/1.51, so only isResolutionPreviewInputSpec was added.

## Backport-only compatibility fix

cloud/1.51 still types widget values as IBaseWidget<boolean | number |
string | object | undefined> and derives TWidgetValue from the IWidget
union, so a widget whose value is `null` does not typecheck (addWidget
rejects it and TWidgetValue widening breaks useNodeReplacement). The
widget value is `undefined` on this branch instead of `null`; the value
is never read, so behaviour is unchanged.
@jtydhr88
jtydhr88 requested a review from a team as a code owner September 5, 2026 13:38
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: cf400292-8c02-43d0-82da-ec25eca7e8b7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1831 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1810 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/05/2026, 01:40:20 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 134ms TBT · 76.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 164.4 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 33ms TBT · 160.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 442ms
canvas-idle: script duration 6ms
canvas-idle: TBT 0ms
canvas-idle: heap used 68.7 MB
canvas-idle: DOM nodes 18
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 38ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 805ms
canvas-mouse-sweep: script duration 109ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.7 MB
canvas-mouse-sweep: DOM nodes 58
canvas-mouse-sweep: event listeners 4
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 358ms
canvas-zoom-sweep: script duration 8ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.2 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 368ms
dom-widget-clipping: script duration 56ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 52.2 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 576ms
large-graph-idle: script duration 13ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 62.0 MB
large-graph-idle: DOM nodes -283
large-graph-idle: event listeners -180
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1128ms
large-graph-pan: script duration 314ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 59.3 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -164
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1335ms
large-graph-zoom: script duration 369ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 55.1 MB
large-graph-zoom: DOM nodes -286
large-graph-zoom: event listeners -168
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 579ms
minimap-idle: script duration 12ms
minimap-idle: TBT 0ms
minimap-idle: heap used 62.5 MB
minimap-idle: DOM nodes -283
minimap-idle: event listeners -180
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 390ms
subgraph-dom-widget-clipping: script duration 116ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 53.8 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 457ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.7 MB
subgraph-idle: DOM nodes 18
subgraph-idle: event listeners 5
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 36ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 742ms
subgraph-mouse-sweep: script duration 82ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.1 MB
subgraph-mouse-sweep: DOM nodes 63
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 914ms
subgraph-transition-enter: script duration 15ms
subgraph-transition-enter: TBT 134ms
subgraph-transition-enter: heap used 76.5 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 3963ms
viewport-pan-sweep: script duration 1009ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 67.0 MB
viewport-pan-sweep: DOM nodes -282
viewport-pan-sweep: event listeners -149
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16087ms
vue-large-graph-idle: script duration 102ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 164.4 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16388
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 169
vue-large-graph-pan: task duration 19794ms
vue-large-graph-pan: script duration 389ms
vue-large-graph-pan: TBT 33ms
vue-large-graph-pan: heap used 160.6 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16384
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 4
workflow-execution: style recalc count 15
workflow-execution: task duration 108ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.2 MB
workflow-execution: DOM nodes 126
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-09-05T13:50:37.608Z",
  "gitSha": "b3854b669a213eb904717b8330e1c400c9b2ebb3",
  "branch": "backport-16511-to-cloud-1.51",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2032.7199999999834,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.588000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.02,
      "heapDeltaBytes": 5478084,
      "heapUsedBytes": 71976528,
      "domNodes": 18,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 6.098000000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2051.2410000000045,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.647000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 444.321,
      "heapDeltaBytes": 5687468,
      "heapUsedBytes": 72033780,
      "domNodes": 18,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 5.625,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1888.307999999995,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.976,
      "layouts": 12,
      "layoutDurationMs": 3.4960000000000004,
      "taskDurationMs": 832.7139999999999,
      "heapDeltaBytes": 606668,
      "heapUsedBytes": 67125028,
      "domNodes": 60,
      "jsHeapTotalBytes": 24383488,
      "scriptDurationMs": 107.585,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1773.4879999999293,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 35.638,
      "layouts": 12,
      "layoutDurationMs": 3.2159999999999997,
      "taskDurationMs": 776.629,
      "heapDeltaBytes": 170748,
      "heapUsedBytes": 66428552,
      "domNodes": 56,
      "jsHeapTotalBytes": 24645632,
      "scriptDurationMs": 110.325,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.6769999999956,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.034,
      "layouts": 6,
      "layoutDurationMs": 0.562,
      "taskDurationMs": 354.30400000000003,
      "heapDeltaBytes": 8199788,
      "heapUsedBytes": 74425416,
      "domNodes": 78,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 8.561000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.2230000000518,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 19.500999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.714,
      "taskDurationMs": 361.28900000000004,
      "heapDeltaBytes": 8484712,
      "heapUsedBytes": 74915616,
      "domNodes": 78,
      "jsHeapTotalBytes": 23855104,
      "scriptDurationMs": 8.379,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 596.5449999999919,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.204000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 386.19800000000004,
      "heapDeltaBytes": -11790516,
      "heapUsedBytes": 54485636,
      "domNodes": 18,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 56.366,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 553.6849999999731,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.502999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 350.148,
      "heapDeltaBytes": -11355760,
      "heapUsedBytes": 55019676,
      "domNodes": 14,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 54.836999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2012.9820000000223,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.007000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 570.748,
      "heapDeltaBytes": 534660,
      "heapUsedBytes": 61575848,
      "domNodes": -283,
      "jsHeapTotalBytes": 1667072,
      "scriptDurationMs": 12.545999999999998,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.1070000000482,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.126,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 581.896,
      "heapDeltaBytes": 7298476,
      "heapUsedBytes": 68353640,
      "domNodes": -282,
      "jsHeapTotalBytes": 2453504,
      "scriptDurationMs": 12.568999999999997,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2107.8790000000254,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.744,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1118.92,
      "heapDeltaBytes": 6574380,
      "heapUsedBytes": 69175652,
      "domNodes": -283,
      "jsHeapTotalBytes": 3694592,
      "scriptDurationMs": 305.44300000000004,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2181.4889999999423,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.359000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1136.644,
      "heapDeltaBytes": -6961104,
      "heapUsedBytes": 55112048,
      "domNodes": -282,
      "jsHeapTotalBytes": 3764224,
      "scriptDurationMs": 322.237,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3180.215999999973,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.325000000000001,
      "layouts": 60,
      "layoutDurationMs": 6.824999999999999,
      "taskDurationMs": 1325.4519999999998,
      "heapDeltaBytes": -4719968,
      "heapUsedBytes": 58905884,
      "domNodes": -285,
      "jsHeapTotalBytes": 3502080,
      "scriptDurationMs": 368.19199999999995,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3129.0599999999813,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.177999999999999,
      "layouts": 60,
      "layoutDurationMs": 6.8950000000000005,
      "taskDurationMs": 1344.058,
      "heapDeltaBytes": -6306636,
      "heapUsedBytes": 56682504,
      "domNodes": -287,
      "jsHeapTotalBytes": 3239936,
      "scriptDurationMs": 370.013,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.1449999999659,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.431000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 577.995,
      "heapDeltaBytes": 2476544,
      "heapUsedBytes": 66005544,
      "domNodes": -281,
      "jsHeapTotalBytes": 2191360,
      "scriptDurationMs": 11.846000000000002,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2009.7950000000537,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.702000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 579.8389999999999,
      "heapDeltaBytes": 3559604,
      "heapUsedBytes": 65148332,
      "domNodes": -284,
      "jsHeapTotalBytes": 2191360,
      "scriptDurationMs": 12.536999999999999,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 551.1479999999551,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.875000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.27900000000005,
      "heapDeltaBytes": -10189620,
      "heapUsedBytes": 56406736,
      "domNodes": 20,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 116.096,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 598.3199999999442,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.313999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 392.6789999999999,
      "heapDeltaBytes": -10191620,
      "heapUsedBytes": 56383712,
      "domNodes": 20,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 116.73800000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.8889999999678,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.78099999999995,
      "heapDeltaBytes": 5417948,
      "heapUsedBytes": 71885636,
      "domNodes": 18,
      "jsHeapTotalBytes": 23855104,
      "scriptDurationMs": 5.582000000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2024.7620000000097,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.398,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 433.958,
      "heapDeltaBytes": 5735180,
      "heapUsedBytes": 72279592,
      "domNodes": 18,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 5.552999999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.0739999999869,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 38.635999999999996,
      "layouts": 16,
      "layoutDurationMs": 4.308,
      "taskDurationMs": 767.7779999999999,
      "heapDeltaBytes": -3387444,
      "heapUsedBytes": 62769092,
      "domNodes": 65,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 85.35400000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1682.1670000000495,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 33.54,
      "layouts": 16,
      "layoutDurationMs": 4.257000000000001,
      "taskDurationMs": 715.471,
      "heapDeltaBytes": -3325124,
      "heapUsedBytes": 63247632,
      "domNodes": 60,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 79.194,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.1360000000122,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 29.81600000000001,
      "layouts": 16,
      "layoutDurationMs": 12.629999999999999,
      "taskDurationMs": 914.242,
      "heapDeltaBytes": -7936744,
      "heapUsedBytes": 80180264,
      "domNodes": 13673,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 15.102000000000004,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 134,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8219.628999999997,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 34.682,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4016.424000000001,
      "heapDeltaBytes": 4208476,
      "heapUsedBytes": 65959808,
      "domNodes": -283,
      "jsHeapTotalBytes": 2908160,
      "scriptDurationMs": 1045.229,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8178.327000000081,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 35.284,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3909.6900000000005,
      "heapDeltaBytes": 13667936,
      "heapUsedBytes": 74479196,
      "domNodes": -280,
      "jsHeapTotalBytes": 4743168,
      "scriptDurationMs": 973.77,
      "eventListeners": -165,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16835.71999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16085.595000000001,
      "heapDeltaBytes": -27666064,
      "heapUsedBytes": 172255528,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8065024,
      "scriptDurationMs": 106.36999999999999,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16870.07200000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16089.215000000004,
      "heapDeltaBytes": -54503316,
      "heapUsedBytes": 172597436,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8032256,
      "scriptDurationMs": 96.916,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20304.828999999925,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 16.981999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19793.964000000004,
      "heapDeltaBytes": -33566360,
      "heapUsedBytes": 165755724,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14618624,
      "scriptDurationMs": 392.601,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 9,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20475.535000000036,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 16.257000000000023,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19794.518000000004,
      "heapDeltaBytes": -28260644,
      "heapUsedBytes": 171094532,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14426112,
      "scriptDurationMs": 386.151,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 57,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 455.04300000004605,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 20.685,
      "layouts": 3,
      "layoutDurationMs": 0.6070000000000001,
      "taskDurationMs": 105.99199999999999,
      "heapDeltaBytes": 4998020,
      "heapUsedBytes": 70380188,
      "domNodes": 128,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 8.342000000000002,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 457.4239999999463,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 22.447999999999997,
      "layouts": 4,
      "layoutDurationMs": 1.2660000000000002,
      "taskDurationMs": 110.694,
      "heapDeltaBytes": 4979700,
      "heapUsedBytes": 70540224,
      "domNodes": 123,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 7.266,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

@github-actions
github-actions Bot requested a review from DrJKL September 5, 2026 13:39
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 5, 2026
@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.14286% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../widgets/composables/useResolutionPreviewWidget.ts 22.22% 7 Missing ⚠️
src/schemas/nodeDef/nodeDefSchemaV2.ts 50.00% 2 Missing ⚠️
...nsions/vueNodes/widgets/registry/widgetRegistry.ts 50.00% 1 Missing ⚠️
@@              Coverage Diff               @@
##           cloud/1.51   #17070      +/-   ##
==============================================
+ Coverage       79.15%   81.71%   +2.55%     
==============================================
  Files            2218     1893     -325     
  Lines          113251   108404    -4847     
  Branches        31239    30600     -639     
==============================================
- Hits            89645    88583    -1062     
+ Misses          23147    19472    -3675     
+ Partials          459      349     -110     
Flag Coverage Δ
unit 73.36% <82.14%> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/types/widgets.ts 100.00% <ø> (ø)
...des/widgets/components/WidgetResolutionPreview.vue 100.00% <100.00%> (ø)
src/scripts/widgets.ts 78.94% <ø> (ø)
...nsions/vueNodes/widgets/registry/widgetRegistry.ts 64.00% <50.00%> (-0.39%) ⬇️
src/schemas/nodeDef/nodeDefSchemaV2.ts 89.58% <50.00%> (-3.60%) ⬇️
.../widgets/composables/useResolutionPreviewWidget.ts 22.22% <22.22%> (ø)

... and 327 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — faithful backport of #16511 to cloud/1.51.

What I verified

  • Backport fidelity: diffed this PR's full diff against the merged #16511 diff. Identical apart from hunk offsets and the documented null -> undefined swap in 6 places.
  • BE dependency: Comfy-Org/ComfyUI#16013 (Add live resolution preview widget to ResolutionSelector) merged 2026-09-02, so the RESOLUTION_PREVIEW input spec this consumes actually exists on the backend.
  • Schema union ordering: zResolutionPreviewInputSpec is inserted before zCustomInputSpec in zInputSpec. That ordering matters — zCustomInputSpec has type: z.string() and would otherwise swallow the spec. Correct here, same as main.
  • CI: green (unit test, 16 Playwright chromium shards, storybook build, licenses, fonts, scan).

On the null → undefined compat change

I checked the "the value is never read" claim rather than taking it at face value, and it holds:

  • WidgetResolutionPreview.vue only ever touches widget.name and widget.options?.{ratio,megapixels,multiple}_widget. There is no widget.value read anywhere in the feature.
  • useResolutionPreviewWidget sets serialize: false on the options and rawWidget.serialize = false on the widget, so the value never reaches widgets_values or the API prompt.

So the swap is inert for behaviour, and it buys typecheck compatibility with this branch's IBaseWidget<boolean | number | string | object | undefined>. Good call keeping the backport type-safe instead of loosening the base type on a release branch.

I left one non-blocking note on #17069 about the frontend duplicating the backend's resolution math (// keep the math in sync with the backend). It applies to this PR's code too, but it is a follow-up for main, not a backport concern — no action needed here.

@jtydhr88
jtydhr88 added this pull request to the merge queue Sep 5, 2026
Merged via the queue into cloud/1.51 with commit d1e046a Sep 5, 2026
71 checks passed
@jtydhr88
jtydhr88 deleted the backport-16511-to-cloud-1.51 branch September 5, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants