Repository navigation
fix(ci): main red after #16967 — PR Backport manual dispatch fails on invalid --json merged field - #16992
Conversation
…validation gh pr view --json merged has never been a valid query (mergedAt/state are); every workflow_dispatch of the PR Backport workflow dies in 'Validate inputs for manual triggers' with: Unknown JSON field: "merged". Run 33892240975 (PR #16967) is the latest example. Replace the existence probe with --json state and derive the merged check as .state == "MERGED". Automatic (pull_request_target) path is untouched.
|
Warning Review limit reachedNext included review available in 10 seconds. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Comment |
🎭 Playwright: ✅ 1908 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.69 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T16:39:29.953Z",
"gitSha": "e18f77612efe17e1eb958f805b21877a7a082cff",
"branch": "cifix-16967-backport-json-state",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2071.995999999956,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.485999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.0409999999999,
"heapDeltaBytes": -10298280,
"heapUsedBytes": 60398016,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 13.277999999999999,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2071.399000000042,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.61999999999995,
"heapDeltaBytes": -8095544,
"heapUsedBytes": 62694084,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.706999999999999,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1903.0019999999581,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.622,
"layouts": 14,
"layoutDurationMs": 4.352999999999999,
"taskDurationMs": 910.649,
"heapDeltaBytes": -8326016,
"heapUsedBytes": 62432516,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 164.89999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.1890000000135,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.779,
"layouts": 14,
"layoutDurationMs": 4.3629999999999995,
"taskDurationMs": 887.85,
"heapDeltaBytes": -7134532,
"heapUsedBytes": 63710320,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 159.211,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1699.9490000000037,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.09,
"layouts": 6,
"layoutDurationMs": 1.0980000000000003,
"taskDurationMs": 355.968,
"heapDeltaBytes": 5112744,
"heapUsedBytes": 75947876,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.597999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.4969999999994,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.098999999999997,
"layouts": 6,
"layoutDurationMs": 1.2479999999999998,
"taskDurationMs": 357.498,
"heapDeltaBytes": 5097628,
"heapUsedBytes": 75837048,
"domNodes": 78,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.908999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 655.0670000000309,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.241000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.669,
"heapDeltaBytes": -7828156,
"heapUsedBytes": 63029352,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 163.101,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 665.7039999999483,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.279000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.91299999999995,
"heapDeltaBytes": -7846456,
"heapUsedBytes": 62726616,
"domNodes": 16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 163.218,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.1139999999928,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.240000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.0320000000002,
"heapDeltaBytes": -14155092,
"heapUsedBytes": 87600712,
"domNodes": -268,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 32.586000000000006,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2051.17000000007,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.708,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.2080000000001,
"heapDeltaBytes": -14365956,
"heapUsedBytes": 87194388,
"domNodes": -269,
"jsHeapTotalBytes": -65536,
"scriptDurationMs": 35.591,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2259.9089999999933,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.223,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1664.7079999999999,
"heapDeltaBytes": -17235776,
"heapUsedBytes": 85497284,
"domNodes": -272,
"jsHeapTotalBytes": 159744,
"scriptDurationMs": 804.5600000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2218.0940000000646,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.409999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1616.9479999999999,
"heapDeltaBytes": 18168968,
"heapUsedBytes": 84388448,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 811.04,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3577.6010000000156,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.659,
"layouts": 60,
"layoutDurationMs": 11.636,
"taskDurationMs": 1706.8070000000002,
"heapDeltaBytes": 8852464,
"heapUsedBytes": 76437104,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 777.582,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3528.4769999999526,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.636,
"layouts": 60,
"layoutDurationMs": 12.049999999999999,
"taskDurationMs": 1680.755,
"heapDeltaBytes": 8364680,
"heapUsedBytes": 76072028,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 761.204,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3058.770999999979,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.934000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1924.334,
"heapDeltaBytes": 21980376,
"heapUsedBytes": 89543164,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 950.5919999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3115.132000000017,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.854000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1958.5079999999998,
"heapDeltaBytes": 17042436,
"heapUsedBytes": 84667576,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 971.3059999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.059999999959,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.2629999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.6919999999999,
"heapDeltaBytes": 10849944,
"heapUsedBytes": 87819704,
"domNodes": -273,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 35.208000000000006,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.1129999999857,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.643999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.82,
"heapDeltaBytes": -16371688,
"heapUsedBytes": 87388396,
"domNodes": -271,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 34.45100000000001,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 604.7410000000468,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.714000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.60299999999995,
"heapDeltaBytes": 15228860,
"heapUsedBytes": 88063540,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.02700000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.9940000000097,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.684999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.87700000000007,
"heapDeltaBytes": 14865012,
"heapUsedBytes": 87544072,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.245,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.0969999999697,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.332999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.37700000000007,
"heapDeltaBytes": -8342448,
"heapUsedBytes": 64507820,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.005,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.9200000000187,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.193000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.76200000000006,
"heapDeltaBytes": -13577052,
"heapUsedBytes": 59368060,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.228,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1759.3739999999798,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.922,
"layouts": 18,
"layoutDurationMs": 5.497999999999999,
"taskDurationMs": 853.933,
"heapDeltaBytes": 2383788,
"heapUsedBytes": 75093296,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 110.421,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.0700000000888,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.397,
"layouts": 18,
"layoutDurationMs": 4.893,
"taskDurationMs": 830.409,
"heapDeltaBytes": 5383336,
"heapUsedBytes": 77468356,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 113.262,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1399.121999999977,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.153,
"layouts": 15,
"layoutDurationMs": 16.164,
"taskDurationMs": 905.568,
"heapDeltaBytes": 26465188,
"heapUsedBytes": 99419868,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.813,
"eventListeners": 2385,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8343.102999999985,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.533,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5728.101,
"heapDeltaBytes": -8015464,
"heapUsedBytes": 93334140,
"domNodes": -267,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 2654.6629999999996,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8549.344999999903,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5833.515,
"heapDeltaBytes": -8197784,
"heapUsedBytes": 93424612,
"domNodes": -270,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 2675.2000000000003,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16977.26899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16516.944,
"heapDeltaBytes": -29721376,
"heapUsedBytes": 180180820,
"domNodes": -6548,
"jsHeapTotalBytes": 1187840,
"scriptDurationMs": 273.925,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17330.66599999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16706.226000000002,
"heapDeltaBytes": -41132040,
"heapUsedBytes": 175964568,
"domNodes": -6548,
"jsHeapTotalBytes": 1462272,
"scriptDurationMs": 283.854,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20939.32699999999,
"styleRecalcs": 172,
"styleRecalcDurationMs": 17.88299999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20572.215999999997,
"heapDeltaBytes": -29177084,
"heapUsedBytes": 180465228,
"domNodes": -6556,
"jsHeapTotalBytes": -5668864,
"scriptDurationMs": 965.6580000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 98,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20766.854999999963,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.355999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20382.081,
"heapDeltaBytes": -33558516,
"heapUsedBytes": 176572540,
"domNodes": -6548,
"jsHeapTotalBytes": -5668864,
"scriptDurationMs": 935.7579999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6304.049000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 95.05999999999997,
"layouts": 20,
"layoutDurationMs": 34.92899999999999,
"taskDurationMs": 6185.266000000001,
"heapDeltaBytes": -34659036,
"heapUsedBytes": 175020088,
"domNodes": -6552,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 120.88900000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 597,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6211.292000000071,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.835,
"layouts": 20,
"layoutDurationMs": 23.053000000000004,
"taskDurationMs": 6074.76,
"heapDeltaBytes": -14147252,
"heapUsedBytes": 196491400,
"domNodes": -6548,
"jsHeapTotalBytes": 10297344,
"scriptDurationMs": 113.376,
"eventListeners": -7469,
"totalBlockingTimeMs": 509,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8543.09599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8321.430000000002,
"heapDeltaBytes": 12099504,
"heapUsedBytes": 176124572,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 135.25799999999998,
"eventListeners": -13,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8586.428999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8360.543000000001,
"heapDeltaBytes": 17490872,
"heapUsedBytes": 177157176,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 137.06299999999993,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 492.4109999999473,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.715999999999994,
"layouts": 3,
"layoutDurationMs": 1.65,
"taskDurationMs": 127.271,
"heapDeltaBytes": 5087936,
"heapUsedBytes": 73764620,
"domNodes": 152,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.027999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 94.50399999991532,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.58,
"layouts": 2,
"layoutDurationMs": 1.046,
"taskDurationMs": 68.163,
"heapDeltaBytes": 2989096,
"heapUsedBytes": 70751668,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.797000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16992 +/- ##
==========================================
+ Coverage 81.24% 82.78% +1.54%
==========================================
Files 2464 2046 -418
Lines 126963 119485 -7478
Branches 33863 30204 -3659
==========================================
- Hits 103148 98917 -4231
+ Misses 23300 20388 -2912
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…po-wide The same removed gh field is used in backport-auto-merge.yaml, where it is worse than the loud dispatch failure this PR already fixes: the call is `2>/dev/null || echo false`, so `is_merged` swallows the error and answers false for every PR. That kills both of its uses. The pre-merge check stops recognising a PR a concurrent run or a human already merged, so the loop burns three merge attempts on it; and the final reconciliation, whose whole purpose is "don't post a false failure if the PR is in fact merged", can no longer rescue the race. The workflow then comments "automatic merge failed after 3 attempts, please merge manually" on backport PRs that did merge. Nothing goes red, so the sweep has been degrading silently every 15 minutes. Adds a static guard over every workflow rather than a third one-line edit, because the field is the defect, not the call site. It resolves literal `FIELDS=` assignments too, so pr-label-backport.yaml's `--json "$FIELDS"` is checked rather than skipped, and it fails on any call site whose fields it cannot read so the scan cannot go quietly blind. Verified: red before the workflow fix naming backport-auto-merge.yaml, and red again naming pr-backport.yaml when that file is reverted to its pre-fix main state, so the guard covers the defect this PR opened for. 108/108 scripts/cicd tests pass; oxfmt, check-yaml.sh, check-shell.sh, tsc clean.
|
pr-shepherd stage pass: pushed
Rather than make a third one-line edit, the commit adds Verified failing-first in both directions: red naming Not merged and not approved. |
|
heads up that #17006 is fixing the same defect on the same two lines of worth flagging that the collision is not just textual. #17006 adds this PR looks like the better survivor to me since it also repairs the second call site in question: is there a reason to prefer |
|
Decision: keep #16992; leave #17006 closed as superseded. Keep the Full context for agent readersBoth fields are valid, but the competing test asserts an implementation choice rather than the required behavior. #16992's repo-wide guard already prevents the actual regression ( Live read-back at head |
There was a problem hiding this comment.
Verdict: ready to approve
The workflow changes correctly replace the unsupported field at both affected call sites, and the current head has no failing or pending checks.
Maintainability: the repo-wide regression test adds a handwritten shell parser that rejects valid quoted --json arguments. This is non-blocking because it does not affect current workflow behavior, but the test should be removed or replaced with a check that does not parse shell.
| const base = { file, line: line.trim() } | ||
|
|
||
| // `--json a,b,c` — a literal, comma-separated field list. | ||
| const literal = /--json\s+([A-Za-z0-9_,]+)/.exec(line) |
There was a problem hiding this comment.
This parser rejects valid gh syntax such as --json "state"; I reproduced that change and can resolve every requested field list failed. It cannot reliably parse general shell, so extending these regexes will keep adding CI-only syntax restrictions. Please remove the repo-wide parser/test and keep the focused workflow fix, or replace it with a check that does not attempt to parse shell.
|
Follow-up queued: the review request to drop the repo-wide shell-argument parser is still outstanding on Full context for agent readersThe merged-review audit found no open or merged PR back-referencing #16992. The reviewer's request on The workflow fix itself is not in question. The residual item is the hand-written parser in the accompanying repo-wide test, which the reviewer reproduced rejecting valid Tracked as |
## Summary Remove the repository-wide `gh pr view --json` shell parser added in Comfy-Org#16992 because it rejects valid quoted field syntax. ## Changes - **What**: Deletes `scripts/cicd/gh-pr-view-fields.test.ts`; the focused backport workflow fix remains unchanged. ## Review Focus Confirms the follow-up requested in [the unresolved Comfy-Org#16992 review thread](Comfy-Org#16992 (comment)) without replacing it with another shell parser. Verification: `pnpm exec vitest run scripts/cicd` (105 tests), `pnpm format:check`, `pnpm typecheck`, `pnpm knip`, and `pnpm lint`.
Justification: restores green main after bypass merge of #16967; CI-only change (workflow validation script fix, no product code).
Evidence
Failing run: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/33892240975 (workflow_dispatch of
PR Backporton exact main heade6be49f53e50eb1eded794bcfc7b67702785d166), failing check-runbackportjob 101086446967, stepValidate inputs for manual triggers:Root cause: the validation step queries
gh pr view <n> --json merged, butmergedhas never been a validgh pr viewJSON field — the error surfaces (rather than passing) on every manual dispatch. PR #15965 (merged 2026-08-26) intentionally un-swallowed this error, revealing the field bug underneath; every dispatch since then fails deterministically. PR #16967 is MERGED and carriesneeds-backport, so the dispatch itself was legitimate.Fix (2 lines):
--json merged→--json state;--jq '.merged'→--jq '.state == "MERGED"'. The automaticpull_request_targetpath is untouched (it reads PR data fromGITHUB_EVENT_PATH).Local verification (gh v2.x,
GH_REPO=Comfy-Org/ComfyUI_frontend), simulating the full fixed validation block against PR #16967:--json state: pass.state == "MERGED":true— passneeds-backportlabel probe: pass--json mergedfails withUnknown JSON field: "merged"as expectedactionlinton the changed file: 64-line finding fingerprint identical to the origin/main baseline (zero new findings); YAML parses cleanScope note: the two recent
pull_request_targetbackport failures (runs 33891193824, 33892334363) are cherry-pick conflicts, the documented not-fixed class per #15965, and unrelated to this bug.