Repository navigation
[backport cloud/1.53] fix(billing): gate plan CTAs on the server capability set, not a client-derived one - #16990
Conversation
…nt-derived one (#16967) ## Summary The pricing table decided *which* server capability governs each plan card from client-side state, then read it with a `?? false` default — so a workspace the server was permitting to subscribe rendered every card disabled. This gates on the server capability set directly. Labels are unchanged. ## Root cause `GET /v1/billing/capabilities` answers a **workspace-scoped** question — seven booleans, with `resolved_for` carrying only `{user_id, workspace_id}`. The pricing table needs a **card-scoped** answer: "can this workspace move to Creator-Yearly right now?" Nothing in the response can produce that, so the component synthesized it. `canUsePersonalPlanAction` picked the governing capability from `hasActivePaidPlan(tier)`, `isCurrentPlan()`, `isCancelled` and `isEnded`; `isTeamButtonDisabled` did the same job with a different expression off `isTeamSubscribed`. That selection is policy, and it fails in two ways: **1. The client picks the wrong capability.** A legacy-rail workspace holds a paid tier with no local subscription row. `hasActivePaidPlan` is therefore true, so the table reads `can_change_seats` — false, because `ResolveBillingCapabilities`'s `!HasSubscription` branch clears it — and greys the card. That same branch leaves `can_subscribe_self_serve` **true**, which is what the server actually returns for these workspaces. The field that is true is never consulted. **2. "Not yet known" renders as "denied."** `useBillingCapabilities` models five read states (`idle | pending | denied | unavailable | resolved`), collapses them to `null`, and `canSubscribeSelfServe`/`canChangeSeats` collapse that to `false`. A slow or failed read disables every plan button for anyone, including new signups. `canTopUp` three lines above deliberately falls open for owners, and `canOpenPricingSurface` falls open to membership — so we let people into a modal whose every button is dead by design. The capability set is documented as *"Effective billing UI **guidance**"*, not an authorization boundary; every checkout endpoint resolves policy again on the write. Treating guidance as a hard gate is what turns a server "probably not" into a customer who cannot buy. Both symptoms are invisible in monitoring: a disabled button emits nothing, and the endpoint returns HTTP 200 with the capability false. That is how 560 workspaces accumulated from 2026-02-10 without paging anyone. ``` BEFORE AFTER ┌───────────────────────────────────────┐ ┌───────────────────────────────────────┐ │ card ──> hasActivePaidPlan? ──┬─ yes ─→│ │ card ──> offersTransition? (shape) │ │ │ │ │ │ │ │ │ can_change_seats └──> lifecycleActionPermitted │ └─ no ──→│ │ = subscribe │ │ can_subscribe_self_serve ‖ change_seats │ │ │ │ ‖ reactivate │ │ null/pending/failed ──> ?? false │ │ unresolved ──> true (server decides) │ └───────────────────────────────────────┘ └───────────────────────────────────────┘ ``` ## Why this is better, not just different Three properties hold after this change that did not hold before. **The client can no longer invent a denial the server never made.** Two separate client decisions could each produce a dead button on their own: choosing which capability applies, and defaulting an absent answer to `false`. Both are gone. A CTA now goes dead on permission grounds only when a resolved server response permits no lifecycle write. **The failure mode moves from silent lockout to loud rejection.** A wrongly disabled button emits nothing — no error, no telemetry, no page — which is exactly how this went unnoticed for seven months. A wrongly enabled button produces a failed checkout call that is visible in Datadog and answered by the server. Since the capability set is explicitly guidance and the write re-checks policy, trading the first failure mode for the second is the right direction for a billing surface. **Divergence has one place to go wrong instead of two.** Personal and team carried two hand-written gate expressions over the same capabilities, already disagreeing on how each classified "current plan". They now derive from one base — the personal catalog is that base plus the single write only it can receive — so a capability change cannot fix one surface and silently miss the other. ## Changes - **What**: Per-card capability selection is replaced by one gate per catalog, neither of which reads client subscription state. `lifecycleActionPermitted` (team catalog) asks whether the server permits any write that can reach it: `can_subscribe_self_serve || can_change_seats || can_reactivate`. `personalPlanActionPermitted` (personal catalog) adds `can_downgrade_to_personal`, the one further write that reaches a personal card. Which capabilities belong to a catalog is a static property of the surface, not a judgement about the customer. An unresolved snapshot (`!snapshotAuthoritative`) keeps the CTA live and lets the checkout endpoint enforce — the same trade `canOpenPricingSurface` and `canTopUp` already make. Non-Cloud still routes to workspace permissions. - **What**: `canDowngradeToPersonal` gains the same unresolved-snapshot fallback. It also gates the plan-scope toggle, so under `?? false` a team-plan workspace lost every personal card *and the personal tab with it* before the server had answered — a whole catalog removed silently, not a greyed button. - **What**: `offersTransition` keeps the one genuinely client-side check — an active current plan has no transition to offer. See Review Focus for why no server field replaces it today. - **What**: Fixes the team CTA treating an ended subscription's still-reported credit stop as the current plan. `isTeamCurrentPlanSelected` was previously shadowed by the `!isTeamSubscribed` early return; composing the two flat conditions exposed it. - **Breaking**: none. Cohort outcomes, in the terms of INC-128: | | server returns | before | after | |---|---|---|---| | legacy rail (9,868) | `subscribe: true`, `change_seats: false` | disabled | **enabled** | | stranded checkout row (560) | all lifecycle capabilities false | disabled | disabled | | unresolved / failed read | no answer | disabled | **enabled**, server enforces | | team plan, unresolved read | no answer | personal tab **removed** | tab kept, CTAs live | | team plan, downgrade permitted only | `downgrade: true`, rest false | personal cards disabled | **enabled** (team CTA stays disabled) | It does not flip a single resolved denial into an allow. ## Review Focus **This must not merge before #8399 is deployed.** Cause 1 of INC-128 is "a declined checkout leaves a `scheduled` row that wedges the customer." Failing open means more attempted checkouts, and any that decline before #8399 lands create new stranded rows on the path already producing 6–15/day. **Open question, for whoever owns the checkout path (Wei Hai).** If a workspace with `can_subscribe_self_serve: false` calls the checkout-create endpoint directly, does the server reject it, or is the capability the only gate? `useWorkspaceUI.ts:209` asserts *"every checkout endpoint enforces its own policy"* and `canOpenPricingSurface` already relies on it, but I have not verified it in `cloud` and would rather not ship on the comment alone. **One gate is deliberately loosened.** Resubscribe was gated on `canReactivatePlan` (the derived value with the legacy-rail membership fallback from #16091); it is now gated on the union. A cancelled subscriber with `can_reactivate: false` but `can_subscribe_self_serve: true` can now click it. That is intentional under "the write is the authorization boundary", and it is the change that depends most on the answer above. `disables Resubscribe when the server permits no lifecycle write` covers the closed direction. **Why `offersTransition` stays client-side.** `GET /api/billing/plans` already returns `availability: {available, reason}` per plan, and `reason: same_plan` looks like a drop-in replacement. It is not. `currentPlanSlug` there comes from `GetBillingStatus().PlanSlug`, which is populated for `ended` and `canceled` subscriptions too, so the server marks both **unavailable**. Adopting it would stop an ended plan being buyable again and would disable Resubscribe — two new instances of the exact failure this PR removes. The client already corrects for both (`isCurrentPlan` returns false when `isEnded`; `offersTransition` allows a cancelled current plan). Making `same_plan` subscription-status-aware is the server-side prerequisite, and it belongs next to `Comfy-Org/cloud#6275`, which is already about making `available` agree with the write path. An earlier revision of this description claimed a stranded `scheduled` row could reach `isCurrentPlan` via `/api/billing/status`. That was wrong and is removed: `GetBillingStatus` reads only `ws.ActiveSubscriptionID` and then explicitly skips `scheduled` (`common/repository/billing/workspace.go`), so the 560 cohort's leftover row cannot surface as a plan slug. The asymmetry with `GetCapabilitySubscription`, which deliberately *does* fall back to a scheduled row, is what makes Cause 1 a capability-side problem only. **Explicitly out of scope.** Labels and the subscribe/resubscribe emit still derive from `isCurrentPlan` / `hasActivePaidPlan`. A wrong label is cosmetic and the server revalidates the action; a wrong gate locks someone out. Deciding labels from capabilities is tracked as [FE-2038](https://linear.app/comfyorg/issue/FE-2038/decide-pricing-button-labels-through-capabilities-api), pending Alex's read on whether the current fields cover every UX string. `availability`'s other reasons (`exceeds_max_seats`, and `annual_to_monthly_unsupported` from `cloud#6275`) are additive rather than corrective — they close false positives, not the false negatives this PR is about — so they are deferred too. `Comfy-Org/cloud#8417` adds `denied_reasons`, which is what would let a disabled CTA say *why*. That is the missing half: this stops the wrong buttons being disabled, but a legitimately disabled one still carries no explanation. ## Tests `pnpm vitest run src/platform/workspace src/platform/cloud/subscription src/composables/billing` — 99 files, 1854 tests, 1852 passing. The two failures are in `useFreeTierQuota.test.ts`, which fails identically on `origin/main` and shares no imports with the changed files. `pnpm typecheck`, `pnpm lint` (0 errors), `pnpm knip` clean. Seven regression tests added in `UnifiedPricingTable.test.ts` — one per row of the cohort table, plus the invariants worth pinning: - `keeps a paid plan actionable when only change-seats is withheld` — the legacy-rail case - `keeps the CTA live while the capability snapshot is unresolved` - `keeps personal plans reachable on a team plan while the snapshot is unresolved` - `blocks the CTA when a resolved snapshot permits no lifecycle write` — proves this is not a blanket fail-open - `withholds personal plans when a resolved snapshot denies the downgrade` — the resolved-denial counterpart - `does not let the downgrade capability alone enable the team CTA` - `keeps personal cards actionable when only the downgrade is permitted` — the same capability on the surface it does govern - `keeps the team CTA live while the capability snapshot is unresolved` — the same row, on the other surface The last two guard a cross-repo invariant rather than a reachable bug: `ResolveBillingCapabilities` sets `CanDowngradeToPersonal = IsOriginalOwner && CanSubscribeSelfServe`, and every branch that clears subscribe clears downgrade first, so a true downgrade currently implies a true subscribe. Both directions of the catalog split are pinned so neither silently depends on that holding. `browser_tests/tests/dialogs/pricingTableCapabilityGating.spec.ts` (`@cloud`) drives the real dialog against capability responses shaped like the cohorts, which the unit tests cannot do — they render the table directly, so they prove the expression but not that a customer reaches a live button. **Verified red on the pre-change component**: the legacy-rail, unresolved-read and failed-read cases all fail there. The closed direction is deliberately unit-only, and the spec says why. Every entry point to the catalog — the `?pricing=` deep link, the settings panel link, the user popover — is itself gated on `canOpenPricingSurface`, which resolves to `can_subscribe_self_serve`. A resolved refusal therefore *withholds the dialog* rather than opening it with dead cards; the e2e asserts that as the negative control. It also means the dialog-with-every-button-dead state this incident reported is only reachable through an unresolved read, which is the route this PR fixes. An earlier revision of this section claimed e2e was impossible because `browser_tests` could not construct the account shapes. That was wrong: `setupCloudApp` takes the capability response directly, including a never-resolving promise for the pending case. ## Screenshots AS IS / TO BE captures from the real app to follow in a comment — capture takes a while and I did not want to hold the PR.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1890 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-04T16:08:33.037Z",
"gitSha": "cb509a7e243e0fbc337db62d3d3533851708c7ec",
"branch": "backport-16967-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.5750000000035,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.108,
"heapDeltaBytes": -9698032,
"heapUsedBytes": 59862296,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 6.609,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2008.2910000000993,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.566999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.98799999999994,
"heapDeltaBytes": -12093084,
"heapUsedBytes": 58180292,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.180999999999999,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1708.7809999999877,
"styleRecalcs": 74,
"styleRecalcDurationMs": 21.038,
"layouts": 14,
"layoutDurationMs": 2.5100000000000002,
"taskDurationMs": 605.496,
"heapDeltaBytes": 4669224,
"heapUsedBytes": 75297720,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 93.084,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.3479999999008,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.299000000000003,
"layouts": 14,
"layoutDurationMs": 3.198,
"taskDurationMs": 626.3910000000001,
"heapDeltaBytes": -12201764,
"heapUsedBytes": 57438268,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 100.098,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1660.271000000023,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.515,
"layouts": 6,
"layoutDurationMs": 0.822,
"taskDurationMs": 273.51800000000003,
"heapDeltaBytes": 4735052,
"heapUsedBytes": 75119772,
"domNodes": 78,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7.438000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1659.1550000000552,
"styleRecalcs": 29,
"styleRecalcDurationMs": 11.788,
"layouts": 6,
"layoutDurationMs": 0.9199999999999999,
"taskDurationMs": 279.231,
"heapDeltaBytes": 4442104,
"heapUsedBytes": 74954268,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.706000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 560.3660000000446,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.492,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.7,
"heapDeltaBytes": -7755840,
"heapUsedBytes": 62829160,
"domNodes": 22,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 113.949,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 517.0739999999796,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.438999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.9069999999999,
"heapDeltaBytes": -8027568,
"heapUsedBytes": 62351808,
"domNodes": 22,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 104.904,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2012.047999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.354000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.70000000000005,
"heapDeltaBytes": -13186808,
"heapUsedBytes": 86990048,
"domNodes": -264,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 18.437,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.8439999999828,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.665000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.383,
"heapDeltaBytes": -13817320,
"heapUsedBytes": 86840396,
"domNodes": -264,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 21.726000000000003,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2104.3339999999944,
"styleRecalcs": 66,
"styleRecalcDurationMs": 6.539,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1125.8919999999998,
"heapDeltaBytes": 22265852,
"heapUsedBytes": 88049852,
"domNodes": 8,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 531.302,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2085.7939999999644,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.535,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1128.936,
"heapDeltaBytes": 19071696,
"heapUsedBytes": 84478064,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 538.395,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3060.771999999986,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.298000000000003,
"layouts": 60,
"layoutDurationMs": 7.266,
"taskDurationMs": 1159.1270000000002,
"heapDeltaBytes": 8524808,
"heapUsedBytes": 75897684,
"domNodes": 6,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 491.42600000000004,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3043.6149999999316,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.425999999999998,
"layouts": 60,
"layoutDurationMs": 7.727,
"taskDurationMs": 1156.618,
"heapDeltaBytes": 8541564,
"heapUsedBytes": 75358516,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 490.71000000000004,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2185.489000000018,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.4159999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1267.479,
"heapDeltaBytes": 17735988,
"heapUsedBytes": 85157560,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 594.546,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2153.752000000054,
"styleRecalcs": 42,
"styleRecalcDurationMs": 3.573999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1276.421,
"heapDeltaBytes": 12820240,
"heapUsedBytes": 79905776,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 601.49,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.5449999999842,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.201,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.392,
"heapDeltaBytes": -15505200,
"heapUsedBytes": 86925940,
"domNodes": -266,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 19.156,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1999.6020000000954,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.3150000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.995,
"heapDeltaBytes": 21740972,
"heapUsedBytes": 87272888,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 20.244999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 509.3369999999595,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.341999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 299.18,
"heapDeltaBytes": 14869420,
"heapUsedBytes": 87601076,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 98.747,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 507.5459999999339,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.938999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.874,
"heapDeltaBytes": 14832172,
"heapUsedBytes": 87464628,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 92.572,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.0940000000323,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.6789999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.297,
"heapDeltaBytes": -6978356,
"heapUsedBytes": 65540944,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 5.887000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.8080000000255,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.426999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.33799999999997,
"heapDeltaBytes": -6481248,
"heapUsedBytes": 66241556,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.103000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.1600000000108,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.34,
"layouts": 18,
"layoutDurationMs": 4.044,
"taskDurationMs": 602.277,
"heapDeltaBytes": -11246036,
"heapUsedBytes": 61262016,
"domNodes": -296,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 69.971,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.572000000022,
"styleRecalcs": 79,
"styleRecalcDurationMs": 23.223,
"layouts": 18,
"layoutDurationMs": 2.885,
"taskDurationMs": 597.29,
"heapDeltaBytes": 2081016,
"heapUsedBytes": 74508000,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 66.11699999999999,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 882.423000000017,
"styleRecalcs": 21,
"styleRecalcDurationMs": 22.727999999999998,
"layouts": 17,
"layoutDurationMs": 10.414000000000001,
"taskDurationMs": 665.3119999999999,
"heapDeltaBytes": -7160996,
"heapUsedBytes": 83226888,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 17.898999999999997,
"eventListeners": 2381,
"totalBlockingTimeMs": 101,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8185.789999999997,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.786,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3976.5099999999993,
"heapDeltaBytes": -7431992,
"heapUsedBytes": 92829368,
"domNodes": -265,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 1750.97,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8175.164999999993,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.96,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4162.964,
"heapDeltaBytes": -9118672,
"heapUsedBytes": 91479856,
"domNodes": -263,
"jsHeapTotalBytes": -344064,
"scriptDurationMs": 1849.1789999999999,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10605.647999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9994.652,
"heapDeltaBytes": -22649968,
"heapUsedBytes": 181116268,
"domNodes": -6548,
"jsHeapTotalBytes": 880640,
"scriptDurationMs": 112.70899999999999,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 10678.640000000087,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10236.54,
"heapDeltaBytes": -33774844,
"heapUsedBytes": 181866204,
"domNodes": -6548,
"jsHeapTotalBytes": 11546624,
"scriptDurationMs": 117.565,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 12883.893999999998,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.456000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12418.33,
"heapDeltaBytes": -10563096,
"heapUsedBytes": 189838808,
"domNodes": -6548,
"jsHeapTotalBytes": 1986560,
"scriptDurationMs": 514.49,
"eventListeners": -7476,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12980.617000000053,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.340999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12383.711,
"heapDeltaBytes": -17021956,
"heapUsedBytes": 170416800,
"domNodes": -6548,
"jsHeapTotalBytes": 12595200,
"scriptDurationMs": 587.9,
"eventListeners": -7471,
"totalBlockingTimeMs": 43,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3796.843000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.86399999999997,
"layouts": 20,
"layoutDurationMs": 15.299999999999994,
"taskDurationMs": 3675.7120000000004,
"heapDeltaBytes": -34479780,
"heapUsedBytes": 166466492,
"domNodes": -6548,
"jsHeapTotalBytes": 18100224,
"scriptDurationMs": 49.554,
"eventListeners": -7473,
"totalBlockingTimeMs": 71,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3931.6499999999905,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.408000000000015,
"layouts": 20,
"layoutDurationMs": 15.768000000000004,
"taskDurationMs": 3766.1649999999995,
"heapDeltaBytes": -31138000,
"heapUsedBytes": 182254604,
"domNodes": -6548,
"jsHeapTotalBytes": 10559488,
"scriptDurationMs": 51.644999999999996,
"eventListeners": -7475,
"totalBlockingTimeMs": 80,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 438.76299999999446,
"styleRecalcs": 14,
"styleRecalcDurationMs": 13.901,
"layouts": 2,
"layoutDurationMs": 0.47400000000000003,
"taskDurationMs": 81.49500000000002,
"heapDeltaBytes": 5072988,
"heapUsedBytes": 72744836,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.996999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 100.92099999997117,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.727999999999998,
"layouts": 3,
"layoutDurationMs": 1.222,
"taskDurationMs": 69.383,
"heapDeltaBytes": 3002104,
"heapUsedBytes": 71692332,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.017000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.53 #16990 +/- ##
=============================================
Coverage ? 83.35%
=============================================
Files ? 2023
Lines ? 117184
Branches ? 32506
=============================================
Hits ? 97673
Misses ? 19153
Partials ? 358
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #16967 to
cloud/1.53Automatically created by backport workflow.