Repository navigation
[backport core/1.53] fix(billing): gate plan CTAs on the server capability set, not a client-derived one - #16989
Conversation
…nt-derived one (#16967) ## Summary The pricing table decided *which* server capability governs each plan card from client-side state, then read it with a `?? false` default — so a workspace the server was permitting to subscribe rendered every card disabled. This gates on the server capability set directly. Labels are unchanged. ## Root cause `GET /v1/billing/capabilities` answers a **workspace-scoped** question — seven booleans, with `resolved_for` carrying only `{user_id, workspace_id}`. The pricing table needs a **card-scoped** answer: "can this workspace move to Creator-Yearly right now?" Nothing in the response can produce that, so the component synthesized it. `canUsePersonalPlanAction` picked the governing capability from `hasActivePaidPlan(tier)`, `isCurrentPlan()`, `isCancelled` and `isEnded`; `isTeamButtonDisabled` did the same job with a different expression off `isTeamSubscribed`. That selection is policy, and it fails in two ways: **1. The client picks the wrong capability.** A legacy-rail workspace holds a paid tier with no local subscription row. `hasActivePaidPlan` is therefore true, so the table reads `can_change_seats` — false, because `ResolveBillingCapabilities`'s `!HasSubscription` branch clears it — and greys the card. That same branch leaves `can_subscribe_self_serve` **true**, which is what the server actually returns for these workspaces. The field that is true is never consulted. **2. "Not yet known" renders as "denied."** `useBillingCapabilities` models five read states (`idle | pending | denied | unavailable | resolved`), collapses them to `null`, and `canSubscribeSelfServe`/`canChangeSeats` collapse that to `false`. A slow or failed read disables every plan button for anyone, including new signups. `canTopUp` three lines above deliberately falls open for owners, and `canOpenPricingSurface` falls open to membership — so we let people into a modal whose every button is dead by design. The capability set is documented as *"Effective billing UI **guidance**"*, not an authorization boundary; every checkout endpoint resolves policy again on the write. Treating guidance as a hard gate is what turns a server "probably not" into a customer who cannot buy. Both symptoms are invisible in monitoring: a disabled button emits nothing, and the endpoint returns HTTP 200 with the capability false. That is how 560 workspaces accumulated from 2026-02-10 without paging anyone. ``` BEFORE AFTER ┌───────────────────────────────────────┐ ┌───────────────────────────────────────┐ │ card ──> hasActivePaidPlan? ──┬─ yes ─→│ │ card ──> offersTransition? (shape) │ │ │ │ │ │ │ │ │ can_change_seats └──> lifecycleActionPermitted │ └─ no ──→│ │ = subscribe │ │ can_subscribe_self_serve ‖ change_seats │ │ │ │ ‖ reactivate │ │ null/pending/failed ──> ?? false │ │ unresolved ──> true (server decides) │ └───────────────────────────────────────┘ └───────────────────────────────────────┘ ``` ## Why this is better, not just different Three properties hold after this change that did not hold before. **The client can no longer invent a denial the server never made.** Two separate client decisions could each produce a dead button on their own: choosing which capability applies, and defaulting an absent answer to `false`. Both are gone. A CTA now goes dead on permission grounds only when a resolved server response permits no lifecycle write. **The failure mode moves from silent lockout to loud rejection.** A wrongly disabled button emits nothing — no error, no telemetry, no page — which is exactly how this went unnoticed for seven months. A wrongly enabled button produces a failed checkout call that is visible in Datadog and answered by the server. Since the capability set is explicitly guidance and the write re-checks policy, trading the first failure mode for the second is the right direction for a billing surface. **Divergence has one place to go wrong instead of two.** Personal and team carried two hand-written gate expressions over the same capabilities, already disagreeing on how each classified "current plan". They now derive from one base — the personal catalog is that base plus the single write only it can receive — so a capability change cannot fix one surface and silently miss the other. ## Changes - **What**: Per-card capability selection is replaced by one gate per catalog, neither of which reads client subscription state. `lifecycleActionPermitted` (team catalog) asks whether the server permits any write that can reach it: `can_subscribe_self_serve || can_change_seats || can_reactivate`. `personalPlanActionPermitted` (personal catalog) adds `can_downgrade_to_personal`, the one further write that reaches a personal card. Which capabilities belong to a catalog is a static property of the surface, not a judgement about the customer. An unresolved snapshot (`!snapshotAuthoritative`) keeps the CTA live and lets the checkout endpoint enforce — the same trade `canOpenPricingSurface` and `canTopUp` already make. Non-Cloud still routes to workspace permissions. - **What**: `canDowngradeToPersonal` gains the same unresolved-snapshot fallback. It also gates the plan-scope toggle, so under `?? false` a team-plan workspace lost every personal card *and the personal tab with it* before the server had answered — a whole catalog removed silently, not a greyed button. - **What**: `offersTransition` keeps the one genuinely client-side check — an active current plan has no transition to offer. See Review Focus for why no server field replaces it today. - **What**: Fixes the team CTA treating an ended subscription's still-reported credit stop as the current plan. `isTeamCurrentPlanSelected` was previously shadowed by the `!isTeamSubscribed` early return; composing the two flat conditions exposed it. - **Breaking**: none. Cohort outcomes, in the terms of INC-128: | | server returns | before | after | |---|---|---|---| | legacy rail (9,868) | `subscribe: true`, `change_seats: false` | disabled | **enabled** | | stranded checkout row (560) | all lifecycle capabilities false | disabled | disabled | | unresolved / failed read | no answer | disabled | **enabled**, server enforces | | team plan, unresolved read | no answer | personal tab **removed** | tab kept, CTAs live | | team plan, downgrade permitted only | `downgrade: true`, rest false | personal cards disabled | **enabled** (team CTA stays disabled) | It does not flip a single resolved denial into an allow. ## Review Focus **This must not merge before #8399 is deployed.** Cause 1 of INC-128 is "a declined checkout leaves a `scheduled` row that wedges the customer." Failing open means more attempted checkouts, and any that decline before #8399 lands create new stranded rows on the path already producing 6–15/day. **Open question, for whoever owns the checkout path (Wei Hai).** If a workspace with `can_subscribe_self_serve: false` calls the checkout-create endpoint directly, does the server reject it, or is the capability the only gate? `useWorkspaceUI.ts:209` asserts *"every checkout endpoint enforces its own policy"* and `canOpenPricingSurface` already relies on it, but I have not verified it in `cloud` and would rather not ship on the comment alone. **One gate is deliberately loosened.** Resubscribe was gated on `canReactivatePlan` (the derived value with the legacy-rail membership fallback from #16091); it is now gated on the union. A cancelled subscriber with `can_reactivate: false` but `can_subscribe_self_serve: true` can now click it. That is intentional under "the write is the authorization boundary", and it is the change that depends most on the answer above. `disables Resubscribe when the server permits no lifecycle write` covers the closed direction. **Why `offersTransition` stays client-side.** `GET /api/billing/plans` already returns `availability: {available, reason}` per plan, and `reason: same_plan` looks like a drop-in replacement. It is not. `currentPlanSlug` there comes from `GetBillingStatus().PlanSlug`, which is populated for `ended` and `canceled` subscriptions too, so the server marks both **unavailable**. Adopting it would stop an ended plan being buyable again and would disable Resubscribe — two new instances of the exact failure this PR removes. The client already corrects for both (`isCurrentPlan` returns false when `isEnded`; `offersTransition` allows a cancelled current plan). Making `same_plan` subscription-status-aware is the server-side prerequisite, and it belongs next to `Comfy-Org/cloud#6275`, which is already about making `available` agree with the write path. An earlier revision of this description claimed a stranded `scheduled` row could reach `isCurrentPlan` via `/api/billing/status`. That was wrong and is removed: `GetBillingStatus` reads only `ws.ActiveSubscriptionID` and then explicitly skips `scheduled` (`common/repository/billing/workspace.go`), so the 560 cohort's leftover row cannot surface as a plan slug. The asymmetry with `GetCapabilitySubscription`, which deliberately *does* fall back to a scheduled row, is what makes Cause 1 a capability-side problem only. **Explicitly out of scope.** Labels and the subscribe/resubscribe emit still derive from `isCurrentPlan` / `hasActivePaidPlan`. A wrong label is cosmetic and the server revalidates the action; a wrong gate locks someone out. Deciding labels from capabilities is tracked as [FE-2038](https://linear.app/comfyorg/issue/FE-2038/decide-pricing-button-labels-through-capabilities-api), pending Alex's read on whether the current fields cover every UX string. `availability`'s other reasons (`exceeds_max_seats`, and `annual_to_monthly_unsupported` from `cloud#6275`) are additive rather than corrective — they close false positives, not the false negatives this PR is about — so they are deferred too. `Comfy-Org/cloud#8417` adds `denied_reasons`, which is what would let a disabled CTA say *why*. That is the missing half: this stops the wrong buttons being disabled, but a legitimately disabled one still carries no explanation. ## Tests `pnpm vitest run src/platform/workspace src/platform/cloud/subscription src/composables/billing` — 99 files, 1854 tests, 1852 passing. The two failures are in `useFreeTierQuota.test.ts`, which fails identically on `origin/main` and shares no imports with the changed files. `pnpm typecheck`, `pnpm lint` (0 errors), `pnpm knip` clean. Seven regression tests added in `UnifiedPricingTable.test.ts` — one per row of the cohort table, plus the invariants worth pinning: - `keeps a paid plan actionable when only change-seats is withheld` — the legacy-rail case - `keeps the CTA live while the capability snapshot is unresolved` - `keeps personal plans reachable on a team plan while the snapshot is unresolved` - `blocks the CTA when a resolved snapshot permits no lifecycle write` — proves this is not a blanket fail-open - `withholds personal plans when a resolved snapshot denies the downgrade` — the resolved-denial counterpart - `does not let the downgrade capability alone enable the team CTA` - `keeps personal cards actionable when only the downgrade is permitted` — the same capability on the surface it does govern - `keeps the team CTA live while the capability snapshot is unresolved` — the same row, on the other surface The last two guard a cross-repo invariant rather than a reachable bug: `ResolveBillingCapabilities` sets `CanDowngradeToPersonal = IsOriginalOwner && CanSubscribeSelfServe`, and every branch that clears subscribe clears downgrade first, so a true downgrade currently implies a true subscribe. Both directions of the catalog split are pinned so neither silently depends on that holding. `browser_tests/tests/dialogs/pricingTableCapabilityGating.spec.ts` (`@cloud`) drives the real dialog against capability responses shaped like the cohorts, which the unit tests cannot do — they render the table directly, so they prove the expression but not that a customer reaches a live button. **Verified red on the pre-change component**: the legacy-rail, unresolved-read and failed-read cases all fail there. The closed direction is deliberately unit-only, and the spec says why. Every entry point to the catalog — the `?pricing=` deep link, the settings panel link, the user popover — is itself gated on `canOpenPricingSurface`, which resolves to `can_subscribe_self_serve`. A resolved refusal therefore *withholds the dialog* rather than opening it with dead cards; the e2e asserts that as the negative control. It also means the dialog-with-every-button-dead state this incident reported is only reachable through an unresolved read, which is the route this PR fixes. An earlier revision of this section claimed e2e was impossible because `browser_tests` could not construct the account shapes. That was wrong: `setupCloudApp` takes the capability response directly, including a never-resolving promise for the pending case. ## Screenshots AS IS / TO BE captures from the real app to follow in a comment — capture takes a while and I did not want to hold the PR.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1889 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T16:10:49.813Z",
"gitSha": "fbf2ab57da1e2056c331de51476c00a3cb6e8ecb",
"branch": "backport-16967-to-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2087.6570000000356,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.698,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.81300000000005,
"heapDeltaBytes": -11310204,
"heapUsedBytes": 58956772,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.268000000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2047.0169999999825,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.484999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.93600000000004,
"heapDeltaBytes": -2720672,
"heapUsedBytes": 67607560,
"domNodes": -285,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.803000000000003,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2021.975999999995,
"styleRecalcs": 79,
"styleRecalcDurationMs": 44.256,
"layouts": 14,
"layoutDurationMs": 5.433999999999999,
"taskDurationMs": 1035.051,
"heapDeltaBytes": -8526852,
"heapUsedBytes": 61610864,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 165.578,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1877.5570000000243,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.484,
"layouts": 14,
"layoutDurationMs": 4.5649999999999995,
"taskDurationMs": 873.424,
"heapDeltaBytes": 4447980,
"heapUsedBytes": 74894928,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 148.04600000000002,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.5620000000254,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.166999999999998,
"layouts": 6,
"layoutDurationMs": 1.2550000000000001,
"taskDurationMs": 345.32199999999995,
"heapDeltaBytes": 4678176,
"heapUsedBytes": 75244920,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.873000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.6989999999341,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.608000000000002,
"layouts": 6,
"layoutDurationMs": 1.11,
"taskDurationMs": 349.187,
"heapDeltaBytes": 4452584,
"heapUsedBytes": 74768256,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.544999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 678.668000000016,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.887999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.93800000000005,
"heapDeltaBytes": -7768744,
"heapUsedBytes": 62870424,
"domNodes": 18,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 159.498,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 677.2649999999203,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.755999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.71700000000004,
"heapDeltaBytes": -7499828,
"heapUsedBytes": 62772316,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 152.317,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2040.303999999992,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.700000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.683,
"heapDeltaBytes": -13656716,
"heapUsedBytes": 87123452,
"domNodes": -270,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 32.419999999999995,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2046.5070000000196,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.622000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.56,
"heapDeltaBytes": -12984676,
"heapUsedBytes": 87101484,
"domNodes": -269,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 34.33500000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2132.925,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.274000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1512.734,
"heapDeltaBytes": 18152196,
"heapUsedBytes": 83424232,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 739.071,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2213.934999999992,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1578.0290000000002,
"heapDeltaBytes": -16892200,
"heapUsedBytes": 84652084,
"domNodes": -272,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 747.054,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3506.8539999999757,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.285,
"layouts": 60,
"layoutDurationMs": 12.57,
"taskDurationMs": 1630.818,
"heapDeltaBytes": 8785976,
"heapUsedBytes": 76145268,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 746.7040000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3504.705000000058,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.536999999999997,
"layouts": 60,
"layoutDurationMs": 12.722000000000001,
"taskDurationMs": 1637.822,
"heapDeltaBytes": 8081764,
"heapUsedBytes": 75719708,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 744.354,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3072.0190000000116,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.500999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1876.128,
"heapDeltaBytes": 17400184,
"heapUsedBytes": 85028956,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 929.8069999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3023.828000000094,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1876.8669999999997,
"heapDeltaBytes": 17812172,
"heapUsedBytes": 84573336,
"domNodes": -279,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 935.535,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.3980000000292,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.168999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.3900000000001,
"heapDeltaBytes": -14928796,
"heapUsedBytes": 87257760,
"domNodes": -271,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 32.474000000000004,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2013.512999999989,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.7689999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.4749999999999,
"heapDeltaBytes": 21707608,
"heapUsedBytes": 87931752,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.070999999999994,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.8830000000148,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.606999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.26099999999997,
"heapDeltaBytes": 14304124,
"heapUsedBytes": 85927044,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.731,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.3260000000901,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.424000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.968,
"heapDeltaBytes": 14816320,
"heapUsedBytes": 87189312,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 150.43699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2056.896999999992,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.453999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.583,
"heapDeltaBytes": -9452752,
"heapUsedBytes": 62288844,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2020.8259999999427,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.630000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.58000000000004,
"heapDeltaBytes": -8338864,
"heapUsedBytes": 63855612,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.094999999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.7109999999939,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.326,
"layouts": 18,
"layoutDurationMs": 5.974,
"taskDurationMs": 805.9490000000001,
"heapDeltaBytes": -12717312,
"heapUsedBytes": 59857444,
"domNodes": -295,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 104.275,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.2889999999989,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.765,
"layouts": 18,
"layoutDurationMs": 5.224,
"taskDurationMs": 807.785,
"heapDeltaBytes": 3430996,
"heapUsedBytes": 75883160,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 103.89099999999999,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.6239999999698,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.849000000000004,
"layouts": 15,
"layoutDurationMs": 15.143,
"taskDurationMs": 959.3760000000002,
"heapDeltaBytes": 21063452,
"heapUsedBytes": 108525836,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.970999999999993,
"eventListeners": 2381,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8299.35400000005,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.716,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5607.011,
"heapDeltaBytes": 6941432,
"heapUsedBytes": 82203112,
"domNodes": -271,
"jsHeapTotalBytes": 143360,
"scriptDurationMs": 2571.27,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8345.04400000003,
"styleRecalcs": 246,
"styleRecalcDurationMs": 37.367999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5665.877,
"heapDeltaBytes": -6821408,
"heapUsedBytes": 93874780,
"domNodes": -271,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 2586.181,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18416.56899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17505.137000000002,
"heapDeltaBytes": -46765464,
"heapUsedBytes": 169780484,
"domNodes": -6548,
"jsHeapTotalBytes": -2527232,
"scriptDurationMs": 289.792,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17455.00900000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16832.140000000003,
"heapDeltaBytes": -33709732,
"heapUsedBytes": 175785688,
"domNodes": -6548,
"jsHeapTotalBytes": -3833856,
"scriptDurationMs": 292.08500000000004,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22487.066999999966,
"styleRecalcs": 173,
"styleRecalcDurationMs": 22.121000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22276.163,
"heapDeltaBytes": -22254488,
"heapUsedBytes": 186541492,
"domNodes": -6548,
"jsHeapTotalBytes": -3940352,
"scriptDurationMs": 914.6059999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 219,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21531.775000000038,
"styleRecalcs": 170,
"styleRecalcDurationMs": 19.111000000000043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21162.133,
"heapDeltaBytes": -25567744,
"heapUsedBytes": 176932528,
"domNodes": -6548,
"jsHeapTotalBytes": 548864,
"scriptDurationMs": 879.632,
"eventListeners": -7469,
"totalBlockingTimeMs": 62,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6621.860999999967,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.25800000000005,
"layouts": 20,
"layoutDurationMs": 27.230000000000004,
"taskDurationMs": 6565.084,
"heapDeltaBytes": -18027944,
"heapUsedBytes": 181775440,
"domNodes": -6548,
"jsHeapTotalBytes": 9678848,
"scriptDurationMs": 121.321,
"eventListeners": -7469,
"totalBlockingTimeMs": 552,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6211.109999999962,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.48200000000004,
"layouts": 20,
"layoutDurationMs": 23.210999999999995,
"taskDurationMs": 6119.509,
"heapDeltaBytes": -23131744,
"heapUsedBytes": 181242072,
"domNodes": -6548,
"jsHeapTotalBytes": 19939328,
"scriptDurationMs": 119.54100000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 390,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 454.7059999999874,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.738999999999997,
"layouts": 3,
"layoutDurationMs": 0.8340000000000001,
"taskDurationMs": 97.46499999999999,
"heapDeltaBytes": 5071012,
"heapUsedBytes": 72678948,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 461.659999999938,
"styleRecalcs": 13,
"styleRecalcDurationMs": 21.384999999999998,
"layouts": 3,
"layoutDurationMs": 0.8770000000000002,
"taskDurationMs": 100.335,
"heapDeltaBytes": 5043696,
"heapUsedBytes": 72263540,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.255000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.53 #16989 +/- ##
=============================================
- Coverage 83.31% 83.30% -0.01%
=============================================
Files 2023 2023
Lines 117050 117083 +33
Branches 32470 33064 +594
=============================================
+ Hits 97523 97541 +18
- Misses 19171 19184 +13
- Partials 356 358 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 20 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #16967 to
core/1.53Automatically created by backport workflow.