Repository navigation
[backport cloud/1.52] fix(billing): gate plan CTAs on the server capability set, not a client-derived one - #16988
Conversation
…nt-derived one (#16967) ## Summary The pricing table decided *which* server capability governs each plan card from client-side state, then read it with a `?? false` default — so a workspace the server was permitting to subscribe rendered every card disabled. This gates on the server capability set directly. Labels are unchanged. ## Root cause `GET /v1/billing/capabilities` answers a **workspace-scoped** question — seven booleans, with `resolved_for` carrying only `{user_id, workspace_id}`. The pricing table needs a **card-scoped** answer: "can this workspace move to Creator-Yearly right now?" Nothing in the response can produce that, so the component synthesized it. `canUsePersonalPlanAction` picked the governing capability from `hasActivePaidPlan(tier)`, `isCurrentPlan()`, `isCancelled` and `isEnded`; `isTeamButtonDisabled` did the same job with a different expression off `isTeamSubscribed`. That selection is policy, and it fails in two ways: **1. The client picks the wrong capability.** A legacy-rail workspace holds a paid tier with no local subscription row. `hasActivePaidPlan` is therefore true, so the table reads `can_change_seats` — false, because `ResolveBillingCapabilities`'s `!HasSubscription` branch clears it — and greys the card. That same branch leaves `can_subscribe_self_serve` **true**, which is what the server actually returns for these workspaces. The field that is true is never consulted. **2. "Not yet known" renders as "denied."** `useBillingCapabilities` models five read states (`idle | pending | denied | unavailable | resolved`), collapses them to `null`, and `canSubscribeSelfServe`/`canChangeSeats` collapse that to `false`. A slow or failed read disables every plan button for anyone, including new signups. `canTopUp` three lines above deliberately falls open for owners, and `canOpenPricingSurface` falls open to membership — so we let people into a modal whose every button is dead by design. The capability set is documented as *"Effective billing UI **guidance**"*, not an authorization boundary; every checkout endpoint resolves policy again on the write. Treating guidance as a hard gate is what turns a server "probably not" into a customer who cannot buy. Both symptoms are invisible in monitoring: a disabled button emits nothing, and the endpoint returns HTTP 200 with the capability false. That is how 560 workspaces accumulated from 2026-02-10 without paging anyone. ``` BEFORE AFTER ┌───────────────────────────────────────┐ ┌───────────────────────────────────────┐ │ card ──> hasActivePaidPlan? ──┬─ yes ─→│ │ card ──> offersTransition? (shape) │ │ │ │ │ │ │ │ │ can_change_seats └──> lifecycleActionPermitted │ └─ no ──→│ │ = subscribe │ │ can_subscribe_self_serve ‖ change_seats │ │ │ │ ‖ reactivate │ │ null/pending/failed ──> ?? false │ │ unresolved ──> true (server decides) │ └───────────────────────────────────────┘ └───────────────────────────────────────┘ ``` ## Why this is better, not just different Three properties hold after this change that did not hold before. **The client can no longer invent a denial the server never made.** Two separate client decisions could each produce a dead button on their own: choosing which capability applies, and defaulting an absent answer to `false`. Both are gone. A CTA now goes dead on permission grounds only when a resolved server response permits no lifecycle write. **The failure mode moves from silent lockout to loud rejection.** A wrongly disabled button emits nothing — no error, no telemetry, no page — which is exactly how this went unnoticed for seven months. A wrongly enabled button produces a failed checkout call that is visible in Datadog and answered by the server. Since the capability set is explicitly guidance and the write re-checks policy, trading the first failure mode for the second is the right direction for a billing surface. **Divergence has one place to go wrong instead of two.** Personal and team carried two hand-written gate expressions over the same capabilities, already disagreeing on how each classified "current plan". They now derive from one base — the personal catalog is that base plus the single write only it can receive — so a capability change cannot fix one surface and silently miss the other. ## Changes - **What**: Per-card capability selection is replaced by one gate per catalog, neither of which reads client subscription state. `lifecycleActionPermitted` (team catalog) asks whether the server permits any write that can reach it: `can_subscribe_self_serve || can_change_seats || can_reactivate`. `personalPlanActionPermitted` (personal catalog) adds `can_downgrade_to_personal`, the one further write that reaches a personal card. Which capabilities belong to a catalog is a static property of the surface, not a judgement about the customer. An unresolved snapshot (`!snapshotAuthoritative`) keeps the CTA live and lets the checkout endpoint enforce — the same trade `canOpenPricingSurface` and `canTopUp` already make. Non-Cloud still routes to workspace permissions. - **What**: `canDowngradeToPersonal` gains the same unresolved-snapshot fallback. It also gates the plan-scope toggle, so under `?? false` a team-plan workspace lost every personal card *and the personal tab with it* before the server had answered — a whole catalog removed silently, not a greyed button. - **What**: `offersTransition` keeps the one genuinely client-side check — an active current plan has no transition to offer. See Review Focus for why no server field replaces it today. - **What**: Fixes the team CTA treating an ended subscription's still-reported credit stop as the current plan. `isTeamCurrentPlanSelected` was previously shadowed by the `!isTeamSubscribed` early return; composing the two flat conditions exposed it. - **Breaking**: none. Cohort outcomes, in the terms of INC-128: | | server returns | before | after | |---|---|---|---| | legacy rail (9,868) | `subscribe: true`, `change_seats: false` | disabled | **enabled** | | stranded checkout row (560) | all lifecycle capabilities false | disabled | disabled | | unresolved / failed read | no answer | disabled | **enabled**, server enforces | | team plan, unresolved read | no answer | personal tab **removed** | tab kept, CTAs live | | team plan, downgrade permitted only | `downgrade: true`, rest false | personal cards disabled | **enabled** (team CTA stays disabled) | It does not flip a single resolved denial into an allow. ## Review Focus **This must not merge before #8399 is deployed.** Cause 1 of INC-128 is "a declined checkout leaves a `scheduled` row that wedges the customer." Failing open means more attempted checkouts, and any that decline before #8399 lands create new stranded rows on the path already producing 6–15/day. **Open question, for whoever owns the checkout path (Wei Hai).** If a workspace with `can_subscribe_self_serve: false` calls the checkout-create endpoint directly, does the server reject it, or is the capability the only gate? `useWorkspaceUI.ts:209` asserts *"every checkout endpoint enforces its own policy"* and `canOpenPricingSurface` already relies on it, but I have not verified it in `cloud` and would rather not ship on the comment alone. **One gate is deliberately loosened.** Resubscribe was gated on `canReactivatePlan` (the derived value with the legacy-rail membership fallback from #16091); it is now gated on the union. A cancelled subscriber with `can_reactivate: false` but `can_subscribe_self_serve: true` can now click it. That is intentional under "the write is the authorization boundary", and it is the change that depends most on the answer above. `disables Resubscribe when the server permits no lifecycle write` covers the closed direction. **Why `offersTransition` stays client-side.** `GET /api/billing/plans` already returns `availability: {available, reason}` per plan, and `reason: same_plan` looks like a drop-in replacement. It is not. `currentPlanSlug` there comes from `GetBillingStatus().PlanSlug`, which is populated for `ended` and `canceled` subscriptions too, so the server marks both **unavailable**. Adopting it would stop an ended plan being buyable again and would disable Resubscribe — two new instances of the exact failure this PR removes. The client already corrects for both (`isCurrentPlan` returns false when `isEnded`; `offersTransition` allows a cancelled current plan). Making `same_plan` subscription-status-aware is the server-side prerequisite, and it belongs next to `Comfy-Org/cloud#6275`, which is already about making `available` agree with the write path. An earlier revision of this description claimed a stranded `scheduled` row could reach `isCurrentPlan` via `/api/billing/status`. That was wrong and is removed: `GetBillingStatus` reads only `ws.ActiveSubscriptionID` and then explicitly skips `scheduled` (`common/repository/billing/workspace.go`), so the 560 cohort's leftover row cannot surface as a plan slug. The asymmetry with `GetCapabilitySubscription`, which deliberately *does* fall back to a scheduled row, is what makes Cause 1 a capability-side problem only. **Explicitly out of scope.** Labels and the subscribe/resubscribe emit still derive from `isCurrentPlan` / `hasActivePaidPlan`. A wrong label is cosmetic and the server revalidates the action; a wrong gate locks someone out. Deciding labels from capabilities is tracked as [FE-2038](https://linear.app/comfyorg/issue/FE-2038/decide-pricing-button-labels-through-capabilities-api), pending Alex's read on whether the current fields cover every UX string. `availability`'s other reasons (`exceeds_max_seats`, and `annual_to_monthly_unsupported` from `cloud#6275`) are additive rather than corrective — they close false positives, not the false negatives this PR is about — so they are deferred too. `Comfy-Org/cloud#8417` adds `denied_reasons`, which is what would let a disabled CTA say *why*. That is the missing half: this stops the wrong buttons being disabled, but a legitimately disabled one still carries no explanation. ## Tests `pnpm vitest run src/platform/workspace src/platform/cloud/subscription src/composables/billing` — 99 files, 1854 tests, 1852 passing. The two failures are in `useFreeTierQuota.test.ts`, which fails identically on `origin/main` and shares no imports with the changed files. `pnpm typecheck`, `pnpm lint` (0 errors), `pnpm knip` clean. Seven regression tests added in `UnifiedPricingTable.test.ts` — one per row of the cohort table, plus the invariants worth pinning: - `keeps a paid plan actionable when only change-seats is withheld` — the legacy-rail case - `keeps the CTA live while the capability snapshot is unresolved` - `keeps personal plans reachable on a team plan while the snapshot is unresolved` - `blocks the CTA when a resolved snapshot permits no lifecycle write` — proves this is not a blanket fail-open - `withholds personal plans when a resolved snapshot denies the downgrade` — the resolved-denial counterpart - `does not let the downgrade capability alone enable the team CTA` - `keeps personal cards actionable when only the downgrade is permitted` — the same capability on the surface it does govern - `keeps the team CTA live while the capability snapshot is unresolved` — the same row, on the other surface The last two guard a cross-repo invariant rather than a reachable bug: `ResolveBillingCapabilities` sets `CanDowngradeToPersonal = IsOriginalOwner && CanSubscribeSelfServe`, and every branch that clears subscribe clears downgrade first, so a true downgrade currently implies a true subscribe. Both directions of the catalog split are pinned so neither silently depends on that holding. `browser_tests/tests/dialogs/pricingTableCapabilityGating.spec.ts` (`@cloud`) drives the real dialog against capability responses shaped like the cohorts, which the unit tests cannot do — they render the table directly, so they prove the expression but not that a customer reaches a live button. **Verified red on the pre-change component**: the legacy-rail, unresolved-read and failed-read cases all fail there. The closed direction is deliberately unit-only, and the spec says why. Every entry point to the catalog — the `?pricing=` deep link, the settings panel link, the user popover — is itself gated on `canOpenPricingSurface`, which resolves to `can_subscribe_self_serve`. A resolved refusal therefore *withholds the dialog* rather than opening it with dead cards; the e2e asserts that as the negative control. It also means the dialog-with-every-button-dead state this incident reported is only reachable through an unresolved read, which is the route this PR fixes. An earlier revision of this section claimed e2e was impossible because `browser_tests` could not construct the account shapes. That was wrong: `setupCloudApp` takes the capability response directly, including a never-resolving promise for the pending case. ## Screenshots AS IS / TO BE captures from the real app to follow in a comment — capture takes a while and I did not want to hold the PR.
🎭 Playwright: ✅ 1981 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-04T16:10:51.613Z",
"gitSha": "dee5c2debf2ada162f9d2858b35ef0e66d01cf0a",
"branch": "backport-16967-to-cloud-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2083.4670000000133,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 743.323,
"heapDeltaBytes": 1446788,
"heapUsedBytes": 63167044,
"domNodes": -282,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 13.283,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2038.8810000000603,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.1910000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.24499999999995,
"heapDeltaBytes": 16879380,
"heapUsedBytes": 79110024,
"domNodes": -285,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.1819999999999995,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1991.1610000000337,
"styleRecalcs": 79,
"styleRecalcDurationMs": 46.282,
"layouts": 12,
"layoutDurationMs": 3.8710000000000004,
"taskDurationMs": 1035.8039999999999,
"heapDeltaBytes": 5948532,
"heapUsedBytes": 68562716,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 118.882,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1866.172000000006,
"styleRecalcs": 73,
"styleRecalcDurationMs": 37.81,
"layouts": 12,
"layoutDurationMs": 3.577,
"taskDurationMs": 901.357,
"heapDeltaBytes": 17236672,
"heapUsedBytes": 80071360,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 107.25399999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1742.695000000026,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.744000000000003,
"layouts": 6,
"layoutDurationMs": 0.7720000000000001,
"taskDurationMs": 480.128,
"heapDeltaBytes": 3126012,
"heapUsedBytes": 65171216,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 15.95,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.5760000000037,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.575,
"layouts": 6,
"layoutDurationMs": 0.7340000000000001,
"taskDurationMs": 377.344,
"heapDeltaBytes": 3335068,
"heapUsedBytes": 66198468,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.887000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 623.5730000000217,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.092000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.272,
"heapDeltaBytes": 10958432,
"heapUsedBytes": 73696540,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 60.293000000000006,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 568.9710000000332,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.7379999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.26399999999995,
"heapDeltaBytes": 10806432,
"heapUsedBytes": 72439360,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 53.605,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2085.965999999985,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.251,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.141,
"heapDeltaBytes": -4400120,
"heapUsedBytes": 72715356,
"domNodes": -282,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 20.142,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2069.111000000021,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.287999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 733.8,
"heapDeltaBytes": -2408740,
"heapUsedBytes": 75014788,
"domNodes": -273,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 19.314,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2276.3419999999996,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.387999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1354.339,
"heapDeltaBytes": -8089300,
"heapUsedBytes": 70243244,
"domNodes": -287,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 357.23099999999994,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2214.8520000000644,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.892999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1308.232,
"heapDeltaBytes": -5844496,
"heapUsedBytes": 72492952,
"domNodes": -279,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 334.112,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3329.4330000000514,
"styleRecalcs": 63,
"styleRecalcDurationMs": 15.966999999999999,
"layouts": 60,
"layoutDurationMs": 9.5,
"taskDurationMs": 1574.261,
"heapDeltaBytes": -5556156,
"heapUsedBytes": 74010928,
"domNodes": -290,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 428.88100000000003,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3264.5949999999857,
"styleRecalcs": 65,
"styleRecalcDurationMs": 17.102,
"layouts": 60,
"layoutDurationMs": 9.129000000000001,
"taskDurationMs": 1510.651,
"heapDeltaBytes": -7457936,
"heapUsedBytes": 71081040,
"domNodes": -288,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 411.17099999999994,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2670.5499999999915,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.552,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1641.7150000000001,
"heapDeltaBytes": -15399244,
"heapUsedBytes": 70138532,
"domNodes": 10,
"jsHeapTotalBytes": 10522624,
"scriptDurationMs": 506.18399999999997,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2510.0779999999077,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.751999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1600.8219999999997,
"heapDeltaBytes": -15208832,
"heapUsedBytes": 70261716,
"domNodes": 12,
"jsHeapTotalBytes": 8687616,
"scriptDurationMs": 506.51599999999996,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2042.441999999994,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.917000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 866.5019999999998,
"heapDeltaBytes": -13167172,
"heapUsedBytes": 70650264,
"domNodes": -281,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 21.436999999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2057.2590000000446,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.770000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 775.2829999999999,
"heapDeltaBytes": -11842744,
"heapUsedBytes": 73388140,
"domNodes": -283,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 19.406,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 678.389999999979,
"styleRecalcs": 44,
"styleRecalcDurationMs": 9.513999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.26199999999994,
"heapDeltaBytes": 11675576,
"heapUsedBytes": 74257188,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 124.89900000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 641.0459999999603,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.373000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.647,
"heapDeltaBytes": 11699032,
"heapUsedBytes": 74581600,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 131.79100000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2071.286999999984,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.602000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 694.941,
"heapDeltaBytes": 18474032,
"heapUsedBytes": 81553888,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 13.601,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2039.0280000000303,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.7200000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.024,
"heapDeltaBytes": 15333956,
"heapUsedBytes": 77705312,
"domNodes": -282,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.32,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1804.2290000000207,
"styleRecalcs": 75,
"styleRecalcDurationMs": 42.199,
"layouts": 16,
"layoutDurationMs": 9.930000000000001,
"taskDurationMs": 919.603,
"heapDeltaBytes": -6427552,
"heapUsedBytes": 56074132,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 95.529,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1769.6349999999939,
"styleRecalcs": 74,
"styleRecalcDurationMs": 38.86099999999999,
"layouts": 16,
"layoutDurationMs": 4.676,
"taskDurationMs": 862.1229999999999,
"heapDeltaBytes": 17898400,
"heapUsedBytes": 80831076,
"domNodes": -285,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 91.78,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.0869999999695,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.148999999999997,
"layouts": 14,
"layoutDurationMs": 13.467999999999998,
"taskDurationMs": 921.762,
"heapDeltaBytes": -6125376,
"heapUsedBytes": 86994616,
"domNodes": 13673,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 16.591999999999995,
"eventListeners": 2373,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9609.785999999986,
"styleRecalcs": 249,
"styleRecalcDurationMs": 48.93399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5066.804,
"heapDeltaBytes": 1312776,
"heapUsedBytes": 78683468,
"domNodes": -280,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 1152.474,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8397.460000000025,
"styleRecalcs": 250,
"styleRecalcDurationMs": 47.486,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4632.639,
"heapDeltaBytes": -3858512,
"heapUsedBytes": 72609720,
"domNodes": -280,
"jsHeapTotalBytes": 4411392,
"scriptDurationMs": 1065.98,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19484.61999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18915.8,
"heapDeltaBytes": -62735860,
"heapUsedBytes": 176600856,
"domNodes": -8312,
"jsHeapTotalBytes": -16601088,
"scriptDurationMs": 144.14100000000002,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18986.521000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18363.248000000003,
"heapDeltaBytes": -36483940,
"heapUsedBytes": 189634188,
"domNodes": -8312,
"jsHeapTotalBytes": -16699392,
"scriptDurationMs": 145.623,
"eventListeners": -16390,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 24879.208000000006,
"styleRecalcs": 180,
"styleRecalcDurationMs": 30.375000000000043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24262.418,
"heapDeltaBytes": -53731144,
"heapUsedBytes": 176853932,
"domNodes": -8312,
"jsHeapTotalBytes": -18948096,
"scriptDurationMs": 469.58599999999996,
"eventListeners": -16381,
"totalBlockingTimeMs": 181,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 23921.01100000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 25.097999999999953,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23181.640000000003,
"heapDeltaBytes": -53003336,
"heapUsedBytes": 173563068,
"domNodes": -8312,
"jsHeapTotalBytes": -17223680,
"scriptDurationMs": 495.48100000000005,
"eventListeners": -16385,
"totalBlockingTimeMs": 204,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "workflow-execution",
"durationMs": 472.30899999999565,
"styleRecalcs": 17,
"styleRecalcDurationMs": 19.946,
"layouts": 3,
"layoutDurationMs": 1.2489999999999999,
"taskDurationMs": 117.503,
"heapDeltaBytes": 5330176,
"heapUsedBytes": 68146428,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.502000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 127.0640000000185,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.018000000000004,
"layouts": 3,
"layoutDurationMs": 1.252,
"taskDurationMs": 93.361,
"heapDeltaBytes": 3224432,
"heapUsedBytes": 65905968,
"domNodes": 134,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 7.292,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.52 #16988 +/- ##
==============================================
+ Coverage 79.65% 82.04% +2.39%
==============================================
Files 2242 1912 -330
Lines 115127 110125 -5002
Branches 32913 32206 -707
==============================================
- Hits 91706 90354 -1352
+ Misses 22926 19418 -3508
+ Partials 495 353 -142
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 338 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #16967 to
cloud/1.52Automatically created by backport workflow.